@michengai/dsh-skills-manager 0.1.0 → 0.1.2

package/README.md

@@ -5,11 +5,12 @@
 <h1 align="center">DSH Skills Manager</h1>
 
 <p align="center">
-  <strong>Manage local DeepSeek Harness skills with a clear boundary for shared Agent skills.</strong>
+  <strong>An npm-installable DeepSeek Harness Web plugin for managing local skills safely.</strong>
 </p>
 
 <p align="center">
   <a href="https://github.com/MichengAI/dsh-skills-manager/issues">Report an issue</a>
+  · <a href="https://www.npmjs.com/package/@michengai/dsh-skills-manager">View on npm</a>
 </p>
 
 <p align="center">
@@ -18,6 +19,7 @@
 
 <p align="center">
   <a href="LICENSE"><img src="https://img.shields.io/badge/license-Apache--2.0-blue.svg" alt="Apache License 2.0"></a>
+  <a href="https://www.npmjs.com/package/@michengai/dsh-skills-manager"><img src="https://img.shields.io/npm/v/%40michengai/dsh-skills-manager?label=npm" alt="npm package"></a>
   <img src="https://img.shields.io/badge/DSH-Web%20Plugin-10b981" alt="DSH Web Plugin">
   <img src="https://img.shields.io/badge/Node.js-%E2%89%A520-339933?logo=nodedotjs&logoColor=white" alt="Node.js 20 or later">
 </p>
@@ -37,6 +39,7 @@
 - **Safe shared-skill view** — public Agent skills are visible but strictly read-only; their global metadata is never changed.
 - **Native file selection** — select a plugin `SKILL.md` from the operating system file picker, or explicitly choose its directory when the client cannot expose the selected file path.
 - **Protected replacement** — a same-name import always requires confirmation, including a flat skill and a bundled skill with the same normalized name.
+- **Safer imports** — importing from the DSH skills directory itself, its parent, or a child path is rejected; symbolic links are also rejected.
 - **Predictable dialogs** — Escape closes only the active upload or confirmation dialog, leaving the Settings page open.
 
 ## Directory permissions
@@ -48,11 +51,17 @@
 
 The shared Agent directory is intentionally read-only in both the interface and the server API.
 
-## Install
+## Safety behavior
 
-Requirements: a working DeepSeek Harness Web installation. The published package declares Node.js 20 or later for the DSH runtime.
+- Enable, disable, and delete only accept one ordinary skill-name path segment; directory traversal names are rejected.
+- Replacements are first copied to a temporary sibling path. Existing files are kept until that copy succeeds.
+- Mutation endpoints require JSON and the DSH client request marker, so a cross-site browser request cannot trigger a local file operation.
 
-Install the published package into the Web profile:
+## Quick start
+
+You need a working DeepSeek Harness Web installation. Do not run `npm install` in an arbitrary directory: install the plugin into the DSH Web profile instead.
+
+1. Run:
 
 ```powershell
 [Console]::OutputEncoding = [System.Text.Encoding]::UTF8
@@ -60,16 +69,23 @@ $OutputEncoding = [System.Text.Encoding]::UTF8
 dsh plugin --profile web add @michengai/dsh-skills-manager
 ```
 
-No source checkout is required. Restart DSH, then open **Settings → Skills**. If a package mirror has not synchronized the latest version yet, append `--registry=https://registry.npmjs.org/` to the install command.
+2. Restart DSH or reload the active Web profile.
+3. Open **Settings → Skills**. No source checkout is required.
+
+If a package mirror has not synchronized the latest version yet, append `--registry=https://registry.npmjs.org/` to the install command.
+
+## Use the Skills panel
 
-## How to use it
+| Goal | What to do | Scope |
+| --- | --- | --- |
+| Check a skill | Open **Settings → Skills** to see its name, form, description, and invocation status. | DSH and shared Agent skills |
+| Enable or disable | Choose **Enable** or **Disable**. This changes model invocation and the `/` manual command without rewriting other `SKILL.md` metadata. | DSH skills only |
+| Upload a plugin | Choose **Upload Plugin**, then select the plugin directory's `SKILL.md`. DSH copies the complete directory, including scripts and resources. | DSH skills only |
+| Select a directory instead | If the selected file has no usable path, choose **Choose Plugin Directory** and select the directory that contains `SKILL.md`. | DSH skills only |
+| Replace or delete | Confirm a same-name replacement; use **Delete** for a DSH-local skill you no longer need. | DSH skills only |
+| Inspect shared skills | Review shared Agent skills without changing their metadata. | Read-only |
 
-1. Open **Settings → Skills**. The panel separates **DSH Skills** from **Shared Agent Skills** and shows each skill's name, form, description, and current invocation status.
-2. In **DSH Skills**, choose **Enable** or **Disable** to control both model invocation and the `/` manual command. Other `SKILL.md` metadata remains untouched.
-3. Choose **Upload Plugin** in the upper-right corner. Select the plugin directory's `SKILL.md`; the complete plugin directory is copied to `$DSH_HOME\skills`.
-4. When the browser does not provide the selected file path, use **Choose Plugin Directory** in the dialog and select the directory that contains `SKILL.md`.
-5. Confirm any replacement of a same-name skill. Use **Delete** only for DSH-local skills you no longer need.
-6. Treat **Shared Agent Skills** as an inspection list: their controls are deliberately unavailable so the shared global skill metadata stays unchanged.
+Press **Escape** to close only the frontmost upload or confirmation dialog; the Settings page remains open.
 
 ## Development and verification
 
@@ -83,18 +99,18 @@ node test\core-test.mjs
 
 Project status, usage boundaries, architecture, and iteration records start at the [documentation entry point](https://github.com/MichengAI/dsh-skills-manager/blob/master/docs/00-%E4%BA%A4%E6%8E%A5%E5%85%A5%E5%8F%A3/00-%E9%98%85%E8%AF%BB%E5%AF%BC%E8%88%AA.md). The Chinese operational guide is available at `docs\02-产品与业务\01-使用说明.md` in the repository.
 
-## Publishing
+## Maintainer release
 
-The user-level npm registry may point to a download mirror such as `registry.npmmirror.com`; mirrors do not accept publication. This package therefore pins publication to the official npm registry. A maintainer with npm publishing access can release the current version with:
+The package is published as [`@michengai/dsh-skills-manager`](https://www.npmjs.com/package/@michengai/dsh-skills-manager). To release a new version:
 
 ```powershell
 [Console]::OutputEncoding = [System.Text.Encoding]::UTF8
 $OutputEncoding = [System.Text.Encoding]::UTF8
-npm login --registry=https://registry.npmjs.org/
+npm version patch
 npm publish
 ```
 
-`prepublishOnly` runs the core test suite before publication, and `publishConfig.registry` prevents `npm publish` from going to a configured download mirror. Use `npm run pack:check` to inspect the exact tarball contents without publishing.
+`prepublishOnly` runs the core test suite before publication. The package always publishes to the official npm registry; use `npm run pack:check` to inspect the tarball first.
 
 ## License
 

package/README.zh-CN.md

@@ -5,11 +5,12 @@
 <h1 align="center">DSH Skills Manager</h1>
 
 <p align="center">
-  <strong>管理本地 DeepSeek Harness 技能，并为公共 Agent 技能提供清晰、安全的查看边界。</strong>
+  <strong>通过 npm 安装的 DeepSeek Harness Web 插件，用于安全管理本地技能。</strong>
 </p>
 
 <p align="center">
   <a href="https://github.com/MichengAI/dsh-skills-manager/issues">反馈问题</a>
+  · <a href="https://www.npmjs.com/package/@michengai/dsh-skills-manager">在 npm 查看</a>
 </p>
 
 <p align="center">
@@ -18,6 +19,7 @@
 
 <p align="center">
   <a href="LICENSE"><img src="https://img.shields.io/badge/license-Apache--2.0-blue.svg" alt="Apache License 2.0"></a>
+  <a href="https://www.npmjs.com/package/@michengai/dsh-skills-manager"><img src="https://img.shields.io/npm/v/%40michengai/dsh-skills-manager?label=npm" alt="npm 包"></a>
   <img src="https://img.shields.io/badge/DSH-Web%20Plugin-10b981" alt="DSH Web Plugin">
   <img src="https://img.shields.io/badge/Node.js-%E2%89%A520-339933?logo=nodedotjs&logoColor=white" alt="Node.js 20 或更高版本">
 </p>
@@ -37,6 +39,7 @@
 - **公共技能安全查看**：公共 Agent 技能可见但严格只读，绝不会改写其全局元数据。
 - **系统原生选择**：通过操作系统文件选择器选择插件的 `SKILL.md`；客户端无法提供所选文件路径时，可显式选择插件目录。
 - **覆盖保护**：导入同名技能一定要求确认；flat 与 bundle 两种形态同名时同样如此。
+- **更安全的导入**：拒绝从 DSH 技能目录自身、其父目录或子目录导入，也拒绝符号链接。
 - **弹窗行为可预期**：按 ESC 只关闭当前上传框或确认框，不会关闭设置页面。
 
 ## 目录权限
@@ -48,11 +51,17 @@
 
 公共 Agent 目录在界面和服务端均为只读，用于避免误改共享的全局技能元数据。
 
-## 安装
+## 安全行为
 
-环境要求：可正常运行的 DeepSeek Harness Web 环境。已发布的包会声明 DSH 运行时需要 Node.js 20 或更高版本。
+- 启用、停用和删除只接受单个普通技能名称，目录穿越名称会被拒绝。
+- 覆盖前会先复制到同目录临时路径；复制成功前不会触碰现有技能。
+- 写入接口要求 JSON 与 DSH 客户端请求标记，跨站浏览器请求无法触发本地文件操作。
 
-将已发布 npm 包安装到 Web profile：
+## 快速开始
+
+环境要求：可正常运行的 DeepSeek Harness Web 环境。不要在任意目录执行 `npm install`；应将插件安装到 DSH Web profile。
+
+1. 执行：
 
 ```powershell
 [Console]::OutputEncoding = [System.Text.Encoding]::UTF8
@@ -60,16 +69,23 @@ $OutputEncoding = [System.Text.Encoding]::UTF8
 dsh plugin --profile web add @michengai/dsh-skills-manager
 ```
 
-无需下载源码。重启 DSH 后，打开「设置 → 技能」。若软件源镜像尚未同步最新版本，可在安装命令末尾添加 `--registry=https://registry.npmjs.org/`。
+2. 重启 DSH 或重新加载当前 Web profile。
+3. 打开「设置 → 技能」。无需下载源码。
+
+若软件源镜像尚未同步最新版本，可在安装命令末尾添加 `--registry=https://registry.npmjs.org/`。
+
+## 使用技能面板
 
-## 使用说明
+| 目标 | 操作 | 范围 |
+| --- | --- | --- |
+| 查看技能 | 打开「设置 → 技能」，查看名称、形态、说明和调用状态。 | DSH 与公共 Agent 技能 |
+| 启用或停用 | 点击「启用」或「停用」。它会同步控制模型调用和 `/` 手动命令，不会改写 `SKILL.md` 的其他元数据。 | 仅 DSH 技能 |
+| 上传插件 | 点击「上传插件」，选择插件目录内的 `SKILL.md`。DSH 会复制完整目录，包括脚本和资源。 | 仅 DSH 技能 |
+| 改选插件目录 | 若所选文件没有可用路径，点击「选择插件文件夹」，并选择包含 `SKILL.md` 的目录。 | 仅 DSH 技能 |
+| 覆盖或删除 | 同名时按提示确认覆盖；使用「删除」移除不再需要的 DSH 本地技能。 | 仅 DSH 技能 |
+| 查看公共技能 | 查看公共 Agent 技能，不修改其元数据。 | 只读 |
 
-1. 打开「设置 → 技能」。面板会区分「DSH 技能」和「公共 Agent 技能」，并展示每个技能的名称、形态、说明和调用状态。
-2. 仅在「DSH 技能」分组中使用「启用」或「停用」。它会同步控制模型调用和 `/` 手动命令，且不会改写 `SKILL.md` 的其他元数据。
-3. 点击右上角「上传插件」，选择插件目录中的 `SKILL.md`；整个插件目录会复制到 `$DSH_HOME\skills`。
-4. 若客户端无法提供所选文件路径，在弹窗中点击「选择插件文件夹」，并选择包含 `SKILL.md` 的目录。
-5. 遇到同名技能时，根据提示确认是否覆盖；仅在「DSH 技能」分组中使用「删除」移除不再需要的插件。
-6. 「公共 Agent 技能」仅供智能查看，不提供启停、上传、覆盖或删除，以保护共享的全局技能元数据。
+按 ESC 只关闭最上层上传框或确认框，设置页保持打开。
 
 ## 开发与验证
 
@@ -83,18 +99,18 @@ node test\core-test.mjs
 
 项目状态、使用边界、技术架构和迭代记录从[文档交接入口](https://github.com/MichengAI/dsh-skills-manager/blob/master/docs/00-%E4%BA%A4%E6%8E%A5%E5%85%A5%E5%8F%A3/00-%E9%98%85%E8%AF%BB%E5%AF%BC%E8%88%AA.md)开始；详细操作说明见仓库中的 `docs\02-产品与业务\01-使用说明.md`。
 
-## 发布 npm 包
+## 维护者发布
 
-用户级 npm registry 可能指向 `registry.npmmirror.com` 等下载镜像；镜像不接受发布。本包已固定发布目标为官方 npm registry，拥有 npm 发布权限的维护者可执行：
+本包已发布为 [`@michengai/dsh-skills-manager`](https://www.npmjs.com/package/@michengai/dsh-skills-manager)。发布新版本时执行：
 
 ```powershell
 [Console]::OutputEncoding = [System.Text.Encoding]::UTF8
 $OutputEncoding = [System.Text.Encoding]::UTF8
-npm login --registry=https://registry.npmjs.org/
+npm version patch
 npm publish
 ```
 
-发布前会由 `prepublishOnly` 自动运行核心测试，`publishConfig.registry` 会避免 `npm publish` 写入下载镜像。执行 `npm run pack:check` 可在不发布的情况下检查最终 tarball 内容。
+发布前会由 `prepublishOnly` 自动运行核心测试。包始终发布到官方 npm registry；可先执行 `npm run pack:check` 检查 tarball 内容。
 
 ## 许可证
 

package/lib/client.js

@@ -1,4 +1,4 @@
-// dsh-skills-manager client half：DSH 设置中的单目录技能管理面板。
+// dsh-skills-manager client half：DSH 设置中的本地管理与公共 Agent 只读技能面板。
 window.__ModuleLoader__.load({
   id: "dsh-skills-manager",
   factory: (require) => {
@@ -7,6 +7,7 @@ window.__ModuleLoader__.load({
     var react = require("react");
     var h = react.createElement;
     var pickDirectory = null;
+    var MUTATION_HEADERS = { "content-type": "application/json", "x-dsh-skills-manager": "1" };
 
     var CSS = `
 .dssm-section{display:flex;min-width:0;flex-direction:column;gap:20px;color:var(--dsw-alias-label-primary)}
@@ -85,7 +86,7 @@ window.__ModuleLoader__.load({
       function action(path, body) {
         if (busy) return;
         setBusy(path);
-        callApi(path, { method: "POST", headers: { "content-type": "application/json" }, body: JSON.stringify(body || {}) }).then(function () {
+        callApi(path, { method: "POST", headers: MUTATION_HEADERS, body: JSON.stringify(body || {}) }).then(function () {
           setBusy(null);
           refresh();
         }).catch(function (error) {
@@ -135,7 +136,7 @@ window.__ModuleLoader__.load({
       function executeImport(source, conflict) {
         setBusy("import");
         setConfirmImport(null);
-        callApi("/import", { method: "POST", headers: { "content-type": "application/json" }, body: JSON.stringify({ source: source, conflict: conflict }) }).then(function (data) {
+        callApi("/import", { method: "POST", headers: MUTATION_HEADERS, body: JSON.stringify({ source: source, conflict: conflict }) }).then(function (data) {
           setBusy(null);
           setImportResult(data);
           setSelected(null);
@@ -150,7 +151,7 @@ window.__ModuleLoader__.load({
       function installSelected() {
         if (!selected || busy) return;
         setBusy("import-check");
-        callApi("/import", { method: "POST", headers: { "content-type": "application/json" }, body: JSON.stringify({ source: selected.source, dryRun: true }) }).then(function (data) {
+        callApi("/import", { method: "POST", headers: MUTATION_HEADERS, body: JSON.stringify({ source: selected.source, dryRun: true }) }).then(function (data) {
           if (data.conflicts && data.conflicts.length) {
             setBusy(null);
             setConfirmImport({ source: selected.source, conflicts: data.conflicts });
@@ -165,14 +166,16 @@ window.__ModuleLoader__.load({
 
       function skillRow(skill, root) {
         var enabled = skill.modelInvocable && skill.userInvocable;
+        var policyValid = skill.invocationPolicyValid !== false;
+        var actionEnabled = policyValid && enabled;
         return h("div", { key: skill.name, className: "dssm-row" },
           h("div", { className: "dssm-row-main" },
             h("div", { className: "dssm-row-id" },
               h("span", { className: "dssm-row-name" }, skill.name),
               h("span", { className: "dssm-tag" }, skill.kind === "bundle" ? "目录插件" : "单文件"),
-              h("span", { className: "dssm-tag " + (enabled ? "dssm-tag-on" : "dssm-tag-off") }, enabled ? "已启用" : "已停用")),
+              h("span", { className: "dssm-tag " + (policyValid && enabled ? "dssm-tag-on" : "dssm-tag-off") }, policyValid ? (enabled ? "已启用" : "已停用") : "配置异常")),
             h("div", { className: "dssm-note", title: skill.description || "" }, skill.description || "未提供简介")),
-          root.mutable ? h("button", { className: "dssm-btn dssm-btn-secondary", disabled: !!busy, onClick: function () { action(enabled ? "/disable" : "/enable", { name: skill.name, root: root.key }); } }, enabled ? "停用" : "启用") : null,
+          root.mutable ? h("button", { className: "dssm-btn dssm-btn-secondary", disabled: !!busy, onClick: function () { action(actionEnabled ? "/disable" : "/enable", { name: skill.name, root: root.key }); } }, actionEnabled ? "停用" : policyValid ? "启用" : "修复并启用") : null,
           root.mutable ? h("button", { className: "dssm-btn dssm-btn-danger", disabled: !!busy, onClick: function () { setConfirmDelete(skill); } }, "删除") : null);
       }
 
@@ -201,8 +204,9 @@ window.__ModuleLoader__.load({
       if (importResult) {
         var importedNames = (importResult.imported || []).map(function (item) { return item.name; });
         var failedItems = importResult.failed || [];
+        var skippedNames = (importResult.skipped || []).map(function (item) { return item.name; });
         var failedText = failedItems.map(function (item) { return item.error; }).join("；");
-        var resultText = importResult.error ? "上传失败：" + importResult.error : failedItems.length ? (importedNames.length ? "部分上传成功：" + importedNames.join("、") + "；失败：" + failedText : "上传失败：" + failedText) : "上传完成：" + importedNames.join("、");
+        var resultText = importResult.error ? "上传失败：" + importResult.error : failedItems.length ? (importedNames.length ? "部分上传成功：" + importedNames.join("、") + "；失败：" + failedText : "上传失败：" + failedText) : importedNames.length ? "上传完成：" + importedNames.join("、") : skippedNames.length ? "未导入：同名插件已跳过：" + skippedNames.join("、") : "未导入任何插件。";
         nodes.push(h("div", { key: "import-result", className: importResult.error || failedItems.length ? "dssm-error" : "dssm-note", role: "status" }, resultText));
       }
       if (uploadOpen) {

package/lib/core.js

@@ -5,13 +5,16 @@
 //   - 条目形态：<root>/<name>/SKILL.md（bundle）或 <root>/<name>.md（flat），只扫一层
 //   - 前端展示 name、description 与启停状态，不做格式检查或自动修复
 //
-// 所有函数返回普通结果对象，失败时返回 { ok: false, error }；写文件/日志失败静默降级。
+// 所有函数返回普通结果对象，业务校验失败返回 { ok: false, error }；文件写入错误由路由返回给调用方。
 
 import { homedir } from "node:os";
-import { join, basename, dirname } from "node:path";
+import { join, basename, dirname, resolve, relative, isAbsolute, sep } from "node:path";
 import { promises as fs } from "node:fs";
+import { randomUUID } from "node:crypto";
 
 const KEBAB_RE = /^[a-z0-9]+(?:-[a-z0-9]+)*$/;
+const WINDOWS_DEVICE_NAME_RE = /^(con|prn|aux|nul|com[1-9]|lpt[1-9])(?:\..*)?$/i;
+const MAX_SOURCE_DEPTH = 64;
 
 // ── 路径解析 ────────────────────────────────────────────────────────────────
 
@@ -35,6 +38,29 @@ export function logPath() {
   return join(resolveDshHome(), "dsh-skills-manager.log");
 }
 
+function dshRootPath() {
+  return userRoots().find((root) => root.key === "dsh").path;
+}
+
+/** 判断 child 是否与 parent 相同或位于其内部。跨盘符时 relative 会返回绝对路径。 */
+function isSameOrDescendant(parent, child) {
+  const rel = relative(resolve(parent), resolve(child));
+  return rel === "" || (!isAbsolute(rel) && rel !== ".." && !rel.startsWith(`..${sep}`));
+}
+
+/** 两个路径重叠时，覆盖导入可能删除自身来源，必须拒绝。 */
+function pathsOverlap(a, b) {
+  return isSameOrDescendant(a, b) || isSameOrDescendant(b, a);
+}
+
+/** 名称只允许一个普通路径段；不把既有技能名称限制为 kebab-case。 */
+function entryPath(root, name) {
+  if (typeof name !== "string" || name === "" || name === "." || name === ".." || /[\\/\0]/.test(name) || /[. ]$/.test(name) || WINDOWS_DEVICE_NAME_RE.test(name) || basename(name) !== name) return null;
+  const rootPath = resolve(root);
+  const path = resolve(rootPath, name);
+  return isSameOrDescendant(rootPath, path) && rootPath !== path ? path : null;
+}
+
 // ── 命名规整 ────────────────────────────────────────────────────────────────
 
 /** 尽量把任意名称规整为 kebab-case；无法生成合法名称时返回空串。 */
@@ -81,9 +107,11 @@ export function parseSkillDoc(text) {
             const content = [];
             while (i + 1 < end && (/^\s/.test(lines[i + 1]) || lines[i + 1] === "")) {
               i++;
-              content.push(lines[i].replace(/^\s{1,2}/, ""));
+              content.push(lines[i]);
             }
-            map[m[1]] = block[1] === ">" ? content.join(" ").replace(/\s+/g, " ").trim() : content.join("\n").trim();
+            const indentation = content.filter((line) => line.trim() !== "").reduce((min, line) => Math.min(min, (/^\s*/.exec(line) || [""])[0].length), Infinity);
+            const normalized = content.map((line) => Number.isFinite(indentation) ? line.slice(Math.min(indentation, line.length)) : line);
+            map[m[1]] = block[1] === ">" ? normalized.join(" ").replace(/\s+/g, " ").trim() : normalized.join("\n").trim();
           } else {
             map[m[1]] = decodeYamlScalar(m[2]);
           }
@@ -118,42 +146,31 @@ export function unquote(v) {
   return s;
 }
 
-/** 把 JS 值序列化为 YAML 标量；需要转义的字符串用 JSON 引号形式。 */
-export function yamlScalar(v) {
-  if (v === true) return "true";
-  if (v === false) return "false";
-  if (v === null || v === undefined) return "null";
-  if (typeof v === "number") return String(v);
-  const s = String(v);
-  if (s === "") return '""';
-  if (/^(true|false|null|yes|no|on|off|~)$/i.test(s) || /^[-+]?\d+(\.\d+)?$/.test(s)) return JSON.stringify(s);
-  if (/[:#{}[\]&*,?|>%@`"'\s]/.test(s) || s !== s.trim()) return JSON.stringify(s);
-  return s;
-}
-
-export function serializeSkillDoc(map, body) {
-  let out = "---\n";
-  for (const key of Object.keys(map)) {
-    out += `${key}: ${yamlScalar(map[key])}\n`;
-  }
-  out += "---\n";
-  out += body;
-  return out;
-}
-
 /** 仅更新调用策略行，避免重写并破坏其他 YAML frontmatter。 */
 function updateInvocationPolicy(text, enabled) {
   const source = String(text);
   const newline = source.includes("\r\n") ? "\r\n" : "\n";
   const lines = source.split(/\r?\n/);
-  if (lines[0]?.trim() !== "---") return source;
+  if (lines[0]?.trim() !== "---") return null;
   const end = lines.findIndex((line, index) => index > 0 && line.trim() === "---");
-  if (end < 0) return source;
+  if (end < 0) return null;
   const fields = lines.slice(1, end).filter((line) => !/^(disable-model-invocation|user-invocable)\s*:/.test(line));
   if (!enabled) fields.push("disable-model-invocation: true", "user-invocable: false");
   return ["---", ...fields, "---", ...lines.slice(end + 1)].join(newline);
 }
 
+/** 同目录临时文件加 rename，避免写入中断时截断原 SKILL.md。 */
+async function writeFileAtomically(path, content) {
+  const temp = join(dirname(path), `.${basename(path)}.dssm-${randomUUID()}.tmp`);
+  try {
+    await fs.writeFile(temp, content, "utf8");
+    await fs.rename(temp, path);
+  } catch (error) {
+    await fs.rm(temp, { force: true }).catch(() => undefined);
+    throw error;
+  }
+}
+
 /** 解析布尔字段值；合法布尔返回 true/false，非法返回 undefined。 */
 export function parseBoolValue(raw) {
   const v = unquote(raw).trim().toLowerCase();
@@ -166,24 +183,30 @@ export function parseBoolValue(raw) {
 
 /** 按名称解析条目（bundle 优先，其次 flat）。找不到返回 null。 */
 export async function resolveEntry(root, name) {
-  if (typeof name !== "string" || name === "" || basename(name) !== name) return null;
-  const bundleDoc = join(root, name, "SKILL.md");
+  const bundlePath = entryPath(root, name);
+  if (bundlePath === null) return null;
+  const rootPath = resolve(root);
+  const bundleDoc = join(bundlePath, "SKILL.md");
   try {
     const st = await fs.stat(bundleDoc);
-    if (st.isFile()) return { kind: "bundle", docPath: bundleDoc };
+    if (st.isFile()) return { kind: "bundle", docPath: bundleDoc, entryPath: bundlePath };
   } catch {}
-  const flatDoc = join(root, `${name}.md`);
+  const flatDoc = resolve(rootPath, `${name}.md`);
+  if (!isSameOrDescendant(rootPath, flatDoc) || rootPath === flatDoc) return null;
   try {
     const st = await fs.stat(flatDoc);
-    if (st.isFile()) return { kind: "flat", docPath: flatDoc };
+    if (st.isFile()) return { kind: "flat", docPath: flatDoc, entryPath: flatDoc };
   } catch {}
   return null;
 }
 
 function entryOf(name, kind, docPath, doc) {
   const description = doc.map.description !== undefined ? unquote(doc.map.description) : "";
-  const modelDisabled = parseBoolValue(doc.map["disable-model-invocation"]) === true;
-  const userDisabled = parseBoolValue(doc.map["user-invocable"]) === false;
+  const modelValue = parseBoolValue(doc.map["disable-model-invocation"]);
+  const userValue = parseBoolValue(doc.map["user-invocable"]);
+  const modelDisabled = modelValue === true;
+  const userDisabled = userValue === false;
+  const invocationPolicyValid = (doc.map["disable-model-invocation"] === undefined || modelValue !== undefined) && (doc.map["user-invocable"] === undefined || userValue !== undefined);
   return {
     name,
     kind,
@@ -191,6 +214,7 @@ function entryOf(name, kind, docPath, doc) {
     description,
     modelInvocable: !modelDisabled,
     userInvocable: !userDisabled,
+    invocationPolicyValid,
   };
 }
 
@@ -211,7 +235,7 @@ export async function scanEntries(root) {
         if (!st.isFile()) continue;
         const doc = parseSkillDoc(await fs.readFile(docPath, "utf8"));
         entries.push(entryOf(it.name, "bundle", docPath, doc));
-      } else if (it.isFile() && it.name.endsWith(".md") && it.name !== "SKILL.md") {
+      } else if (it.isFile() && it.name.toLowerCase().endsWith(".md") && it.name.toLowerCase() !== "skill.md") {
         const docPath = join(root, it.name);
         const doc = parseSkillDoc(await fs.readFile(docPath, "utf8"));
         entries.push(entryOf(it.name.slice(0, -3), "flat", docPath, doc));
@@ -228,22 +252,23 @@ export async function scanEntries(root) {
 
 /** enabled=true 恢复模型与 / 手动调用；false 同时停用两种调用入口。 */
 export async function setSkillEnabled(root, name, enabled) {
-  if (root !== userRoots()[0].path) return { ok: false, error: "公共 Agent 技能目录不允许启用或停用" };
+  if (root !== dshRootPath()) return { ok: false, error: "公共 Agent 技能目录不允许启用或停用" };
   const resolved = await resolveEntry(root, name);
   if (resolved === null) return { ok: false, error: `技能不存在: ${name}` };
   const source = await fs.readFile(resolved.docPath, "utf8");
-  await fs.writeFile(resolved.docPath, updateInvocationPolicy(source, enabled), "utf8");
+  const updated = updateInvocationPolicy(source, enabled);
+  if (updated === null) return { ok: false, error: `技能缺少完整 frontmatter，无法${enabled ? "启用" : "停用"}: ${name}` };
+  await writeFileAtomically(resolved.docPath, updated);
   return { name, enabled };
 }
 
 /** 删除 DSH 根目录中的单个技能。调用方必须先向用户确认。 */
 export async function deleteSkill(root, name, log) {
-  if (root !== userRoots()[0].path) return { ok: false, error: "公共 Agent 技能目录不允许删除" };
+  if (root !== dshRootPath()) return { ok: false, error: "公共 Agent 技能目录不允许删除" };
   const resolved = await resolveEntry(root, name);
   if (resolved === null) return { ok: false, error: `技能不存在: ${name}` };
-  const entryPath = resolved.kind === "bundle" ? join(root, name) : resolved.docPath;
-  await fs.rm(entryPath, { recursive: resolved.kind === "bundle", force: true });
-  if (log) log("delete", `删除 ${entryPath}`);
+  await fs.rm(resolved.entryPath, { recursive: resolved.kind === "bundle", force: true });
+  if (log) log("delete", `删除 ${resolved.entryPath}`);
   return { name };
 }
 
@@ -253,10 +278,11 @@ export async function deleteSkill(root, name, log) {
 async function analyzeSource(source) {
   let st;
   try {
-    st = await fs.stat(source);
+    st = await fs.lstat(source);
   } catch {
     return { kind: "none", error: `路径不存在: ${source}` };
   }
+  if (st.isSymbolicLink()) return { kind: "none", error: `不支持包含符号链接的 skill 来源: ${source}` };
   if (st.isDirectory()) {
     try {
       const sk = join(source, "SKILL.md");
@@ -282,6 +308,7 @@ async function collectCandidates(dir) {
   const items = await fs.readdir(dir, { withFileTypes: true });
   const out = [];
   for (const it of items) {
+    if (it.isSymbolicLink()) throw new Error(`不支持包含符号链接的 skill 来源: ${join(dir, it.name)}`);
     try {
       if (it.isDirectory()) {
         const sk = join(dir, it.name, "SKILL.md");
@@ -289,7 +316,7 @@ async function collectCandidates(dir) {
         if (st.isFile()) {
           out.push({ source: join(dir, it.name), kebab: toKebab(it.name), rawName: it.name, isDir: true });
         }
-      } else if (it.isFile() && it.name.endsWith(".md") && it.name !== "SKILL.md") {
+      } else if (it.isFile() && it.name.toLowerCase().endsWith(".md") && it.name.toLowerCase() !== "skill.md") {
         out.push({ source: join(dir, it.name), kebab: toKebab(it.name.slice(0, -3)), rawName: it.name.slice(0, -3), isDir: false });
       }
     } catch {
@@ -299,24 +326,92 @@ async function collectCandidates(dir) {
   return out;
 }
 
+/** 导入内容不接受符号链接，避免把目标目录外的内容带入技能目录。 */
+async function assertNoSymbolicLinks(source) {
+  const pending = [{ path: source, depth: 0 }];
+  while (pending.length) {
+    const current = pending.pop();
+    if (current.depth > MAX_SOURCE_DEPTH) throw new Error(`skill 来源目录层级超过 ${MAX_SOURCE_DEPTH} 层: ${source}`);
+    const st = await fs.lstat(current.path);
+    if (st.isSymbolicLink()) throw new Error(`不支持包含符号链接的 skill 来源: ${current.path}`);
+    if (!st.isDirectory()) continue;
+    const items = await fs.readdir(current.path, { withFileTypes: true });
+    for (const item of items) {
+      const path = join(current.path, item.name);
+      if (item.isSymbolicLink()) throw new Error(`不支持包含符号链接的 skill 来源: ${path}`);
+      if (item.isDirectory()) pending.push({ path, depth: current.depth + 1 });
+    }
+  }
+}
+
+function temporaryPath(target, kind) {
+  return join(dirname(target), `.${basename(target)}.dssm-${kind}-${randomUUID()}`);
+}
+
+/** 先复制到同目录临时路径，复制失败时不触碰现有技能。 */
+async function copyToTemporary(source, target, isDir) {
+  const temp = temporaryPath(target, "stage");
+  try {
+    await assertNoSymbolicLinks(source);
+    if (isDir) await fs.cp(source, temp, { recursive: true, dereference: false });
+    else await fs.copyFile(source, temp);
+    return temp;
+  } catch (error) {
+    await fs.rm(temp, { recursive: true, force: true }).catch(() => undefined);
+    throw error;
+  }
+}
+
+/** 临时副本就绪后再替换；替换失败时尽力恢复旧条目。 */
+async function replaceWithCopy(source, dest, isDir, existing = []) {
+  const stage = await copyToTemporary(source, dest, isDir);
+  const backups = [];
+  try {
+    for (const path of existing) {
+      const backup = temporaryPath(path, "backup");
+      await fs.rename(path, backup);
+      backups.push({ path, backup });
+    }
+    await fs.rename(stage, dest);
+  } catch (error) {
+    await fs.rm(stage, { recursive: true, force: true }).catch(() => undefined);
+    for (const item of backups.reverse()) await fs.rename(item.backup, item.path).catch(() => undefined);
+    throw error;
+  }
+  const warnings = [];
+  for (const item of backups) {
+    try {
+      await fs.rm(item.backup, { recursive: true, force: true });
+    } catch (error) {
+      warnings.push(`旧版本备份未清理: ${item.backup}（${String(error && error.message ? error.message : error)}）`);
+    }
+  }
+  return warnings;
+}
+
 /**
  * 导入技能到目标根。
  * options: { conflict: 'skip'|'overwrite', dryRun: boolean }
  * 成功返回 { kind, imported, skipped, failed }；失败返回 { ok:false, error }。
  */
 export async function importSkill(source, log, options = {}) {
-  const targetRoot = userRoots()[0].path;
+  const targetRoot = dshRootPath();
   const conflict = options.conflict === "overwrite" ? "overwrite" : "skip";
   const dryRun = options.dryRun === true;
 
   const analysis = await analyzeSource(source);
   if (analysis.kind === "none") return { ok: false, error: analysis.error || "无法识别的 skill 来源" };
+  if (pathsOverlap(analysis.source, targetRoot)) return { ok: false, error: "导入来源不能与 DSH 技能目录相同、包含或位于其中" };
 
   let candidates = [];
   if (analysis.kind === "single") {
     candidates = [{ source: analysis.source, kebab: analysis.kebab, rawName: analysis.rawName, isDir: analysis.isDir }];
   } else {
-    candidates = await collectCandidates(source);
+    try {
+      candidates = await collectCandidates(source);
+    } catch (error) {
+      return { ok: false, error: String(error && error.message ? error.message : error) };
+    }
     if (candidates.length === 0) return { ok: false, error: `目录下未找到任何 skill 条目（需含 SKILL.md 的子目录或 .md 文件）: ${source}` };
   }
 
@@ -326,6 +421,11 @@ export async function importSkill(source, log, options = {}) {
   const imported = [];
   const skipped = [];
 
+  const nameCount = new Map();
+  for (const candidate of candidates) {
+    if (candidate.kebab && KEBAB_RE.test(candidate.kebab)) nameCount.set(candidate.kebab, (nameCount.get(candidate.kebab) || 0) + 1);
+  }
+
   function failureResult() {
     return {
       ok: false,
@@ -342,6 +442,10 @@ export async function importSkill(source, log, options = {}) {
       failed.push({ source: c.source, error: `无法生成合法 kebab-case 名称（原始名: ${c.rawName || basename(c.source)}）` });
       continue;
     }
+    if (nameCount.get(c.kebab) > 1) {
+      failed.push({ source: c.source, error: `批量来源中存在多个同名插件: ${c.kebab}` });
+      continue;
+    }
     const dest = c.isDir ? join(targetRoot, c.kebab) : join(targetRoot, `${c.kebab}.md`);
     const paths = [join(targetRoot, c.kebab), join(targetRoot, `${c.kebab}.md`)];
     const existing = [];
@@ -367,9 +471,8 @@ export async function importSkill(source, log, options = {}) {
 
   for (const p of pending) {
     try {
-      if (p.isDir) await fs.cp(p.source, p.dest, { recursive: true });
-      else await fs.copyFile(p.source, p.dest);
-      imported.push({ name: p.name, overwritten: false, warnings: [] });
+      const warnings = await replaceWithCopy(p.source, p.dest, p.isDir);
+      imported.push({ name: p.name, overwritten: false, warnings });
       if (log) log("import", `导入 ${p.source} -> ${p.dest}`);
     } catch (e) {
       failed.push({ source: p.source, error: String(e && e.message ? e.message : e) });
@@ -380,10 +483,8 @@ export async function importSkill(source, log, options = {}) {
     for (const c of conflicts) {
       try {
         const dest = c.isDir ? join(targetRoot, c.name) : join(targetRoot, `${c.name}.md`);
-        for (const path of c.paths) await fs.rm(path, { recursive: true, force: true });
-        if (c.isDir) await fs.cp(c.source, dest, { recursive: true });
-        else await fs.copyFile(c.source, dest);
-        imported.push({ name: c.name, overwritten: true, warnings: [] });
+        const warnings = await replaceWithCopy(c.source, dest, c.isDir, c.paths);
+        imported.push({ name: c.name, overwritten: true, warnings });
         if (log) log("import-overwrite", `覆盖导入 ${c.source} -> ${dest}`);
       } catch (e) {
         failed.push({ source: c.source, error: String(e && e.message ? e.message : e) });
@@ -413,6 +514,7 @@ export async function state() {
         description: e.description,
         modelInvocable: e.modelInvocable,
         userInvocable: e.userInvocable,
+        invocationPolicyValid: e.invocationPolicyValid,
       });
     }
     result.roots.push({ key: root.key, path: root.path, label: root.label, mutable: root.mutable, exists, skills });

package/lib/index.js

@@ -3,48 +3,81 @@
 // - 路由：/api/dsh-skills-manager/state | enable | disable | delete | import
 // - $DSH_HOME\skills 可上传、删除、启停；$DSH_AGENTS_HOME\skills 仅允许查看
 
-import { appendFile } from "node:fs/promises";
+import { appendFile, rename, rm, stat } from "node:fs/promises";
 import { state, setSkillEnabled, deleteSkill, importSkill, userRoots, logPath } from "./core.js";
 
 const name = "skills-manager";
 const inject = ["webServer", "skills"];
+const CLIENT_MARKER_HEADER = "x-dsh-skills-manager";
+const MAX_LOG_BYTES = 1 << 20;
 
 function makeLog() {
   const file = logPath();
+  let queue = Promise.resolve();
   return async (event, detail) => {
-    try {
-      await appendFile(file, `${JSON.stringify({ ts: new Date().toISOString(), event, detail })}\n`, "utf8");
-    } catch {
-      /* 日志失败不阻塞主流程 */
-    }
+    queue = queue.then(async () => {
+      try {
+        const current = await stat(file).catch(() => null);
+        if (current && current.size >= MAX_LOG_BYTES) {
+          await rm(`${file}.1`, { force: true });
+          await rename(file, `${file}.1`);
+        }
+        await appendFile(file, `${JSON.stringify({ ts: new Date().toISOString(), event, detail })}\n`, "utf8");
+      } catch {
+        /* 日志失败不阻塞主流程 */
+      }
+    });
+    await queue;
   };
 }
 
 function readBody(req, limit = 1 << 20) {
   return new Promise((resolve, reject) => {
     let size = 0;
+    let settled = false;
     const chunks = [];
+    const fail = (error) => {
+      if (settled) return;
+      settled = true;
+      reject(error);
+    };
     req.on("data", (c) => {
+      if (settled) return;
       size += c.length;
       if (size > limit) {
-        reject(new Error("body too large"));
-        req.destroy();
+        const error = new Error("body too large");
+        error.statusCode = 413;
+        fail(error);
+        req.resume();
         return;
       }
       chunks.push(c);
     });
     req.on("end", () => {
+      if (settled) return;
       try {
         const raw = Buffer.concat(chunks).toString("utf8");
-        resolve(raw ? JSON.parse(raw) : {});
+        const body = raw ? JSON.parse(raw) : {};
+        settled = true;
+        resolve(body);
       } catch (e) {
-        reject(new Error(`invalid JSON body: ${e.message}`));
+        const error = new Error(`invalid JSON body: ${e.message}`);
+        error.statusCode = 400;
+        fail(error);
       }
     });
-    req.on("error", reject);
+    req.on("error", fail);
   });
 }
 
+/** 自定义请求头使跨站 fetch 必须预检；本地接口不提供 CORS 响应。 */
+function validateMutationRequest(req) {
+  if (req.headers[CLIENT_MARKER_HEADER] !== "1") return { statusCode: 403, error: "forbidden mutation request" };
+  const contentType = String(req.headers["content-type"] || "").split(";", 1)[0].trim().toLowerCase();
+  if (contentType !== "application/json") return { statusCode: 415, error: "content-type must be application/json" };
+  return null;
+}
+
 function json(res, code, payload) {
   const body = JSON.stringify(payload);
   res.writeHead(code, {
@@ -104,6 +137,11 @@ function apply(ctx) {
           json(res, 405, { ok: false, error: `method not allowed: ${req.method}` });
           return;
         }
+        const requestError = validateMutationRequest(req);
+        if (requestError) {
+          json(res, requestError.statusCode, { ok: false, error: requestError.error });
+          return;
+        }
         const body = await readBody(req);
         switch (path) {
           case "/api/dsh-skills-manager/enable": {
@@ -128,7 +166,7 @@ function apply(ctx) {
             json(res, 404, { ok: false, error: `unknown action: ${path}` });
         }
       } catch (e) {
-        json(res, 500, { ok: false, error: String(e && e.message ? e.message : e) });
+        json(res, Number.isInteger(e && e.statusCode) ? e.statusCode : 500, { ok: false, error: String(e && e.message ? e.message : e) });
       }
     },
   });

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@michengai/dsh-skills-manager",
-  "version": "0.1.0",
-  "description": "DSH Web plugin: manage local DSH skills and safely view shared Agent skills.",
+  "version": "0.1.2",
+  "description": "NPM-installable DSH Web plugin for managing local skills and viewing shared Agent skills safely.",
   "license": "Apache-2.0",
   "repository": {
     "type": "git",
@@ -47,9 +47,12 @@
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": ">=4.0.1 <5.0.0",
+    "@deepseek-ai/dsh-client-runtime": ">=0.1.0-rc.0 <0.2.0",
+    "@deepseek-ai/dsh-client-ui-slots": ">=0.1.0-rc.0 <0.2.0",
     "@deepseek-ai/dsh-host-webserver": ">=0.1.0-rc.5",
     "@deepseek-ai/dsh-skill": ">=0.1.0-rc.5",
-    "@deepseek-ai/dsh-client-ui-workspace": ">=0.1.0-rc.5"
+    "@deepseek-ai/dsh-client-ui-workspace": ">=0.1.0-rc.5",
+    "react": "^18.2.0"
   },
   "engines": {
     "node": ">=20"