@michaleffffff/mcp-trading-server 3.1.1 → 3.1.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 3.1.2 - 2026-03-23
+### Changed
+- Added local preflight validation for opening `LIMIT` / `STOP` orders so `open_position_simple` and `execute_trade` now fail fast with clear guidance when:
+  - `triggerType` conflicts with the selected open-order semantics
+  - the target price is on the wrong side of the current oracle price for the chosen `LONG` / `SHORT` + `LIMIT` / `STOP` combination
+
 ## 3.1.1 - 2026-03-23
 ### Changed
 - Upgraded the active SDK baseline to `@myx-trade/sdk@^1.0.4`.

package/dist/services/tradeService.js

@@ -121,6 +121,68 @@ function computeRecommendedSizeRaw(targetQuoteRaw, priceRaw30, baseDecimals, quo
     const denominator = priceRaw30 * (10n ** BigInt(quoteDecimals));
     return numerator / denominator;
 }
+function getOrderTypeLabel(orderType) {
+    if (orderType === OrderType.MARKET)
+        return "MARKET";
+    if (orderType === OrderType.LIMIT)
+        return "LIMIT";
+    if (orderType === OrderType.STOP)
+        return "STOP";
+    return `ORDER_TYPE_${String(orderType)}`;
+}
+function getDirectionLabel(direction) {
+    return direction === 0 ? "LONG" : "SHORT";
+}
+function getTriggerTypeLabel(triggerType) {
+    if (triggerType === TriggerType.NONE)
+        return "NONE";
+    if (triggerType === TriggerType.GTE)
+        return "GTE";
+    if (triggerType === TriggerType.LTE)
+        return "LTE";
+    return `TRIGGER_TYPE_${String(triggerType)}`;
+}
+async function validateIncreaseOrderTriggerSemantics(client, args, chainId) {
+    const directionIndex = resolveDirectionIndex(args.direction);
+    const orderType = Number(args.orderType);
+    const explicitTriggerType = args.triggerType;
+    if (orderType === OrderType.MARKET) {
+        if (explicitTriggerType !== undefined && explicitTriggerType !== null && Number(explicitTriggerType) !== TriggerType.NONE) {
+            throw new Error("Invalid triggerType for MARKET open order: MARKET orders must use triggerType=0/NONE.");
+        }
+        return;
+    }
+    if (orderType !== OrderType.LIMIT && orderType !== OrderType.STOP) {
+        return;
+    }
+    const expectedTriggerType = resolveTriggerType(orderType, directionIndex, false);
+    const effectiveTriggerType = explicitTriggerType === undefined || explicitTriggerType === null
+        ? expectedTriggerType
+        : Number(explicitTriggerType);
+    if (effectiveTriggerType !== expectedTriggerType) {
+        throw new Error(`Invalid triggerType for opening ${getDirectionLabel(directionIndex)} ${getOrderTypeLabel(orderType)} order: ` +
+            `expected ${getTriggerTypeLabel(expectedTriggerType)}, got ${getTriggerTypeLabel(effectiveTriggerType)}.`);
+    }
+    const oracleData = await getFreshOraclePrice(client, args.poolId, chainId);
+    const currentPriceRaw = ensureUnits(oracleData.price, 30, "oracle price", { allowImplicitRaw: false });
+    const targetPriceRaw = BigInt(args.priceRaw30);
+    const currentPriceRawBig = BigInt(currentPriceRaw);
+    const currentPriceHuman = formatUnits(currentPriceRawBig, 30);
+    const targetPriceHuman = formatUnits(targetPriceRaw, 30);
+    const orderLabel = `${getDirectionLabel(directionIndex)} ${getOrderTypeLabel(orderType)}`;
+    const shouldBeBelowCurrent = (orderType === OrderType.LIMIT && directionIndex === 0) ||
+        (orderType === OrderType.STOP && directionIndex === 1);
+    const shouldBeAboveCurrent = (orderType === OrderType.STOP && directionIndex === 0) ||
+        (orderType === OrderType.LIMIT && directionIndex === 1);
+    if (shouldBeBelowCurrent && targetPriceRaw >= currentPriceRawBig) {
+        throw new Error(`Invalid ${orderLabel} price: target price ${targetPriceHuman} must be below current oracle price ${currentPriceHuman}. ` +
+            `If you want to trade above current price, use ${directionIndex === 0 ? "STOP LONG" : "LIMIT SHORT"} instead.`);
+    }
+    if (shouldBeAboveCurrent && targetPriceRaw <= currentPriceRawBig) {
+        throw new Error(`Invalid ${orderLabel} price: target price ${targetPriceHuman} must be above current oracle price ${currentPriceHuman}. ` +
+            `If you want to trade below current price, use ${directionIndex === 0 ? "LIMIT LONG" : "STOP SHORT"} instead.`);
+    }
+}
 function validateIncreaseOrderEconomics(args) {
     const collateralRawBig = BigInt(args.collateralRaw);
     const sizeRawBig = BigInt(args.sizeRaw);
@@ -250,6 +312,13 @@ export async function openPosition(client, address, args) {
         baseDecimals,
         quoteDecimals,
     });
+    await validateIncreaseOrderTriggerSemantics(client, {
+        poolId: args.poolId,
+        orderType: Number(args.orderType),
+        direction: args.direction,
+        triggerType: args.triggerType,
+        priceRaw30: priceRaw,
+    }, chainId);
     const timeInForce = mapTimeInForce(args.timeInForce);
     const orderParams = {
         chainId,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@michaleffffff/mcp-trading-server",
-  "version": "3.1.1",
+  "version": "3.1.2",
   "type": "module",
   "bin": {
     "myx-mcp": "dist/server.js"