@michaleffffff/mcp-trading-server 3.0.26 → 3.0.28

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # Changelog
 
+## [3.0.28] - 2026-03-20
+- **Fix**: Disabled problematic Beta mode auto-detection for Arbitrum Sepolia and Linea Sepolia.
+  - This restores discovery for standard testnet pools (e.g., ARB/USDC, KNY/USDC) which were previously hidden in the empty beta environment.
+  - Users can still manually override via `IS_BETA_MODE=true` in `.env`.
+
+## 3.0.27 - 2026-03-20
+
+### Fixed
+- Hardened LP MCP behavior for mismatched token metadata and non-standard ERC20 approvals:
+  - `get_my_lp_holdings` now retries balance discovery against live `poolInfo` LP token addresses when market detail addresses are stale.
+  - LP router fallback now treats SDK `allowance()` read reverts as recoverable and attempts direct router approval/execution.
+  - Removed the MCP-side 5% LP slippage business cap; `manage_liquidity.slippage` now only normalizes ratio input and leaves risk tolerance to the caller / downstream contracts.
+
+### Changed
+- Refreshed operator docs and examples to match current LP execution semantics:
+  - `TOOL_EXAMPLES.md` clarifies LP `slippage` ratio semantics and removal of the business cap.
+  - `trading_best_practices` prompt now aligns with release `v3.0.27`.
+
 ## 3.0.26 - 2026-03-20
 
 ### Fixed
@@ -14,7 +32,7 @@
 - Refreshed operator docs and examples to match current execution semantics:
   - `README.md` now documents explicit `price` in the quick-start trade example, SDK-delegated increase-order funding deltas, and the new `check_account_ready` degraded diagnostics.
   - `TOOL_EXAMPLES.md` now marks `autoDeposit` as deprecated and updates `MARKET` examples to provide `price`.
-  - `trading_best_practices` prompt now explains that pre-checks use SDK `availableMarginBalance` and that increase-order funding reconciliation lives in the SDK.
+  - `trading_best_practices` prompt now explains that pre-checks use SDK `availableMarginBalance`, that increase-order funding reconciliation lives in the SDK, and that LP holdings may be resolved from live pool token addresses.
 - Updated stale tests to match current MCP semantics:
   - `tests/test_trading.ts` now provides `price` for `open_position_simple` market dry runs.
   - `tests/verify_tp_sl_close_invalid_param.mjs` no longer relies on legacy `autoDeposit` semantics and now supplies `price` when opening a market position.

package/README.md

@@ -98,8 +98,11 @@ If `IS_BETA_MODE` is omitted, MCP now auto-detects beta mode for the two testnet
 - **Direction validation**: when a tool operates on an existing `positionId`, the supplied `direction` must match the live position.
 - **TP/SL semantics**: LONG requires `tpPrice > entryPrice` and `slPrice < entryPrice`; SHORT uses the inverse.
 - **LP safety**: LP preview failures are fail-close and no longer downgrade to `minAmountOut=0`.
+- **LP slippage input**: `manage_liquidity.slippage` only validates numeric format and ratio normalization; MCP no longer imposes its own 5% business cap.
 - **LP metadata safety**: `get_pool_metadata(includeLiquidity=true)` now ignores caller-supplied `marketPrice` and derives liquidity depth from a fresh Oracle price only.
 - **LP holdings semantics**: `get_my_lp_holdings` is an inventory view; returned rows are no longer ranked by mixed BASE/QUOTE LP raw balances.
+- **LP token-source safety**: `get_my_lp_holdings` now falls back to live `poolInfo.basePool.poolToken` / `poolInfo.quotePool.poolToken` when market-detail token addresses are stale or mismatched.
+- **LP approval fallback**: when SDK LP deposit paths fail on non-standard `allowance()` reads, MCP falls back to direct router approval/execution instead of stopping at the SDK error.
 
 ---
 

package/TOOL_EXAMPLES.md

@@ -304,6 +304,9 @@ Alias-friendly form also works:
 
 LP preview failures now fail closed; the server no longer downgrades to `minAmountOut=0`.
 Oracle-backed LP pricing requires a fresh price snapshot before execution.
+`slippage` here is a ratio, so `0.01 = 1%` and `0.005 = 0.5%`.
+MCP no longer adds its own 5% LP slippage business cap on top of the provided value.
+When the SDK LP path fails on a non-standard token `allowance()` read, MCP falls back to the direct router path automatically.
 
 ### `get_lp_price`
 Read LP NAV price for BASE or QUOTE side.
@@ -334,6 +337,7 @@ Read current LP balances across pools.
 ```
 
 `get_my_lp_holdings` is an inventory view. Results are now stably ordered by symbol / pool id instead of summing BASE LP raw units with QUOTE LP raw units into a misleading mixed-unit ranking.
+If market detail exposes stale LP token addresses, MCP now re-checks live pool token addresses from pool info before reporting balances.
 
 ---
 

package/dist/auth/resolveClient.js

@@ -3,8 +3,8 @@ import { JsonRpcProvider, Wallet } from "ethers";
 import { normalizeAddress } from "../utils/address.js";
 let cached = null;
 const BETA_BROKERS_BY_CHAIN = {
-    421614: ["0x895c4ae2a22bb26851011d733a9355f663a1f939"],
-    59141: ["0x634efdc9dc76d7abf6e49279875a31b02e9891e2"],
+    421614: [],
+    59141: [],
 };
 function getDefaultBrokerByChainId(chainId) {
     // Testnet mappings

package/dist/prompts/tradingGuide.js

@@ -12,7 +12,7 @@ export const tradingGuidePrompt = {
                     content: {
                         type: "text",
                         text: `
-# MYX Trading MCP Best Practices (v3.0.26)
+# MYX Trading MCP Best Practices (v3.0.27)
 
 You are an expert crypto trader using the MYX Protocol. To ensure successful execution and safe handling of user funds, follow these patterns:
 
@@ -42,6 +42,8 @@ You are an expert crypto trader using the MYX Protocol. To ensure successful exe
 - **TP/SL Semantics**: LONG should use \`tpPrice > entryPrice\` and \`slPrice < entryPrice\`; SHORT uses the inverse. Plain integer strings like \`"65000"\` are treated as human prices, not implicit raw 30-decimal values.
 - **LP Safety**: LP execution requires a fresh price snapshot and preview success; do not continue after preview failure.
 - **LP Read Semantics**: Treat \`get_my_lp_holdings\` as an inventory listing, not a portfolio ranking by economic value.
+- **LP Token Resolution**: If LP balances look empty but pool supply changed, re-check live pool token addresses from pool info instead of trusting market-detail LP token addresses blindly.
+- **LP Approval Fallback**: Some test tokens revert on \`allowance()\`; MCP should treat that as a recoverable LP write-path issue and try the direct router approval/execution path.
 
 ## 3. Testnet Broker Reference
 - Arbitrum test: \`0x895C4ae2A22bB26851011d733A9355f663a1F939\`

package/dist/server.js

@@ -461,7 +461,7 @@ function zodSchemaToJsonSchema(zodSchema) {
     };
 }
 // ─── MCP Server ───
-const server = new Server({ name: "myx-mcp-trading-server", version: "3.0.26" }, { capabilities: { tools: {}, resources: {}, prompts: {} } });
+const server = new Server({ name: "myx-mcp-trading-server", version: "3.0.28" }, { capabilities: { tools: {}, resources: {}, prompts: {} } });
 // List tools
 server.setRequestHandler(ListToolsRequestSchema, async () => {
     return {

package/dist/services/poolService.js

@@ -110,6 +110,14 @@ function isAbiLengthMismatchError(message) {
 function isSdkWaitNotFunctionError(message) {
     return message.toLowerCase().includes("wait is not a function");
 }
+function isAllowanceReadError(message) {
+    const lower = message.toLowerCase();
+    return (lower.includes("function \"allowance\" reverted") ||
+        lower.includes("function 'allowance' reverted") ||
+        lower.includes("allowance(address owner, address spender)") ||
+        lower.includes("allowance(address,address)") ||
+        lower.includes("allowance reverted"));
+}
 function readLastMockTxHash() {
     const hash = String(globalThis?.__MCP_LAST_TX_HASH ?? "").trim();
     if (!hash.startsWith("0x") || hash.length !== 66)
@@ -261,17 +269,33 @@ async function executeLiquidityTxViaRouter(params) {
         throw new Error(`Liquidity ${poolType.toLowerCase()} ${action} amount must be > 0.`);
     }
     let approvalTxHash = null;
+    let approvalMode = "not_required";
+    let allowanceReadError = null;
     if (action === "deposit") {
         const tokenAddress = normalizeAddress(poolType === "QUOTE" ? marketDetail.quoteToken : marketDetail.baseToken, poolType === "QUOTE" ? "quoteToken" : "baseToken");
+        const approvalSpender = poolType === "QUOTE" ? addresses.quotePool : addresses.basePool;
         const tokenContract = new Contract(tokenAddress, ERC20_ABI, signer);
-        const allowance = toPositiveBigint(await tokenContract.allowance(address, addresses.router)) ?? 0n;
-        if (allowance < amountIn) {
-            logger.info(`[LP fallback] allowance insufficient for ${poolType} deposit, approving router. required=${amountIn.toString()}, current=${allowance.toString()}`);
-            const approveTx = await tokenContract.approve(addresses.router, amountIn);
+        let needsApproval = true;
+        try {
+            const allowance = toPositiveBigint(await tokenContract.allowance(address, approvalSpender)) ?? 0n;
+            needsApproval = allowance < amountIn;
+            approvalMode = needsApproval ? "checked_allowance_then_approve" : "existing_allowance";
+            if (!needsApproval) {
+                logger.info(`[LP fallback] allowance already sufficient for ${poolType} deposit. spender=${approvalSpender}, current=${allowance.toString()}, required=${amountIn.toString()}`);
+            }
+        }
+        catch (error) {
+            allowanceReadError = extractErrorMessage(error);
+            approvalMode = "optimistic_approve_after_allowance_revert";
+            logger.warn(`[LP fallback] allowance read failed for ${poolType} deposit; trying direct approve on spender=${approvalSpender}. error=${allowanceReadError}`);
+        }
+        if (needsApproval) {
+            logger.info(`[LP fallback] approving spender=${approvalSpender} for ${poolType} deposit. required=${amountIn.toString()}, mode=${approvalMode}`);
+            const approveTx = await tokenContract.approve(approvalSpender, amountIn);
             approvalTxHash = String(approveTx?.hash ?? "").trim() || null;
             const approveReceipt = await approveTx?.wait?.();
             if (approveReceipt && approveReceipt.status !== 1) {
-                throw new Error(`Router approval transaction reverted for ${poolType} deposit.`);
+                throw new Error(`Approval transaction reverted for ${poolType} deposit (spender=${approvalSpender}).`);
             }
         }
     }
@@ -363,6 +387,9 @@ async function executeLiquidityTxViaRouter(params) {
             usedOraclePrice: oraclePayload.prices.length > 0,
             oracleValue: oraclePayload.value.toString(),
             approvalTxHash,
+            approvalMode,
+            allowanceReadError,
+            approvalSpender: action === "deposit" ? (poolType === "QUOTE" ? addresses.quotePool : addresses.basePool) : null,
         },
     };
 }
@@ -398,6 +425,10 @@ async function executeLiquidityTx(params) {
             logger.warn(`[LP SDK] ABI overload mismatch for ${poolType} ${action}; falling back to explicit router path.`);
             return executeLiquidityTxViaRouter(params);
         }
+        if (isAllowanceReadError(message)) {
+            logger.warn(`[LP SDK] allowance read failed for ${poolType} ${action}; falling back to explicit router path.`);
+            return executeLiquidityTxViaRouter(params);
+        }
         throw error;
     }
 }

package/dist/tools/getMyLpHoldings.js

@@ -4,6 +4,7 @@ import { COMMON_LP_AMOUNT_DECIMALS } from "@myx-trade/sdk";
 import { Contract, formatUnits } from "ethers";
 import { extractErrorMessage } from "../utils/errorMessage.js";
 import { getPoolList } from "../services/marketService.js";
+import { getPoolInfo } from "../services/poolService.js";
 const ADDRESS_RE = /^0x[a-fA-F0-9]{40}$/;
 const ERC20_BALANCE_ABI = ["function balanceOf(address owner) view returns (uint256)"];
 function collectRows(input) {
@@ -126,6 +127,40 @@ async function readErc20Balance(provider, tokenAddress, holder) {
     const balance = await contract.balanceOf(holder);
     return BigInt(balance).toString();
 }
+function collectAddressCandidates(...values) {
+    const unique = new Set();
+    for (const value of values) {
+        const normalized = readAddress(value);
+        if (normalized)
+            unique.add(normalized.toLowerCase());
+    }
+    return Array.from(unique.values());
+}
+async function resolveLpBalanceFromCandidates(provider, holder, candidateAddresses) {
+    let selectedAddress = null;
+    let selectedBalanceRaw = "0";
+    const warnings = [];
+    for (const candidate of candidateAddresses) {
+        try {
+            const balanceRaw = await readErc20Balance(provider, candidate, holder);
+            if (!selectedAddress) {
+                selectedAddress = candidate;
+                selectedBalanceRaw = balanceRaw;
+            }
+            if (BigInt(balanceRaw) > 0n) {
+                return { tokenAddress: candidate, balanceRaw, warnings };
+            }
+        }
+        catch (error) {
+            warnings.push(`${candidate}: ${extractErrorMessage(error)}`);
+        }
+    }
+    return {
+        tokenAddress: selectedAddress,
+        balanceRaw: selectedBalanceRaw,
+        warnings,
+    };
+}
 export const getMyLpHoldingsTool = {
     name: "get_my_lp_holdings",
     description: "[ACCOUNT] List your LP holdings across pools on the current wallet chain by reading base/quote LP token balances. Includes standardized LP asset names: base LP `mBASE.QUOTE`, quote LP `mQUOTE.BASE`.",
@@ -175,6 +210,7 @@ export const getMyLpHoldingsTool = {
                 let basePoolToken = readAddress(row?.basePoolToken ?? row?.base_pool_token);
                 let quotePoolToken = readAddress(row?.quotePoolToken ?? row?.quote_pool_token);
                 let detail = null;
+                let poolInfo = null;
                 if (!basePoolToken || !quotePoolToken) {
                     try {
                         const detailRes = await client.markets.getMarketDetail({ chainId, poolId });
@@ -188,23 +224,34 @@ export const getMyLpHoldingsTool = {
                 }
                 const { baseSymbol, quoteSymbol } = resolveBaseQuoteSymbols(row, detail);
                 const { baseLpAssetName, quoteLpAssetName } = buildLpAssetNames(baseSymbol, quoteSymbol);
-                let baseLpRaw = "0";
-                let quoteLpRaw = "0";
-                if (basePoolToken) {
+                let baseCandidates = collectAddressCandidates(basePoolToken);
+                let quoteCandidates = collectAddressCandidates(quotePoolToken);
+                let baseResolved = await resolveLpBalanceFromCandidates(provider, address, baseCandidates);
+                let quoteResolved = await resolveLpBalanceFromCandidates(provider, address, quoteCandidates);
+                const needPoolInfoEnrichment = (BigInt(baseResolved.balanceRaw) === 0n && BigInt(quoteResolved.balanceRaw) === 0n) ||
+                    !baseResolved.tokenAddress ||
+                    !quoteResolved.tokenAddress;
+                if (needPoolInfoEnrichment) {
                     try {
-                        baseLpRaw = await readErc20Balance(provider, basePoolToken, address);
+                        poolInfo = await getPoolInfo(poolId, chainId, client);
+                        baseCandidates = collectAddressCandidates(...baseCandidates, poolInfo?.basePool?.poolToken, poolInfo?.basePool?.pool_token);
+                        quoteCandidates = collectAddressCandidates(...quoteCandidates, poolInfo?.quotePool?.poolToken, poolInfo?.quotePool?.pool_token);
+                        baseResolved = await resolveLpBalanceFromCandidates(provider, address, baseCandidates);
+                        quoteResolved = await resolveLpBalanceFromCandidates(provider, address, quoteCandidates);
                     }
                     catch (error) {
-                        warnings.push(`pool ${poolId}: failed to read base LP balance (${extractErrorMessage(error)})`);
+                        warnings.push(`pool ${poolId}: failed to enrich pool info (${extractErrorMessage(error)})`);
                     }
                 }
-                if (quotePoolToken) {
-                    try {
-                        quoteLpRaw = await readErc20Balance(provider, quotePoolToken, address);
-                    }
-                    catch (error) {
-                        warnings.push(`pool ${poolId}: failed to read quote LP balance (${extractErrorMessage(error)})`);
-                    }
+                const baseLpRaw = baseResolved.balanceRaw;
+                const quoteLpRaw = quoteResolved.balanceRaw;
+                basePoolToken = baseResolved.tokenAddress ?? basePoolToken;
+                quotePoolToken = quoteResolved.tokenAddress ?? quotePoolToken;
+                for (const warning of baseResolved.warnings) {
+                    warnings.push(`pool ${poolId}: failed to read base LP balance (${warning})`);
+                }
+                for (const warning of quoteResolved.warnings) {
+                    warnings.push(`pool ${poolId}: failed to read quote LP balance (${warning})`);
                 }
                 const hasAnyLp = BigInt(baseLpRaw) > 0n || BigInt(quoteLpRaw) > 0n;
                 if (!includeZero && !hasAnyLp)

package/dist/utils/slippage.js

@@ -3,7 +3,6 @@ export const SLIPPAGE_PCT_4DP_MAX = 10000n;
 export const BUSINESS_SLIPPAGE_PCT_4DP_MAX = BigInt(process.env.BUSINESS_MAX_SLIPPAGE_PCT_4DP ?? "500");
 export const SLIPPAGE_PCT_4DP_DESC = "Slippage in 4-decimal precision raw units (1 = 0.01%, 10000 = 100%)";
 const SLIPPAGE_PERCENT_HUMAN_RE = /^\d+(\.\d{1,2})?$/;
-export const BUSINESS_LP_SLIPPAGE_MAX_RATIO = Number(process.env.BUSINESS_MAX_LP_SLIPPAGE_RATIO ?? 0.05);
 export function isValidSlippagePct4dp(value) {
     if (!SLIPPAGE_PCT_4DP_RE.test(value))
         return false;
@@ -50,9 +49,5 @@ export function normalizeLpSlippageRatio(value, label = "slippage") {
     if (!Number.isFinite(numeric) || numeric < 0) {
         throw new Error(`${label} must be a finite number >= 0.`);
     }
-    const ratio = numeric > 1 && numeric <= 100 ? numeric / 100 : numeric;
-    if (ratio > BUSINESS_LP_SLIPPAGE_MAX_RATIO) {
-        throw new Error(`${label} exceeds business safety cap ${BUSINESS_LP_SLIPPAGE_MAX_RATIO * 100}%.`);
-    }
-    return ratio;
+    return numeric > 1 && numeric <= 100 ? numeric / 100 : numeric;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@michaleffffff/mcp-trading-server",
-  "version": "3.0.26",
+  "version": "3.0.28",
   "type": "module",
   "bin": {
     "myx-mcp": "dist/server.js"