@michaleffffff/mcp-trading-server 3.0.15 → 3.0.16

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 3.0.16 - 2026-03-18
+
+### Fixed
+- Improved MCP-side validation UX:
+  - `executionFeeToken` now fails early with a clear `INVALID_PARAM` when callers pass the zero address, and points users to the real pool `quoteToken`.
+  - `open_position_simple` no longer returns a generic numeric parse error when `collateralAmount` is omitted; it now explains that `collateralAmount` is still required and suggests an approximate value from `size`, `price`, and `leverage`.
+
 ## 3.0.15 - 2026-03-18
 
 ### Fixed

package/README.md

@@ -6,7 +6,7 @@ A production-ready MCP (Model Context Protocol) server for deep integration with
 
 # Release Notes
 
-- **Current release: 3.0.15**
+- **Current release: 3.0.16**
 - **SDK baseline**: `@myx-trade/sdk@^1.0.2` compatibility completed.
 - **Refinement**: Consolidated 40+ specialized tools into ~26 high-level unified tools.
 - **Improved UX**: Enhanced AI parameter parsing, automated unit conversion, and structured error reporting.
@@ -109,6 +109,7 @@ Use these conventions when generating tool arguments:
 - `orderType`: `MARKET` / `LIMIT` / `STOP` / `CONDITIONAL`
 - `timeInForce`: SDK `v1.0.2` currently supports `IOC` only, so use `0` or `"IOC"`
 - `size`: base token quantity, not USD notional; expected order value is usually `collateralAmount * leverage`
+- `executionFeeToken`: must be a real token address; zero address is rejected. Use the pool `quoteToken`
 - Human units: `"100"` means 100 USDC or 100 token units depending on field
 - Raw units: `"raw:1000000"` means exact on-chain integer units
 

package/TOOL_EXAMPLES.md

@@ -74,6 +74,7 @@ Recommended high-level entry tool.
 
 `marketId` is optional on `open_position_simple`. If supplied, it is validated against the market resolved from `poolId` or `keyword`.
 `size` is always the base-asset quantity, not the USD notional. For example, a 500 USD order at price 1200 implies `size ≈ 0.416666...`.
+`collateralAmount` remains required on `open_position_simple`; if omitted, MCP now returns an actionable suggestion instead of a generic parse error.
 
 Raw-units example:
 
@@ -111,6 +112,7 @@ Low-level increase-order tool when you want full control.
 ```
 
 `timeInForce` should be `0` (or `"IOC"` in string form) for SDK `v1.0.2`.
+`executionFeeToken` must be a real token address; do not pass the zero address. Use the pool `quoteToken`.
 
 ### `close_position`
 Close or reduce a position. Use `ALL` for a full close.

package/dist/server.js

@@ -39,7 +39,7 @@ function safeJsonStringify(value) {
 }
 function inferToolErrorCode(message) {
     const lower = message.toLowerCase();
-    if (lower.includes("required") || lower.includes("invalid") || lower.includes("must be") || lower.includes("unexpected") || lower.includes("unrecognized")) {
+    if (lower.includes("required") || lower.includes("invalid") || lower.includes("must be") || lower.includes("unexpected") || lower.includes("unrecognized") || lower.includes("zero address")) {
         return "INVALID_PARAM";
     }
     if (lower.includes("insufficient") && (lower.includes("allowance") || lower.includes("approval"))) {
@@ -461,7 +461,7 @@ function zodSchemaToJsonSchema(zodSchema) {
     };
 }
 // ─── MCP Server ───
-const server = new Server({ name: "myx-mcp-trading-server", version: "3.0.15" }, { capabilities: { tools: {}, resources: {}, prompts: {} } });
+const server = new Server({ name: "myx-mcp-trading-server", version: "3.0.16" }, { capabilities: { tools: {}, resources: {}, prompts: {} } });
 // List tools
 server.setRequestHandler(ListToolsRequestSchema, async () => {
     return {
@@ -582,7 +582,7 @@ server.setRequestHandler(GetPromptRequestSchema, async (request) => {
 async function main() {
     const transport = new StdioServerTransport();
     await server.connect(transport);
-    logger.info("🚀 MYX Trading MCP Server v3.0.15 running (stdio, pure on-chain, prod ready)");
+    logger.info("🚀 MYX Trading MCP Server v3.0.16 running (stdio, pure on-chain, prod ready)");
 }
 main().catch((err) => {
     logger.error("Fatal Server Startup Error", err);

package/dist/tools/executeTrade.js

@@ -7,6 +7,7 @@ import { verifyTradeOutcome } from "../utils/verification.js";
 import { mapDirection, mapOrderType, mapTriggerType } from "../utils/mappings.js";
 import { extractErrorMessage } from "../utils/errorMessage.js";
 import { parseUserUnits } from "../utils/units.js";
+import { isZeroAddress } from "../utils/address.js";
 const POSITION_ID_RE = /^$|^0x[0-9a-fA-F]{64}$/;
 const ZERO_POSITION_ID_RE = /^0x0{64}$/i;
 export const executeTradeTool = {
@@ -61,6 +62,11 @@ export const executeTradeTool = {
             const mappedOrderType = mapOrderType(args.orderType);
             const mappedTriggerType = args.triggerType !== undefined ? mapTriggerType(args.triggerType) : undefined;
             const slippagePctNormalized = normalizeSlippagePct4dp(args.slippagePct);
+            if (args.executionFeeToken !== undefined && args.executionFeeToken !== null && String(args.executionFeeToken).trim() !== "") {
+                if (isZeroAddress(args.executionFeeToken)) {
+                    throw new Error(`executionFeeToken cannot be zero address. Use the pool quoteToken address ${poolData.quoteToken}.`);
+                }
+            }
             const collateralRaw = parseUserUnits(args.collateralAmount, quoteDecimals, "collateralAmount");
             const sizeRaw = parseUserUnits(args.size, baseDecimals, "size");
             const priceRaw = parseUserUnits(args.price, 30, "price");

package/dist/tools/openPositionSimple.js

@@ -1,9 +1,10 @@
 import { z } from "zod";
 import { OrderType } from "@myx-trade/sdk";
+import { formatUnits } from "ethers";
 import { resolveClient, getChainId } from "../auth/resolveClient.js";
 import { resolvePool } from "../services/marketService.js";
 import { openPosition } from "../services/tradeService.js";
-import { normalizeAddress } from "../utils/address.js";
+import { isZeroAddress, normalizeAddress } from "../utils/address.js";
 import { finalizeMutationResult } from "../utils/mutationResult.js";
 import { mapDirection, mapOrderType } from "../utils/mappings.js";
 import { normalizeSlippagePct4dp, SLIPPAGE_PCT_4DP_DESC } from "../utils/slippage.js";
@@ -43,6 +44,7 @@ export const openPositionSimpleTool = {
         direction: z.any().describe("0=LONG, 1=SHORT, or strings like 'BUY'/'SELL'/'LONG'/'SHORT'."),
         collateralAmount: z.coerce
             .string()
+            .optional()
             .describe("Collateral. e.g. '100' (quoted in USDC) or 'raw:100000000'."),
         leverage: z.coerce.number().int().positive().describe("Leverage (integer, e.g. 5, 10)."),
         orderType: z.union([z.string(), z.number()]).optional().describe("MARKET, LIMIT, STOP (default MARKET). Strings allowed."),
@@ -113,21 +115,14 @@ export const openPositionSimpleTool = {
             const defaultAssetClass = Number(poolLevelConfig?.levelConfig?.assetClass ?? 0);
             // 3) Parse & validate primary inputs
             const dir = mapDirection(args.direction);
-            const collateralRaw = parseUserUnits(args.collateralAmount, quoteDecimals, "collateralAmount");
-            const collateralRawBig = asBigint(collateralRaw, "collateralAmount");
-            if (collateralRawBig <= 0n)
-                throw new Error("collateralAmount must be > 0.");
-            const maxTradeAmountHuman = String(process.env.MAX_TRADE_AMOUNT ?? "").trim();
-            if (maxTradeAmountHuman) {
-                const maxTradeRaw = parseUserUnits(maxTradeAmountHuman, quoteDecimals, "MAX_TRADE_AMOUNT");
-                const maxTradeRawBig = asBigint(maxTradeRaw, "MAX_TRADE_AMOUNT");
-                if (collateralRawBig > maxTradeRawBig) {
-                    throw new Error(`collateralAmount exceeds MAX_TRADE_AMOUNT (collateralRaw=${collateralRawBig.toString()} > maxRaw=${maxTradeRawBig.toString()}).`);
-                }
-            }
             const orderType = mapOrderType(args.orderType ?? 0);
             const postOnly = Boolean(args.postOnly ?? false);
             const slippagePct = normalizeSlippagePct4dp(args.slippagePct ?? "50");
+            if (args.executionFeeToken !== undefined && args.executionFeeToken !== null && String(args.executionFeeToken).trim() !== "") {
+                if (isZeroAddress(args.executionFeeToken)) {
+                    throw new Error(`executionFeeToken cannot be zero address. Use the pool quoteToken address ${quoteToken}.`);
+                }
+            }
             const executionFeeToken = normalizeAddress(args.executionFeeToken || quoteToken, "executionFeeToken");
             // 4) Determine reference price (30 decimals)
             let price30;
@@ -157,6 +152,15 @@ export const openPositionSimpleTool = {
             const price30Big = asBigint(price30, "price");
             if (price30Big <= 0n)
                 throw new Error("price must be > 0.");
+            const collateralInput = String(args.collateralAmount ?? "").trim();
+            let collateralRaw = "";
+            let collateralRawBig = 0n;
+            if (collateralInput) {
+                collateralRaw = parseUserUnits(collateralInput, quoteDecimals, "collateralAmount");
+                collateralRawBig = asBigint(collateralRaw, "collateralAmount");
+                if (collateralRawBig <= 0n)
+                    throw new Error("collateralAmount must be > 0.");
+            }
             // 5) Compute or parse size (base raw units)
             let sizeRaw = "";
             let sizeMeta = { source: "computed" };
@@ -166,6 +170,9 @@ export const openPositionSimpleTool = {
                 sizeMeta = { source: "user" };
             }
             else {
+                if (!collateralInput) {
+                    throw new Error("Either collateralAmount or size is required for open_position_simple.");
+                }
                 const notionalQuoteRaw = collateralRawBig * BigInt(args.leverage);
                 const numerator = notionalQuoteRaw * pow10(30 + baseDecimals);
                 const denominator = price30Big * pow10(quoteDecimals);
@@ -176,6 +183,22 @@ export const openPositionSimpleTool = {
                 sizeRaw = computed.toString();
                 sizeMeta = { source: "computed", notionalQuoteRaw: notionalQuoteRaw.toString() };
             }
+            const sizeRawBig = asBigint(sizeRaw, "size");
+            if (!collateralInput) {
+                const notionalQuoteRaw = (sizeRawBig * price30Big * pow10(quoteDecimals)) / pow10(baseDecimals + 30);
+                const suggestedCollateralRaw = notionalQuoteRaw / BigInt(args.leverage);
+                const suggestedCollateralHuman = formatUnits(suggestedCollateralRaw, quoteDecimals);
+                const notionalHuman = formatUnits(notionalQuoteRaw, quoteDecimals);
+                throw new Error(`collateralAmount is required for open_position_simple. Based on size=${userSize || formatUnits(sizeRawBig, baseDecimals)}, price=${priceMeta.human ?? formatUnits(price30Big, 30)}, leverage=${args.leverage}, implied order value is ≈${notionalHuman} quote and suggested collateralAmount is ≈${suggestedCollateralHuman}.`);
+            }
+            const maxTradeAmountHuman = String(process.env.MAX_TRADE_AMOUNT ?? "").trim();
+            if (maxTradeAmountHuman) {
+                const maxTradeRaw = parseUserUnits(maxTradeAmountHuman, quoteDecimals, "MAX_TRADE_AMOUNT");
+                const maxTradeRawBig = asBigint(maxTradeRaw, "MAX_TRADE_AMOUNT");
+                if (collateralRawBig > maxTradeRawBig) {
+                    throw new Error(`collateralAmount exceeds MAX_TRADE_AMOUNT (collateralRaw=${collateralRawBig.toString()} > maxRaw=${maxTradeRawBig.toString()}).`);
+                }
+            }
             // 6) Compute tradingFee (quote raw units)
             let tradingFeeRaw = null;
             let tradingFeeMeta = { source: "computed" };

package/dist/utils/address.js

@@ -1,4 +1,5 @@
 import { getAddress } from "ethers";
+export const ZERO_ADDRESS = "0x0000000000000000000000000000000000000000";
 export function normalizeAddress(value, label = "address") {
     const raw = String(value || "").trim();
     if (!raw)
@@ -15,3 +16,14 @@ export function normalizeAddress(value, label = "address") {
         }
     }
 }
+export function isZeroAddress(value) {
+    const raw = String(value ?? "").trim();
+    if (!raw)
+        return false;
+    try {
+        return getAddress(raw).toLowerCase() === ZERO_ADDRESS;
+    }
+    catch {
+        return raw.toLowerCase() === ZERO_ADDRESS;
+    }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@michaleffffff/mcp-trading-server",
-  "version": "3.0.15",
+  "version": "3.0.16",
   "type": "module",
   "bin": {
     "myx-mcp": "dist/server.js"