@michaelthielemann/kestrel-blobstore-s3 5.6.0 → 5.8.0

package/README.md

@@ -8,8 +8,14 @@ the SDK's retry limit including the first try). `put` stores the `contentType` h
 `Content-Type`, so a bucket served directly answers with the right type; `get` returns bytes only
 and `list` reports key and size. The store never wrote sidecar files.
 
+`move` copies through `CopyObject`, whose `CopySource` is a path: the segments are percent-encoded,
+the slashes separating them are not.
+
 `pnpm test:s3` runs the `blobstore@1` contract test against a real MinIO instance in Podman
-(starts it, creates the bucket, runs `minio.test.ts`, always stops the container).
+(starts it, creates the bucket, runs `minio.test.ts`, always stops the container). Only a real
+S3-compatible target exercises the `CopySource` encoding and the `NoSuchKey`/404 detection on
+`CopyObject`, which a fake says nothing about. `@aws-sdk/client-s3` is a dependency of this package
+alone and not of the workspace root, so the script resolves it from here.
 
 ## Errors
 

package/dist/impl.js

@@ -26,7 +26,6 @@ export function createClient(config) {
 }
 const TRANSIENT_NAMES = new Set(["TimeoutError", "NetworkingError", "AbortError"]);
 const TRANSIENT_CODES = new Set(["ECONNRESET", "ECONNREFUSED", "ETIMEDOUT", "EPIPE", "EAI_AGAIN"]);
-/** After the SDK's own `maxAttempts` are spent, this is the only line separating "retry the caller" from "the operation is broken". */
 function isTransient(cause) {
     const e = boundaryCast(cause, "host");
     const status = e.$metadata?.httpStatusCode;
@@ -90,7 +89,6 @@ export function createBlobstoreS3(config, client = createClient(config)) {
         },
         async move(from, to) {
             const source = fullKey(from);
-            // CopySource is a path: the segments are percent-encoded, the slashes separating them are not
             const copySource = `${config.bucket}/${source.split("/").map(encodeURIComponent).join("/")}`;
             try {
                 await client.send(new CopyObjectCommand({ Bucket: config.bucket, Key: fullKey(to), CopySource: copySource, MetadataDirective: "COPY" }));