@micha.bigler/ui-core-micha 3.14.4 → 4.0.0

package/tests/timeSeriesLegend.test.js

@@ -1,99 +0,0 @@
-// @vitest-environment jsdom
-import React from 'react';
-import i18next from 'i18next';
-import { afterEach, describe, expect, it, vi } from 'vitest';
-import { cleanup, render, screen } from '@testing-library/react';
-import { I18nextProvider } from 'react-i18next';
-import { ThemeProvider, createTheme } from '@mui/material/styles';
-
-const chartSpy = vi.hoisted(() => vi.fn(() => null));
-vi.mock('@mui/x-charts/BarChart', () => ({ BarChart: chartSpy }));
-
-import { TimeSeriesChart } from '../src/components/charts/TimeSeriesChart';
-
-chartSpy.mockImplementation((props) => React.createElement(
-  'div',
-  { 'data-testid': 'mui-bar-chart' },
-  !props.hideLegend
-    ? React.createElement('div', { 'data-testid': 'mui-legend' }, 'MUI legend')
-    : null,
-));
-
-const i18n = i18next.createInstance();
-i18n.init({
-  lng: 'en',
-  resources: {
-    en: {
-      translation: {
-        'TimeSeriesChart.RANGE_LABEL': 'Range',
-        'TimeSeriesChart.RANGE_1_DAY': '1 day',
-        'TimeSeriesChart.RANGE_1_WEEK': '1 week',
-        'TimeSeriesChart.RANGE_1_MONTH': '1 month',
-        'TimeSeriesChart.RANGE_1_YEAR': '1 year',
-        'TimeSeriesChart.SERIES_LABEL': 'Series',
-        'ChartFrame.EMPTY_DEFAULT': 'No data available.',
-        'ChartFrame.LOADING': 'Loading chart.',
-        'ChartFrame.ERROR_DEFAULT': 'The chart could not be loaded.',
-      },
-    },
-  },
-  interpolation: { escapeValue: false },
-});
-
-const MULTI_SERIES = {
-  xLabels: ['Mon', 'Tue'],
-  series: [
-    { key: 'users', label: 'Users', data: [1, 2] },
-    { key: 'hours', label: 'Presence hours', data: [3, 4] },
-  ],
-};
-
-function renderChart(data = MULTI_SERIES) {
-  return render(React.createElement(
-    ThemeProvider,
-    { theme: createTheme() },
-    React.createElement(
-      I18nextProvider,
-      { i18n },
-      React.createElement(TimeSeriesChart, {
-        title: 'Activity',
-        xAxisLabel: 'Day',
-        yAxisLabel: 'Count',
-        data,
-      }),
-    ),
-  ),
-  );
-}
-
-describe('TimeSeriesChart toolbar legend', () => {
-  afterEach(() => {
-    cleanup();
-    vi.clearAllMocks();
-  });
-
-  it('removes the MUI legend when the toolbar names and toggles multiple series', () => {
-    renderChart();
-
-    expect(chartSpy.mock.calls.at(-1)[0].hideLegend).toBe(true);
-    expect(screen.queryByTestId('mui-legend')).toBeNull();
-  });
-
-  it('keeps an accessible name on every toolbar series toggle', () => {
-    renderChart();
-
-    expect(screen.getByRole('checkbox', { name: 'Users' })).toBeTruthy();
-    expect(screen.getByRole('checkbox', { name: 'Presence hours' })).toBeTruthy();
-    expect(screen.getAllByTestId('series-colour-dot')).toHaveLength(2);
-  });
-
-  it('still hides the redundant MUI legend for a single series', () => {
-    renderChart({
-      xLabels: ['Mon', 'Tue'],
-      series: [{ key: 'users', label: 'Users', data: [1, 2] }],
-    });
-
-    expect(chartSpy.mock.calls.at(-1)[0].hideLegend).toBe(true);
-    expect(screen.queryByTestId('mui-legend')).toBeNull();
-  });
-});

package/tests/userScreenTranslations.test.jsx

@@ -1,218 +0,0 @@
-// @vitest-environment jsdom
-import React from 'react';
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
-import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
-import { I18nextProvider } from 'react-i18next';
-import i18next from 'i18next';
-
-const authApi = vi.hoisted(() => ({
-  deleteUser: vi.fn(),
-  fetchUsersList: vi.fn(),
-  sendAdminInvite: vi.fn(),
-  updateUserRole: vi.fn(),
-}));
-
-vi.mock('../src/auth/authApi', () => authApi);
-
-import { authTranslations } from '../src/i18n/authTranslations';
-import { BulkInviteCsvTab } from '../src/components/BulkInviteCsvTab';
-import { UserInviteComponent } from '../src/components/UserInviteComponent';
-import { UserListComponent } from '../src/components/UserListComponent';
-
-const germanResources = Object.fromEntries(
-  Object.entries(authTranslations).map(([key, value]) => [key, value.de]),
-);
-const englishResources = Object.fromEntries(
-  Object.entries(authTranslations).map(([key, value]) => [key, value.en]),
-);
-const i18n = i18next.createInstance();
-i18n.init({
-  lng: 'de',
-  fallbackLng: 'de',
-  resources: { de: { translation: germanResources } },
-  keySeparator: false,
-  nsSeparator: false,
-  interpolation: { escapeValue: false },
-});
-const englishI18n = i18next.createInstance();
-englishI18n.init({
-  lng: 'en',
-  fallbackLng: 'en',
-  resources: { en: { translation: englishResources } },
-  keySeparator: false,
-  nsSeparator: false,
-  interpolation: { escapeValue: false },
-});
-
-const ENGLISH_DEFAULTS = [
-  'All Users',
-  'Search',
-  'Search users...',
-  'Rows per page:',
-  'of 1',
-  'Successful Login',
-  'Are you sure you want to delete this user?',
-  'Invite a new user',
-  'Bulk Invite via CSV',
-  'Upload a CSV file containing email addresses. Header "email" is supported.',
-  'Upload CSV',
-  'Send Invites',
-  'Invitation sent.',
-];
-
-function withGermanI18n(children) {
-  return <I18nextProvider i18n={i18n}>{children}</I18nextProvider>;
-}
-
-function withEnglishI18n(children) {
-  return <I18nextProvider i18n={englishI18n}>{children}</I18nextProvider>;
-}
-
-function expectNoEnglishDefaults() {
-  const text = document.body.textContent;
-  for (const english of ENGLISH_DEFAULTS) {
-    expect(text).not.toContain(english);
-  }
-}
-
-describe('German user and invite screen translations', () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-    authApi.fetchUsersList.mockResolvedValue([
-      {
-        id: 1,
-        email: 'person@example.com',
-        first_name: 'Ada',
-        role: 'student',
-        is_new: true,
-        successful_login: true,
-      },
-    ]);
-    authApi.sendAdminInvite.mockResolvedValue({});
-  });
-
-  afterEach(() => {
-    cleanup();
-  });
-
-  it('renders the empty-list and CSV-error strings in German too', async () => {
-    authApi.fetchUsersList.mockResolvedValue([]);
-    render(withGermanI18n(<UserListComponent currentUser={{ id: 99, is_superuser: true, role: 'admin' }} />));
-    await waitFor(() => expect(screen.getByText('Keine Benutzer gefunden.')).toBeTruthy());
-
-    cleanup();
-
-    render(withGermanI18n(<BulkInviteCsvTab inviteFn={vi.fn()} />));
-    const fileInput = document.querySelector('input[type="file"]');
-    fireEvent.change(fileInput, {
-      target: { files: [new File([''], 'empty.csv', { type: 'text/csv' })] },
-    });
-    await waitFor(() => expect(screen.getByText('Keine gültigen E-Mail-Adressen in der CSV-Datei gefunden.')).toBeTruthy());
-    expectNoEnglishDefaults();
-  });
-
-  it('renders UserListComponent in German, including pagination and action feedback', async () => {
-    const confirm = vi.spyOn(window, 'confirm').mockReturnValue(false);
-    const alert = vi.spyOn(window, 'alert').mockImplementation(() => {});
-
-    render(withGermanI18n(
-      <UserListComponent
-        currentUser={{ id: 99, is_superuser: true, role: 'admin' }}
-        extraRowActions={[{
-          key: 'failing-action',
-          label: 'Aktion',
-          onClick: () => Promise.reject({}),
-        }]}
-      />,
-    ));
-
-    await waitFor(() => expect(screen.getByText('Alle Benutzer')).toBeTruthy());
-    expect(screen.getByLabelText('Suche')).toBeTruthy();
-    expect(screen.getByPlaceholderText('Benutzer suchen...')).toBeTruthy();
-    expect(screen.getByText('1–1 von 1')).toBeTruthy();
-    for (const german of ['Neu', 'Erfolgreiche Anmeldung', 'Rolle', 'Aktionen', 'Zeilen pro Seite:', 'Löschen']) {
-      expect(screen.getByText(german)).toBeTruthy();
-    }
-
-    fireEvent.click(screen.getByRole('button', { name: 'Löschen' }));
-    expect(confirm).toHaveBeenCalledWith('Möchten Sie diesen Benutzer wirklich löschen?');
-
-    fireEvent.click(screen.getByRole('button', { name: 'Aktion' }));
-    await waitFor(() => expect(alert).toHaveBeenCalledWith('Vorgang fehlgeschlagen.'));
-    expectNoEnglishDefaults();
-  });
-
-  it('renders the pagination range in English when the locale is English', async () => {
-    render(withEnglishI18n(<UserListComponent currentUser={{ id: 99, is_superuser: true, role: 'admin' }} />));
-
-    await waitFor(() => expect(screen.getByText('1–1 of 1')).toBeTruthy());
-  });
-
-  it('actually goes through the translation key, not a coincidental match with MUI\'s own default', async () => {
-    // The real English wording is deliberately identical to MUI's own hardcoded default text
-    // (both "{from}-{to} of {count}"), so the assertion above would still pass even if
-    // labelDisplayedRows were reverted to unset entirely. Swap in a distinctive marker for just
-    // this one key to prove the render genuinely resolves it through i18next, not MUI's fallback
-    // (UCM-I18N-5 review, tests lens).
-    const markerI18n = i18next.createInstance();
-    markerI18n.init({
-      lng: 'en',
-      fallbackLng: 'en',
-      resources: {
-        en: {
-          translation: { ...englishResources, 'UserList.DISPLAYED_ROWS': '__MARKER__ {{from}}-{{to}}/{{count}}' },
-        },
-      },
-      keySeparator: false,
-      nsSeparator: false,
-      interpolation: { escapeValue: false },
-    });
-
-    render(
-      <I18nextProvider i18n={markerI18n}>
-        <UserListComponent currentUser={{ id: 99, is_superuser: true, role: 'admin' }} />
-      </I18nextProvider>,
-    );
-
-    await waitFor(() => expect(screen.getByText('__MARKER__ 1-1/1')).toBeTruthy());
-  });
-
-  it('renders UserInviteComponent in German and translates the success message', async () => {
-    render(withGermanI18n(<UserInviteComponent />));
-
-    expect(screen.getByText('Neuen Benutzer einladen')).toBeTruthy();
-    fireEvent.change(screen.getByLabelText('E-Mail-Adresse'), {
-      target: { value: 'new@example.com' },
-    });
-    fireEvent.click(screen.getByRole('button', { name: 'Einladen' }));
-
-    await waitFor(() => expect(screen.getByText('Einladung gesendet.')).toBeTruthy());
-    expectNoEnglishDefaults();
-  });
-
-  it('renders BulkInviteCsvTab in German with translated progress and table copy', async () => {
-    render(withGermanI18n(
-      <BulkInviteCsvTab inviteFn={vi.fn().mockResolvedValue({})} />,
-    ));
-
-    expect(screen.getByText('Masseneinladung per CSV')).toBeTruthy();
-    expect(screen.getByText('CSV-Datei mit E-Mail-Adressen hochladen. Header "email" wird unterstützt.')).toBeTruthy();
-    expect(screen.getByRole('button', { name: 'CSV hochladen' })).toBeTruthy();
-    expect(screen.getByRole('button', { name: 'Einladungen senden' })).toBeTruthy();
-
-    const fileInput = document.querySelector('input[type="file"]');
-    fireEvent.change(fileInput, {
-      target: { files: [new File(['email\nperson@example.com'], 'users.csv', { type: 'text/csv' })] },
-    });
-    await waitFor(() => expect(screen.getByText('1 E-Mail-Adressen geladen')).toBeTruthy());
-
-    fireEvent.click(screen.getByRole('button', { name: 'Einladungen senden' }));
-    await waitFor(() => expect(screen.getByText('1 / 1 Einladungen gesendet.')).toBeTruthy());
-    for (const german of ['Einladung gesendet.', 'Erfolgreich', 'Status', 'Details']) {
-      expect(screen.getByText(german)).toBeTruthy();
-    }
-    expect(document.body.textContent).toContain('1 / 1 verarbeitet');
-    expect(document.body.textContent).toContain('1 erfolgreich');
-    expectNoEnglishDefaults();
-  });
-});

package/tsconfig.build.json

@@ -1,18 +0,0 @@
-{
-  "compilerOptions": {
-    "rootDir": "./src",
-    "outDir": "dist",
-    "allowJs": true,
-    "checkJs": false,
-    "jsx": "react-jsx",
-    "module": "ESNext",
-    "target": "ES2017",
-    "moduleResolution": "Bundler",
-    "ignoreDeprecations": "6.0",
-    "esModuleInterop": true,
-    "skipLibCheck": true,
-    "noEmit": false,
-    "declaration": false
-  },
-  "include": ["src"]
-}

package/vite.config.mjs

@@ -1,6 +0,0 @@
-import { defineConfig } from 'vite';
-import react from '@vitejs/plugin-react';
-
-export default defineConfig({
-  plugins: [react()],
-});

package/work-orders/AUTH-1.md

@@ -1,74 +0,0 @@
-# WORK ORDER AUTH-1 — Password forms: state the rules (proactive helperText + inline validator)
-
-Tier 2 (touches `ui-core-micha` = shared-core). ucm-only, **zero per-app work** (consumers get it
-on their next ucm pin-bump). Origin: Spesix field report 2026-08-06 — a first-time admin setting a
-password from an invitation link could not tell what the password had to satisfy; the only way to
-learn the rules was to submit and read the rejection.
-
-## A. Envelope (authoritative WHAT / WHY)
-
-### Goal
-Tell the user the password rules **before** they submit, and give **instant frontend feedback** on
-the two most common failures — so the invitation/first-contact screen no longer rejects people
-without ever saying what it wants.
-
-### Scope — exactly the two forms that take a NEW password
-- `src/components/PasswordSetForm.jsx` (invitation set + reset-confirm).
-- `src/components/PasswordChangeForm.jsx`.
-- **NOT** `PasswordResetRequestForm.jsx` — verified it takes **email only** (`type="email"`,
-  `onSubmit(email)`), no password field. The Spesix report listed it by mistake.
-
-### Deliverable 1 — proactive helperText (the rules, stated)
-- Render `helperText` on the **new-password** `TextField` in both forms, default =
-  `t('Auth.PASSWORD_RULES_HINT')`.
-- Add `Auth.PASSWORD_RULES_HINT` to `src/i18n/authTranslations.ts` in **de/fr/en**, stating the
-  baseline the template ships with. The baseline is authoritative from dcm
-  `settings_base.py:493-498` (the 4 Django defaults): **min 8 chars · not entirely numeric · not a
-  common password · not too similar to personal info.** Suggested de: „Mindestens 8 Zeichen, nicht
-  nur Zahlen, kein gängiges Passwort." (keep it concise; the similarity rule is niche — translator
-  finalises).
-- Add an **optional prop** `passwordRulesHint` (string) to both forms — overrides the default so an
-  app that configures custom validators can pass matching text. This is the "Better" variant: cheap
-  effort, removes the only real objection (divergence from a customised backend).
-
-### Deliverable 2 — inline validator (signal before the backend rejects)
-Before calling `onSubmit(...)`, validate the two rules that are cheap and faithful to replicate,
-reusing the existing local-error mechanism (`localErrorKey` — the forms already do this for
-empty/mismatch):
-- **min length 8** → `Auth.PASSWORD_TOO_SHORT_LOCAL`,
-- **not entirely numeric** → `Auth.PASSWORD_NUMERIC_LOCAL`.
-Add both keys (de/fr/en). **Deliberately NOT** replicating CommonPassword (needs the ~20k list in
-the browser) or UserAttributeSimilarity (needs user attributes the set-from-invite form doesn't
-have) — those stay backend-enforced; the helperText already warns about them, and AUTH-2 will
-translate their backend rejection. This is a **best-effort UX layer, not a security boundary** —
-the backend stays authoritative (frontend permissive, backend decides).
-
-### Non-goals
-- Don't change the backend or the validators. Don't touch `PasswordResetRequestForm`. Don't touch
-  the `onSubmit` contract or add API-error rendering (that's the deferred reactive error-prop, out
-  of scope). No new screen → **no prototype** (trivial addition per `frontend-design`).
-
-### Tier / rollout
-Tier 2 (shared-core). ucm has **no staging** → publish-from-main: land on `main` → **minor version
-bump** (2.26.4 → 2.27.0) → consumers adopt on their own pin-bump. **Spesix is pinned at 2.5.0**
-(far behind) — it won't receive this until it does a separate, larger ucm pin-bump; that's an
-app-side decision, not part of this WO.
-
-### Required tests
-ucm component tests: helperText renders on both forms (and the `passwordRulesHint` prop overrides);
-the inline validator blocks submit + shows the right message for a <8-char and an all-numeric
-password; de/fr/en keys present for all 3 new strings.
-
-## B. Implementation map (seed)
-- `src/components/PasswordSetForm.jsx` (new-password `TextField` ~L48) + `PasswordChangeForm.jsx` —
-  add `helperText` + the pre-`onSubmit` length/numeric check via `localErrorKey`; add the
-  `passwordRulesHint` prop.
-- `src/i18n/authTranslations.ts` — 3 new keys × de/fr/en: `PASSWORD_RULES_HINT`,
-  `PASSWORD_TOO_SHORT_LOCAL`, `PASSWORD_NUMERIC_LOCAL`.
-- `package.json` — minor bump at finalize (Orchestrator, on green).
-
-**Review:** Tier 2 → independent `reviewer` + **`ui_reviewer`** (frontend diff, i18n coverage).
-**Directive:** implementer leaves the diff; Orchestrator reviews + bumps the version + commits on
-green. Codex out until 2026-08-06 → direct Claude.
-
-**Companion:** AUTH-2 (translate the backend auth error codes — the *reactive* half, broader).

package/work-orders/AUTH-2.md

@@ -1,74 +0,0 @@
-# WORK ORDER AUTH-2 — Translate backend auth error codes (stop leaking raw codes to users)
-
-Tier 2 (touches `ui-core-micha` = shared-core). ucm-only, **zero per-app work** for the core (the
-components already call `t(err.code)` — they just lack the translations). Found alongside the
-AUTH-1 password report: ucm surfaces raw backend error **codes**, not human text.
-
-## A. Envelope (authoritative WHAT / WHY)
-
-### Problem (verified)
-`src/auth/apiClient.jsx:107-124` extracts `err.code` (a machine code) from the backend/allauth
-response. Components then render it as an i18n key: `setErrorKey(err.code || 'Auth.X_FAILED')` →
-`t(errorKey)` (e.g. `SecurityComponent.jsx:60/71`, `ProfileComponent.jsx:143`,
-`MfaLoginComponent.jsx:53`), or `t(err?.code || 'Auth.X_FAILED', 'fallback')`. **The i18n
-catalogue has no entries for these codes** (grep for `email_password_mismatch` / `password_too_*`
-= empty), so i18next returns the key unchanged and the user sees the literal
-**`email_password_mismatch`** (or a generic fallback that hides the specific reason). This affects
-**all** rendering auth screens — login, change-password, MFA, profile — not just passwords.
-
-### Goal
-Render translated, human text for the known backend auth error codes, so the specific reason
-(including the password rules AUTH-1's frontend validator can't replicate — common-password,
-similarity) shows wherever a ucm component already renders an auth error. Because the components
-already `t(err.code)`, this is achieved by **adding the translations** — no component change, no
-app change.
-
-### Deliverable
-1. **Enumerate the backend auth error codes** actually emitted — from allauth-headless + Django
-   password-validator codes, confirmed against real responses (don't guess the full set). Known
-   starters: `email_password_mismatch`, `password_too_short`, `password_too_common`,
-   `password_entirely_numeric` (verify exact spelling), `password_too_similar`, and the current-
-   password / incorrect-password codes surfaced by the change-password flow.
-2. Add i18n entries for each, **de/fr/en**, in `src/i18n/authTranslations.ts`, **keyed by the raw
-   code string** (so the existing `t(err.code)` resolves as a drop-in — no component edit).
-3. Keep the generic `Auth.X_FAILED` fallback for unknown/unmapped codes (no regression).
-
-### Design note — keying (decision to confirm in planning)
-Raw-code keys (`"password_too_short": {...}`) are the **drop-in** fix matching the existing
-`t(err.code)` calls — pure ucm, no backend change. Cleaner but two-repo alternative: have dcm's
-exception handler set a namespaced `i18nKey` per error (apiClient already reads `data.i18nKey`,
-`apiClient.jsx:107`) → ucm keys become `Auth.ERROR.*`. Prefer the drop-in unless the operator wants
-the namespaced contract.
-
-### Scope boundary (honest)
-This fixes screens that **render** the error (login, change-password via `SecurityComponent`, MFA,
-profile). It does **NOT** reach the invitation **`PasswordSetForm`** — that form **delegates**
-`onSubmit` and renders no API error at all; its proactive coverage is AUTH-1 (helperText +
-validator), and its full reactive display would need the deferred per-app error-prop.
-
-### Non-goals
-No component/contract change (translations only, unless the namespaced-`i18nKey` option is chosen →
-then a small dcm touch). No new error surfaces. Don't remove the generic fallbacks.
-
-### Tier / rollout
-Tier 2 (shared-core). Publish-from-main → minor bump → consumers adopt on pin-bump. Zero per-app
-for the core.
-
-### Required tests
-`t(<code>)` resolves to translated text for each mapped code (de/fr/en); an unmapped code still
-falls back to the generic `Auth.*_FAILED`; a representative render path (e.g. `SecurityComponent`
-change-password error) shows human text, not the raw code.
-
-## B. Implementation map (seed)
-- `src/i18n/authTranslations.ts` — add the enumerated code→text entries (de/fr/en).
-- (verification only) `src/auth/apiClient.jsx:107-124` + the `setErrorKey(err.code…)` /
-  `t(err.code…)` call sites — confirm they resolve against the new entries; no edit expected.
-- `package.json` — minor bump at finalize.
-- (optional, if namespaced-`i18nKey` chosen) `django-core-micha` auth exception handler — set
-  `i18nKey` per error.
-
-**Review:** Tier 2 → `reviewer` + **`ui_reviewer`** (i18n/translation coverage — the whole point).
-**Directive:** implementer leaves the diff; Orchestrator reviews + bumps version + commits on
-green. Codex out until 2026-08-06 → direct Claude.
-
-**Companion:** AUTH-1 (the proactive helperText + inline validator — the other half).