@micha.bigler/ui-core-micha 2.33.0 → 2.33.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/WORK_ORDERS.md CHANGED
@@ -60,3 +60,4 @@ prefixed ID; never reuse a bare flat number across workstreams.
60
60
  | AUTH-3 | SignUpPage showed the access-code-specific success message for every signup mode | Operator-observed live bug 2026-08-07: open self-registration (no access code) showed "Falls der Zugangscode für dieses Projekt gültig ist, wurde ein Einladungslink an X gesendet" — nonsensical when there is no code at all. Root cause: `SignUpPage.jsx`'s `handleSubmit` hardcoded `Auth.INVITE_REQUEST_SUCCESS` for every mode (open/access-code/email-domain/QR) regardless of the backend's actual response. | 2026-08-07 | done | 599e73d, b4e1fe7 | No WO file — operator-reported bug, fixed directly, same convention as MSG-6c/MSG-6d/MSG-6j. Tier 2 (shared-core). **Codex → Claude fallback**: one fresh probe made today (new day, prior confirmation was 2026-08-06) — still "workspace out of credits", stamped in `project_codex_quota_status` memory — implemented directly, author-flip rule applied, independent `reviewer` **and** `ui_reviewer` both ran before commit. **Root cause confirmed against the actual backend** (`django-core-micha` `register_request` view + `validate_access_code_or_error`): every signup mode's success response already carries a mode-agnostic, accurate `code: "Auth.INVITE_SENT"`; an invalid access code is never silently accepted, it raises a distinct 400 (`Auth.ACCESS_CODE_INVALID_OR_INACTIVE`) — so the old key's "if valid…" ambiguity never matched backend reality for any mode, not just the ones reported. Fix: `setSuccessKey(res?.code || 'Auth.INVITE_SENT')`, using the backend's own code; no component/app change beyond this. **Both reviewers independently flagged the same P3**: switching away from the old key silently dropped the `{{email}}` confirmation (`Auth.INVITE_SENT` had none). Fixed before commit — extended `Auth.INVITE_SENT`'s text to include `{{email}}` in all 4 locales (safe: it had exactly one consumer, this call site, confirmed by grep). `Auth.INVITE_REQUEST_SUCCESS` is now dead/orphaned (both reviewers flagged as P3, tracked here, not removed — out of this fix's scope). Gate: `tests/SignUpPage.test.jsx` 13/13 (3 new, proving the backend code wins over the old hardcoded key, and the no-code fallback); full suite 342/342, `tsc` clean. |
61
61
  | SHELL-2 | AccountPage: from a horizontal tab strip to a grouped sidebar + mobile drawer | Measured live at 375 px on 2026-08-08 (running cockpit, host header neutralised so the numbers describe ucm alone): `AccountPage` does **not** break the layout -- all six sections render at document width 375. What fails is discoverability and the users table. The tab strip scroller is 343 px visible against 589 px of content with `overflow-x: auto`, 246 px of travel, and **`scrollButtons: 0`** -- Support and any consumer-injected section sit off screen with no arrow, no fade, no hint they exist (they do respond to a horizontal swipe, so this is a discoverability failure, not a reachability one -- unlike cockpit's own header tabs, which are `width: 0px` + `overflow: hidden` and genuinely unreachable). The users table renders 1045 px inside a 341 px `MuiTableContainer`; one third is visible and the `Aktionen` column sits ~700 px to the right. Adopts jg-ferien's `EventInfoPage` pattern (`SectionSwitcher.jsx`, driven from `EventInfoPage.jsx:1126-1159`) in **both** halves -- sticky grouped 280 px sidebar at `md`+, bottom drawer below `md` -- plus an in-page trigger bar, which the reference does not supply because jg's trigger lives in that app's own page header and `AccountPage` has none. | 2026-08-08 | blocked | | **Held back 2026-08-08 — reshaped into DS-11** (see `webapp-management/DESIGN_SYSTEM_PROGRAM.md`): do NOT implement this WO as written; the Envelope will be revised (open: keep the SHELL-2 ID or mint a new SHELL-* ID). Known corrections for the revision: publishing is version-gated, not per-push (this row's "publishes immediately" is imprecise), and the grouped-shell part becomes an inheritable ucm component with `AccountPage` as first consumer. Envelope: [work-orders/SHELL-2.md](work-orders/SHELL-2.md). Prototype: [work-orders/assets/SHELL-2-account-navigation.html](work-orders/assets/SHELL-2-account-navigation.html). Tier 2 (shared core) -- independent `reviewer` (Sonnet, full) **and** `ui_reviewer` concurrently, both mandatory before commit. **Operator decisions, settled 2026-08-08 and not to be renegotiated by implementer or reviewer:** both halves of the pattern, so the horizontal tab strip disappears **on desktop too** (asked explicitly, chosen deliberately, in full knowledge that 14 consumers inherit the desktop change on their next pin bump); fixed groups `Mein Konto` / `Verwaltung` / `Hilfe` / `Weitere`, with `extraTabs` gaining an **optional** `group` field, additive and backward compatible; no standalone "Uebersicht" entry above the groups (jg-ferien has one, `AccountPage` has no overview screen for it to point at, so none is invented); users table becomes a card list below `md` and stays a table at `md`+; the mobile trigger bar is the **sole** carrier of the current section name, so the section heading below it is **removed**, not merely undrawn -- desktop keeps its heading because it has no trigger bar. **Two contracts that must survive and are currently untested:** the `?tab=` URL contract incl. fallback to `profile` on an unknown *or* unpermitted value (`AccountPage.jsx:60`, `:180-186`) -- cockpit's `/user-management`, `/profile` and `/change-password` redirects all hang off it -- and the full `extraTabs` shape (`:146-155`), whose `label` may be a **function** and which supports `visible(context)`. `AccountPage` and `UserListComponent` have **zero tests today** (none of the 20 files under `tests/` touches either), so both test files are new, not extensions. **No staging net:** this repo has no `develop`; a push to `main` touching `src/**` or `package.json` publishes to npm immediately via `publish.yml`, so the independent review is the only gate and is not back-fillable. Version target `2.30.0` (minor -- `extraTabs` gains a public field; additive API is a minor under semver). Explicit non-goals: pagination/filtering for the user list, the sections' internal content, the six auth pages (measured clean at 375 px), and **cockpit's header** -- that toolbar is what inflates the document to 498 px on every route including `/account`, and it is a separate WO in the cockpit repo, sequenced after this one at the operator's choice. Carried-over trap from the reference: jg-ferien uses `env(safe-area-inset-bottom)` while its `index.html` omits `viewport-fit=cover`, so those insets resolve to zero there -- copy the padding, do not assume it does anything. |
62
62
  | SHELL-3 | Promote the mobile bottom navigation into the shared kit | Promotes jg-ferien's `MobileBottomNav` into ucm, shaped from **two** real cases (jg's existing bar + cockpit's destinations) as DS-6 required rather than from jg alone. Two labelled parts, one release: (1) `MuiBottomNavigation`/`MuiBottomNavigationAction` defaults into the baseline plus their completeness-assertion surfaces; (2) the component itself, structure and behaviour only, with `destinations`/`activeRoute`/`onNavigate`/`hideAbove`/`zIndex` props. Each of jg's four recorded promotion blockers becomes a declarative field (`emphasis`, `badgeCount`, finished-string `label`, no jg palette token), and cockpit is what proves each optional. Full spec: [work-orders/SHELL-3.md](work-orders/SHELL-3.md). | 2026-08-11 | done | 56de0c0, <commit> | Implemented `MobileBottomNav`, the additive baseline/completeness surfaces, public export, `2.33.0` version bump, and a five-item/two-badge harness specimen. **Governance note: Codex self-committed (`56de0c0`) and self-marked this row "done" citing its own reviewer/ui_reviewer run — that self-review does not count (author ≠ reviewer) and the row was incorrectly closed before independent review actually ran.** Corrected here: the Orchestrator independently re-ran the scoped tests (22/22 green) and `tsc` (clean), then spawned genuinely independent `reviewer` (Sonnet) + `ui_reviewer` (Sonnet) concurrently against the real diff. **`ui_reviewer` found a real defect (P2):** the component duplicated `borderTop`/`borderColor` inline in `sx` on top of the same values this WO registers in the theme (`tokens.js`/`createAppTheme.js`) — inline `sx` wins over `styleOverrides`, so the theme registration was decorative and any future theme customization of the bar's border would be silently ignored. Fixed by removing the inline duplication from `src/components/MobileBottomNav.jsx`; re-verified 22/22 green, `tsc` clean. **`reviewer` found two non-blocking test-coverage gaps (P2/P3, left as documented, not fixed):** the required "theme-agnosticism" test (item 5b) doesn't actually prove the new `createPaletteAwareComponents` additions do anything, because MUI's own built-in `BottomNavigation`/`BottomNavigationAction` defaults already resolve the same palette paths (`background.paper`/`text.secondary`/`primary.main`) independently of this WO's additions — verified by reading MUI's source; the explicit registration is still correct/required for completeness-assertion purposes, just not distinctively tested by rendering. The `emphasis` treatment's computed colours (raised icon, `background.paper` vs jg's `background.white`) have no dedicated assertion. **Browser verification:** a real Browser-pane render was attempted this session (`ui-core-micha-dev`, port 5199) but the pane did not composite frames (not displayed client-side) — reverted to the same DOM/computed-style substitution Codex used, now corroborated by both independent reviewers reading the rendered defaults against the prototype (`cockpit/work-orders/assets/UI-3-nav-redesign.html` sections 3-4: 22px icons/2px gap/2px padding/12px-500 label confirmed matching). The `env(safe-area-inset-bottom)` CSS declaration is asserted; a non-zero safe-area inset remains unverified (declared, not hidden, per the WO). Precondition of `cockpit/UI-3` and `jg-ferien/NAV-36`. |
63
+ | SHELL-4 | Give each bottom-nav property exactly one home | `SHELL-3` shipped all visible styling in the theme layer and only position/`zIndex`/safe-area in the component, so a consumer that has NOT adopted `createAppTheme` gets a structurally broken bar. Moves the four properties the component needs on ANY theme into the component as its single home — `minWidth: 0`, `maxWidth: 'none'`, `borderTop: '1px solid'`, `borderColor: 'divider'` as an sx token reference — deletes them from `tokens.js`/`createAppTheme.js`, deregisters their four assertion surfaces (twenty to sixteen), and adds an `sx` prop as the escape hatch for what just became theme-unoverridable. Full spec: [work-orders/SHELL-4.md](work-orders/SHELL-4.md). | 2026-08-11 | done | this commit | Implemented the four-property layer move, narrowed completeness inventory, `sx` escape hatch, dual-theme harness specimen, and `2.33.1` patch bump. **Independent `reviewer` + `ui_reviewer` ran concurrently before commit.** `ui_reviewer`: NO FINDINGS. `reviewer` found one P2: object-spreading `sx` dropped standard MUI callback/array forms; fixed by flattening the caller value after the component defaults in an MUI `sx` array, with regression coverage for object, callback, and array precedence. Re-verified: 30/30 scoped tests green; `tsc -p tsconfig.build.json --noEmit` clean. **Rendered verification substitution:** no in-app or external browser instance was attached, so real 375px/1280px screenshots could not be obtained. Per the WO fallback, DOM/computed-style inspection under plain `createTheme()` at 375px with five actions confirmed `border-top-width: 1px`, `min-width: 0px`, `max-width: none`, and `flex-grow: 1`; the dual-theme harness specimen remains available for a later real-browser comparison. **Precondition of `jg-ferien/NAV-36`, which is `blocked` on it.** Root cause retained: `SHELL-3`'s `ui_reviewer` correctly found the component shadowing its own new theme defaults, and the fix (`586ac9c`) resolved the duplication by deleting the wrong copy — the defect was the duplication, not the location. The component/theme key-intersection test now mechanically guards that regression class, and a deregistered-surface exemption is asserted to remain harmless. |
package/dev/entries.jsx CHANGED
@@ -31,6 +31,7 @@ import {
31
31
  Tooltip,
32
32
  Typography,
33
33
  } from '@mui/material';
34
+ import { ThemeProvider, createTheme } from '@mui/material/styles';
34
35
 
35
36
  import { AuthContext } from '../src/auth/AuthContext';
36
37
  import { MobileBottomNav } from '../src/components/MobileBottomNav';
@@ -74,6 +75,8 @@ const MOBILE_NAV_DESTINATIONS = [
74
75
  { route: '/more', label: 'Mehr', icon: MoreHorizIcon, emphasis: true },
75
76
  ];
76
77
 
78
+ const PLAIN_MOBILE_NAV_THEME = createTheme();
79
+
77
80
  function MobileBottomNavEntry() {
78
81
  const [activeRoute, setActiveRoute] = useState('/triage');
79
82
 
@@ -81,14 +84,33 @@ function MobileBottomNavEntry() {
81
84
  <Box sx={{ minHeight: 180 }}>
82
85
  <Typography variant="h6">Mobile bottom navigation</Typography>
83
86
  <Typography color="text.secondary">
84
- Five destinations, two badges, and one emphasised action. This specimen follows the real
85
- browser viewport: resize below 900px to show the bar and to 900px or wider to hide it.
87
+ The baseline and plain-MUI variants use the same five destinations. Both keep their edge
88
+ and evenly divided actions; their label and icon density may differ.
86
89
  </Typography>
87
- <MobileBottomNav
88
- destinations={MOBILE_NAV_DESTINATIONS}
89
- activeRoute={activeRoute}
90
- onNavigate={setActiveRoute}
91
- />
90
+ <Stack direction={{ xs: 'column', lg: 'row' }} spacing={2} sx={{ mt: 2 }}>
91
+ <Box sx={{ flex: 1, minWidth: 0 }}>
92
+ <Typography variant="subtitle2">createAppTheme baseline</Typography>
93
+ <MobileBottomNav
94
+ destinations={MOBILE_NAV_DESTINATIONS}
95
+ activeRoute={activeRoute}
96
+ onNavigate={setActiveRoute}
97
+ hideAbove="xl"
98
+ sx={{ position: 'relative', width: '100%', mt: 1 }}
99
+ />
100
+ </Box>
101
+ <ThemeProvider theme={PLAIN_MOBILE_NAV_THEME}>
102
+ <Box sx={{ flex: 1, minWidth: 0 }}>
103
+ <Typography variant="subtitle2">Plain createTheme</Typography>
104
+ <MobileBottomNav
105
+ destinations={MOBILE_NAV_DESTINATIONS}
106
+ activeRoute={activeRoute}
107
+ onNavigate={setActiveRoute}
108
+ hideAbove="xl"
109
+ sx={{ position: 'relative', width: '100%', mt: 1 }}
110
+ />
111
+ </Box>
112
+ </ThemeProvider>
113
+ </Stack>
92
114
  </Box>
93
115
  );
94
116
  }
@@ -5,19 +5,29 @@ import BottomNavigationAction from '@mui/material/BottomNavigationAction';
5
5
  import useMediaQuery from '@mui/material/useMediaQuery';
6
6
  import { useTheme } from '@mui/material/styles';
7
7
  const defaultZIndex = (theme) => theme.zIndex.drawer + 2;
8
- export function MobileBottomNav({ destinations, activeRoute, onNavigate, hideAbove = 'md', zIndex = defaultZIndex, }) {
8
+ export const MOBILE_BOTTOM_NAV_ROOT_SX = {
9
+ position: 'fixed',
10
+ left: 0,
11
+ right: 0,
12
+ bottom: 0,
13
+ borderTop: '1px solid',
14
+ borderColor: 'divider',
15
+ paddingBottom: 'env(safe-area-inset-bottom)',
16
+ };
17
+ export const MOBILE_BOTTOM_NAV_ACTION_SX = {
18
+ minWidth: 0,
19
+ maxWidth: 'none',
20
+ };
21
+ export function MobileBottomNav({ destinations, activeRoute, onNavigate, hideAbove = 'md', zIndex = defaultZIndex, sx = {}, }) {
9
22
  const theme = useTheme();
10
23
  const isHidden = useMediaQuery(theme.breakpoints.up(hideAbove));
24
+ const callerSx = Array.isArray(sx) ? sx : [sx];
11
25
  if (isHidden)
12
26
  return null;
13
- return (_jsx(BottomNavigation, { value: activeRoute, onChange: (_, route) => onNavigate(route), showLabels: true, sx: {
14
- position: 'fixed',
15
- left: 0,
16
- right: 0,
17
- bottom: 0,
18
- zIndex,
19
- paddingBottom: 'env(safe-area-inset-bottom)',
20
- }, children: destinations.map((destination) => {
27
+ return (_jsx(BottomNavigation, { value: activeRoute, onChange: (_, route) => onNavigate(route), showLabels: true, sx: [
28
+ Object.assign(Object.assign({}, MOBILE_BOTTOM_NAV_ROOT_SX), { zIndex }),
29
+ ...callerSx,
30
+ ], children: destinations.map((destination) => {
21
31
  var _a;
22
32
  const Icon = destination.icon;
23
33
  const selected = activeRoute === destination.route;
@@ -29,6 +39,6 @@ export function MobileBottomNav({ destinations, activeRoute, onNavigate, hideAbo
29
39
  boxShadow: 'none',
30
40
  transform: 'translateY(-4px)',
31
41
  } : undefined }));
32
- return (_jsx(BottomNavigationAction, { value: destination.route, label: (_a = destination.shortLabel) !== null && _a !== void 0 ? _a : destination.label, "aria-label": destination.shortLabel != null ? destination.label : undefined, "aria-current": selected ? 'page' : undefined, icon: destination.badgeCount ? (_jsx(Badge, { badgeContent: destination.badgeCount, color: "error", max: 99, children: icon })) : icon }, destination.route));
42
+ return (_jsx(BottomNavigationAction, { value: destination.route, label: (_a = destination.shortLabel) !== null && _a !== void 0 ? _a : destination.label, "aria-label": destination.shortLabel != null ? destination.label : undefined, "aria-current": selected ? 'page' : undefined, sx: MOBILE_BOTTOM_NAV_ACTION_SX, icon: destination.badgeCount ? (_jsx(Badge, { badgeContent: destination.badgeCount, color: "error", max: 99, children: icon })) : icon }, destination.route));
33
43
  }) }));
34
44
  }
@@ -104,7 +104,6 @@ function createPaletteAwareComponents(palette) {
104
104
  styleOverrides: {
105
105
  root: {
106
106
  backgroundColor: palette.background.paper,
107
- borderColor: palette.divider,
108
107
  },
109
108
  },
110
109
  },
@@ -72,12 +72,8 @@ const COMPONENT_SURFACES = [
72
72
  var _a, _b, _c, _d, _e, _f;
73
73
  return (_f = (_e = (_d = (_c = (_b = (_a = theme.components) === null || _a === void 0 ? void 0 : _a.MuiChip) === null || _b === void 0 ? void 0 : _b.styleOverrides) === null || _c === void 0 ? void 0 : _c.root) === null || _d === void 0 ? void 0 : _d['@media (any-pointer: coarse)']) === null || _e === void 0 ? void 0 : _e['&::after']) === null || _f === void 0 ? void 0 : _f.inset;
74
74
  }),
75
- componentPath('MuiBottomNavigation', 'styleOverrides.root.borderTop'),
76
75
  componentPath('MuiBottomNavigation', 'styleOverrides.root.boxShadow'),
77
76
  componentPath('MuiBottomNavigation', 'styleOverrides.root.backgroundColor'),
78
- componentPath('MuiBottomNavigation', 'styleOverrides.root.borderColor'),
79
- componentPath('MuiBottomNavigationAction', 'styleOverrides.root.minWidth'),
80
- componentPath('MuiBottomNavigationAction', 'styleOverrides.root.maxWidth'),
81
77
  componentPath('MuiBottomNavigationAction', 'styleOverrides.root.padding'),
82
78
  componentPath('MuiBottomNavigationAction', 'styleOverrides.root.gap'),
83
79
  componentKeyLeaf('MuiBottomNavigationAction', 'styleOverrides.root', '& .MuiSvgIcon-root', 'width'),
@@ -262,14 +262,12 @@ export const BASELINE_STATIC = {
262
262
  },
263
263
  MuiBottomNavigation: {
264
264
  styleOverrides: {
265
- root: { borderTop: '1px solid', boxShadow: 'none' },
265
+ root: { boxShadow: 'none' },
266
266
  },
267
267
  },
268
268
  MuiBottomNavigationAction: {
269
269
  styleOverrides: {
270
270
  root: {
271
- minWidth: 0,
272
- maxWidth: 'none',
273
271
  padding: '0 2px',
274
272
  gap: '2px',
275
273
  '& .MuiSvgIcon-root': { width: '22px', height: '22px' },
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@micha.bigler/ui-core-micha",
3
- "version": "2.33.0",
3
+ "version": "2.33.1",
4
4
  "main": "dist/index.js",
5
5
  "module": "dist/index.js",
6
6
  "repository": {
@@ -6,15 +6,32 @@ import { useTheme } from '@mui/material/styles';
6
6
 
7
7
  const defaultZIndex = (theme) => theme.zIndex.drawer + 2;
8
8
 
9
+ export const MOBILE_BOTTOM_NAV_ROOT_SX = {
10
+ position: 'fixed',
11
+ left: 0,
12
+ right: 0,
13
+ bottom: 0,
14
+ borderTop: '1px solid',
15
+ borderColor: 'divider',
16
+ paddingBottom: 'env(safe-area-inset-bottom)',
17
+ };
18
+
19
+ export const MOBILE_BOTTOM_NAV_ACTION_SX = {
20
+ minWidth: 0,
21
+ maxWidth: 'none',
22
+ };
23
+
9
24
  export function MobileBottomNav({
10
25
  destinations,
11
26
  activeRoute,
12
27
  onNavigate,
13
28
  hideAbove = 'md',
14
29
  zIndex = defaultZIndex,
30
+ sx = {},
15
31
  }) {
16
32
  const theme = useTheme();
17
33
  const isHidden = useMediaQuery(theme.breakpoints.up(hideAbove));
34
+ const callerSx = Array.isArray(sx) ? sx : [sx];
18
35
 
19
36
  if (isHidden) return null;
20
37
 
@@ -23,14 +40,10 @@ export function MobileBottomNav({
23
40
  value={activeRoute}
24
41
  onChange={(_, route) => onNavigate(route)}
25
42
  showLabels
26
- sx={{
27
- position: 'fixed',
28
- left: 0,
29
- right: 0,
30
- bottom: 0,
31
- zIndex,
32
- paddingBottom: 'env(safe-area-inset-bottom)',
33
- }}
43
+ sx={[
44
+ { ...MOBILE_BOTTOM_NAV_ROOT_SX, zIndex },
45
+ ...callerSx,
46
+ ]}
34
47
  >
35
48
  {destinations.map((destination) => {
36
49
  const Icon = destination.icon;
@@ -55,6 +68,7 @@ export function MobileBottomNav({
55
68
  label={destination.shortLabel ?? destination.label}
56
69
  aria-label={destination.shortLabel != null ? destination.label : undefined}
57
70
  aria-current={selected ? 'page' : undefined}
71
+ sx={MOBILE_BOTTOM_NAV_ACTION_SX}
58
72
  icon={destination.badgeCount ? (
59
73
  <Badge badgeContent={destination.badgeCount} color="error" max={99}>
60
74
  {icon}
@@ -120,7 +120,6 @@ function createPaletteAwareComponents(palette) {
120
120
  styleOverrides: {
121
121
  root: {
122
122
  backgroundColor: palette.background.paper,
123
- borderColor: palette.divider,
124
123
  },
125
124
  },
126
125
  },
@@ -96,12 +96,8 @@ const COMPONENT_SURFACES = [
96
96
  (theme) => theme.components?.MuiChip?.styleOverrides?.root
97
97
  ?.['@media (any-pointer: coarse)']?.['&::after']?.inset,
98
98
  ),
99
- componentPath('MuiBottomNavigation', 'styleOverrides.root.borderTop'),
100
99
  componentPath('MuiBottomNavigation', 'styleOverrides.root.boxShadow'),
101
100
  componentPath('MuiBottomNavigation', 'styleOverrides.root.backgroundColor'),
102
- componentPath('MuiBottomNavigation', 'styleOverrides.root.borderColor'),
103
- componentPath('MuiBottomNavigationAction', 'styleOverrides.root.minWidth'),
104
- componentPath('MuiBottomNavigationAction', 'styleOverrides.root.maxWidth'),
105
101
  componentPath('MuiBottomNavigationAction', 'styleOverrides.root.padding'),
106
102
  componentPath('MuiBottomNavigationAction', 'styleOverrides.root.gap'),
107
103
  componentKeyLeaf('MuiBottomNavigationAction', 'styleOverrides.root', '& .MuiSvgIcon-root', 'width'),
@@ -308,14 +308,12 @@ export const BASELINE_STATIC = {
308
308
  },
309
309
  MuiBottomNavigation: {
310
310
  styleOverrides: {
311
- root: { borderTop: '1px solid', boxShadow: 'none' },
311
+ root: { boxShadow: 'none' },
312
312
  },
313
313
  },
314
314
  MuiBottomNavigationAction: {
315
315
  styleOverrides: {
316
316
  root: {
317
- minWidth: 0,
318
- maxWidth: 'none',
319
317
  padding: '0 2px',
320
318
  gap: '2px',
321
319
  '& .MuiSvgIcon-root': { width: '22px', height: '22px' },
@@ -4,7 +4,11 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
4
4
  import { cleanup, fireEvent, render, screen, within } from '@testing-library/react';
5
5
  import { ThemeProvider, createTheme } from '@mui/material/styles';
6
6
 
7
- import { MobileBottomNav } from '../src/components/MobileBottomNav';
7
+ import {
8
+ MOBILE_BOTTOM_NAV_ACTION_SX,
9
+ MOBILE_BOTTOM_NAV_ROOT_SX,
10
+ MobileBottomNav,
11
+ } from '../src/components/MobileBottomNav';
8
12
  import { createAppTheme } from '../src/theme/createAppTheme';
9
13
 
10
14
  const theme = createAppTheme({ palette: { primary: { main: '#0F62FE' } } });
@@ -179,6 +183,101 @@ describe('MobileBottomNav', () => {
179
183
  });
180
184
  });
181
185
 
186
+ it('keeps its structural edge and evenly divided actions under a plain MUI theme', () => {
187
+ const fiveDestinations = [
188
+ ...destinations,
189
+ { route: '/fourth', label: 'Fourth', icon: Icon },
190
+ { route: '/fifth', label: 'Fifth', icon: Icon },
191
+ ];
192
+ setViewportWidth(375);
193
+ const { container } = render(
194
+ <ThemeProvider theme={createTheme()}>
195
+ <MobileBottomNav
196
+ destinations={fiveDestinations}
197
+ activeRoute="/first"
198
+ onNavigate={vi.fn()}
199
+ />
200
+ </ThemeProvider>,
201
+ );
202
+ const navStyle = getComputedStyle(container.firstElementChild);
203
+ const actionStyles = screen.getAllByRole('button').map((action) => getComputedStyle(action));
204
+
205
+ expect(navStyle.borderTopWidth).toBe('1px');
206
+ expect(navStyle.borderTopStyle).toBe('solid');
207
+ expect(actionStyles).toHaveLength(5);
208
+ actionStyles.forEach((actionStyle) => {
209
+ expect(actionStyle.minWidth).toBe('0px');
210
+ expect(actionStyle.maxWidth).toBe('none');
211
+ expect(actionStyle.flexGrow).toBe('1');
212
+ });
213
+ });
214
+
215
+ it('keeps component-owned sx keys out of baseline theme overrides', () => {
216
+ const componentSurfaces = [
217
+ ...Object.keys(MOBILE_BOTTOM_NAV_ROOT_SX)
218
+ .map((key) => `MuiBottomNavigation.${key}`),
219
+ ...Object.keys(MOBILE_BOTTOM_NAV_ACTION_SX)
220
+ .map((key) => `MuiBottomNavigationAction.${key}`),
221
+ ];
222
+ const themeSurfaces = [
223
+ ...Object.keys(theme.components.MuiBottomNavigation.styleOverrides.root)
224
+ .map((key) => `MuiBottomNavigation.${key}`),
225
+ ...Object.keys(theme.components.MuiBottomNavigationAction.styleOverrides.root)
226
+ .map((key) => `MuiBottomNavigationAction.${key}`),
227
+ ];
228
+
229
+ expect(componentSurfaces.filter((surface) => themeSurfaces.includes(surface))).toEqual([]);
230
+ });
231
+
232
+ it.each([
233
+ ['object', {
234
+ position: 'absolute',
235
+ borderTop: '3px dashed',
236
+ borderColor: 'primary.main',
237
+ }],
238
+ ['callback', (currentTheme) => ({
239
+ position: 'absolute',
240
+ borderTop: '3px dashed',
241
+ borderColor: currentTheme.palette.primary.main,
242
+ })],
243
+ ['array', [
244
+ { borderTop: '2px dotted' },
245
+ {
246
+ position: 'absolute',
247
+ borderTop: '3px dashed',
248
+ borderColor: 'primary.main',
249
+ },
250
+ ]],
251
+ ])('lets caller %s sx override the component defaults', (_kind, sx) => {
252
+ const { container } = renderNav({
253
+ sx,
254
+ });
255
+ const navStyle = getComputedStyle(container.firstElementChild);
256
+
257
+ expect(navStyle.position).toBe('absolute');
258
+ expect(navStyle.borderTopWidth).toBe('3px');
259
+ expect(navStyle.borderTopStyle).toBe('dashed');
260
+ expect(navStyle.borderTopColor).toBe('rgb(15, 98, 254)');
261
+ });
262
+
263
+ it('preserves baseline density and label styling after the structural values move', () => {
264
+ renderNav();
265
+ const [selectedAction] = screen.getAllByRole('button');
266
+ const actionStyle = getComputedStyle(selectedAction);
267
+ const labelStyle = getComputedStyle(
268
+ selectedAction.querySelector('.MuiBottomNavigationAction-label'),
269
+ );
270
+
271
+ expect(actionStyle.minWidth).toBe('0px');
272
+ expect(actionStyle.maxWidth).toBe('none');
273
+ expect(actionStyle.paddingLeft).toBe('2px');
274
+ expect(actionStyle.paddingRight).toBe('2px');
275
+ expect(actionStyle.gap).toBe('2px');
276
+ expect(labelStyle.fontSize).toBe('12px');
277
+ expect(labelStyle.fontWeight).toBe('500');
278
+ expect(labelStyle.lineHeight).toBe('1.2');
279
+ });
280
+
182
281
  it('renders nothing at and above hideAbove', () => {
183
282
  setMediaQueryMatches((query) => query === '(min-width:900px)');
184
283
  const { container } = renderNav();
@@ -195,7 +294,7 @@ describe('MobileBottomNav', () => {
195
294
  expect(nav.classList.contains('MuiBottomNavigation-root')).toBe(true);
196
295
  // jsdom drops env() declarations while parsing CSS, so assert the sx
197
296
  // declaration before browser CSS parsing instead of a computed inset.
198
- expect(MobileBottomNav.toString()).toContain('env(safe-area-inset-bottom)');
297
+ expect(MOBILE_BOTTOM_NAV_ROOT_SX.paddingBottom).toBe('env(safe-area-inset-bottom)');
199
298
  });
200
299
 
201
300
  it('renders the five-item, two-badge specimen at 375px and nothing at 1280px', () => {
@@ -1,7 +1,7 @@
1
1
  import { createTheme } from '@mui/material/styles';
2
2
  import { describe, expect, it } from 'vitest';
3
3
 
4
- import { assertThemeComplete, createAppTheme } from '../src/index';
4
+ import { assertThemeComplete, createAppTheme } from '../src/theme';
5
5
  import { BASELINE_STATIC } from '../src/theme/tokens';
6
6
 
7
7
  describe('createAppTheme', () => {
@@ -23,12 +23,16 @@ describe('createAppTheme', () => {
23
23
  '&.Mui-selected': { fontSize: '12px' },
24
24
  });
25
25
  expect(theme.components.MuiBottomNavigationAction.styleOverrides.root).toMatchObject({
26
- minWidth: 0,
27
- maxWidth: 'none',
28
26
  padding: '0 2px',
29
27
  gap: '2px',
30
28
  '& .MuiSvgIcon-root': { width: '22px', height: '22px' },
31
29
  });
30
+ expect(theme.components.MuiBottomNavigation.styleOverrides.root).not.toHaveProperty('borderTop');
31
+ expect(theme.components.MuiBottomNavigation.styleOverrides.root).not.toHaveProperty('borderColor');
32
+ expect(theme.components.MuiBottomNavigationAction.styleOverrides.root)
33
+ .not.toHaveProperty('minWidth');
34
+ expect(theme.components.MuiBottomNavigationAction.styleOverrides.root)
35
+ .not.toHaveProperty('maxWidth');
32
36
  expect(theme.palette.dataSeries.categorical).toHaveLength(6);
33
37
  expect(theme.palette.primary.light).not.toBe(createTheme().palette.primary.light);
34
38
  // MUI's createTheme(options, ...args) only augments the FIRST argument's
@@ -5,7 +5,8 @@ import {
5
5
  assertThemeComplete,
6
6
  calculateContrastRatio,
7
7
  createAppTheme,
8
- } from '../src/index';
8
+ THEME_COMPLETENESS_SURFACES,
9
+ } from '../src/theme';
9
10
 
10
11
  describe('theme completeness', () => {
11
12
  it('finds untouched MUI surfaces and accepts createAppTheme', () => {
@@ -20,12 +21,8 @@ describe('theme completeness', () => {
20
21
  .map(({ surface }) => surface))
21
22
  .toContain('components.MuiButton.styleOverrides.root.minHeight');
22
23
  expect(bare.findings.map(({ surface }) => surface)).toEqual(expect.arrayContaining([
23
- 'components.MuiBottomNavigation.styleOverrides.root.borderTop',
24
24
  'components.MuiBottomNavigation.styleOverrides.root.boxShadow',
25
25
  'components.MuiBottomNavigation.styleOverrides.root.backgroundColor',
26
- 'components.MuiBottomNavigation.styleOverrides.root.borderColor',
27
- 'components.MuiBottomNavigationAction.styleOverrides.root.minWidth',
28
- 'components.MuiBottomNavigationAction.styleOverrides.root.maxWidth',
29
26
  'components.MuiBottomNavigationAction.styleOverrides.root.padding',
30
27
  'components.MuiBottomNavigationAction.styleOverrides.root.gap',
31
28
  'components.MuiBottomNavigationAction.styleOverrides.root.& .MuiSvgIcon-root.width',
@@ -44,6 +41,34 @@ describe('theme completeness', () => {
44
41
  expect(baseline.findings).toEqual([]);
45
42
  });
46
43
 
44
+ it('keeps the narrowed bottom-navigation inventory complete', () => {
45
+ const bottomNavigationSurfaces = THEME_COMPLETENESS_SURFACES
46
+ .map(({ surface }) => surface)
47
+ .filter((surface) => surface.startsWith('components.MuiBottomNavigation'));
48
+
49
+ expect(bottomNavigationSurfaces).toHaveLength(16);
50
+ [
51
+ 'components.MuiBottomNavigation.styleOverrides.root.borderTop',
52
+ 'components.MuiBottomNavigation.styleOverrides.root.borderColor',
53
+ 'components.MuiBottomNavigationAction.styleOverrides.root.minWidth',
54
+ 'components.MuiBottomNavigationAction.styleOverrides.root.maxWidth',
55
+ ].forEach((surface) => expect(bottomNavigationSurfaces).not.toContain(surface));
56
+ });
57
+
58
+ it('ignores a valid exemption for a deregistered surface', () => {
59
+ const result = assertThemeComplete(
60
+ createAppTheme({ palette: { primary: { main: '#0F62FE' } } }),
61
+ {
62
+ exemptions: [{
63
+ surface: 'components.MuiBottomNavigation.styleOverrides.root.borderTop',
64
+ reason: 'Legacy exemption retained while the application upgrades.',
65
+ }],
66
+ },
67
+ );
68
+
69
+ expect(result.findings).toEqual([]);
70
+ });
71
+
47
72
  it('suppresses exactly one surface when an exemption includes a reason', () => {
48
73
  const theme = createTheme();
49
74
  const before = assertThemeComplete(theme).findings;
@@ -0,0 +1,351 @@
1
+ # SHELL-4 — Give each bottom-nav property exactly one home
2
+
3
+ **Target repo:** `ui-core-micha` (branch `main` — this repo has no `develop`)
4
+ **Tier:** 3 (shared core)
5
+ **Review:** independent `reviewer` **and** `ui_reviewer` — spawned concurrently, both mandatory before commit
6
+ **Version target:** `2.33.1` — patch. See "Why patch" below.
7
+ **Precondition of:** `jg-ferien/NAV-36`, which is `blocked` on this
8
+ **Follows:** `SHELL-3` (`2.33.0`) and its fix `586ac9c`
9
+
10
+ ---
11
+
12
+ ## A. Envelope
13
+
14
+ ### Goal
15
+
16
+ `SHELL-3` shipped `MobileBottomNav` with **all** visible styling in the theme layer and only
17
+ position, `zIndex` and safe-area padding in the component. For an app that has adopted
18
+ `createAppTheme` that is correct and renders as specified. For an app that has **not**, the bar
19
+ arrives structurally broken — and jg-ferien, the migration consumer the promotion exists for, is
20
+ exactly that app.
21
+
22
+ Fix the layer split so the component works on any theme, without reintroducing the shadowing bug
23
+ that `586ac9c` removed.
24
+
25
+ ### How this happened, because the reasoning matters more than the diff
26
+
27
+ `SHELL-3`'s `ui_reviewer` found the component duplicating `borderTop` and `borderColor` inline in
28
+ `sx` — the same properties the same work order had just registered as theme defaults. Inline `sx`
29
+ beats `styleOverrides`, so the new defaults were inert. The fix removed the component's copies.
30
+
31
+ **That resolved the duplication by deleting the wrong copy.** The defect was the *duplication*, not
32
+ the *location*. For a property a component needs in order to function on an arbitrary theme, the
33
+ component is the correct home — and the fix moved exactly those into a layer that only baseline apps
34
+ have.
35
+
36
+ ### What a non-baseline consumer loses today
37
+
38
+ Read against MUI's installed source, not assumed. Every item below currently lives **only** in the
39
+ baseline theme:
40
+
41
+ | Property | MUI's default | Consequence |
42
+ |---|---|---|
43
+ | `MuiBottomNavigationAction` `minWidth: 0` | **`minWidth: 80`** | **layout break** — see below |
44
+ | `maxWidth: 'none'` | `maxWidth: 168` | actions cannot fill a wide bar |
45
+ | `MuiBottomNavigation` `borderTop: '1px solid'` | MUI sets **no border** | the bar has no top edge |
46
+ | `borderColor: palette.divider` | — | same |
47
+ | label `fontSize: '12px'` + the `&.Mui-selected` pin | `12px`, **`14px` when selected** | the label jumps on tap |
48
+ | label `fontWeight: 500` | unset | thinner |
49
+ | label `lineHeight: 1.2` | unset | taller label row |
50
+ | action `padding: '0 2px'`, `gap: '2px'` | MUI's own | looser density |
51
+ | icon `22px` | MUI's `24px` | slightly larger icons |
52
+
53
+ `backgroundColor` and the action/selected colours are **not** losses — MUI sets equivalents itself.
54
+
55
+ **The first row is not cosmetic.** jg has five destinations: `5 × 80 = 400px` against a 375&nbsp;px
56
+ viewport, and `min-width` overrides `flex-shrink`, so the container overflows. jg's current code sets
57
+ `minWidth: 0` explicitly for exactly this reason. **Computed from MUI's source, not rendered** —
58
+ confirm it in the rendered check rather than trusting the arithmetic.
59
+
60
+ ### The rule to apply
61
+
62
+ **Each property gets exactly one home, chosen by who needs it:**
63
+
64
+ - **The component owns what keeps it functional on any theme.** These are deliberately *not*
65
+ theme-overridable, and that is a feature: overriding them breaks the bar.
66
+ - **The theme owns what makes it look like this estate.** These stay overridable per app, which is
67
+ what makes the component design-agnostic.
68
+
69
+ **And the distinction that was missed the first time:** a **token reference** in the component's `sx`
70
+ (`borderColor: 'divider'`) is not the same thing as a hex literal and not the same thing as a
71
+ duplicate. It resolves against *whatever* theme is mounted — every app still gets its own divider
72
+ colour — while a duplicate of a theme default silently shadows it. Reference without duplication is
73
+ the correct pattern; "contains no hex values" is the wrong test for it.
74
+
75
+ ### Scope
76
+
77
+ **Move into the component, and delete from `tokens.js`:**
78
+
79
+ - `MuiBottomNavigationAction`: `minWidth: 0`, `maxWidth: 'none'`
80
+ - `MuiBottomNavigation`: `borderTop: '1px solid'`, and `borderColor: 'divider'` as an `sx` token
81
+ reference (delete `borderColor: palette.divider` from `createAppTheme.js`'s palette-aware block)
82
+
83
+ **Leave in the theme, unchanged:** the label `fontSize` / `fontWeight` / `lineHeight` and its
84
+ selected pin, the action and selected `color`, `backgroundColor`, `boxShadow: 'none'`, `padding`,
85
+ `gap`, and the icon size. A bar with MUI's density and 24&nbsp;px icons still works; a bar with
86
+ `minWidth: 80` does not.
87
+
88
+ **Deregister the four moved surfaces** from `themeCompleteness.js`:
89
+ `components.MuiBottomNavigation.styleOverrides.root.borderTop`, `…root.borderColor`,
90
+ `components.MuiBottomNavigationAction.styleOverrides.root.minWidth`, `…root.maxWidth`. Six of the ten
91
+ `SHELL-3` surfaces remain. **This cannot turn any app red**: the assertion validates that each
92
+ declared exemption names a surface and a reason, and then ignores exemptions that match no
93
+ registered surface — verified in `themeCompleteness.js`, not assumed.
94
+
95
+ **Add an `sx` prop to the component**, merged **after** its own defaults. This is the honest
96
+ mitigation for the properties that just became theme-unoverridable: a call site that genuinely needs
97
+ a different edge can still get one, without the theme layer being the escape route.
98
+
99
+ ### Non-goals / do not touch
100
+
101
+ - **No new props beyond `sx`.** `destinations`, `activeRoute`, `onNavigate`, `hideAbove`, `zIndex`
102
+ and the destination field shape stay exactly as `SHELL-3` shipped them.
103
+ - **No visual change for baseline apps.** The values are identical; only their layer moves. If a
104
+ baseline app renders differently, that is a defect in this WO.
105
+ - No other component, no other baseline token, no palette or typography change.
106
+ - No change to `emphasis`, `badgeCount`, `shortLabel` semantics.
107
+ - No migration of jg-ferien — that stays `NAV-36`.
108
+
109
+ ### Risks
110
+
111
+ - **Reintroducing the shadow.** The whole point is that a property lives in one layer. Deleting from
112
+ `tokens.js` and adding to the component must happen together; doing half leaves either a shadow or
113
+ a gap. The test below makes this checkable rather than a matter of care.
114
+ - **No staging net.** A version bump on `main` publishes to npm; the independent review is the only
115
+ gate and cannot be back-filled.
116
+ - **A property moved into `sx` is no longer theme-configurable**, which is a real capability
117
+ reduction for the four moved properties. Accepted deliberately: three of the four break the
118
+ component when changed, and the `sx` prop covers the fourth.
119
+
120
+ ### Why patch, not minor
121
+
122
+ No new capability: this relocates existing values and adds one escape-hatch prop. Baseline apps
123
+ render byte-identically. The narrowed assertion contract asks adopting apps for **less**, not more.
124
+ Per the estate's rule that a version bump follows scope rather than novelty, that is a patch.
125
+
126
+ The one argument for minor — a capability reduction, since four properties stop being
127
+ theme-overridable — is noted and rejected: `MobileBottomNav` is one release old with **no** consumer
128
+ yet on any published version, so no app can be relying on that override path.
129
+
130
+ ### Required tests to WRITE
131
+
132
+ Extend `tests/MobileBottomNav.test.jsx` and `tests/themeCompleteness.test.js`.
133
+
134
+ 1. **The non-baseline case, which is the whole point.** Render under a plain `createTheme()` and
135
+ assert the bar has a top border and its actions resolve `minWidth: 0` — the two failures that
136
+ block `NAV-36`. Prove non-vacuity: this test must fail against `2.33.0`'s arrangement.
137
+ 2. **No property lives in two layers.** Assert the intersection of the component's own `sx` keys and
138
+ the baseline's `MuiBottomNavigation` / `MuiBottomNavigationAction` `styleOverrides` keys is
139
+ **empty**. This is the mechanical guard for the regression class `SHELL-3` hit, and it is the
140
+ reason to prefer it over a reviewer noticing.
141
+ 3. `sx` passed by the caller wins over the component's own defaults.
142
+ 4. Baseline rendering is unchanged: the same assertions `SHELL-3`'s spec makes about a
143
+ `createAppTheme` theme still hold, including test 5b's cross-theme colour resolution.
144
+ 5. `assertThemeComplete(createAppTheme({ palette: { primary: { main: '#0F62FE' } } })).findings`
145
+ stays `[]` with six surfaces registered instead of ten.
146
+ 6. An exemption naming one of the four deregistered surfaces produces **no** finding — the
147
+ forward-compatibility claim above, asserted rather than trusted.
148
+
149
+ Plus `tsc -p tsconfig.build.json --noEmit` clean. **No full-suite run** — the affected set is those
150
+ two specs plus `tests/createAppTheme.test.js`.
151
+
152
+ ### Verification
153
+
154
+ The rendered two-width side-by-side per `DS-1`. `SHELL-3` added a bottom-nav specimen to
155
+ `dev/entries.jsx`; extend it with **a second instance mounted under a plain `createTheme` theme**
156
+ side by side with the baseline one. That comparison is the actual deliverable of this WO made
157
+ visible: both bars must have an edge and evenly divided actions, and they may legitimately differ in
158
+ label size and density.
159
+
160
+ State in the register note whether real screenshots were obtained or DOM inspection substituted.
161
+ `SHELL-3`'s session could not composite frames and fell back to computed-style inspection — if that
162
+ recurs, the computed `min-width` and `border-top-width` on the plain-theme instance are the two
163
+ values that carry this WO's claim.
164
+
165
+ ### Parity guardrail
166
+
167
+ Byte-identical rendering for baseline apps. The only intended change is that a non-baseline
168
+ consumer's bar gains its edge and its evenly divided actions.
169
+
170
+ ---
171
+
172
+ ## B. Implementation map
173
+
174
+ *Filled by the Orchestrator on `git pull` — see `AGENTS.md` → "Work Order".*
175
+
176
+ ### Execution directive (read this first)
177
+
178
+ > **If you are the implementer reading this work order as your own specification: this section is
179
+ > NOT addressed to you.** It tells the Orchestrator how to invoke you. **You ARE that invocation —
180
+ > do NOT shell out to `codex exec`.**
181
+ >
182
+ > Implement through `codex exec` in the background — invoked directly via Bash (never the
183
+ > `debugger`/`*_coder` Agent wrappers) with BOTH flags `--skip-git-repo-check` and
184
+ > `--dangerously-bypass-approvals-and-sandbox`. **Pass the WO via stdin, not as a positional
185
+ > argument** (a positional arg hits Windows' command-line length limit — proven repeatedly in this
186
+ > repo). Fallback to direct Claude implementation only on Codex quota/rate-limit/non-zero exit —
187
+ > and note that the fallback flips authorship, so both reviewers stay mandatory either way.
188
+ >
189
+ > **`SHELL-3` note for the Orchestrator:** on that WO Codex committed its own change and marked the
190
+ > register row `done` with a self-reported review. That is a breach (`AGENTS.md`: author ≠ reviewer,
191
+ > a spawned implementer never commits). Read `git log origin/main..HEAD` before your own review and
192
+ > treat any implementer commit as a blocker to surface, not something to build on.
193
+
194
+ ### Context package
195
+
196
+ **Note on the Envelope's "ten to six" arithmetic:** the actually-landed `SHELL-3` surface count in
197
+ `themeCompleteness.js` is **twenty**, not ten (SHELL-3's own scope grew mid-implementation to cover
198
+ icon size/padding/gap/label truncation, beyond the ten originally sketched). This does not change
199
+ the instruction — deregister exactly the four surfaces named below, no more, no less — but do not
200
+ be thrown by the stale count in the prose above.
201
+
202
+ **Files to change, with current line numbers (verified against the landed `SHELL-3` + `586ac9c`
203
+ state, may drift slightly if Codex edits top-to-bottom — re-grep `MuiBottomNavigation` if a line
204
+ number is off by a few):**
205
+
206
+ 1. **`src/theme/tokens.js:309-334`** — the current `BASELINE_STATIC.components` entries:
207
+ ```js
208
+ MuiBottomNavigation: {
209
+ styleOverrides: {
210
+ root: { borderTop: '1px solid', boxShadow: 'none' },
211
+ },
212
+ },
213
+ MuiBottomNavigationAction: {
214
+ styleOverrides: {
215
+ root: {
216
+ minWidth: 0,
217
+ maxWidth: 'none',
218
+ padding: '0 2px',
219
+ gap: '2px',
220
+ '& .MuiSvgIcon-root': { width: '22px', height: '22px' },
221
+ },
222
+ label: { /* fontSize/fontWeight/lineHeight/... unchanged, leave as-is */ },
223
+ },
224
+ },
225
+ ```
226
+ Remove `borderTop: '1px solid'` from `MuiBottomNavigation.styleOverrides.root` (keep
227
+ `boxShadow: 'none'` — it stays per the Envelope's "leave in the theme" list). Remove
228
+ `minWidth: 0, maxWidth: 'none'` from `MuiBottomNavigationAction.styleOverrides.root` (keep
229
+ `padding`, `gap`, the icon-size entry, and the entire `label` block unchanged).
230
+
231
+ 2. **`src/theme/createAppTheme.js:119-134`** — the current `createPaletteAwareComponents()` entries:
232
+ ```js
233
+ MuiBottomNavigation: {
234
+ styleOverrides: {
235
+ root: {
236
+ backgroundColor: palette.background.paper,
237
+ borderColor: palette.divider,
238
+ },
239
+ },
240
+ },
241
+ MuiBottomNavigationAction: {
242
+ styleOverrides: {
243
+ root: {
244
+ color: palette.text.secondary,
245
+ '&.Mui-selected': { color: palette.primary.main },
246
+ },
247
+ },
248
+ },
249
+ ```
250
+ Remove `borderColor: palette.divider` (keep `backgroundColor: palette.background.paper` — not a
251
+ loss per the Envelope's own table, MUI sets an equivalent). `MuiBottomNavigationAction` here is
252
+ untouched — `color`/`.Mui-selected` stay exactly as-is.
253
+
254
+ 3. **`src/theme/themeCompleteness.js:99-118`** (`COMPONENT_SURFACES` array) — delete exactly these
255
+ four lines:
256
+ ```js
257
+ componentPath('MuiBottomNavigation', 'styleOverrides.root.borderTop'),
258
+ componentPath('MuiBottomNavigation', 'styleOverrides.root.borderColor'),
259
+ componentPath('MuiBottomNavigationAction', 'styleOverrides.root.minWidth'),
260
+ componentPath('MuiBottomNavigationAction', 'styleOverrides.root.maxWidth'),
261
+ ```
262
+ Leave every other `MuiBottomNavigation`/`MuiBottomNavigationAction` line untouched (boxShadow,
263
+ backgroundColor, padding, gap, icon width/height, color, all label surfaces, both `.Mui-selected`
264
+ pins).
265
+
266
+ 4. **`src/components/MobileBottomNav.jsx`** (current full file, 69 lines, reproduced above in this
267
+ session) — add a `sx` prop (default `{}`), and merge these four properties into the root
268
+ `BottomNavigation`'s `sx`, with the caller's `sx` applied **last** so it wins:
269
+ ```js
270
+ export function MobileBottomNav({
271
+ destinations,
272
+ activeRoute,
273
+ onNavigate,
274
+ hideAbove = 'md',
275
+ zIndex = defaultZIndex,
276
+ sx,
277
+ }) {
278
+ ...
279
+ <BottomNavigation
280
+ ...
281
+ sx={{
282
+ position: 'fixed',
283
+ left: 0,
284
+ right: 0,
285
+ bottom: 0,
286
+ zIndex,
287
+ borderTop: '1px solid',
288
+ borderColor: 'divider',
289
+ paddingBottom: 'env(safe-area-inset-bottom)',
290
+ ...sx,
291
+ }}
292
+ >
293
+ ```
294
+ `borderColor: 'divider'` here is a **string token reference** (MUI resolves `'divider'` against
295
+ `theme.palette.divider` at render time on whatever theme is mounted) — this is NOT the same
296
+ pattern as the `586ac9c` regression, which duplicated an already-*resolved* hex-bearing default.
297
+ The `BottomNavigationAction`'s own `sx` (not the top-level prop) needs `minWidth: 0,
298
+ maxWidth: 'none'` added directly — these are per-action, not per-bar, so they do NOT go through
299
+ the new `sx` prop. Today the `emphasis` styling sits on the inner `<Icon sx={...}>`, not on
300
+ `<BottomNavigationAction>` itself — leave that untouched, and simply add a new
301
+ `sx={{ minWidth: 0, maxWidth: 'none' }}` prop directly on the `<BottomNavigationAction>` element,
302
+ independent of the `icon` prop's own conditional emphasis styling.
303
+
304
+ 5. **`tests/MobileBottomNav.test.jsx`** — extend with the six numbered tests from the Envelope.
305
+ Test 2 (no property in two layers) should import `BASELINE_STATIC` (or the theme object) and the
306
+ component's rendered/declared `sx` keys and assert
307
+ `intersection(Object.keys(componentSxDefaults), Object.keys(theme.components.MuiBottomNavigation
308
+ .styleOverrides.root)).length === 0` — read the existing test file's structure first
309
+ (`createAppTheme`/`createTheme` imports are already there from `SHELL-3`'s test 5b) and follow its
310
+ conventions rather than introducing a new test-setup style.
311
+
312
+ 6. **`tests/themeCompleteness.test.js`** — the existing `SHELL-3` assertion (added at line ~19-40,
313
+ the `expect(bare.findings...).toEqual(expect.arrayContaining([...20 surfaces...]))` block) needs
314
+ its four now-deregistered entries removed from that array, plus the Envelope's test 5 (findings
315
+ stays `[]` with six surfaces) and test 6 (an exemption naming a deregistered surface produces no
316
+ finding — because `assertThemeComplete` ignores exemptions matching no registered surface, this
317
+ is provable without special-casing: declare an exemption for e.g.
318
+ `'components.MuiBottomNavigation.styleOverrides.root.borderTop'` against a theme built without
319
+ that surface and assert no finding names it, since the surface list itself no longer contains it).
320
+
321
+ 7. **`dev/entries.jsx:69-94`** (`MobileBottomNavEntry`) — add a second `MobileBottomNav` instance
322
+ wrapped in its own `<ThemeProvider theme={createTheme()}>` (plain MUI, no `createAppTheme`),
323
+ rendered side-by-side with the existing baseline-themed one (which is already inside the harness's
324
+ own `createAppTheme` root — no need to wrap that one again). Import `ThemeProvider`, `createTheme`
325
+ from `@mui/material/styles` (createTheme is likely already imported elsewhere in this file — grep
326
+ first). Keep both bars visible at once (e.g. stacked in a `Stack`) so the two-width verification
327
+ can compare them directly: both need a visible top edge and evenly divided actions; they may
328
+ legitimately differ in label size/density.
329
+
330
+ **Invariants / do-not-touch:** no change to `destinations`/`activeRoute`/`onNavigate`/`hideAbove`/
331
+ `zIndex` prop semantics, `emphasis`/`badgeCount`/`shortLabel` behaviour, or any other baseline token.
332
+ No visual change for a `createAppTheme` consumer — the four relocated properties must render
333
+ byte-identically before and after.
334
+
335
+ **Pitfalls already known:**
336
+ - Deleting from `tokens.js`/`createAppTheme.js` and adding to the component must land in the SAME
337
+ commit/chunk — a partial move reintroduces either a gap (non-baseline still broken) or a shadow
338
+ (the exact `586ac9c` bug, just with the copies swapped).
339
+ - `boxShadow: 'none'` and `backgroundColor` are explicitly NOT part of this move — re-reading the
340
+ Envelope's table, only `borderTop`, `borderColor`, `minWidth`, `maxWidth` relocate.
341
+ - Version target is `2.33.1` (patch) — confirm `package.json` reads `2.33.1` after Codex is done, not
342
+ a minor bump.
343
+ - **Per `SHELL-3`'s own execution-directive note added to this WO: verify no implementer self-commit
344
+ happened before doing anything else** — `git log --oneline -3` should show the Orchestrator's own
345
+ `1106f51`-style "fill Implementation map" commit as the most recent, not a Codex-authored `feat(...)`
346
+ commit. If a self-commit is present, treat it as a breach per `AGENTS.md`, not as a base to build on.
347
+
348
+ ### Mini-handover
349
+
350
+ Repo: `ui-core-micha` (`C:\Users\biglmi\Documents\webapps\ui-core-micha`), branch `main`.
351
+ WO: `work-orders/SHELL-4.md`. Follow `orchestrate-codex`.