@micha.bigler/ui-core-micha 2.16.0 → 2.18.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (46) hide show
  1. package/WORK_ORDERS.md +3 -1
  2. package/dev/entries.jsx +5 -1
  3. package/dist/i18n/messagingTranslations.js +27 -0
  4. package/dist/index.js +1 -0
  5. package/dist/messaging/Composer.js +41 -5
  6. package/dist/messaging/ConversationList.js +10 -3
  7. package/dist/messaging/DirectMessageLauncher.js +48 -0
  8. package/dist/messaging/MessageBubble.js +84 -4
  9. package/dist/messaging/MessagingProvider.js +102 -21
  10. package/dist/messaging/PollCard.js +22 -5
  11. package/dist/messaging/ReactionBar.js +1 -1
  12. package/dist/messaging/ReadTicks.js +7 -4
  13. package/dist/messaging/Thread.js +45 -8
  14. package/dist/messaging/api.js +3 -3
  15. package/dist/messaging/composerImageCompression.js +36 -0
  16. package/docs/messaging-deviations.md +108 -26
  17. package/package.json +1 -1
  18. package/src/i18n/messagingTranslations.ts +27 -0
  19. package/src/index.js +1 -0
  20. package/src/messaging/Composer.jsx +54 -8
  21. package/src/messaging/ConversationList.jsx +10 -4
  22. package/src/messaging/DirectMessageLauncher.jsx +96 -0
  23. package/src/messaging/MessageBubble.jsx +74 -7
  24. package/src/messaging/MessagingProvider.jsx +124 -15
  25. package/src/messaging/PollCard.jsx +19 -3
  26. package/src/messaging/ReactionBar.jsx +1 -1
  27. package/src/messaging/ReadTicks.jsx +5 -3
  28. package/src/messaging/Thread.jsx +39 -8
  29. package/src/messaging/api.js +3 -2
  30. package/src/messaging/composerImageCompression.js +35 -0
  31. package/tests/ConversationList.test.jsx +1 -1
  32. package/tests/Thread.test.jsx +1 -1
  33. package/tests/messagingChunk6.test.jsx +109 -0
  34. package/tests/messagingComposerChunk5.test.jsx +110 -0
  35. package/tests/messagingContractConformance.test.js +69 -0
  36. package/tests/messagingDirectMessageLauncher.test.jsx +78 -0
  37. package/tests/messagingExports.test.js +2 -1
  38. package/tests/messagingInteractions.test.jsx +3 -1
  39. package/tests/messagingLastMessagePreview.test.jsx +93 -0
  40. package/tests/messagingMessageActions.test.jsx +93 -0
  41. package/tests/messagingPollRendering.test.jsx +115 -0
  42. package/tests/messagingReactionMerge.test.jsx +79 -0
  43. package/tests/messagingThreadingQuoting.test.jsx +86 -0
  44. package/tests/messagingUnreadLifecycle.test.jsx +63 -0
  45. package/work-orders/MSG-3b.md +1002 -0
  46. package/work-orders/MSG-3c.md +378 -0
@@ -0,0 +1,109 @@
1
+ // @vitest-environment jsdom
2
+ import React from 'react';
3
+ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
4
+ import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
5
+
6
+ let frameHandler;
7
+ vi.mock('react-i18next', () => ({ useTranslation: () => ({ t: (key, options) => options?.count != null ? `${key}:${options.count}` : key, i18n: { language: 'en' } }) }));
8
+ vi.mock('../src/notifications/realtime', () => ({ useRealtime: () => ({ subscribe: (_envelope, handler) => { frameHandler = handler; return () => {}; }, onReconnect: () => () => {} }) }));
9
+
10
+ import { Composer } from '../src/messaging/Composer';
11
+ import { ConversationList } from '../src/messaging/ConversationList';
12
+ import { MessageBubble } from '../src/messaging/MessageBubble';
13
+ import { MessagingProvider } from '../src/messaging/MessagingProvider';
14
+ import { ReadTicks } from '../src/messaging/ReadTicks';
15
+ import { Thread } from '../src/messaging/Thread';
16
+
17
+ function makeApi(overrides = {}) {
18
+ return {
19
+ listConversations: vi.fn().mockResolvedValue({ results: [] }),
20
+ listMessages: vi.fn().mockResolvedValue({ results: [] }),
21
+ listThread: vi.fn().mockResolvedValue({ results: [] }),
22
+ getUnreadCount: vi.fn().mockResolvedValue({ unread_count: 0, by_conversation: {} }),
23
+ getReadStatus: vi.fn().mockResolvedValue({ all_read: false, delivered_count: 2 }),
24
+ markConversationRead: vi.fn().mockResolvedValue({}), markThreadRead: vi.fn().mockResolvedValue({}),
25
+ createPoll: vi.fn().mockResolvedValue({}),
26
+ ...overrides,
27
+ };
28
+ }
29
+
30
+ afterEach(() => { cleanup(); vi.useRealTimers(); vi.restoreAllMocks(); frameHandler = undefined; });
31
+
32
+ describe('MSG-3b chunk 6', () => {
33
+ it('renders localized relative list timestamps for now, minutes, hours, and days', async () => {
34
+ vi.spyOn(Date, 'now').mockReturnValue(new Date('2026-07-31T12:00:00Z').getTime());
35
+ const api = makeApi({ listConversations: vi.fn().mockResolvedValue({ results: [
36
+ { id: 1, title: 'Now', last_message_at: '2026-07-31T11:59:50Z' },
37
+ { id: 2, title: 'Minutes', last_message_at: '2026-07-31T11:55:00Z' },
38
+ { id: 3, title: 'Hours', last_message_at: '2026-07-31T09:00:00Z' },
39
+ { id: 4, title: 'Days', last_message_at: '2026-07-29T12:00:00Z' },
40
+ ] }) });
41
+ render(<MessagingProvider api={api}><ConversationList /></MessagingProvider>);
42
+ await screen.findByText('Now');
43
+ expect(screen.getByText('now')).toBeTruthy();
44
+ expect(screen.getByText(/5m/)).toBeTruthy();
45
+ expect(screen.getByText(/3h/)).toBeTruthy();
46
+ expect(screen.getByText(/2d/)).toBeTruthy();
47
+ });
48
+
49
+ it('auto-scrolls only for active-conversation messages when the reader was near the bottom', async () => {
50
+ const api = makeApi({ listConversations: vi.fn().mockResolvedValue({ results: [{ id: 1, kind: 'group' }] }), listMessages: vi.fn().mockResolvedValue({ results: [{ id: 1, conversation_id: 1, body: 'First' }] }) });
51
+ render(<MessagingProvider api={api} activeConversationId={1}><Thread conversationId={1} /></MessagingProvider>);
52
+ const timeline = await screen.findByLabelText('MessagingThread.TIMELINE');
53
+ Object.defineProperties(timeline, { scrollHeight: { configurable: true, value: 1000 }, clientHeight: { configurable: true, value: 300 }, scrollTop: { configurable: true, writable: true, value: 690 } });
54
+ timeline.scrollTo = vi.fn();
55
+ fireEvent.scroll(timeline);
56
+ frameHandler({ type: 'message', conversation_id: 1, message: { id: 2, body: 'Near bottom' } });
57
+ await waitFor(() => expect(timeline.scrollTo).toHaveBeenCalledTimes(1));
58
+ timeline.scrollTo.mockClear(); timeline.scrollTop = 100;
59
+ fireEvent.scroll(timeline);
60
+ frameHandler({ type: 'message', conversation_id: 1, message: { id: 3, body: 'Reading history' } });
61
+ await screen.findByText('Reading history');
62
+ expect(timeline.scrollTo).not.toHaveBeenCalled();
63
+ });
64
+
65
+ it('renders announcement deep links only with a host handler and supplies its exact target', () => {
66
+ const onAnnouncementLink = vi.fn();
67
+ const message = { id: 3, kind: 'announcement', title: 'Notice', body: 'Read this', link_target: '/events/7' };
68
+ const bubble = (props) => <MessagingProvider api={makeApi()} active={false}><MessageBubble {...props} /></MessagingProvider>;
69
+ const view = render(bubble({ message, onAnnouncementLink }));
70
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingAnnouncement.OPEN_LINK' }));
71
+ expect(onAnnouncementLink).toHaveBeenCalledWith('/events/7');
72
+ view.rerender(bubble({ message }));
73
+ expect(screen.queryByRole('button', { name: 'MessagingAnnouncement.OPEN_LINK' })).toBeNull();
74
+ view.rerender(bubble({ message: { ...message, link_target: null }, onAnnouncementLink }));
75
+ expect(screen.queryByRole('button', { name: 'MessagingAnnouncement.OPEN_LINK' })).toBeNull();
76
+ });
77
+
78
+ it('shows senders for group messages and suppresses them for direct messages', () => {
79
+ const message = { id: 4, body: 'Hi', sender: { display_name: 'Ava' } };
80
+ const bubble = (conversation) => <MessagingProvider api={makeApi()} active={false}><MessageBubble message={message} conversation={conversation} /></MessagingProvider>;
81
+ const view = render(bubble({ kind: 'group' }));
82
+ expect(screen.getByText('Ava')).toBeTruthy();
83
+ view.rerender(bubble({ kind: 'direct' }));
84
+ expect(screen.queryByText('Ava')).toBeNull();
85
+ });
86
+
87
+ it('opens receipt recipients by click for non-direct conversations and never exposes direct details', async () => {
88
+ const api = makeApi({ getReadStatus: vi.fn().mockResolvedValue({ all_read: false, delivered_count: 2, recipient_detail: [{ display_name: 'Ava' }] }) });
89
+ const view = render(<MessagingProvider api={api} active={false}><ReadTicks messageId={7} conversation={{ kind: 'group' }} /></MessagingProvider>);
90
+ const detail = await screen.findByRole('button', { name: 'MessagingReadTicks.DELIVERED:2' });
91
+ fireEvent.click(detail);
92
+ expect(await screen.findByText('Ava')).toBeTruthy();
93
+ view.unmount();
94
+ render(<MessagingProvider api={api} active={false}><ReadTicks messageId={7} conversation={{ kind: 'direct' }} /></MessagingProvider>);
95
+ await screen.findByLabelText('MessagingReadTicks.DELIVERED:2');
96
+ expect(screen.queryByRole('button', { name: 'MessagingReadTicks.DELIVERED:2' })).toBeNull();
97
+ expect(screen.queryByText('Ava')).toBeNull();
98
+ });
99
+
100
+ it('caps poll composer options at ten without changing the existing two-option start', () => {
101
+ render(<MessagingProvider api={makeApi()} active={false}><Composer conversationId={1} /></MessagingProvider>);
102
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingPoll.CREATE' }));
103
+ const addOption = screen.getByRole('button', { name: 'MessagingPoll.ADD_OPTION' });
104
+ expect(screen.getAllByLabelText(/MessagingPoll.OPTION/)).toHaveLength(2);
105
+ for (let count = 0; count < 8; count += 1) fireEvent.click(addOption);
106
+ expect(screen.getAllByLabelText(/MessagingPoll.OPTION/)).toHaveLength(10);
107
+ expect(addOption.disabled).toBe(true);
108
+ });
109
+ });
@@ -0,0 +1,110 @@
1
+ // @vitest-environment jsdom
2
+ import React from 'react';
3
+ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
4
+ import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
5
+
6
+ vi.mock('react-i18next', () => ({ useTranslation: () => ({ t: (key, options) => options?.name ? `${key}:${options.name}` : key }) }));
7
+ vi.mock('../src/notifications/realtime', () => ({ useRealtime: () => ({ subscribe: () => () => {}, onReconnect: () => () => {} }) }));
8
+
9
+ import { Composer } from '../src/messaging/Composer';
10
+ import { MessagingProvider } from '../src/messaging/MessagingProvider';
11
+
12
+ function makeApi() {
13
+ return {
14
+ listConversations: vi.fn().mockResolvedValue({ results: [] }), listMessages: vi.fn().mockResolvedValue({ results: [] }), getUnreadCount: vi.fn().mockResolvedValue({ unread_count: 0, by_conversation: {} }),
15
+ createMessage: vi.fn().mockResolvedValue({ id: 1, conversation_id: 7 }), uploadAttachments: vi.fn().mockResolvedValue({ id: 2, conversation_id: 7 }), getAttachment: vi.fn(), getAttachmentThumbnail: vi.fn(),
16
+ };
17
+ }
18
+ function renderComposer(api = makeApi(), conversationId = 7) {
19
+ return render(<MessagingProvider api={api} active={false}><Composer conversationId={conversationId} /></MessagingProvider>);
20
+ }
21
+ function attachmentInput() { return document.querySelector('input[type=file]'); }
22
+ function messageInput() { return screen.getByLabelText('MessagingComposer.MESSAGE'); }
23
+ function imageFile(name = 'photo.png') { return new File(['image'], name, { type: 'image/png' }); }
24
+
25
+ beforeEach(() => {
26
+ URL.createObjectURL = vi.fn((file) => `blob:${file.name}`);
27
+ URL.revokeObjectURL = vi.fn();
28
+ });
29
+ afterEach(() => { cleanup(); vi.restoreAllMocks(); });
30
+
31
+ describe('Composer chunk 5 behavior', () => {
32
+ it('sends on Enter and leaves Shift+Enter available for a newline', async () => {
33
+ const api = makeApi(); renderComposer(api);
34
+ fireEvent.change(messageInput(), { target: { value: 'first' } });
35
+ fireEvent.keyDown(messageInput(), { key: 'Enter', code: 'Enter' });
36
+ await waitFor(() => expect(api.createMessage).toHaveBeenCalledTimes(1));
37
+
38
+ fireEvent.change(messageInput(), { target: { value: 'first' } });
39
+ fireEvent.keyDown(messageInput(), { key: 'Enter', code: 'Enter', shiftKey: true });
40
+ fireEvent.change(messageInput(), { target: { value: 'first\nsecond' } });
41
+ expect(api.createMessage).toHaveBeenCalledTimes(1);
42
+ expect(messageInput().value).toBe('first\nsecond');
43
+ });
44
+
45
+ it('shows staged image previews and removes only the chosen file before upload', async () => {
46
+ const api = makeApi(); renderComposer(api);
47
+ const first = imageFile('first.png'); const second = imageFile('second.png');
48
+ fireEvent.change(attachmentInput(), { target: { files: [first, second] } });
49
+ expect(screen.getByRole('img', { name: 'first.png' })).toBeTruthy();
50
+ expect(screen.getByRole('img', { name: 'second.png' })).toBeTruthy();
51
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingComposer.REMOVE_ATTACHMENT:first.png' }));
52
+ expect(screen.queryByRole('img', { name: 'first.png' })).toBeNull();
53
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingComposer.SEND' }));
54
+ await waitFor(() => expect(api.uploadAttachments).toHaveBeenCalledTimes(1));
55
+ const sentFiles = Array.from(api.uploadAttachments.mock.calls[0][1].getAll('files[]'));
56
+ expect(sentFiles).toHaveLength(1);
57
+ expect(sentFiles[0].name).toBe('second.png');
58
+ });
59
+
60
+ it('shows real byte-percentage upload progress while an attachment upload is in flight', async () => {
61
+ let resolveUpload; const api = makeApi(); api.uploadAttachments.mockReturnValue(new Promise((resolve) => { resolveUpload = resolve; }));
62
+ renderComposer(api); fireEvent.change(attachmentInput(), { target: { files: [imageFile()] } });
63
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingComposer.SEND' }));
64
+ expect(await screen.findByRole('status')).toBeTruthy();
65
+ const { onUploadProgress } = api.uploadAttachments.mock.calls[0][2];
66
+ onUploadProgress({ loaded: 25, total: 100 });
67
+ await waitFor(() => expect(screen.getAllByRole('progressbar')[0].getAttribute('aria-valuenow')).toBe('25'));
68
+ resolveUpload({ id: 2, conversation_id: 7 });
69
+ await waitFor(() => expect(screen.queryByRole('status')).toBeNull());
70
+ });
71
+
72
+ it('compresses oversized images before adding them to FormData and falls back silently if compression fails', async () => {
73
+ const largeImage = new File([new Uint8Array(2 * 1024 * 1024 + 1)], 'large.png', { type: 'image/png' });
74
+ const api = makeApi();
75
+ class SuccessfulImage { naturalWidth = 5120; naturalHeight = 2560; set src(_) { this.onload(); } }
76
+ vi.stubGlobal('Image', SuccessfulImage);
77
+ vi.spyOn(HTMLCanvasElement.prototype, 'getContext').mockReturnValue({ drawImage: vi.fn() });
78
+ vi.spyOn(HTMLCanvasElement.prototype, 'toBlob').mockImplementation((callback) => callback(new Blob(['compressed'], { type: 'image/jpeg' })));
79
+ renderComposer(api); fireEvent.change(attachmentInput(), { target: { files: [largeImage] } }); fireEvent.click(screen.getByRole('button', { name: 'MessagingComposer.SEND' }));
80
+ await waitFor(() => expect(api.uploadAttachments).toHaveBeenCalledTimes(1));
81
+ const compressed = api.uploadAttachments.mock.calls[0][1].get('files[]');
82
+ expect(compressed.name).toBe('large.jpg'); expect(compressed.type).toBe('image/jpeg');
83
+
84
+ cleanup(); const fallbackApi = makeApi(); class FailingImage { set src(_) { this.onerror(); } }
85
+ vi.stubGlobal('Image', FailingImage);
86
+ renderComposer(fallbackApi); fireEvent.change(attachmentInput(), { target: { files: [largeImage] } }); fireEvent.click(screen.getByRole('button', { name: 'MessagingComposer.SEND' }));
87
+ await waitFor(() => expect(fallbackApi.uploadAttachments).toHaveBeenCalledTimes(1));
88
+ const fallback = fallbackApi.uploadAttachments.mock.calls[0][1].get('files[]');
89
+ expect(fallback.name).toBe('large.png'); expect(fallback.type).toBe('image/png');
90
+ });
91
+
92
+ it('inserts the selected emoji at the current cursor position', async () => {
93
+ renderComposer(); fireEvent.change(messageInput(), { target: { value: 'abCD' } });
94
+ messageInput().setSelectionRange(2, 2);
95
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingComposer.ADD_EMOJI' }));
96
+ fireEvent.click(await screen.findByRole('menuitem', { name: '👍' }));
97
+ await waitFor(() => expect(messageInput().value).toBe('ab👍CD'));
98
+ });
99
+
100
+ it('disables poll composing while an image is staged and resets drafts for a new conversation', async () => {
101
+ const api = makeApi(); const view = renderComposer(api, 7);
102
+ fireEvent.change(attachmentInput(), { target: { files: [imageFile()] } });
103
+ expect(screen.getByRole('button', { name: 'MessagingPoll.CREATE' }).disabled).toBe(true);
104
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingComposer.REMOVE_ATTACHMENT:photo.png' }));
105
+ expect(screen.getByRole('button', { name: 'MessagingPoll.CREATE' }).disabled).toBe(false);
106
+ fireEvent.change(messageInput(), { target: { value: 'unsent draft' } });
107
+ view.rerender(<MessagingProvider api={api} active={false}><Composer conversationId={8} /></MessagingProvider>);
108
+ await waitFor(() => expect(messageInput().value).toBe(''));
109
+ });
110
+ });
@@ -0,0 +1,69 @@
1
+ import fs from 'node:fs';
2
+ import path from 'node:path';
3
+ import { describe, expect, it } from 'vitest';
4
+
5
+ const root = path.resolve(import.meta.dirname, '..');
6
+ const messagingRoot = path.join(root, 'src', 'messaging');
7
+
8
+ // These are deliberately named and time-bounded. Chunks 3 and 4 must remove
9
+ // their entries when they wire their existing adapters; the final three are
10
+ // retained only if their stated product rationale still holds at WO close.
11
+ const API_EXEMPTIONS = {
12
+ createManagedConversation: 'No managed-conversation launcher is in the current public surface.',
13
+ createObjectThreadConversation: 'Object-thread creation is host-owned routing/scope work.',
14
+ getMessage: 'Timeline data is loaded through listMessages and listThread.',
15
+ };
16
+ const FRAME_TYPES = ['conversation_upsert', 'conversation_archived', 'message', 'message_edited', 'message_deleted', 'attachment_ready', 'reaction', 'poll_updated', 'delivered', 'read_state', 'thread_read_state', 'participant_changed'];
17
+ const FRAME_EXEMPTIONS = {
18
+ attachment_ready: 'Reserved by the design and deliberately unemitted.',
19
+ delivered: 'Receipt synchronisation is outside MSG-3b.',
20
+ read_state: 'Receipt synchronisation is outside MSG-3b.',
21
+ thread_read_state: 'Receipt synchronisation is outside MSG-3b.',
22
+ };
23
+
24
+ const BLOCKED_LINE = /\*\*BLOCKED\*\*/;
25
+ const VERSION_PIN = /dcm \d+\.\d+\.\d+/;
26
+
27
+ // A BLOCKED row without a version pin is exactly how MSG-3b's seven blocked
28
+ // rows went stale unnoticed: dcm shipped what they needed mid-flight and the
29
+ // WO-end review had no cheap way to tell. This check can't know whether dcm
30
+ // has since shipped — it only guarantees the pin exists, which is what turns
31
+ // the re-check into a two-minute job instead of an archaeology exercise.
32
+ function unpinnedBlockedLines(markdown) {
33
+ return markdown.split('\n').filter((line) => BLOCKED_LINE.test(line) && !VERSION_PIN.test(line));
34
+ }
35
+
36
+ describe('messaging deviation-doc BLOCKED entries carry a dependency version pin', () => {
37
+ it('every BLOCKED line in docs/messaging-deviations.md names the dcm version it was blocked at', () => {
38
+ const markdown = fs.readFileSync(path.join(root, 'docs', 'messaging-deviations.md'), 'utf8');
39
+ expect(unpinnedBlockedLines(markdown)).toEqual([]);
40
+ });
41
+
42
+ // Required negative case (the WO is explicit: prove the check can fail,
43
+ // not only that the real file happens to pass).
44
+ it('flags a BLOCKED line that omits the version pin', () => {
45
+ const unpinned = '99. **BLOCKED** — some capability with no dependency version named.';
46
+ const pinned = '100. **BLOCKED** (blocked as of dcm 2.37.0) — some other capability.';
47
+ expect(unpinnedBlockedLines(`${unpinned}\n${pinned}`)).toEqual([unpinned]);
48
+ });
49
+ });
50
+
51
+ describe('messaging adapter and realtime contract conformance', () => {
52
+ it('has a caller for every API export unless it has an explicit rationale', () => {
53
+ const apiSource = fs.readFileSync(path.join(messagingRoot, 'api.js'), 'utf8');
54
+ const source = fs.readdirSync(messagingRoot).filter((file) => file.endsWith('.jsx')).map((file) => fs.readFileSync(path.join(messagingRoot, file), 'utf8')).join('\n');
55
+ const exports = [...apiSource.matchAll(/export function (\w+)\(/g)].map((match) => match[1]);
56
+ // Attachment readers are intentionally passed through the provider to the
57
+ // standalone AttachmentList, where they are called. All other adapters
58
+ // are invoked by the provider/component that owns the action.
59
+ const unwired = exports.filter((name) => !new RegExp(`api\\.${name}\\(|${name}: api\\.${name}`).test(source) && !API_EXEMPTIONS[name]);
60
+ expect(unwired).toEqual([]);
61
+ });
62
+
63
+ it('handles only design-listed frames and accounts for intentionally unhandled frames', () => {
64
+ const provider = fs.readFileSync(path.join(messagingRoot, 'MessagingProvider.jsx'), 'utf8');
65
+ const handled = [...provider.matchAll(/frame\.type === '([^']+)'/g)].map((match) => match[1]);
66
+ expect(handled.every((type) => FRAME_TYPES.includes(type))).toBe(true);
67
+ expect(FRAME_TYPES.filter((type) => !handled.includes(type) && !FRAME_EXEMPTIONS[type])).toEqual([]);
68
+ });
69
+ });
@@ -0,0 +1,78 @@
1
+ // @vitest-environment jsdom
2
+ import React from 'react';
3
+ import { afterEach, describe, expect, it, vi } from 'vitest';
4
+ import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
5
+
6
+ vi.mock('react-i18next', () => ({ useTranslation: () => ({ t: (key) => key }) }));
7
+ vi.mock('../src/notifications/realtime', () => ({ useRealtime: () => ({ subscribe: () => () => {}, onReconnect: () => () => {} }) }));
8
+
9
+ import { DirectMessageLauncher } from '../src/index';
10
+ import { MessagingProvider } from '../src/messaging/MessagingProvider';
11
+
12
+ const candidates = [{ id: 2, display_name: 'Alex' }, { id: 3, display_name: 'Sam' }];
13
+
14
+ function renderLauncher({ api = { createDirectConversation: vi.fn().mockResolvedValue({ id: 41, kind: 'direct' }) }, ...props } = {}) {
15
+ const onOpen = props.onOpen || vi.fn();
16
+ render(<MessagingProvider api={api} active={false}><DirectMessageLauncher candidates={candidates} onOpen={onOpen} {...props} /></MessagingProvider>);
17
+ return { api, onOpen };
18
+ }
19
+ function openPicker() { fireEvent.click(screen.getByRole('button', { name: 'MessagingDirect.LAUNCH' })); }
20
+
21
+ afterEach(() => {
22
+ cleanup();
23
+ window.matchMedia = undefined;
24
+ });
25
+
26
+ describe('DirectMessageLauncher', () => {
27
+ it('opens a picker over host-supplied candidates and renders a distinct empty state', () => {
28
+ renderLauncher();
29
+ openPicker();
30
+ expect(screen.getByRole('dialog')).toBeTruthy();
31
+ expect(screen.getByText('Alex')).toBeTruthy();
32
+ expect(screen.getByText('Sam')).toBeTruthy();
33
+
34
+ cleanup();
35
+ renderLauncher({ candidates: [] });
36
+ openPicker();
37
+ expect(screen.getByText('MessagingDirect.EMPTY')).toBeTruthy();
38
+ });
39
+
40
+ it('requires a recipient, disables while starting, then opens the created conversation with scope', async () => {
41
+ let resolveRequest;
42
+ const api = { createDirectConversation: vi.fn(() => new Promise((resolve) => { resolveRequest = resolve; })) };
43
+ const { onOpen } = renderLauncher({ api, scope: { kind: 'event', id: 8 } });
44
+ openPicker();
45
+ const start = screen.getByRole('button', { name: 'MessagingDirect.START' });
46
+ expect(start.disabled).toBe(true);
47
+ fireEvent.click(screen.getByText('Alex'));
48
+ expect(start.disabled).toBe(false);
49
+ fireEvent.click(start);
50
+ expect(api.createDirectConversation).toHaveBeenCalledWith({ target_user_id: 2, scope: { kind: 'event', id: 8 } });
51
+ expect(start.disabled).toBe(true);
52
+ expect(screen.getByRole('status')).toBeTruthy();
53
+ resolveRequest({ id: 41, kind: 'direct' });
54
+ await waitFor(() => expect(onOpen).toHaveBeenCalledWith({ id: 41, kind: 'direct' }));
55
+ await waitFor(() => expect(screen.queryByRole('dialog')).toBeNull());
56
+ });
57
+
58
+ it('surfaces a policy rejection without closing the picker', async () => {
59
+ const api = { createDirectConversation: vi.fn().mockRejectedValue({ response: { data: { detail: 'Direct messages are restricted.' } } }) };
60
+ renderLauncher({ api });
61
+ openPicker();
62
+ fireEvent.click(screen.getByText('Alex'));
63
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingDirect.START' }));
64
+ expect((await screen.findByRole('alert')).textContent).toContain('Direct messages are restricted.');
65
+ expect(screen.getByRole('dialog')).toBeTruthy();
66
+ });
67
+
68
+ it('uses a fullscreen dialog at the small-viewport media query', () => {
69
+ window.matchMedia = vi.fn().mockImplementation(() => ({
70
+ matches: true,
71
+ addEventListener: vi.fn(),
72
+ removeEventListener: vi.fn(),
73
+ }));
74
+ renderLauncher();
75
+ openPicker();
76
+ expect(document.querySelector('.MuiDialog-paperFullScreen')).not.toBeNull();
77
+ });
78
+ });
@@ -1,5 +1,5 @@
1
1
  import { describe, expect, it } from 'vitest';
2
- import { AttachmentList, Composer, ConversationLaunchers, ConversationList, MessageBubble, MessagingProvider, MessagingScopeConfig, messagingTranslations, PollCard, ReactionBar, ReadTicks, Thread, useMessaging } from '../src/index';
2
+ import { AttachmentList, Composer, ConversationLaunchers, ConversationList, DirectMessageLauncher, MessageBubble, MessagingProvider, MessagingScopeConfig, messagingTranslations, PollCard, ReactionBar, ReadTicks, Thread, useMessaging } from '../src/index';
3
3
 
4
4
  describe('messaging barrel exports', () => {
5
5
  it('exports the provider, hook, standalone list and launchers', () => {
@@ -7,6 +7,7 @@ describe('messaging barrel exports', () => {
7
7
  expect(useMessaging).toBeDefined();
8
8
  expect(ConversationList).toBeDefined();
9
9
  expect(ConversationLaunchers).toBeDefined();
10
+ expect(DirectMessageLauncher).toBeDefined();
10
11
  expect(Thread).toBeDefined();
11
12
  expect(MessageBubble).toBeDefined();
12
13
  expect(ReadTicks).toBeDefined();
@@ -19,7 +19,9 @@ afterEach(cleanup);
19
19
 
20
20
  describe('messaging reactions and polls', () => {
21
21
  it('round-trips add and remove reactions through the cache-backed API', async () => {
22
- const api = baseApi(); api.addReaction.mockResolvedValue({ reactions: [{ emoji: '👍', count: 1, reacted: true }] }); api.removeReaction.mockResolvedValue({ reactions: [] });
22
+ // serialize_reactions (dcm) never returns a per-viewer `reacted` flag —
23
+ // {emoji, count} only, in every context.
24
+ const api = baseApi(); api.addReaction.mockResolvedValue({ reactions: [{ emoji: '👍', count: 1 }] }); api.removeReaction.mockResolvedValue({ reactions: [] });
23
25
  const { rerender } = render(<MessagingProvider api={api} active={false}><ReactionBar message={{ id: 7, reactions: [{ emoji: '👍', count: 1, reacted: false }] }} /></MessagingProvider>);
24
26
  fireEvent.click(screen.getByRole('button', { name: 'MessagingReactions.TOGGLE' })); await waitFor(() => expect(api.addReaction).toHaveBeenCalledWith(7, '👍'));
25
27
  rerender(<MessagingProvider api={api} active={false}><ReactionBar message={{ id: 7, reactions: [{ emoji: '👍', count: 1, reacted: true }] }} /></MessagingProvider>);
@@ -0,0 +1,93 @@
1
+ // @vitest-environment jsdom
2
+ import React from 'react';
3
+ import { afterEach, describe, expect, it, vi } from 'vitest';
4
+ import { cleanup, render, screen, waitFor } from '@testing-library/react';
5
+
6
+ vi.mock('react-i18next', () => ({ useTranslation: () => ({ t: (key) => key }) }));
7
+
8
+ const realtimeSubscribers = new Map();
9
+ vi.mock('../src/notifications/realtime', () => ({
10
+ useRealtime: () => ({
11
+ subscribe: (envelope, handler) => { realtimeSubscribers.set(envelope, handler); return () => realtimeSubscribers.delete(envelope); },
12
+ onReconnect: () => () => {},
13
+ }),
14
+ }));
15
+ function dispatchMessagingFrame(frame) { realtimeSubscribers.get('messaging')?.(frame); }
16
+
17
+ import { ConversationList } from '../src/messaging/ConversationList';
18
+ import { applyFrame, MessagingProvider, useMessaging } from '../src/messaging/MessagingProvider';
19
+
20
+ function cache() { return { conversations: {}, messages: {}, threads: {}, polls: {}, reactions: {}, receipts: {}, unread: { unread_count: 0, by_conversation: {} }, cursors: { conversations: null, messages: {}, threads: {} } }; }
21
+
22
+ afterEach(() => { cleanup(); realtimeSubscribers.clear(); });
23
+
24
+ describe('last-message preview and conversation reorder', () => {
25
+ it('moves a conversation to the top and updates its preview from a server-shaped conversation_upsert frame', async () => {
26
+ const api = {
27
+ listConversations: vi.fn().mockResolvedValue({
28
+ results: [
29
+ { id: 1, title: 'Older', last_message_at: '2026-07-31T09:00:00Z', last_message: { excerpt: 'Old preview' } },
30
+ { id: 2, title: 'Newer', last_message_at: '2026-07-31T10:00:00Z', last_message: { excerpt: 'Newer preview' } },
31
+ ],
32
+ next_cursor: null,
33
+ }),
34
+ getUnreadCount: vi.fn().mockResolvedValue({ unread_count: 0, by_conversation: {} }),
35
+ listMessages: vi.fn().mockResolvedValue({ results: [] }),
36
+ };
37
+ render(<MessagingProvider api={api}><ConversationList /></MessagingProvider>);
38
+ await screen.findByText('Newer preview');
39
+ // Server-shaped conversation_upsert payload: serialize_conversation_core's
40
+ // real keys (id, last_message_at, last_message: {excerpt}), not a
41
+ // client-invented shape.
42
+ dispatchMessagingFrame({
43
+ envelope: 'messaging', type: 'conversation_upsert', event_id: 'evt-1', conversation_id: 1,
44
+ id: '1', last_message_at: '2026-07-31T12:00:00Z', last_message: { excerpt: 'Fresh reply' },
45
+ });
46
+ await screen.findByText('Fresh reply');
47
+ const rows = screen.getAllByRole('button').map((el) => el.textContent);
48
+ const olderIndex = rows.findIndex((text) => text.includes('Older'));
49
+ const newerIndex = rows.findIndex((text) => text.includes('Newer'));
50
+ expect(olderIndex).toBeGreaterThanOrEqual(0);
51
+ expect(olderIndex).toBeLessThan(newerIndex);
52
+ });
53
+
54
+ it('reflects an edited or deleted last message through a REST refresh', async () => {
55
+ const api = {
56
+ listConversations: vi.fn()
57
+ .mockResolvedValueOnce({ results: [{ id: 1, title: 'Chat', last_message: { excerpt: 'Original text' } }], next_cursor: null })
58
+ .mockResolvedValueOnce({ results: [{ id: 1, title: 'Chat', last_message: { excerpt: '' } }], next_cursor: null }),
59
+ getUnreadCount: vi.fn().mockResolvedValue({ unread_count: 0, by_conversation: {} }),
60
+ listMessages: vi.fn().mockResolvedValue({ results: [] }),
61
+ };
62
+ function Refresher() {
63
+ const { refreshConversations } = useMessaging();
64
+ return <button onClick={() => refreshConversations()}>refresh</button>;
65
+ }
66
+ render(<MessagingProvider api={api}><ConversationList /><Refresher /></MessagingProvider>);
67
+ await screen.findByText('Original text');
68
+ screen.getByText('refresh').click();
69
+ await waitFor(() => expect(screen.queryByText('Original text')).toBeNull());
70
+ await screen.findByText('MessagingList.NO_MESSAGES');
71
+ });
72
+
73
+ it('applies a real message_edited frame (dcm always attaches frame.message) and updates the edited body', () => {
74
+ const state = { ...cache(), messages: { 'msg-1': { id: 'msg-1', conversation_id: 'conv-1', body: 'Before' } } };
75
+ // dcm's publish_messaging_event (realtime.py) always attaches a full
76
+ // frame.message = serialize_message(message) for message_edited, never
77
+ // just {message_id} alone — verified against django_core_micha's actual
78
+ // realtime.py. This is the real wire shape, not a client-invented one.
79
+ const next = applyFrame(state, {
80
+ envelope: 'messaging', type: 'message_edited', event_id: 'evt-2', conversation_id: 'conv-1', message_id: 'msg-1',
81
+ message: { id: 'msg-1', conversation_id: 'conv-1', body: 'After edit', edited_at: '2026-07-31T12:00:00Z' },
82
+ }, null);
83
+ expect(next.messages['msg-1'].body).toBe('After edit');
84
+ expect(next.messages['msg-1'].edited_at).toBe('2026-07-31T12:00:00Z');
85
+ });
86
+
87
+ it('keys a message_edited frame by message_id defensively, even if a producer ever omitted frame.message', () => {
88
+ const state = { ...cache(), messages: { 'msg-1': { id: 'msg-1', conversation_id: 'conv-1', body: 'Before' } } };
89
+ const next = applyFrame(state, { envelope: 'messaging', type: 'message_edited', event_id: 'evt-3', conversation_id: 'conv-1', message_id: 'msg-1' }, null);
90
+ expect(next.messages['msg-1']).toBeTruthy();
91
+ expect(next.messages['conv-1']).toBeUndefined();
92
+ });
93
+ });
@@ -0,0 +1,93 @@
1
+ // @vitest-environment jsdom
2
+ import React from 'react';
3
+ import { afterEach, describe, expect, it, vi } from 'vitest';
4
+ import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
5
+
6
+ vi.mock('react-i18next', () => ({ useTranslation: () => ({ t: (key, options) => options?.message ? `${key}:${options.message}` : key }) }));
7
+ vi.mock('../src/notifications/realtime', () => ({ useRealtime: () => ({ subscribe: () => () => {}, onReconnect: () => () => {} }) }));
8
+
9
+ import { AuthContext } from '../src/auth/AuthContext';
10
+ import { Composer } from '../src/messaging/Composer';
11
+ import { MessageBubble } from '../src/messaging/MessageBubble';
12
+ import { MessagingProvider } from '../src/messaging/MessagingProvider';
13
+
14
+ function makeApi() {
15
+ return {
16
+ patchMessage: vi.fn().mockImplementation(async (id, patch) => ({ id, ...patch, edited_at: '2026-07-31T10:01:00Z' })),
17
+ deleteMessage: vi.fn().mockImplementation(async (id) => ({ id, deleted_at: '2026-07-31T10:01:00Z' })),
18
+ };
19
+ }
20
+ function renderBubble(message, { userId = 1, canModerateMessages = false, api = makeApi() } = {}) {
21
+ const result = render(<AuthContext.Provider value={{ user: { id: userId } }}><MessagingProvider api={api} active={false}><MessageBubble message={message} canModerateMessages={canModerateMessages} /></MessagingProvider></AuthContext.Provider>);
22
+ return { ...result, api };
23
+ }
24
+ function openActions() { fireEvent.click(screen.getByRole('button', { name: 'MessagingActions.MENU' })); }
25
+
26
+ afterEach(cleanup);
27
+
28
+ describe('message actions', () => {
29
+ it('gates the menu to the author or host-supplied moderator capability, never deleted or poll messages', () => {
30
+ const mine = { id: 1, body: 'Mine', sender: { id: 1 } };
31
+ const theirs = { id: 2, body: 'Theirs', sender: { id: 2 } };
32
+ const { rerender } = renderBubble(mine);
33
+ expect(screen.getByRole('button', { name: 'MessagingActions.MENU' })).toBeTruthy();
34
+ rerender(<AuthContext.Provider value={{ user: { id: 1 } }}><MessagingProvider api={makeApi()} active={false}><MessageBubble message={theirs} /></MessagingProvider></AuthContext.Provider>);
35
+ expect(screen.queryByRole('button', { name: 'MessagingActions.MENU' })).toBeNull();
36
+ rerender(<AuthContext.Provider value={{ user: { id: 1 } }}><MessagingProvider api={makeApi()} active={false}><MessageBubble message={theirs} canModerateMessages /></MessagingProvider></AuthContext.Provider>);
37
+ expect(screen.getByRole('button', { name: 'MessagingActions.MENU' })).toBeTruthy();
38
+ rerender(<AuthContext.Provider value={{ user: { id: 1 } }}><MessagingProvider api={makeApi()} active={false}><MessageBubble message={{ ...mine, deleted_at: '2026-07-31T10:00:00Z' }} /></MessagingProvider></AuthContext.Provider>);
39
+ expect(screen.queryByRole('button', { name: 'MessagingActions.MENU' })).toBeNull();
40
+ rerender(<AuthContext.Provider value={{ user: { id: 1 } }}><MessagingProvider api={makeApi()} active={false}><MessageBubble message={{ ...mine, kind: 'poll' }} /></MessagingProvider></AuthContext.Provider>);
41
+ expect(screen.queryByRole('button', { name: 'MessagingActions.MENU' })).toBeNull();
42
+ });
43
+
44
+ it('edits an author message through the API and auto-cancels when deleted elsewhere', async () => {
45
+ const api = makeApi();
46
+ const message = { id: 4, body: 'Before', sender: { id: 1 } };
47
+ const { rerender } = renderBubble(message, { api });
48
+ openActions();
49
+ fireEvent.click(screen.getByRole('menuitem', { name: 'MessagingActions.EDIT' }));
50
+ const field = screen.getByRole('textbox', { name: 'MessagingActions.EDIT' });
51
+ fireEvent.change(field, { target: { value: 'After' } });
52
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingActions.SAVE' }));
53
+ await waitFor(() => expect(api.patchMessage).toHaveBeenCalledWith(4, { body: 'After' }));
54
+ openActions();
55
+ fireEvent.click(screen.getByRole('menuitem', { name: 'MessagingActions.EDIT' }));
56
+ expect(screen.getByRole('textbox', { name: 'MessagingActions.EDIT' })).toBeTruthy();
57
+ rerender(<AuthContext.Provider value={{ user: { id: 1 } }}><MessagingProvider api={api} active={false}><MessageBubble message={{ ...message, deleted_at: '2026-07-31T10:02:00Z' }} /></MessagingProvider></AuthContext.Provider>);
58
+ await waitFor(() => expect(screen.queryByRole('textbox', { name: 'MessagingActions.EDIT' })).toBeNull());
59
+ });
60
+
61
+ it('requires confirmation before author or moderator deletion reaches the API', async () => {
62
+ const api = makeApi();
63
+ const { rerender } = renderBubble({ id: 5, body: 'Delete me', sender: { id: 1 } }, { api });
64
+ openActions();
65
+ fireEvent.click(screen.getByRole('menuitem', { name: 'MessagingActions.DELETE' }));
66
+ expect(api.deleteMessage).not.toHaveBeenCalled();
67
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingActions.DELETE' }));
68
+ await waitFor(() => expect(api.deleteMessage).toHaveBeenCalledWith(5));
69
+ await waitFor(() => expect(screen.queryByRole('dialog')).toBeNull());
70
+ const moderatorApi = makeApi();
71
+ rerender(<AuthContext.Provider value={{ user: { id: 1 } }}><MessagingProvider api={moderatorApi} active={false}><MessageBubble message={{ id: 6, body: 'Moderator delete', sender: { id: 2 } }} canModerateMessages /></MessagingProvider></AuthContext.Provider>);
72
+ openActions();
73
+ fireEvent.click(screen.getByRole('menuitem', { name: 'MessagingActions.DELETE' }));
74
+ fireEvent.click(screen.getByRole('button', { name: 'MessagingActions.DELETE' }));
75
+ await waitFor(() => expect(moderatorApi.deleteMessage).toHaveBeenCalledWith(6));
76
+ });
77
+
78
+ it('clears a deleted reply target and copies the exact message body', async () => {
79
+ const onReplyTargetChange = vi.fn();
80
+ const replyTarget = { id: 7, body: 'Reply source', sender: { display_name: 'Ava' } };
81
+ const { rerender } = render(<MessagingProvider api={makeApi()} active={false}><Composer conversationId={1} replyTarget={replyTarget} onReplyTargetChange={onReplyTargetChange} /></MessagingProvider>);
82
+ onReplyTargetChange.mockClear();
83
+ rerender(<MessagingProvider api={makeApi()} active={false}><Composer conversationId={1} replyTarget={{ ...replyTarget, deleted_at: '2026-07-31T10:00:00Z' }} onReplyTargetChange={onReplyTargetChange} /></MessagingProvider>);
84
+ await waitFor(() => expect(onReplyTargetChange).toHaveBeenCalledWith(null));
85
+
86
+ const writeText = vi.fn().mockResolvedValue(undefined);
87
+ Object.defineProperty(navigator, 'clipboard', { configurable: true, value: { writeText } });
88
+ renderBubble({ id: 8, body: 'Copy exactly this', sender: { id: 1 } });
89
+ openActions();
90
+ fireEvent.click(screen.getByRole('menuitem', { name: 'MessagingActions.COPY' }));
91
+ await waitFor(() => expect(writeText).toHaveBeenCalledWith('Copy exactly this'));
92
+ });
93
+ });