@mflrevan/ucp 0.6.1 → 0.6.3

package/bridge/com.ucp.bridge/{Runtime.meta → Editor/Ui.meta}

@@ -1,5 +1,5 @@
 fileFormatVersion: 2
-guid: ed1329cd64b53ba45b1a53c86007094a
+guid: 72ee32817b4f45abac53f471c69e899e
 folderAsset: yes
 DefaultImporter:
   externalObjects: {}

package/bridge/com.ucp.bridge/Tests/Editor/ControllerSmokeTests.cs

@@ -7,6 +7,7 @@ using NUnit.Framework;
 using UnityEditor;
 using UnityEditor.SceneManagement;
 using UnityEngine;
+using UnityEngine.SceneManagement;
 using UnityEngine.Profiling;
 using UnityEngine.TestTools;
 
@@ -46,6 +47,7 @@ namespace UCP.Bridge.Tests
             PlayModeController.Register(_router);
             ReferenceController.Register(_router);
             LogsController.Register(_router);
+            RecordingController.Register(_router);
             HierarchyController.Register(_router);
             ProfilerController.Register(_router);
             PropertyController.Register(_router);
@@ -72,6 +74,7 @@ namespace UCP.Bridge.Tests
             DeleteTempLocalPackage();
             RemoveTempLocalPackageDependencyIfPresent();
             LogsController.ClearHistoryForTests();
+            RecordingController.ResetForTests();
             AssetImportSupport.ClearTestState();
             Profiler.enabled = false;
             Profiler.enableBinaryLog = false;
@@ -97,6 +100,7 @@ namespace UCP.Bridge.Tests
             DeleteTempLocalPackage();
             RemoveTempLocalPackageDependencyIfPresent();
             LogsController.ClearHistoryForTests();
+            RecordingController.ResetForTests();
             AssetImportSupport.ClearTestState();
             Profiler.enabled = false;
             Profiler.enableBinaryLog = false;
@@ -123,6 +127,115 @@ namespace UCP.Bridge.Tests
             Assert.That(Convert.ToBoolean(capabilities["sessionControl"]), Is.True);
         }
 
+        [Test]
+        public void RecordingController_RegistersLifecycleMethodsAndReportsIdle()
+        {
+            Assert.That(_router.HasMethod("record/start"), Is.True);
+            Assert.That(_router.HasMethod("record/stop"), Is.True);
+            Assert.That(_router.HasMethod("record/status"), Is.True);
+            Assert.That(_router.HasMethod("record/arm"), Is.True);
+            Assert.That(_router.HasMethod("record/signal"), Is.True);
+
+            var response = _router.Dispatch("record/status", 1, "{}");
+            Assert.That(response.error, Is.Null);
+            var result = (Dictionary<string, object>)response.result;
+            Assert.That(result["state"], Is.EqualTo("idle"));
+        }
+
+        [Test]
+        public void RecordingController_ResolvesEvenAspectPreservingDimensions()
+        {
+            Assert.That(RecordingController.ResolveDimensionsForTests(16f / 9f, 960, null, null),
+                Is.EqualTo((960, 540)));
+            Assert.That(RecordingController.ResolveDimensionsForTests(9f / 16f, 960, null, null),
+                Is.EqualTo((540, 960)));
+            Assert.That(RecordingController.ResolveDimensionsForTests(4f / 3f, 960, 640, null),
+                Is.EqualTo((640, 480)));
+            Assert.That(RecordingController.ResolveDimensionsForTests(4f / 3f, 960, null, 600),
+                Is.EqualTo((800, 600)));
+        }
+
+        [Test]
+        public void RecordingController_ArmsAndMatchesNamedSignal()
+        {
+            var response = _router.Dispatch(
+                "record/arm",
+                1,
+                "{\"trigger\":\"signal:not-this-one\",\"duration\":1,\"timeout\":5}");
+            Assert.That(response.error, Is.Null);
+
+            var signal = _router.Dispatch("record/signal", 2, "{\"name\":\"different\"}");
+            Assert.That(signal.error, Is.Null);
+            var result = (Dictionary<string, object>)signal.result;
+            Assert.That(Convert.ToBoolean(result["matched"]), Is.False);
+            Assert.That(result["state"], Is.EqualTo("armed"));
+
+            var stop = _router.Dispatch("record/stop", 3, "{}");
+            Assert.That(stop.error, Is.Null);
+            var stopped = (Dictionary<string, object>)stop.result;
+            Assert.That(stopped["state"], Is.EqualTo("idle"));
+        }
+
+        [Test]
+        public void GetProperty_ReturnsCompositeValuesRatherThanTypeNames()
+        {
+            // Regression: when SerializedObject.FindProperty resolves a name, the value it returns
+            // is already JSON-shaped. That result used to be converted a second time, match no
+            // case, and fall through to value.ToString() -- so a Vector3 arrived as
+            // "System.Collections.Generic.List`1[System.Object]". Querying the serialized name
+            // (m_LocalPosition) is what forces the FindProperty path; the public alias (position)
+            // has no serialized entry and takes the reflection fallback instead, which is why that
+            // one never looked broken.
+            var go = new GameObject("UcpPropertyProbe");
+            try
+            {
+                go.transform.localPosition = new Vector3(1.5f, 2.5f, 3.5f);
+                var id = go.GetId();
+
+                var serialized = _router.Dispatch("object/get-property", 1, "{\"instanceId\":ID,\"component\":\"Transform\",\"property\":\"m_LocalPosition\"}".Replace("ID", id.ToString()));
+                Assert.That(serialized.error, Is.Null);
+                var serializedResult = (Dictionary<string, object>)serialized.result;
+                var localPosition = serializedResult["value"] as IList;
+                Assert.That(localPosition, Is.Not.Null,
+                    "a serialized Vector3 must come back as an array, not a stringified type name");
+                Assert.That(localPosition.Count, Is.EqualTo(3));
+                Assert.That(Convert.ToDouble(localPosition[0]), Is.EqualTo(1.5d).Within(1e-4));
+                Assert.That(Convert.ToDouble(localPosition[2]), Is.EqualTo(3.5d).Within(1e-4));
+                Assert.That(serializedResult["type"], Is.EqualTo("Vector3"),
+                    "type must describe the field, not the container it was shaped into");
+
+                // Reflection fallback: no serialized entry named "position".
+                var reflected = _router.Dispatch("object/get-property", 2, "{\"instanceId\":ID,\"component\":\"Transform\",\"property\":\"position\"}".Replace("ID", id.ToString()));
+                Assert.That(reflected.error, Is.Null);
+                var reflectedResult = (Dictionary<string, object>)reflected.result;
+                Assert.That(reflectedResult["value"] as IList, Is.Not.Null);
+                Assert.That(reflectedResult["type"], Is.EqualTo("Vector3"));
+            }
+            finally
+            {
+                UnityEngine.Object.DestroyImmediate(go);
+            }
+        }
+
+        [Test]
+        public void RecordingController_ValidatesSlowdownRange()
+        {
+            // --slowdown exists to raise effective temporal resolution for models that sample a
+            // clip at a fixed low rate, so an out-of-range factor must fail loudly rather than
+            // silently producing a file whose playback rate is meaningless.
+            var tooLarge = _router.Dispatch("record/arm", 1, "{\"trigger\":\"signal:sd\",\"duration\":1,\"timeout\":5,\"slowdown\":40}");
+            Assert.That(tooLarge.error, Is.Not.Null, "a slowdown above the supported range must be rejected");
+
+            var accepted = _router.Dispatch("record/arm", 2, "{\"trigger\":\"signal:sd\",\"duration\":1,\"timeout\":5,\"slowdown\":6}");
+            Assert.That(accepted.error, Is.Null);
+            var armed = (Dictionary<string, object>)accepted.result;
+            Assert.That(armed["state"], Is.EqualTo("armed"));
+
+            var stop = _router.Dispatch("record/stop", 3, "{}");
+            Assert.That(stop.error, Is.Null);
+            Assert.That(((Dictionary<string, object>)stop.result)["state"], Is.EqualTo("idle"));
+        }
+
         [Test]
         public void ProfilerSessionStartStop_TogglesProfilerState()
         {
@@ -545,6 +658,80 @@ namespace UCP.Bridge.Tests
             Assert.That(getResult["stackTrace"], Is.EqualTo("stack line 1\nstack line 2"));
         }
 
+        [Test]
+        public void EditorStateSummary_ReportsModeSceneAndConsoleAndCountsNewEntries()
+        {
+            var cursor = LogsController.GetLatestId();
+            var summary = EditorStateSummary.Capture(cursor);
+
+            Assert.That(summary["mode"], Is.EqualTo("edit"));
+            var scene = (Dictionary<string, object>)summary["scene"];
+            Assert.That(scene["name"], Is.EqualTo(SceneManager.GetActiveScene().name));
+            Assert.That(scene["dirty"], Is.EqualTo(SceneManager.GetActiveScene().isDirty));
+            var console = (Dictionary<string, object>)summary["console"];
+            Assert.That(Convert.ToInt32(console["errors"]), Is.GreaterThanOrEqualTo(0));
+            Assert.That(Convert.ToInt32(console["warnings"]), Is.GreaterThanOrEqualTo(0));
+            Assert.That(console.ContainsKey("newWarnings"), Is.False, "nothing was logged after the cursor");
+            Assert.That(summary.ContainsKey("recording"), Is.False);
+
+            LogAssert.Expect(LogType.Warning, "ucp summary probe warning");
+            Debug.LogWarning("ucp summary probe warning");
+
+            var after = (Dictionary<string, object>)EditorStateSummary.Capture(cursor)["console"];
+            Assert.That(Convert.ToInt32(after["newWarnings"]), Is.EqualTo(1));
+            Assert.That(after.ContainsKey("newErrors"), Is.False);
+            LogsController.CountLevels(cursor, out var errors, out var warnings);
+            Assert.That(errors, Is.EqualTo(0));
+            Assert.That(warnings, Is.EqualTo(1));
+        }
+
+        [Test]
+        public void EditorStateSummary_ReadsTheConsoleBadgeCounts()
+        {
+            Assert.That(EditorStateSummary.TryReadConsoleCounts(out var errors, out var warnings), Is.True,
+                "UnityEditor.LogEntries.GetCountsByType must be reachable on this editor");
+            Assert.That(errors, Is.GreaterThanOrEqualTo(0));
+            Assert.That(warnings, Is.GreaterThanOrEqualTo(0));
+        }
+
+        [Test]
+        public void Responses_CarryTheEditorSummaryOnlyWhenDispatchedOnTheMainThread()
+        {
+            var response = JsonRpcResponse.Success(7, new Dictionary<string, object> { ["ok"] = true });
+
+            var offThread = BridgeServer.ResponseToDict(response);
+            Assert.That(offThread.ContainsKey("editor"), Is.False);
+
+            var onThread = BridgeServer.ResponseToDict(response, LogsController.GetLatestId());
+            var editor = (Dictionary<string, object>)onThread["editor"];
+            Assert.That(editor["mode"], Is.EqualTo("edit"));
+            Assert.That(onThread["result"], Is.SameAs(response.result));
+
+            var json = MiniJson.Serialize(onThread);
+            var parsed = (Dictionary<string, object>)MiniJson.Deserialize(json);
+            Assert.That(((Dictionary<string, object>)parsed["editor"]).ContainsKey("console"), Is.True);
+        }
+
+        [Test]
+        public void TestGuard_IgnoresLogsInsideIgnoreFailingMessagesWindows()
+        {
+            var entries = new List<string>
+            {
+                "real error before",
+                "\n" + LogsController.IgnoreFailingMessagesOnMarker,
+                "expected importer error",
+                "expected warning",
+                LogsController.IgnoreFailingMessagesOffMarker + "\n",
+                "real error after",
+                LogsController.IgnoreFailingMessagesOnMarker,
+                "still ignored when a test never resets the flag"
+            };
+
+            var kept = LogsController.ExcludeExpectedNoise(entries, entry => entry);
+
+            Assert.That(kept, Is.EqualTo(new[] { "real error before", "real error after" }));
+        }
+
         [Test]
         public void ObjectLifecycle_CreateMutateAndDelete_WorksEndToEnd()
         {
@@ -552,7 +739,7 @@ namespace UCP.Bridge.Tests
             Assert.That(create.error, Is.Null);
 
             var createResult = (Dictionary<string, object>)create.result;
-            var instanceId = Convert.ToInt32(createResult["instanceId"]);
+            var instanceId = Convert.ToInt64(createResult["instanceId"]);
 
             var rename = _router.Dispatch("object/set-name", 1, "{\"instanceId\":" + instanceId + ",\"name\":\"RenamedSmoke\"}");
             Assert.That(rename.error, Is.Null);
@@ -1264,7 +1451,7 @@ namespace UCP.Bridge.Tests
         {
             var create = _router.Dispatch("object/create", 1, "{\"name\":\"PrefabSource\"}");
             Assert.That(create.error, Is.Null);
-            var sourceId = Convert.ToInt32(((Dictionary<string, object>)create.result)["instanceId"]);
+            var sourceId = Convert.ToInt64(((Dictionary<string, object>)create.result)["instanceId"]);
 
             var createPrefab = _router.Dispatch(
                 "prefab/create",
@@ -1279,7 +1466,7 @@ namespace UCP.Bridge.Tests
                 "{\"prefab\":\"Assets/UcpControllerSmoke.prefab\",\"name\":\"PrefabInstance\"}"
             );
             Assert.That(instantiate.error, Is.Null);
-            var instanceId = Convert.ToInt32(((Dictionary<string, object>)instantiate.result)["instanceId"]);
+            var instanceId = Convert.ToInt64(((Dictionary<string, object>)instantiate.result)["instanceId"]);
 
             var status = _router.Dispatch("prefab/status", 1, "{\"instanceId\":" + instanceId + "}");
             Assert.That(status.error, Is.Null);
@@ -1647,4 +1834,5 @@ namespace UCP.Bridge.Tests
             public SearchRootAsset referenceAsset;
         }
     }
+
 }

package/bridge/com.ucp.bridge/Tests/Editor/SpatialVisualControllerTests.cs

@@ -62,7 +62,7 @@ namespace UCP.Bridge.Tests
         {
             var res = Result(_router.Dispatch("object/create", 1,
                 "{\"name\":\"Greybox\",\"primitive\":\"Cube\"}"));
-            var id = Convert.ToInt32(res["instanceId"]);
+            var id = Convert.ToInt64(res["instanceId"]);
             var go = ObjectLocator.FindByInstanceId(id);
             _spawned.Add(go);
 
@@ -179,7 +179,7 @@ namespace UCP.Bridge.Tests
             var res = Result(_router.Dispatch("physics/raycast", 1,
                 "{\"origin\":[0,5,0],\"direction\":[0,-1,0]}"));
             Assert.That(Convert.ToBoolean(res["hit"]), Is.True);
-            Assert.That(Convert.ToInt32(res["instanceId"]), Is.EqualTo(ground.GetId()));
+            Assert.That(Convert.ToInt64(res["instanceId"]), Is.EqualTo(ground.GetId()));
         }
 
         [Test]