@mettlecast/domain-cli 0.2.63 → 0.2.65

package/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 ## Unreleased
 
+### fix(#4810): `build` no longer crashes on aggregate/flows registries
+
+`runBuild` aggregated **every** `.mc/*-registry.json` file for `actions-types.d.ts`
+generation, including the aggregate `domain-registry.json` and the
+`flows-registry.json` (which have no `domain`/`actions` shape). This threw
+`TypeError: Cannot read properties of undefined (reading 'id')` in
+`buildActionsTypes`, breaking `mc-domain-module build` (and, downstream, the
+`doctor` "Actions have types" check) on any scaffolded project that has flows
+or an aggregate registry. The build now only aggregates per-domain registries
+(those carrying `domain.id` and an `actions` array), and `buildActionsTypes`
+defensively skips malformed registries.
+
 ### feat(#2132): Policy-as-data refactor (manifest v2)
 
 **Manifest schema bumped to v2.** Each `ManifestFileEntry` now carries a `policy` field:

package/dist/builder/build-types.js

@@ -9,6 +9,13 @@
 export function buildActionsTypes(registries) {
     const overloads = [];
     for (const reg of registries) {
+        // Skip registries that are not per-domain registries. The `.mc/` directory
+        // also contains aggregate (`domain-registry.json`) and flows
+        // (`flows-registry.json`) snapshots that share the `*-registry.json` suffix
+        // but have a different shape (no `domain` object / no `actions` array).
+        if (!reg?.domain?.id || !Array.isArray(reg.actions)) {
+            continue;
+        }
         for (const action of reg.actions) {
             const fqn = `${reg.domain.id}.${action.id}`;
             // Phase 1: use unknown for input/output

package/dist/commands/build.js

@@ -25,13 +25,29 @@ export async function runBuild(options) {
     await writeFile(outFile, JSON.stringify(registry), 'utf8');
     const apiExposedActions = registry.actions.filter(action => action.exposure.type === 'api').length;
     cliLogger.info({ outFile, apiExposedActions, events: registry.events.length }, 'Registry written');
-    // Discover all sibling registries and emit aggregated types
+    // Discover all sibling per-domain registries and emit aggregated types.
+    // The `.mc/` directory also holds aggregate (`domain-registry.json`) and
+    // flows (`flows-registry.json`) snapshots that share the `*-registry.json`
+    // suffix but are not per-domain registries; only registries carrying a
+    // `domain.id` and an `actions` array are aggregated for type generation.
     const registryDir = join(outFile, '..');
     const registryFiles = (await readdir(registryDir)).filter(f => f.endsWith('-registry.json'));
     const allRegistries = [];
     for (const f of registryFiles) {
         const raw = await readFile(join(registryDir, f), 'utf8');
-        allRegistries.push(JSON.parse(raw));
+        let parsed;
+        try {
+            parsed = JSON.parse(raw);
+        }
+        catch {
+            cliLogger.warn(`Skipping unparseable registry file: ${f}`);
+            continue;
+        }
+        const candidate = parsed;
+        if (!candidate?.domain?.id || !Array.isArray(candidate.actions)) {
+            continue;
+        }
+        allRegistries.push(candidate);
     }
     const typesContent = buildActionsTypes(allRegistries);
     const typesFile = join(registryDir, 'actions-types.d.ts');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mettlecast/domain-cli",
-  "version": "0.2.63",
+  "version": "0.2.65",
   "type": "module",
   "publishConfig": {
     "registry": "https://registry.npmjs.org",

package/src/__tests__/build-types.test.ts

@@ -71,6 +71,35 @@ describe('buildActionsTypes', () => {
     expect(output).toContain("call(actionId: 'payments.charge'");
   });
 
+  it('skips aggregate/flows registries that lack a domain object', () => {
+    const auth: DomainRegistry = {
+      schemaVersion: '1',
+      domainRoot: '/test/auth',
+      domain: { id: 'auth', kind: 'domain', name: 'Auth', tenancy: 'required' },
+      webhooks: [],
+      subscribers: [],
+      schedules: [],
+      jobs: [],
+      actions: [
+        { id: 'verify', kind: 'action', handlerFile: 'verify.ts', backendAccess: 'platform', exposure: { type: 'internal' }, idempotent: true },
+      ],
+      integrations: [],
+      events: [],
+    };
+
+    // Aggregate registry (domain-registry.json): has actions but no domain.
+    const aggregate = { schemaVersion: '1', actions: [{ id: 'x' }] } as unknown as DomainRegistry;
+    // Flows registry (flows-registry.json): neither domain nor actions.
+    const flows = { schemaVersion: '1', flows: [] } as unknown as DomainRegistry;
+
+    expect(() => buildActionsTypes([auth, aggregate, flows])).not.toThrow();
+
+    const output = buildActionsTypes([auth, aggregate, flows]);
+    expect(output).toContain("call(actionId: 'auth.verify'");
+    // The aggregate registry's bare action must not leak in without a domain prefix.
+    expect(output).not.toContain('undefined.x');
+  });
+
   it('returns valid TypeScript .d.ts syntax', () => {
     const registry: DomainRegistry = {
       schemaVersion: '1',

package/src/builder/build-types.ts

@@ -12,6 +12,13 @@ export function buildActionsTypes(registries: DomainRegistry[]): string {
   const overloads: string[] = [];
 
   for (const reg of registries) {
+    // Skip registries that are not per-domain registries. The `.mc/` directory
+    // also contains aggregate (`domain-registry.json`) and flows
+    // (`flows-registry.json`) snapshots that share the `*-registry.json` suffix
+    // but have a different shape (no `domain` object / no `actions` array).
+    if (!reg?.domain?.id || !Array.isArray(reg.actions)) {
+      continue;
+    }
     for (const action of reg.actions) {
       const fqn = `${reg.domain.id}.${action.id}`;
       // Phase 1: use unknown for input/output

package/src/commands/build.ts

@@ -43,13 +43,28 @@ export async function runBuild(options: BuildOptions): Promise<string> {
   const apiExposedActions = registry.actions.filter(action => action.exposure.type === 'api').length;
   cliLogger.info({ outFile, apiExposedActions, events: registry.events.length }, 'Registry written');
 
-  // Discover all sibling registries and emit aggregated types
+  // Discover all sibling per-domain registries and emit aggregated types.
+  // The `.mc/` directory also holds aggregate (`domain-registry.json`) and
+  // flows (`flows-registry.json`) snapshots that share the `*-registry.json`
+  // suffix but are not per-domain registries; only registries carrying a
+  // `domain.id` and an `actions` array are aggregated for type generation.
   const registryDir = join(outFile, '..');
   const registryFiles = (await readdir(registryDir)).filter(f => f.endsWith('-registry.json'));
   const allRegistries: DomainRegistry[] = [];
   for (const f of registryFiles) {
     const raw = await readFile(join(registryDir, f), 'utf8');
-    allRegistries.push(JSON.parse(raw) as DomainRegistry);
+    let parsed: unknown;
+    try {
+      parsed = JSON.parse(raw);
+    } catch {
+      cliLogger.warn(`Skipping unparseable registry file: ${f}`);
+      continue;
+    }
+    const candidate = parsed as Partial<DomainRegistry>;
+    if (!candidate?.domain?.id || !Array.isArray(candidate.actions)) {
+      continue;
+    }
+    allRegistries.push(candidate as DomainRegistry);
   }
   const typesContent = buildActionsTypes(allRegistries);
   const typesFile = join(registryDir, 'actions-types.d.ts');