@meteorjs/rspack 3.0.0-rc.0 → 3.0.0-rc.1

package/lib/compilationOutput.js

@@ -0,0 +1,33 @@
+// Type checkers and other plugins/watchers can invalidate a compilation without
+// changing its output. This can affect any Rspack project, regardless of language.
+// Rspack already compares asset contents before writing them, so track emitted
+// flags and asset names without copying and hashing entire bundles in JS.
+function createOutputTracker() {
+  let version = 0;
+  let previousNames;
+
+  return stats => {
+    const { assets } = stats.toJson({
+      all: false,
+      assets: true,
+      cachedAssets: true,
+      relatedAssets: true,
+    });
+    const pending = [...assets];
+    const names = [];
+    let emitted = false;
+    for (let i = 0; i < pending.length; i++) {
+      const asset = pending[i];
+      names.push(asset.name);
+      emitted ||= asset.emitted;
+      // Source maps are nested under their parent asset in Rspack stats.
+      if (asset.related) pending.push(...asset.related);
+    }
+    const currentNames = JSON.stringify(names.sort());
+    if (emitted || currentNames !== previousNames) version++;
+    previousNames = currentNames;
+    return version;
+  };
+}
+
+module.exports = { createOutputTracker };

package/lib/compilationOutput.test.js

@@ -0,0 +1,62 @@
+const { createOutputTracker } = require('./compilationOutput.js');
+
+const stats = (assets, { hash = 'compilation-hash', hasErrors = false } = {}) => ({
+  hash,
+  hasErrors: () => hasErrors,
+  toJson: () => ({ assets }),
+});
+const asset = (name, emitted = false, related = []) => ({
+  name, emitted, related,
+});
+
+describe('server output tracking', () => {
+  test('ignores compilation-only changes and asset ordering', () => {
+    const track = createOutputTracker();
+    const first = track(stats([
+      asset('server.js', true),
+      asset('chunk.js', true),
+    ]));
+
+    expect(track(stats([
+      asset('chunk.js'),
+      asset('server.js'),
+    ], { hash: 'different-compilation-hash' }))).toBe(first);
+
+    expect(track(stats([
+      asset('server.js'),
+      asset('chunk.js', true),
+    ]))).not.toBe(first);
+  });
+
+  test('detects source-map-only changes and asset removals', () => {
+    const track = createOutputTracker();
+    const first = track(stats([
+      asset('server.js', false, [asset('server.js.map')]),
+      asset('chunk.js'),
+    ]));
+    const updatedMap = track(stats([
+      asset('server.js', false, [asset('server.js.map', true)]),
+      asset('chunk.js'),
+    ]));
+    expect(updatedMap).not.toBe(first);
+
+    const removedChunk = track(stats([
+      asset('server.js', false, [asset('server.js.map')]),
+    ]));
+    expect(removedChunk).not.toBe(updatedMap);
+    expect(track(stats([
+      asset('server.js', false, [asset('server.js.map')]),
+    ]))).toBe(removedChunk);
+  });
+
+  test('keeps output changes visible when a failed build recovers without writing again', () => {
+    const track = createOutputTracker();
+    const lastSuccessful = track(stats([asset('server.js', true)]));
+    const failed = track(stats([asset('server.js', true)], { hasErrors: true }));
+    // Meteor ignores failed compilations; recovery must still differ from the
+    // last successful version even when Rspack has already written the output.
+    const recovered = track(stats([asset('server.js')]));
+    expect(recovered).toBe(failed);
+    expect(recovered).not.toBe(lastSuccessful);
+  });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@meteorjs/rspack",
-  "version": "3.0.0-rc.0",
+  "version": "3.0.0-rc.1",
   "description": "Configuration logic for using Rspack in Meteor projects",
   "main": "index.js",
   "type": "commonjs",

package/rspack.config.js

@@ -30,6 +30,7 @@ const { loadUserAndOverrideConfig } = require('./lib/meteorRspackConfigHelpers.j
 const { prepareMeteorRspackConfig } = require("./lib/meteorRspackConfigFactory");
 const { extractLocalDependencies } = require('./lib/localDependenciesHelpers.js');
 const { createTestClientNodePolyfillConfig } = require("./lib/testClientNodePolyfills.js");
+const { createOutputTracker } = require('./lib/compilationOutput.js');
 
 // Safe require that doesn't throw if the module isn't found
 function safeRequire(moduleName) {
@@ -961,6 +962,7 @@ module.exports = async function (inMeteor = {}, argv = {}) {
   }
 
   // Add MeteorRspackOutputPlugin as the last plugin to output compilation info
+  const trackServerOutput = createOutputTracker();
   const meteorRspackOutputPlugin = new MeteorRspackOutputPlugin({
     getData: (stats, { isRebuild, compilationCount, compiler }) => {
       const generatedAppPaths = [
@@ -988,7 +990,13 @@ module.exports = async function (inMeteor = {}, argv = {}) {
         hasErrors: stats.hasErrors(),
         hasWarnings: stats.hasWarnings(),
         hasAppSourceChanges,
-        hash: stats.hash,
+        // Use output changes to decide development server restarts. Production,
+        // test, native, and client compilations keep Rspack's original hash.
+        // Include failed emissions in the version so recovery still restarts
+        // if the output changed before the errors were cleared.
+        hash: isServer && isDevEnvironment
+          ? trackServerOutput(stats)
+          : stats.hash,
         timestamp: Date.now(),
         statsOverrided,
         compilationCount,