@metaobjectsdev/cli 1.0.3 → 1.0.4-rc.1

package/src/commands/verify.ts

@@ -14,7 +14,9 @@ import { emitStructured, type OutputFormat } from "../lib/format.js";
 import {
   antiPatternRows, missingBaseUrlRows, removedPropRows, ranSection, skippedSection, warnCapped,
   type AdvisoryDiagnosticRow, type AdvisoryFindingRow, type AdvisorySection,
+  libraryPrefixRows,
 } from "../lib/advisory.js";
+import { scanForUnprovenancedLibraryPrefix } from "../lib/library-prefix-advisory.js";
 import { warnIfAgentContextStale } from "../lib/agent-context-staleness.js";
 import { warnIfManifestIgnored } from "../lib/manifest-ignored-check.js";
 import { scanSourceForAntiPatterns } from "../lib/anti-patterns.js";
@@ -382,7 +384,7 @@ export async function verifyCommand(
   // model. Warnings ONLY — never changes the exit code (bias to under-flagging).
   // Suppressed with --no-antipatterns or META_NO_ANTIPATTERNS=1 for the rare
   // noisy project (both opt-outs work on `meta verify` and `meta gen`).
-  runAntiPatternAdvisory();
+  await runAntiPatternAdvisory();
 
   const exitCode = Math.max(
     templateExit,
@@ -646,15 +648,20 @@ export async function verifyCommand(
       say(
         `meta verify — requirements: ${s.total} entries (${s.functional} functional, ` +
         `${s.architectural} architectural) — ${parts.join(", ")}; ` +
-        `${s.entitiesClaimed}/${s.entitiesTotal} entities claimed, ` +
-        `counted over ${collection.files.length} metadata file(s)` +
-        // FR-023 — only when there ARE dependencies. A project that declares none
-        // must print the sentence it printed before dependencies existed, to the
-        // byte: "0 from dependencies" is noise on every existing project, and this
-        // line is a SURFACE the no-dependency guarantee covers like any other.
-        (collection.dependencies.length > 0
-          ? `, ${collection.dependencies.length} from dependencies.`
-          : `.`),
+        // FR-043 §5.4 — a project whose every requirement came from a shipped library
+        // is not measured, and says so rather than printing a ratio. Silence would be
+        // worse than either: a missing clause reads as a clean coverage result.
+        (s.entitiesTotal === undefined
+          ? `coverage: not measured (no project-authored requirements).`
+          : `${s.entitiesClaimed}/${s.entitiesTotal} entities claimed, ` +
+            `counted over ${collection.files.length} metadata file(s)` +
+            // FR-023 — only when there ARE dependencies. A project that declares none
+            // must print the sentence it printed before dependencies existed, to the
+            // byte: "0 from dependencies" is noise on every existing project, and this
+            // line is a SURFACE the no-dependency guarantee covers like any other.
+            (collection.dependencies.length > 0
+              ? `, ${collection.dependencies.length} from dependencies.`
+              : `.`)),
       );
       if (s.undecided > 0) {
         say(
@@ -674,8 +681,12 @@ export async function verifyCommand(
           .filter((k) => (s.byStatus[k] ?? 0) > 0)
           .map((k) => ({ status: k, count: s.byStatus[k] ?? 0 })),
         undecided: s.undecided,
-        entitiesClaimed: s.entitiesClaimed,
-        entitiesTotal: s.entitiesTotal,
+        // Absent when coverage was not measured (FR-043 §5.4), never zeroed: a reader
+        // cannot tell `0/0 claimed` from "not measured", and the two mean opposite
+        // things.
+        ...(s.entitiesTotal === undefined
+          ? {}
+          : { entitiesClaimed: s.entitiesClaimed ?? 0, entitiesTotal: s.entitiesTotal }),
         metadataFiles: collection.files.length,
       };
     }
@@ -777,7 +788,7 @@ export async function verifyCommand(
   // Records its result EITHER WAY — a skip carries its reason rather than looking
   // like a clean scan. Warnings only; nothing here reaches the exit code (the
   // scanner's own header: bias to under-flagging, never a non-zero exit).
-  function runAntiPatternAdvisory(): void {
+  async function runAntiPatternAdvisory(): Promise<void> {
     if (flags.noAntipatterns) {
       antiPatternSection = skippedSection("suppressed by --no-antipatterns");
       return;
@@ -816,10 +827,23 @@ export async function verifyCommand(
       // advisory only — never breaks verify.
     }
 
+    // FR-043 §3.5 — `metaobjects::` in this project's own metadata with no ejection
+    // provenance. Advisory because with the library NOT opted in nothing is broken; the
+    // opted-in case is refused at load instead.
+    let libraryPrefix: Awaited<ReturnType<typeof scanForUnprovenancedLibraryPrefix>> = [];
+    try {
+      libraryPrefix = await scanForUnprovenancedLibraryPrefix(
+        root, collection.ownFiles, collection.configDir,
+      );
+    } catch {
+      // Same discipline as its siblings: an advisory scan never breaks verify.
+    }
+
     antiPatternSection = ranSection([
       ...antiPatternRows(findings),
       ...missingBaseUrlRows(baseUrl),
       ...removedPropRows(removedProps),
+      ...libraryPrefixRows(libraryPrefix),
     ]);
     if (findings.length > 0) {
       log.warn(
@@ -842,6 +866,13 @@ export async function verifyCommand(
       );
       warnCapped(removedProps.map((f) => `  ${f.message}`), flags.limit, { structured });
     }
+    if (libraryPrefix.length > 0) {
+      log.warn(
+        `meta verify — ${libraryPrefix.length} node(s) declared under "metaobjects::" with ` +
+          `no ejection provenance (advisory — does not fail the build):`,
+      );
+      warnCapped(libraryPrefix.map((f) => `  ${f.message}`), flags.limit, { structured });
+    }
   }
 
   // -- template (prompt / output) drift --------------------------------------
@@ -1572,8 +1603,9 @@ interface RequirementCounts {
   architectural: number;
   byStatus: { status: string; count: number }[];
   undecided: number;
-  entitiesClaimed: number;
-  entitiesTotal: number;
+  /** Absent when coverage was not measured — FR-043 §5.4. */
+  entitiesClaimed?: number;
+  entitiesTotal?: number;
   /** How many metadata files the two entity counts were taken over. */
   metadataFiles: number;
 }

package/src/index.ts

@@ -17,7 +17,7 @@ const VERSION = cliVersion();
  * human text. It is named ONCE and used by both the warning below and the help
  * text above, so the two cannot drift apart.
  */
-const FORMAT_AWARE_COMMANDS: readonly string[] = ["gen", "verify", "migrate", "types", "deps"];
+const FORMAT_AWARE_COMMANDS: readonly string[] = ["gen", "verify", "migrate", "types", "deps", "eject"];
 
 const HELP_TEXT = `meta — MetaObjects CLI (v${VERSION})
 
@@ -58,8 +58,14 @@ GLOBAL OPTIONS:
 
 GEN FLAGS:
   --dry-run             Compute and print, don't write
-  --list                Print the generator registry (name, tier, options) and exit —
-                        no config or metadata required
+  --list                Print the generator CATALOG (name, layer, tier, what it emits,
+                        what to install) and exit. Codegen is opt-in: nothing runs until
+                        you wire it, and this is where you choose. No config or metadata
+                        required — add --format json for the same catalog, machine-readable.
+  --probe               With --list: construct every catalog generator and dry-run it
+                        against YOUR model, reporting how many files each would emit.
+                        A count per generator beats any category label — and it
+                        cannot go stale, because it runs the generators. Needs a project.
   --baseline <default|adopt|fresh>
                         First-time-on-existing-file behavior. Default: refuse a file that
                         cannot be proved to be generated output. "adopt" records the files
@@ -156,8 +162,14 @@ USAGE:
 
 FLAGS:
   --dry-run             Compute and print, don't write
-  --list                Print the generator registry (name, tier, options) and exit —
-                        no config or metadata required
+  --list                Print the generator CATALOG (name, layer, tier, what it emits,
+                        what to install) and exit. Codegen is opt-in: nothing runs until
+                        you wire it, and this is where you choose. No config or metadata
+                        required — add --format json for the same catalog, machine-readable.
+  --probe               With --list: construct every catalog generator and dry-run it
+                        against YOUR model, reporting how many files each would emit.
+                        A count per generator beats any category label — and it cannot go
+                        stale, because it runs the generators. Needs a project.
   --baseline <default|adopt|fresh>
                         First-time-on-existing-file behavior. Default: refuse a file that
                         cannot be proved to be generated output. "adopt" records the files
@@ -183,23 +195,33 @@ limit on the machine-readable result.
 
 NOTE: outDir, dialect, dbImport, extStyle are read from metaobjects.config.ts
 `,
-  eject: `meta eject — copy a reference generator into your repo so you own it
+  eject: `meta eject — copy reference generators into your repo so you own them
 
 USAGE:
-  meta eject <name>      Copy generator <name> into codegen/generators/<name>.ts
+  meta eject <name>...   Copy each generator into codegen/generators/<name>.ts
   meta eject --list      List every ejectable generator name, grouped by package
 
+Codegen is opt-in — \`meta init\` wires nothing — so this is the door every generator
+you run comes through. Take several at once: the install set is CONSOLIDATED, so
+\`meta eject form hooks grid\` prints one install line, not three. An unknown name
+refuses the whole call and copies nothing.
+
 FLAGS:
   --list                 List ejectable generators instead of copying one
   --force                Overwrite an already-ejected file (default: never clobber)
+  --format <toon|json|text>   Output format (global flag). The structured form carries
+                         each file's wire lines, the consolidated install set and the
+                         config keys the ejected generators read.
   --help, -h             Print this help
 
-\`meta init\` copies five generators (entity, queries, routes, barrel, names) into
-codegen/generators/ automatically (ADR-0034 scaffold-and-own). \`meta eject\` is
-the same operation for ANY generator — one you skipped at init time, a UI-tier
-generator like form/hooks/grid, or one a package gains later. It prints the
-import line to paste into metaobjects.config.ts, and it never overwrites a
-file you already own unless you pass --force.
+\`meta init\` copies NO generators — codegen is opt-in, and codegen/generators/
+starts empty on purpose. Everything you run comes through here (ADR-0034
+scaffold-and-own): the file is YOURS to edit, and \`meta gen\` runs your copy, not
+the package's. It prints the import line and the entry to add in
+metaobjects.config.ts, and never overwrites a file you already own without --force.
+
+Find names with \`meta gen --list\` — add --probe to see how many files each would
+emit for your model.
 `,
   deps: `meta deps — sync a declared metadata dependency's committed snapshot
 
@@ -584,7 +606,7 @@ export async function run(argv: string[]): Promise<number> {
     }
     case "eject": {
       const { ejectCommand } = await import("./commands/eject.js");
-      return ejectCommand(rest, cwd);
+      return ejectCommand(rest, cwd, fmt);
     }
     case "deps": {
       const { depsCommand } = await import("./commands/deps.js");

package/src/lib/advisory.ts

@@ -150,6 +150,19 @@ export function removedPropRows(findings: readonly RemovedPropFinding[]): Adviso
   }));
 }
 
+/** FR-043 §3.5 findings in the same row shape. */
+export function libraryPrefixRows(
+  findings: readonly { file: string; fqn: string; message: string }[],
+): AdvisoryFindingRow[] {
+  return findings.map((f) => ({
+    file: f.file,
+    line: 0,
+    rule: "library-prefix-unprovenanced",
+    construct: f.fqn,
+    message: f.message,
+  }));
+}
+
 // ---------------------------------------------------------------------------
 // text output
 // ---------------------------------------------------------------------------

package/src/lib/args.ts

@@ -107,6 +107,12 @@ export interface GenFlags {
   /** ADR-0021 D3 — print the stable-name generator registry and exit without
    *  running codegen. */
   list: boolean;
+  /**
+   * `--list` only: construct every catalog generator and dry-run it against THIS
+   * project's model, reporting a real file count per generator. Needs a project;
+   * plain `--list` deliberately does not (it describes the installed engine).
+   */
+  probe: boolean;
   /** Suppress the advisory anti-pattern (verify-as-teacher) pass. */
   noAntipatterns: boolean;
   /**
@@ -122,6 +128,7 @@ export const GEN_OPTIONS = {
   "dry-run": { type: "boolean", default: false },
   "baseline": { type: "string" },
   "list": { type: "boolean", default: false },
+  "probe": { type: "boolean", default: false },
   "no-antipatterns": { type: "boolean", default: false },
   "limit": { type: "string" },
 } as const;
@@ -149,6 +156,7 @@ export function parseGenArgs(argv: string[]): GenFlags {
     entities: positionals,
     baseline: (baselineRaw as "default" | "fresh" | "adopt" | undefined) ?? "default",
     list: !!values.list,
+    probe: !!values.probe,
     noAntipatterns: !!values["no-antipatterns"],
     // Throws on a bad value; the command layer reports it and exits 2, exactly as
     // it does for --baseline above.
@@ -602,8 +610,14 @@ export function parseMigrateArgs(argv: string[]): MigrateFlags {
 // ---------------------------------------------------------------------------
 
 export interface EjectFlags {
-  /** The generator name to eject; undefined when only --list was given. */
-  name: string | undefined;
+  /**
+   * The generator names to eject, in the order given. Empty when only --list was given.
+   *
+   * MANY, not one: choosing a client tier means `form hooks grid`, and three separate
+   * invocations produce three separate install lines for the same package. The
+   * consolidated install set is the point of taking them together.
+   */
+  names: string[];
   list: boolean;
   /** Overwrite an already-ejected file; default false — eject never clobbers. */
   force: boolean;
@@ -623,12 +637,22 @@ export function parseEjectArgs(argv: string[]): EjectFlags {
     allowPositionals: true,
   });
 
-  if (positionals.length > 1) {
-    throw new Error(`meta eject takes at most one generator name; got: ${positionals.join(", ")}`);
+  // `Set.add` returns the SET, which is always truthy — so the tempting
+  // `positionals.filter((n) => !seen.add(n))` never reports anything.
+  const seen = new Set<string>();
+  const duplicates: string[] = [];
+  for (const n of positionals) {
+    if (seen.has(n)) duplicates.push(n);
+    else seen.add(n);
+  }
+  if (duplicates.length > 0) {
+    throw new Error(
+      `meta eject: repeated generator name(s): ${[...new Set(duplicates)].join(", ")}`,
+    );
   }
 
   return {
-    name: positionals[0],
+    names: positionals,
     list: !!values.list,
     force: !!values.force,
   };