@metamask/assets-controller 4.0.0 → 5.0.1

package/CHANGELOG.md

@@ -7,6 +7,41 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [5.0.1]
+
+### Changed
+
+- Bump `@metamask/transaction-controller` from `^64.0.0` to `^64.2.0` ([#8432](https://github.com/MetaMask/core/pull/8432), [#8447](https://github.com/MetaMask/core/pull/8447))
+- Bump `@metamask/base-controller` from `^9.0.1` to `^9.1.0` ([#8457](https://github.com/MetaMask/core/pull/8457))
+- Bump `@metamask/assets-controllers` from `^103.1.1` to `^104.0.0` ([#8466](https://github.com/MetaMask/core/pull/8466))
+
+### Fixed
+
+- `AssetsController` no longer silently skips asset fetching on startup for returning users ([#8412](https://github.com/MetaMask/core/pull/8412))
+  - Previously, `#start()` was called at keyring unlock before `AccountTreeController.init()` had built the account tree, causing `#selectedAccounts` to return an empty array and all subscriptions and fetches to be skipped. `selectedAccountGroupChange` does not fire when the persisted selected group is unchanged, leaving the controller idle.
+  - Now subscribes to `AccountTreeController:stateChange` (the base-controller event guaranteed to fire when `init()` calls `this.update()`), so the controller re-evaluates its active state once accounts are available.
+  - `#start()` is now idempotent: it returns early when accounts or chains are not yet available, and when subscriptions are already active, preventing duplicate fetches from repeated events.
+
+## [5.0.0]
+
+### Changed
+
+- **BREAKING:** `TokenDetector` now fetches the token list directly from the Tokens API (`/v3/chains/{chain}/assets`) via a new `TokensApiClient` instead of reading from `TokenListController:getState` ([#8385](https://github.com/MetaMask/core/pull/8385))
+  - `TokenDetectorMessenger` type has been removed; `TokenDetector` constructor now takes a `TokensApiClient` instance as its second argument
+  - `RpcDataSource` no longer requires `TokenListController:getState` — `GetTokenListState` has been removed from `RpcDataSourceAllowedActions` and `AssetsControllerAllowedActions`
+  - Unknown ERC-20 metadata is no longer looked up from the token list as a fallback in `RpcDataSource`; `TokenDataSource` handles enrichment downstream
+- Split `getAssets` fetch pipeline into a fast awaited path and a parallel fire-and-forget background path to reduce perceived latency on unlock and onboarding ([#8383](https://github.com/MetaMask/core/pull/8383))
+  - Fast pipeline: AccountsApi + StakedBalance → Detection → Token + Price (awaited, committed to state immediately)
+  - Background pipeline: Snap + RPC run in parallel → Detection → Token + Price when basic functionality is enabled; when disabled (RPC-only mode), Token + Price are omitted (fire-and-forget merge)
+  - `handleAssetsUpdate` skips token/price enrichment and strips `metadata` / `price` from the effective request when basic functionality is disabled (RPC-only mode)
+  - `setSelectedCurrency` no longer triggers a price refresh via `getAssets` when basic functionality is disabled
+- `PriceDataSource` now batches spot-price API requests in chunks of 50 using `reduceInBatchesSerially` to avoid DynamoDB batch-limit errors ([#8383](https://github.com/MetaMask/core/pull/8383))
+- `TokenDataSource` now batches token metadata API requests in chunks of 50 using `reduceInBatchesSerially` to avoid DynamoDB batch-limit errors ([#8383](https://github.com/MetaMask/core/pull/8383))
+- `PriceDataSource` filters out all synthetic `slip44:NUMBER-*` staking-position asset IDs before calling the Price API ([#8383](https://github.com/MetaMask/core/pull/8383))
+- `TokenDataSource` filters EVM ERC-20 tokens by `occurrences >= 3` and treats missing occurrences as 0 ([#8383](https://github.com/MetaMask/core/pull/8383))
+- Bump `@metamask/keyring-controller` from `^25.1.1` to `^25.2.0` ([#8363](https://github.com/MetaMask/core/pull/8363))
+- Bump `@metamask/messenger` from `^1.0.0` to `^1.1.1` ([#8364](https://github.com/MetaMask/core/pull/8364), [#8373](https://github.com/MetaMask/core/pull/8373))
+
 ## [4.0.0]
 
 ### Changed
@@ -267,7 +302,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Refactor `RpcDataSource` to delegate polling to `BalanceFetcher` and `TokenDetector` services ([#7709](https://github.com/MetaMask/core/pull/7709))
 - Refactor `BalanceFetcher` and `TokenDetector` to extend `StaticIntervalPollingControllerOnly` for independent polling management ([#7709](https://github.com/MetaMask/core/pull/7709))
 
-[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@4.0.0...HEAD
+[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@5.0.1...HEAD
+[5.0.1]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@5.0.0...@metamask/assets-controller@5.0.1
+[5.0.0]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@4.0.0...@metamask/assets-controller@5.0.0
 [4.0.0]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@3.3.0...@metamask/assets-controller@4.0.0
 [3.3.0]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@3.2.1...@metamask/assets-controller@3.3.0
 [3.2.1]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@3.2.0...@metamask/assets-controller@3.2.1

package/dist/AssetsController.cjs

@@ -263,7 +263,15 @@ class AssetsController extends base_controller_1.BaseController {
         __classPrivateFieldSet(this, _AssetsController_trace, trace, "f");
         const rpcConfig = rpcDataSourceConfig ?? {};
         __classPrivateFieldSet(this, _AssetsController_onActiveChainsUpdated, (dataSourceName, chains, previousChains) => {
-            __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_handleActiveChainsUpdate).call(this, dataSourceName, chains, previousChains);
+            try {
+                __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_handleActiveChainsUpdate).call(this, dataSourceName, chains, previousChains);
+            }
+            catch (error) {
+                log('Failed to handle active chains update', {
+                    dataSourceName,
+                    error,
+                });
+            }
         }, "f");
         __classPrivateFieldSet(this, _AssetsController_backendWebsocketDataSource, new BackendWebsocketDataSource_1.BackendWebsocketDataSource({
             messenger: this.messenger,
@@ -356,12 +364,18 @@ class AssetsController extends base_controller_1.BaseController {
                 forceUpdate: true,
                 assetsForPriceUpdate: options?.assetsForPriceUpdate,
             });
-            const sources = __classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)
+            // Fast pipeline: accountsApi + stakedBalance → detection → token + price.
+            // Snap and RPC are excluded here due to their latency (snap triggers account
+            // creation, RPC is slow on many chains). Results are committed to state
+            // immediately so the UI can display balances without waiting for them.
+            //
+            // Both the fast and background pipelines use 'merge' mode because neither
+            // alone represents the full set of data sources. Using 'full' in either
+            // would wipe balances from the sources handled by the other pipeline.
+            const fastSources = __classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)
                 ? [
                     (0, ParallelMiddleware_1.createParallelBalanceMiddleware)([
                         __classPrivateFieldGet(this, _AssetsController_accountsApiDataSource, "f"),
-                        __classPrivateFieldGet(this, _AssetsController_snapDataSource, "f"),
-                        __classPrivateFieldGet(this, _AssetsController_rpcDataSource, "f"),
                         __classPrivateFieldGet(this, _AssetsController_stakedBalanceDataSource, "f"),
                     ]),
                     __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f"),
@@ -370,18 +384,33 @@ class AssetsController extends base_controller_1.BaseController {
                         __classPrivateFieldGet(this, _AssetsController_priceDataSource, "f"),
                     ]),
                 ]
-                : [
-                    __classPrivateFieldGet(this, _AssetsController_rpcDataSource, "f"),
-                    __classPrivateFieldGet(this, _AssetsController_stakedBalanceDataSource, "f"),
-                    __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f"),
-                ];
-            const { response, durationByDataSource } = await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_executeMiddlewares).call(this, sources, request);
-            // Default to 'merge' when fetching a subset of chains so we don't wipe
-            // balances from chains that weren't included in this fetch.
-            const isPartialChainFetch = options?.chainIds !== undefined &&
-                options.chainIds.length < __classPrivateFieldGet(this, _AssetsController_enabledChains, "f").size;
-            const updateMode = options?.updateMode ?? (isPartialChainFetch ? 'merge' : 'full');
-            await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateState).call(this, { ...response, updateMode });
+                : [__classPrivateFieldGet(this, _AssetsController_stakedBalanceDataSource, "f"), __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f")];
+            const { response, durationByDataSource } = await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_executeMiddlewares).call(this, fastSources, request);
+            // The fast pipeline only contains a subset of data sources (AccountsApi +
+            // StakedBalance), so it must always merge to avoid wiping Snap/RPC
+            // balances that the background pipeline hasn't yet replaced.
+            await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateState).call(this, { ...response, updateMode: 'merge' });
+            // Background pipeline: snap and RPC run in parallel after the fast path
+            // commits to state. Their balances are merged together before detection.
+            // Token + price enrichment matches the pre-split behavior: only when basic
+            // functionality is on (RPC-only mode must not call token/price APIs).
+            const slowSources = __classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)
+                ? [__classPrivateFieldGet(this, _AssetsController_snapDataSource, "f"), __classPrivateFieldGet(this, _AssetsController_rpcDataSource, "f")]
+                : [__classPrivateFieldGet(this, _AssetsController_rpcDataSource, "f")];
+            __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_executeMiddlewares).call(this, [
+                (0, ParallelMiddleware_1.createParallelBalanceMiddleware)(slowSources),
+                __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f"),
+                ...(__classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)
+                    ? [
+                        (0, ParallelMiddleware_1.createParallelMiddleware)([
+                            __classPrivateFieldGet(this, _AssetsController_tokenDataSource, "f"),
+                            __classPrivateFieldGet(this, _AssetsController_priceDataSource, "f"),
+                        ]),
+                    ]
+                    : []),
+            ], request)
+                .then(({ response: slowResponse }) => __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateState).call(this, { ...slowResponse, updateMode: 'merge' }))
+                .catch((error) => log('Background pipeline failed', { error }));
             const durationMs = performance.now() - startTime;
             // Emit trace for every full fetch (Assets Health dashboard)
             __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_FULL_FETCH, {
@@ -648,6 +677,9 @@ class AssetsController extends base_controller_1.BaseController {
             previousCurrency,
             selectedCurrency,
         });
+        if (!__classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)) {
+            return;
+        }
         this.getAssets(__classPrivateFieldGet(this, _AssetsController_instances, "a", _AssetsController_selectedAccounts_get), {
             forceUpdate: true,
             dataTypes: ['price'],
@@ -722,7 +754,8 @@ class AssetsController extends base_controller_1.BaseController {
     /**
      * Handle assets updated from a data source.
      * Called via the onAssetsUpdate callback passed in SubscriptionRequest when the controller subscribes to a data source.
-     * Enriches the response with token metadata (via middlewares) before updating state.
+     * Runs detection, then (when basic functionality is enabled) token metadata and price enrichment before updating state.
+     * When basic functionality is disabled (RPC-only mode), only detection runs; token and price APIs are not used.
      *
      * @param response - The data response with updated assets
      * @param sourceId - The data source ID reporting the update
@@ -735,19 +768,27 @@ class AssetsController extends base_controller_1.BaseController {
             hasBalance: Boolean(response.assetsBalance),
             hasPrice: Boolean(response.assetsPrice),
         });
-        // Run through enrichment middlewares (Detection, then Token + Price in parallel)
-        // Include 'metadata' in dataTypes so TokenDataSource runs to enrich detected assets
-        const { response: enrichedResponse } = await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_executeMiddlewares).call(this, [
-            __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f"),
-            (0, ParallelMiddleware_1.createParallelMiddleware)([
-                __classPrivateFieldGet(this, _AssetsController_tokenDataSource, "f"),
-                __classPrivateFieldGet(this, _AssetsController_priceDataSource, "f"),
-            ]),
-        ], request ?? {
+        const resolvedRequest = request ?? {
             accountsWithSupportedChains: [],
             chainIds: [],
             dataTypes: ['balance', 'metadata', 'price'],
-        }, response);
+        };
+        // RPC-only mode (basic functionality off): never run token/price APIs. Strip
+        // those data types so downstream middleware cannot treat them as requested.
+        const pipelineRequest = __classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)
+            ? resolvedRequest
+            : {
+                ...resolvedRequest,
+                dataTypes: resolvedRequest.dataTypes.filter((dt) => dt !== 'metadata' && dt !== 'price'),
+            };
+        const enrichmentSources = [__classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f")];
+        if (__classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)) {
+            enrichmentSources.push((0, ParallelMiddleware_1.createParallelMiddleware)([
+                __classPrivateFieldGet(this, _AssetsController_tokenDataSource, "f"),
+                __classPrivateFieldGet(this, _AssetsController_priceDataSource, "f"),
+            ]));
+        }
+        const { response: enrichedResponse } = await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_executeMiddlewares).call(this, enrichmentSources, pipelineRequest, response);
         await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateState).call(this, enrichedResponse);
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_UPDATE_PIPELINE, {
             source: sourceId,
@@ -887,6 +928,16 @@ _AssetsController_isEnabled = new WeakMap(), _AssetsController_isBasicFunctional
     this.messenger.subscribe('AccountTreeController:selectedAccountGroupChange', () => {
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_handleAccountGroupChanged).call(this).catch(console.error);
     });
+    // Catch the initial tree build. On returning users,
+    // `selectedAccountGroupChange` does NOT fire when the persisted group
+    // is unchanged, and `accountTreeChange` doesn't fire either (init()
+    // rebuilds from persisted accounts without publishing it).
+    // The base-controller `:stateChange` event is guaranteed to fire
+    // when init() calls this.update(). #start() is idempotent so
+    // repeated fires are safe.
+    this.messenger.subscribe('AccountTreeController:stateChange', () => {
+        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateActive).call(this);
+    });
     // Subscribe to network enablement changes (only enabledNetworkMap)
     this.messenger.subscribe('NetworkEnablementController:stateChange', ({ enabledNetworkMap }) => {
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_handleEnabledNetworksChanged).call(this, enabledNetworkMap).catch(console.error);
@@ -1302,14 +1353,22 @@ async function _AssetsController_executeMiddlewares(sources, request, initialRes
             return 'fungible';
     }
 }, _AssetsController_start = function _AssetsController_start() {
+    const accounts = __classPrivateFieldGet(this, _AssetsController_instances, "a", _AssetsController_selectedAccounts_get);
+    const chainIds = [...__classPrivateFieldGet(this, _AssetsController_enabledChains, "f")];
+    if (accounts.length === 0 || chainIds.length === 0) {
+        return;
+    }
+    if (__classPrivateFieldGet(this, _AssetsController_activeSubscriptions, "f").size > 0) {
+        return;
+    }
     log('Starting asset tracking', {
-        selectedAccountCount: __classPrivateFieldGet(this, _AssetsController_instances, "a", _AssetsController_selectedAccounts_get).length,
-        enabledChainCount: __classPrivateFieldGet(this, _AssetsController_enabledChains, "f").size,
+        selectedAccountCount: accounts.length,
+        enabledChainCount: chainIds.length,
     });
     __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_subscribeAssets).call(this);
     __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_ensureNativeBalancesDefaultZero).call(this);
-    this.getAssets(__classPrivateFieldGet(this, _AssetsController_instances, "a", _AssetsController_selectedAccounts_get), {
-        chainIds: [...__classPrivateFieldGet(this, _AssetsController_enabledChains, "f")],
+    this.getAssets(accounts, {
+        chainIds,
         forceUpdate: true,
     }).catch((error) => {
         log('Failed to fetch assets', error);