@metamask-previews/transaction-controller 68.0.0-preview-e4b456ca8 → 68.0.1-preview-0bd5566

package/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [68.0.1]
+
+### Fixed
+
+- Set `isExternalSign` to `true` when `isGasFeeSponsored` is confirmed by simulation, so gas-sponsored transactions from accounts that cannot locally sign (e.g. Money Account keyring) skip `KeyringController:signTransaction` ([#9148](https://github.com/MetaMask/core/pull/9148))
+
 ## [68.0.0]
 
 ### Changed
@@ -2500,7 +2506,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
     All changes listed after this point were applied to this package following the monorepo conversion.
 
-[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@68.0.0...HEAD
+[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@68.0.1...HEAD
+[68.0.1]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@68.0.0...@metamask/transaction-controller@68.0.1
 [68.0.0]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@67.1.0...@metamask/transaction-controller@68.0.0
 [67.1.0]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@67.0.0...@metamask/transaction-controller@67.1.0
 [67.0.0]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@66.0.1...@metamask/transaction-controller@67.0.0

package/dist/TransactionController.cjs

@@ -425,6 +425,7 @@ class TransactionController extends base_controller_1.BaseController {
             isGasFeeTokenIgnoredIfBalance,
             isGasFeeIncluded,
             isGasFeeSponsored,
+            ...(isGasFeeSponsored ? { isExternalSign: true } : {}),
             // To avoid the property to be set as undefined.
             ...(excludeNativeTokenForFee === undefined
                 ? {}
@@ -2197,7 +2198,11 @@ async function _TransactionController_approveTransaction(transactionId, traceCon
         skipResimulateCheck: Boolean(blockTime),
     }, (txMeta) => {
         txMeta.gasFeeTokens = gasFeeTokens;
-        txMeta.isGasFeeSponsored = isGasFeeSponsored;
+        txMeta.isGasFeeSponsored =
+            txMeta.isGasFeeSponsored ?? isGasFeeSponsored;
+        if (txMeta.isGasFeeSponsored) {
+            txMeta.isExternalSign = true;
+        }
         txMeta.gasUsed = gasUsed;
         if (!__classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_isBalanceChangesSkipped).call(this, txMeta)) {
             txMeta.simulationData = simulationData;