@metamask-previews/transaction-controller 52.1.0-preview-35da3ac → 52.1.0-preview-7ecf950

package/dist/TransactionController.mjs

@@ -9,7 +9,7 @@ var __classPrivateFieldSet = (this && this.__classPrivateFieldSet) || function (
     if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot write private member to an object whose class did not declare it");
     return (kind === "a" ? f.call(receiver, value) : f ? f.value = value : state.set(receiver, value)), value;
 };
-var _TransactionController_instances, _TransactionController_internalEvents, _TransactionController_methodDataHelper, _TransactionController_incomingTransactionHelper, _TransactionController_incomingTransactionOptions, _TransactionController_pendingTransactionOptions, _TransactionController_publishBatchHook, _TransactionController_publicKeyEIP7702, _TransactionController_trace, _TransactionController_transactionHistoryLimit, _TransactionController_isFirstTimeInteractionEnabled, _TransactionController_isSimulationEnabled, _TransactionController_testGasFeeFlows, _TransactionController_multichainTrackingHelper, _TransactionController_retryTransaction, _TransactionController_rejectTransaction, _TransactionController_getChainId, _TransactionController_getNetworkClientId, _TransactionController_getEthQuery, _TransactionController_getProvider, _TransactionController_createNonceTracker, _TransactionController_createPendingTransactionTracker, _TransactionController_checkForPendingTransactionAndStartPolling, _TransactionController_stopAllTracking, _TransactionController_addIncomingTransactionHelperListeners, _TransactionController_removePendingTransactionTrackerListeners, _TransactionController_addPendingTransactionTrackerListeners, _TransactionController_getNonceTrackerPendingTransactions, _TransactionController_getGasFeeFlows, _TransactionController_getLayer1GasFeeFlows, _TransactionController_updateTransactionInternal, _TransactionController_updateFirstTimeInteraction, _TransactionController_updateSimulationData, _TransactionController_onGasFeePollerTransactionUpdate, _TransactionController_getSelectedAccount, _TransactionController_getInternalAccounts, _TransactionController_updateSubmitHistory, _TransactionController_updateGasEstimate, _TransactionController_deleteTransaction, _TransactionController_isRejectError, _TransactionController_rejectTransactionAndThrow;
+var _TransactionController_instances, _TransactionController_internalEvents, _TransactionController_methodDataHelper, _TransactionController_incomingTransactionHelper, _TransactionController_incomingTransactionOptions, _TransactionController_pendingTransactionOptions, _TransactionController_publicKeyEIP7702, _TransactionController_trace, _TransactionController_transactionHistoryLimit, _TransactionController_isFirstTimeInteractionEnabled, _TransactionController_isSimulationEnabled, _TransactionController_testGasFeeFlows, _TransactionController_multichainTrackingHelper, _TransactionController_retryTransaction, _TransactionController_rejectTransaction, _TransactionController_getChainId, _TransactionController_getNetworkClientId, _TransactionController_getEthQuery, _TransactionController_getProvider, _TransactionController_createNonceTracker, _TransactionController_createPendingTransactionTracker, _TransactionController_checkForPendingTransactionAndStartPolling, _TransactionController_stopAllTracking, _TransactionController_addIncomingTransactionHelperListeners, _TransactionController_removePendingTransactionTrackerListeners, _TransactionController_addPendingTransactionTrackerListeners, _TransactionController_getNonceTrackerPendingTransactions, _TransactionController_getGasFeeFlows, _TransactionController_getLayer1GasFeeFlows, _TransactionController_updateTransactionInternal, _TransactionController_updateFirstTimeInteraction, _TransactionController_updateSimulationData, _TransactionController_onGasFeePollerTransactionUpdate, _TransactionController_getSelectedAccount, _TransactionController_getInternalAccounts, _TransactionController_updateSubmitHistory, _TransactionController_updateGasEstimate, _TransactionController_deleteTransaction, _TransactionController_isRejectError, _TransactionController_rejectTransactionAndThrow;
 function $importDefault(module) {
     if (module?.__esModule) {
         return module.default;
@@ -24,6 +24,7 @@ import { NetworkClientType } from "@metamask/network-controller";
 import { NonceTracker } from "@metamask/nonce-tracker";
 import { errorCodes, rpcErrors, providerErrors } from "@metamask/rpc-errors";
 import { add0x, hexToNumber } from "@metamask/utils";
+import { Mutex } from "async-mutex";
 // This package purposefully relies on Node's EventEmitter module.
 // eslint-disable-next-line import-x/no-nodejs-modules
 import { EventEmitter } from "events";
@@ -43,7 +44,6 @@ import { MethodDataHelper } from "./helpers/MethodDataHelper.mjs";
 import { MultichainTrackingHelper } from "./helpers/MultichainTrackingHelper.mjs";
 import { PendingTransactionTracker } from "./helpers/PendingTransactionTracker.mjs";
 import { ResimulateHelper, hasSimulationDataChanged, shouldResimulate } from "./helpers/ResimulateHelper.mjs";
-import { ExtraTransactionsPublishHook } from "./hooks/ExtraTransactionsPublishHook.mjs";
 import { projectLogger as log } from "./logger.mjs";
 import { TransactionEnvelopeType, TransactionType, TransactionStatus, SimulationErrorCode } from "./types.mjs";
 import { addTransactionBatch, isAtomicBatchSupported } from "./utils/batch.mjs";
@@ -172,10 +172,10 @@ export class TransactionController extends BaseController {
         _TransactionController_internalEvents.set(this, new EventEmitter());
         this.approvingTransactionIds = new Set();
         _TransactionController_methodDataHelper.set(this, void 0);
+        this.mutex = new Mutex();
         _TransactionController_incomingTransactionHelper.set(this, void 0);
         _TransactionController_incomingTransactionOptions.set(this, void 0);
         _TransactionController_pendingTransactionOptions.set(this, void 0);
-        _TransactionController_publishBatchHook.set(this, void 0);
         _TransactionController_publicKeyEIP7702.set(this, void 0);
         this.signAbortCallbacks = new Map();
         _TransactionController_trace.set(this, void 0);
@@ -208,7 +208,6 @@ export class TransactionController extends BaseController {
         this.securityProviderRequest = securityProviderRequest;
         __classPrivateFieldSet(this, _TransactionController_incomingTransactionOptions, incomingTransactions, "f");
         __classPrivateFieldSet(this, _TransactionController_pendingTransactionOptions, pendingTransactions, "f");
-        __classPrivateFieldSet(this, _TransactionController_publishBatchHook, hooks?.publishBatch, "f");
         __classPrivateFieldSet(this, _TransactionController_publicKeyEIP7702, publicKeyEIP7702, "f");
         __classPrivateFieldSet(this, _TransactionController_transactionHistoryLimit, transactionHistoryLimit, "f");
         this.sign = sign;
@@ -323,12 +322,9 @@ export class TransactionController extends BaseController {
             getChainId: __classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_getChainId).bind(this),
             getEthQuery: (networkClientId) => __classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_getEthQuery).call(this, { networkClientId }),
             getInternalAccounts: __classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_getInternalAccounts).bind(this),
-            getTransaction: (transactionId) => this.getTransactionOrThrow(transactionId),
             messenger: this.messagingSystem,
-            publishBatchHook: __classPrivateFieldGet(this, _TransactionController_publishBatchHook, "f"),
             publicKeyEIP7702: __classPrivateFieldGet(this, _TransactionController_publicKeyEIP7702, "f"),
             request,
-            updateTransaction: __classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_updateTransactionInternal).bind(this),
         });
     }
     /**
@@ -355,11 +351,9 @@ export class TransactionController extends BaseController {
      * @param options.actionId - Unique ID to prevent duplicate requests.
      * @param options.batchId - A custom ID for the batch this transaction belongs to.
      * @param options.deviceConfirmedOn - An enum to indicate what device confirmed the transaction.
-     * @param options.disableGasBuffer - Whether to disable the gas estimation buffer.
      * @param options.method - RPC method that requested the transaction.
      * @param options.nestedTransactions - Params for any nested transactions encoded in the data.
      * @param options.origin - The origin of the transaction request, such as a dApp hostname.
-     * @param options.publishHook - Custom logic to publish the transaction.
      * @param options.requireApproval - Whether the transaction requires approval by the user, defaults to true unless explicitly disabled.
      * @param options.securityAlertResponse - Response from security validator.
      * @param options.sendFlowHistory - The sendFlowHistory entries to add.
@@ -373,7 +367,7 @@ export class TransactionController extends BaseController {
      */
     async addTransaction(txParams, options) {
         log('Adding transaction', txParams, options);
-        const { actionId, batchId, deviceConfirmedOn, disableGasBuffer, method, nestedTransactions, networkClientId, origin, publishHook, requireApproval, securityAlertResponse, sendFlowHistory, swaps = {}, traceContext, type, } = options;
+        const { actionId, batchId, deviceConfirmedOn, method, nestedTransactions, networkClientId, origin, requireApproval, securityAlertResponse, sendFlowHistory, swaps = {}, traceContext, type, } = options;
         txParams = normalizeTransactionParams(txParams);
         if (!__classPrivateFieldGet(this, _TransactionController_multichainTrackingHelper, "f").has(networkClientId)) {
             throw new Error(`Network client not found - ${networkClientId}`);
@@ -402,7 +396,7 @@ export class TransactionController extends BaseController {
         validateTxParams(txParams, isEIP1559Compatible);
         const isDuplicateBatchId = batchId?.length &&
             this.state.transactions.some((tx) => tx.batchId?.toLowerCase() === batchId?.toLowerCase());
-        if (isDuplicateBatchId && origin && origin !== ORIGIN_METAMASK) {
+        if (isDuplicateBatchId) {
             throw rpcErrors.invalidInput('Batch ID already exists');
         }
         const dappSuggestedGasFees = this.generateDappSuggestedGasFees(txParams, origin);
@@ -420,7 +414,6 @@ export class TransactionController extends BaseController {
                 dappSuggestedGasFees,
                 delegationAddress,
                 deviceConfirmedOn,
-                disableGasBuffer,
                 id: random(),
                 isFirstTimeInteraction: undefined,
                 nestedTransactions,
@@ -478,10 +471,9 @@ export class TransactionController extends BaseController {
         }
         return {
             result: this.processApproval(addedTransactionMeta, {
-                actionId,
                 isExisting: Boolean(existingTransactionMeta),
-                publishHook,
                 requireApproval,
+                actionId,
                 traceContext,
             }),
             transactionMeta: addedTransactionMeta,
@@ -804,16 +796,14 @@ export class TransactionController extends BaseController {
      * @param txId - The ID of the transaction to update.
      * @param params - The editable parameters to update.
      * @param params.data - Data to pass with the transaction.
-     * @param params.from - Address to send the transaction from.
      * @param params.gas - Maximum number of units of gas to use for the transaction.
      * @param params.gasPrice - Price per gas for legacy transactions.
-     * @param params.maxFeePerGas - Maximum amount per gas to pay for the transaction, including the priority fee.
-     * @param params.maxPriorityFeePerGas - Maximum amount per gas to give to validator as incentive.
+     * @param params.from - Address to send the transaction from.
      * @param params.to - Address to send the transaction to.
      * @param params.value - Value associated with the transaction.
      * @returns The updated transaction metadata.
      */
-    async updateEditableParams(txId, { data, from, gas, gasPrice, maxFeePerGas, maxPriorityFeePerGas, to, value, }) {
+    async updateEditableParams(txId, { data, gas, gasPrice, from, to, value, }) {
         const transactionMeta = this.getTransaction(txId);
         if (!transactionMeta) {
             throw new Error(`Cannot update editable params as no transaction metadata found`);
@@ -827,8 +817,6 @@ export class TransactionController extends BaseController {
                 value,
                 gas,
                 gasPrice,
-                maxFeePerGas,
-                maxPriorityFeePerGas,
             },
         };
         editableParams.txParams = pickBy(editableParams.txParams);
@@ -1181,38 +1169,6 @@ export class TransactionController extends BaseController {
         });
         return updatedTransactionMeta.txParams.data;
     }
-    /**
-     * Update the batch transactions associated with a transaction.
-     * These transactions will be submitted with the main transaction as a batch.
-     *
-     * @param request - The request object.
-     * @param request.transactionId - The ID of the transaction to update.
-     * @param request.batchTransactions - The new batch transactions.
-     */
-    updateBatchTransactions({ transactionId, batchTransactions, }) {
-        log('Updating batch transactions', { transactionId, batchTransactions });
-        __classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_updateTransactionInternal).call(this, {
-            transactionId,
-            note: 'TransactionController#updateBatchTransactions - Batch transactions updated',
-        }, (transactionMeta) => {
-            transactionMeta.batchTransactions = batchTransactions;
-        });
-    }
-    /**
-     * Update the selected gas fee token for a transaction.
-     *
-     * @param transactionId - The ID of the transaction to update.
-     * @param contractAddress - The contract address of the selected gas fee token.
-     */
-    updateSelectedGasFeeToken(transactionId, contractAddress) {
-        __classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_updateTransactionInternal).call(this, { transactionId }, (transactionMeta) => {
-            const hasMatchingGasFeeToken = transactionMeta.gasFeeTokens?.some((token) => token.tokenAddress.toLowerCase() === contractAddress.toLowerCase());
-            if (!hasMatchingGasFeeToken) {
-                throw new Error(`No matching gas fee token found with address - ${contractAddress}`);
-            }
-            transactionMeta.selectedGasFeeToken = contractAddress;
-        });
-    }
     addMetadata(transactionMeta) {
         validateTxParams(transactionMeta.txParams);
         this.update((state) => {
@@ -1255,7 +1211,7 @@ export class TransactionController extends BaseController {
             this.failTransaction(transactionMeta, new Error('Transaction incomplete at startup'));
         }
     }
-    async processApproval(transactionMeta, { actionId, isExisting = false, publishHook, requireApproval, shouldShowRequest = true, traceContext, }) {
+    async processApproval(transactionMeta, { isExisting = false, requireApproval, shouldShowRequest = true, actionId, traceContext, }) {
         const transactionId = transactionMeta.id;
         let resultCallbacks;
         const { meta, isCompleted } = this.isTransactionCompleted(transactionId);
@@ -1282,7 +1238,7 @@ export class TransactionController extends BaseController {
                 }
                 const { isCompleted: isTxCompleted } = this.isTransactionCompleted(transactionId);
                 if (!isTxCompleted) {
-                    const approvalResult = await this.approveTransaction(transactionId, traceContext, publishHook);
+                    const approvalResult = await this.approveTransaction(transactionId, traceContext);
                     if (approvalResult === ApprovalState.SkippedViaBeforePublishHook &&
                         resultCallbacks) {
                         resultCallbacks.success();
@@ -1330,14 +1286,12 @@ export class TransactionController extends BaseController {
      *
      * @param transactionId - The ID of the transaction to approve.
      * @param traceContext - The parent context for any new traces.
-     * @param publishHookOverride - Custom logic to publish the transaction.
      * @returns The state of the approval.
      */
-    async approveTransaction(transactionId, traceContext, publishHookOverride) {
-        let clearApprovingTransactionId;
-        let clearNonceLock;
+    async approveTransaction(transactionId, traceContext) {
+        const cleanupTasks = new Array();
+        cleanupTasks.push(await this.mutex.acquire());
         let transactionMeta = this.getTransactionOrThrow(transactionId);
-        log('Approving transaction', transactionMeta);
         try {
             if (!this.sign) {
                 this.failTransaction(transactionMeta, new Error('No sign method defined.'));
@@ -1352,9 +1306,10 @@ export class TransactionController extends BaseController {
                 return ApprovalState.NotApproved;
             }
             this.approvingTransactionIds.add(transactionId);
-            clearApprovingTransactionId = () => this.approvingTransactionIds.delete(transactionId);
+            cleanupTasks.push(() => this.approvingTransactionIds.delete(transactionId));
             const [nonce, releaseNonce] = await getNextNonce(transactionMeta, (address) => __classPrivateFieldGet(this, _TransactionController_multichainTrackingHelper, "f").getNonceLock(address, transactionMeta.networkClientId));
-            clearNonceLock = releaseNonce;
+            // must set transaction to submitted/failed before releasing lock
+            releaseNonce && cleanupTasks.push(releaseNonce);
             transactionMeta = __classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_updateTransactionInternal).call(this, {
                 transactionId,
                 note: 'TransactionController#approveTransaction - Transaction approved',
@@ -1391,19 +1346,8 @@ export class TransactionController extends BaseController {
             }
             log('Publishing transaction', transactionMeta.txParams);
             let hash;
-            clearNonceLock?.();
-            clearNonceLock = undefined;
-            if (transactionMeta.batchTransactions?.length) {
-                log('Found batch transactions', transactionMeta.batchTransactions);
-                const extraTransactionsPublishHook = new ExtraTransactionsPublishHook({
-                    addTransactionBatch: this.addTransactionBatch.bind(this),
-                    transactions: transactionMeta.batchTransactions,
-                });
-                publishHookOverride = extraTransactionsPublishHook.getHook();
-            }
             await __classPrivateFieldGet(this, _TransactionController_trace, "f").call(this, { name: 'Publish', parentContext: traceContext }, async () => {
-                const publishHook = publishHookOverride ?? this.publish;
-                ({ transactionHash: hash } = await publishHook(transactionMeta, rawTx));
+                ({ transactionHash: hash } = await this.publish(transactionMeta, rawTx));
                 if (hash === undefined) {
                     hash = await this.publishTransaction(ethQuery, {
                         ...transactionMeta,
@@ -1439,8 +1383,7 @@ export class TransactionController extends BaseController {
             return ApprovalState.NotApproved;
         }
         finally {
-            clearApprovingTransactionId?.();
-            clearNonceLock?.();
+            cleanupTasks.forEach((task) => task());
         }
     }
     async publishTransaction(ethQuery, transactionMeta, { skipSubmitHistory } = {}) {
@@ -1767,8 +1710,8 @@ export class TransactionController extends BaseController {
             transactionMeta,
         });
     }
-    getNonceTrackerTransactions(statuses, address, chainId) {
-        return getAndFormatTransactionsForNonceTracker(chainId, address, statuses, this.state.transactions);
+    getNonceTrackerTransactions(status, address, chainId) {
+        return getAndFormatTransactionsForNonceTracker(chainId, address, status, this.state.transactions);
     }
     onConfirmedTransaction(transactionMeta) {
         log('Processing confirmed transaction', transactionMeta.id);
@@ -1828,7 +1771,7 @@ export class TransactionController extends BaseController {
             error?.data?.message?.includes('nonce too low'));
     }
 }
-_TransactionController_internalEvents = new WeakMap(), _TransactionController_methodDataHelper = new WeakMap(), _TransactionController_incomingTransactionHelper = new WeakMap(), _TransactionController_incomingTransactionOptions = new WeakMap(), _TransactionController_pendingTransactionOptions = new WeakMap(), _TransactionController_publishBatchHook = new WeakMap(), _TransactionController_publicKeyEIP7702 = new WeakMap(), _TransactionController_trace = new WeakMap(), _TransactionController_transactionHistoryLimit = new WeakMap(), _TransactionController_isFirstTimeInteractionEnabled = new WeakMap(), _TransactionController_isSimulationEnabled = new WeakMap(), _TransactionController_testGasFeeFlows = new WeakMap(), _TransactionController_multichainTrackingHelper = new WeakMap(), _TransactionController_checkForPendingTransactionAndStartPolling = new WeakMap(), _TransactionController_instances = new WeakSet(), _TransactionController_retryTransaction = async function _TransactionController_retryTransaction({ actionId, afterSubmit, estimatedBaseFee, gasValues, label, prepareTransactionParams, rate, transactionId, transactionType, }) {
+_TransactionController_internalEvents = new WeakMap(), _TransactionController_methodDataHelper = new WeakMap(), _TransactionController_incomingTransactionHelper = new WeakMap(), _TransactionController_incomingTransactionOptions = new WeakMap(), _TransactionController_pendingTransactionOptions = new WeakMap(), _TransactionController_publicKeyEIP7702 = new WeakMap(), _TransactionController_trace = new WeakMap(), _TransactionController_transactionHistoryLimit = new WeakMap(), _TransactionController_isFirstTimeInteractionEnabled = new WeakMap(), _TransactionController_isSimulationEnabled = new WeakMap(), _TransactionController_testGasFeeFlows = new WeakMap(), _TransactionController_multichainTrackingHelper = new WeakMap(), _TransactionController_checkForPendingTransactionAndStartPolling = new WeakMap(), _TransactionController_instances = new WeakSet(), _TransactionController_retryTransaction = async function _TransactionController_retryTransaction({ actionId, afterSubmit, estimatedBaseFee, gasValues, label, prepareTransactionParams, rate, transactionId, transactionType, }) {
     // If transaction is found for same action id, do not create a new transaction.
     if (this.getTransactionWithActionId(actionId)) {
         return;
@@ -1936,7 +1879,7 @@ _TransactionController_internalEvents = new WeakMap(), _TransactionController_me
         // TODO: Fix types
         blockTracker,
         getPendingTransactions: __classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_getNonceTrackerPendingTransactions).bind(this, chainId),
-        getConfirmedTransactions: this.getNonceTrackerTransactions.bind(this, [TransactionStatus.confirmed], chainId),
+        getConfirmedTransactions: this.getNonceTrackerTransactions.bind(this, TransactionStatus.confirmed, chainId),
     });
 }, _TransactionController_createPendingTransactionTracker = function _TransactionController_createPendingTransactionTracker({ provider, blockTracker, chainId, networkClientId, }) {
     const ethQuery = new EthQuery(provider);
@@ -1975,11 +1918,7 @@ _TransactionController_internalEvents = new WeakMap(), _TransactionController_me
     pendingTransactionTracker.hub.on('transaction-failed', this.failTransaction.bind(this));
     pendingTransactionTracker.hub.on('transaction-updated', this.updateTransaction.bind(this));
 }, _TransactionController_getNonceTrackerPendingTransactions = function _TransactionController_getNonceTrackerPendingTransactions(chainId, address) {
-    const standardPendingTransactions = this.getNonceTrackerTransactions([
-        TransactionStatus.approved,
-        TransactionStatus.signed,
-        TransactionStatus.submitted,
-    ], address, chainId);
+    const standardPendingTransactions = this.getNonceTrackerTransactions(TransactionStatus.submitted, address, chainId);
     const externalPendingTransactions = this.getExternalPendingTransactions(address, chainId);
     return [...standardPendingTransactions, ...externalPendingTransactions];
 }, _TransactionController_getGasFeeFlows = function _TransactionController_getGasFeeFlows() {
@@ -2074,9 +2013,8 @@ _TransactionController_internalEvents = new WeakMap(), _TransactionController_me
         },
         tokenBalanceChanges: [],
     };
-    let gasFeeTokens = [];
     if (__classPrivateFieldGet(this, _TransactionController_isSimulationEnabled, "f").call(this)) {
-        const result = await __classPrivateFieldGet(this, _TransactionController_trace, "f").call(this, { name: 'Simulate', parentContext: traceContext }, () => getSimulationData({
+        simulationData = await __classPrivateFieldGet(this, _TransactionController_trace, "f").call(this, { name: 'Simulate', parentContext: traceContext }, () => getSimulationData({
             chainId,
             from: from,
             to: to,
@@ -2085,8 +2023,6 @@ _TransactionController_internalEvents = new WeakMap(), _TransactionController_me
         }, {
             blockTime,
         }));
-        gasFeeTokens = result?.gasFeeTokens;
-        simulationData = result?.simulationData;
         if (blockTime &&
             prevSimulationData &&
             hasSimulationDataChanged(prevSimulationData, simulationData)) {
@@ -2107,7 +2043,6 @@ _TransactionController_internalEvents = new WeakMap(), _TransactionController_me
         note: 'TransactionController#updateSimulationData - Update simulation data',
         skipResimulateCheck: Boolean(blockTime),
     }, (txMeta) => {
-        txMeta.gasFeeTokens = gasFeeTokens;
         txMeta.simulationData = simulationData;
     });
     log('Updated simulation data', transactionId, simulationData);