@metamask-previews/transaction-controller 41.0.0-preview-57e6ab5d → 41.0.0-preview-e58ce4ab

package/CHANGELOG.md

@@ -7,15 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-### Fixed
-
-- Make implicit peer dependencies explicit ([#4974](https://github.com/MetaMask/core/pull/4974))
-  - Add the following packages as peer dependencies of this package to satisfy peer dependency requirements from other dependencies:
-    - `@babel/runtime` `^7.0.0` (required by `@metamask/ethjs-provider-http`)
-    - `@metamask/eth-block-tracker` `>=9` (required by `@metamask/nonce-tracker`)
-  - These dependencies really should be present in projects that consume this package (e.g. MetaMask clients), and this change ensures that they now are.
-  - Furthermore, we are assuming that clients already use these dependencies, since otherwise it would be impossible to consume this package in its entirety or even create a working build. Hence, the addition of these peer dependencies is really a formality and should not be breaking.
-
 ## [41.0.0]
 
 ### Added

package/README.md

@@ -10,10 +10,6 @@ or
 
 `npm install @metamask/transaction-controller`
 
-## Compatibility
-
-This package relies implicitly upon the `EventEmitter` module. This module is available natively in Node.js, but when using this package for the browser, make sure to use a polyfill such as `events`.
-
 ## Contributing
 
 This package is part of a monorepo. Instructions for contributing can be found in the [monorepo README](https://github.com/MetaMask/core#readme).

package/dist/TransactionController.cjs

@@ -1,4 +1,6 @@
 "use strict";
+/* istanbul ignore file */
+// FIXME  - remove above ignore
 var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (receiver, state, kind, f) {
     if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter");
     if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
@@ -27,8 +29,6 @@ const nonce_tracker_1 = require("@metamask/nonce-tracker");
 const rpc_errors_1 = require("@metamask/rpc-errors");
 const utils_1 = require("@metamask/utils");
 const async_mutex_1 = require("async-mutex");
-// This package purposefully relies on Node's EventEmitter module.
-// eslint-disable-next-line import/no-nodejs-modules
 const events_1 = require("events");
 const lodash_1 = require("lodash");
 const uuid_1 = require("uuid");
@@ -599,6 +599,7 @@ class TransactionController extends base_controller_1.BaseController {
             this.onTransactionStatusChange(updatedTransactionMeta);
             // Intentional given potential duration of process.
             this.updatePostBalance(updatedTransactionMeta).catch((error) => {
+                /* istanbul ignore next */
                 (0, logger_1.projectLogger)('Error while updating post balance', error);
                 throw error;
             });
@@ -835,9 +836,6 @@ class TransactionController extends base_controller_1.BaseController {
         if (!transactionMeta) {
             throw new Error(`Cannot update custodial transaction as no transaction metadata found`);
         }
-        if (!transactionMeta.custodyId) {
-            throw new Error('Transaction must be a custodian transaction');
-        }
         if (status &&
             ![
                 types_1.TransactionStatus.submitted,
@@ -1197,7 +1195,7 @@ class TransactionController extends base_controller_1.BaseController {
             });
             this.onTransactionStatusChange(transactionMeta);
             const rawTx = await __classPrivateFieldGet(this, _TransactionController_trace, "f").call(this, { name: 'Sign', parentContext: traceContext }, () => this.signTransaction(transactionMeta, transactionMeta.txParams));
-            if (!this.beforePublish(transactionMeta)) {
+            if (!this.beforePublish(transactionMeta, rawTx)) {
                 (0, logger_1.projectLogger)('Skipping publishing transaction based on hook');
                 this.messagingSystem.publish(`${controllerName}:transactionPublishingSkipped`, transactionMeta);
                 return ApprovalState.SkippedViaBeforePublishHook;
@@ -1817,7 +1815,6 @@ _TransactionController_internalEvents = new WeakMap(), _TransactionController_me
         }),
         hooks: {
             beforeCheckPendingTransaction: this.beforeCheckPendingTransaction.bind(this),
-            beforePublish: this.beforePublish.bind(this),
         },
     });
     __classPrivateFieldGet(this, _TransactionController_instances, "m", _TransactionController_addPendingTransactionTrackerListeners).call(this, pendingTransactionTracker);