@metamask-previews/social-controllers 3.6.0-preview-44b7ded21 → 3.6.0-preview-cbae429b5

package/dist/SocialService.js

@@ -33,13 +33,10 @@ const PositionStruct = structType({
     chain: string(),
     positionAmount: number(),
     isOpen: optional(boolean()),
-    // Incomplete Clicker metrics serialize these as `null` (`undefined + n`
-    // becomes `NaN`, then JSON `null`). Rejecting the field used to fail the
-    // entire feed page, so they are nullable here.
-    boughtUsd: nullable(number()),
-    soldUsd: nullable(number()),
-    realizedPnl: nullable(number()),
-    costBasis: nullable(number()),
+    boughtUsd: number(),
+    soldUsd: number(),
+    realizedPnl: number(),
+    costBasis: number(),
     trades: array(TradeStruct),
     lastTradeAt: number(),
     tokenImageUrl: optional(nullable(string())),
@@ -185,34 +182,6 @@ const FeedResponseStruct = structType({
     items: array(FeedItemStruct),
     pagination: FeedPaginationStruct,
 });
-/**
- * One malformed feed item must not blank the page. When the envelope is
- * well-shaped, keep items that match {@link FeedItemStruct} and drop the rest.
- * Still throw when `items` or `pagination` themselves are unusable.
- *
- * @param feedData - Parsed JSON body from a feed endpoint.
- * @param invalidMessage - Error message to throw when the envelope is unusable.
- * @returns The validated feed response, possibly with invalid items dropped.
- */
-const parseFeedResponse = (feedData, invalidMessage) => {
-    if (is(feedData, FeedResponseStruct)) {
-        return feedData;
-    }
-    if (typeof feedData !== 'object' ||
-        feedData === null ||
-        !('items' in feedData) ||
-        !('pagination' in feedData)) {
-        throw new Error(invalidMessage);
-    }
-    const { items, pagination } = feedData;
-    if (!Array.isArray(items) || !is(pagination, FeedPaginationStruct)) {
-        throw new Error(invalidMessage);
-    }
-    return {
-        items: items.filter((item) => is(item, FeedItemStruct)),
-        pagination,
-    };
-};
 const FollowersResponseStruct = structType({
     followers: array(ProfileSummaryStruct),
     count: number(),
@@ -258,9 +227,7 @@ const MESSENGER_EXPOSED_METHODS = [
     'fetchOpenPositions',
     'fetchClosedPositions',
     'fetchFollowers',
-    'fetchTraderFollowing',
     'fetchFollowing',
-    'fetchMyFollowing',
     'fetchMyFollowers',
     'fetchPositionById',
     'fetchFeed',
@@ -348,7 +315,7 @@ export class SocialService extends BaseDataService {
                     headers: authHeaders,
                 });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.FETCH_LEADERBOARD_FAILED);
-                const leaderboardData = (await response.json());
+                const leaderboardData = await response.json();
                 if (!is(leaderboardData, LeaderboardResponseStruct)) {
                     throw new Error(SocialServiceErrorMessage.FETCH_LEADERBOARD_INVALID_RESPONSE);
                 }
@@ -375,7 +342,7 @@ export class SocialService extends BaseDataService {
                 const authHeaders = await this.#getAuthHeaders();
                 const response = await fetch(url, { headers: authHeaders });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.FETCH_TRADER_PROFILE_FAILED);
-                const traderProfileData = (await response.json());
+                const traderProfileData = await response.json();
                 if (!is(traderProfileData, TraderProfileResponseStruct)) {
                     throw new Error(SocialServiceErrorMessage.FETCH_TRADER_PROFILE_INVALID_RESPONSE);
                 }
@@ -419,31 +386,22 @@ export class SocialService extends BaseDataService {
     /**
      * Fetches a trader's MetaMask followers.
      *
-     * Calls `GET ${baseUrl}/traders/${addressOrId}/followers`. Pass
-     * `mutuals: true` to append `?mutuals=true` (profiles that follow both this
-     * trader and the authenticated user; `count` is the mutual total). Requires a
-     * bearer token; the trader is identified by `addressOrId`, not the JWT
-     * subject (see {@link fetchMyFollowers} for the current user's inbound list).
+     * Calls `GET ${baseUrl}/traders/${addressOrId}/followers`.
      *
      * @param options - Options bag.
      * @param options.addressOrId - Wallet address or Clicker profile ID.
-     * @param options.mutuals - When true, request mutual followers only.
      * @returns The followers response.
      */
     async fetchFollowers(options) {
-        const { addressOrId, mutuals } = options;
-        const mutualsOnly = mutuals === true;
+        const { addressOrId } = options;
         const followersResponse = await this.fetchQuery({
-            queryKey: [`${this.name}:fetchFollowers`, addressOrId, mutualsOnly],
+            queryKey: [`${this.name}:fetchFollowers`, addressOrId],
             queryFn: async () => {
-                const url = new URL(`${this.#v1Url}/traders/${encodeURIComponent(addressOrId)}/followers`);
-                if (mutualsOnly) {
-                    url.searchParams.append('mutuals', 'true');
-                }
+                const url = `${this.#v1Url}/traders/${encodeURIComponent(addressOrId)}/followers`;
                 const authHeaders = await this.#getAuthHeaders();
-                const response = await fetch(url.toString(), { headers: authHeaders });
+                const response = await fetch(url, { headers: authHeaders });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.FETCH_FOLLOWERS_FAILED);
-                const followersData = (await response.json());
+                const followersData = await response.json();
                 if (!is(followersData, FollowersResponseStruct)) {
                     throw new Error(SocialServiceErrorMessage.FETCH_FOLLOWERS_INVALID_RESPONSE);
                 }
@@ -452,35 +410,6 @@ export class SocialService extends BaseDataService {
         });
         return followersResponse;
     }
-    /**
-     * Fetches the list of traders a profile follows.
-     *
-     * Calls `GET ${baseUrl}/traders/${addressOrId}/following`. Requires a bearer
-     * token; the trader is identified by `addressOrId`, not the JWT subject (see
-     * {@link fetchFollowing} for the current user's outbound list).
-     *
-     * @param options - Options bag.
-     * @param options.addressOrId - Wallet address or Clicker profile ID.
-     * @returns The following response.
-     */
-    async fetchTraderFollowing(options) {
-        const { addressOrId } = options;
-        const followingResponse = await this.fetchQuery({
-            queryKey: [`${this.name}:fetchTraderFollowing`, addressOrId],
-            queryFn: async () => {
-                const url = `${this.#v1Url}/traders/${encodeURIComponent(addressOrId)}/following`;
-                const authHeaders = await this.#getAuthHeaders();
-                const response = await fetch(url, { headers: authHeaders });
-                _a.#throwIfNotOk(response, SocialServiceErrorMessage.FETCH_TRADER_FOLLOWING_FAILED);
-                const followingData = (await response.json());
-                if (!is(followingData, FollowingResponseStruct)) {
-                    throw new Error(SocialServiceErrorMessage.FETCH_TRADER_FOLLOWING_INVALID_RESPONSE);
-                }
-                return followingData;
-            },
-        });
-        return followingResponse;
-    }
     /**
      * Fetches a single position by its unique ID.
      *
@@ -499,7 +428,7 @@ export class SocialService extends BaseDataService {
                 const authHeaders = await this.#getAuthHeaders();
                 const response = await fetch(url, { headers: authHeaders });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.FETCH_POSITION_BY_ID_FAILED);
-                const positionData = (await response.json());
+                const positionData = await response.json();
                 if (!is(positionData, PositionStruct)) {
                     throw new Error(SocialServiceErrorMessage.FETCH_POSITION_BY_ID_INVALID_RESPONSE);
                 }
@@ -556,8 +485,11 @@ export class SocialService extends BaseDataService {
                     headers: authHeaders,
                 });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.FETCH_FEED_FAILED);
-                const feedData = (await response.json());
-                return parseFeedResponse(feedData, SocialServiceErrorMessage.FETCH_FEED_INVALID_RESPONSE);
+                const feedData = await response.json();
+                if (!is(feedData, FeedResponseStruct)) {
+                    throw new Error(SocialServiceErrorMessage.FETCH_FEED_INVALID_RESPONSE);
+                }
+                return feedData;
             },
         });
         return feedResponse;
@@ -610,8 +542,11 @@ export class SocialService extends BaseDataService {
                     headers: authHeaders,
                 });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.FETCH_TRADER_FEED_FAILED);
-                const feedData = (await response.json());
-                return parseFeedResponse(feedData, SocialServiceErrorMessage.FETCH_TRADER_FEED_INVALID_RESPONSE);
+                const feedData = await response.json();
+                if (!is(feedData, FeedResponseStruct)) {
+                    throw new Error(SocialServiceErrorMessage.FETCH_TRADER_FEED_INVALID_RESPONSE);
+                }
+                return feedData;
             },
         });
         return traderFeedResponse;
@@ -666,7 +601,10 @@ export class SocialService extends BaseDataService {
                 });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.FETCH_TOKEN_FEED_FAILED);
                 const feedData = (await response.json());
-                return parseFeedResponse(feedData, SocialServiceErrorMessage.FETCH_TOKEN_FEED_INVALID_RESPONSE);
+                if (!is(feedData, FeedResponseStruct)) {
+                    throw new Error(SocialServiceErrorMessage.FETCH_TOKEN_FEED_INVALID_RESPONSE);
+                }
+                return feedData;
             },
         });
         return tokenFeedResponse;
@@ -696,7 +634,7 @@ export class SocialService extends BaseDataService {
                     body: JSON.stringify({ emotion }),
                 });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.REACT_TO_COMMENT_FAILED);
-                const metrics = (await response.json());
+                const metrics = await response.json();
                 if (!is(metrics, CommentEngagementStruct)) {
                     throw new Error(SocialServiceErrorMessage.REACT_TO_COMMENT_INVALID_RESPONSE);
                 }
@@ -727,7 +665,7 @@ export class SocialService extends BaseDataService {
                     headers: authHeaders,
                 });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.REMOVE_COMMENT_REACTION_FAILED);
-                const metrics = (await response.json());
+                const metrics = await response.json();
                 if (!is(metrics, CommentEngagementStruct)) {
                     throw new Error(SocialServiceErrorMessage.REMOVE_COMMENT_REACTION_INVALID_RESPONSE);
                 }
@@ -792,10 +730,6 @@ export class SocialService extends BaseDataService {
      * Calls `GET ${baseUrl}/users/me/following`. The caller is identified
      * server-side from the JWT sub claim carried in the Authorization header.
      *
-     * Prefer {@link fetchMyFollowing} in new code (pairs with
-     * {@link fetchMyFollowers}). This method is unchanged and remains the
-     * `/users/me/following` read.
-     *
      * @returns The following response.
      */
     async fetchFollowing() {
@@ -807,7 +741,7 @@ export class SocialService extends BaseDataService {
                 const authHeaders = await this.#getAuthHeaders();
                 const response = await fetch(url, { headers: authHeaders });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.FETCH_FOLLOWING_FAILED);
-                const followingData = (await response.json());
+                const followingData = await response.json();
                 if (!is(followingData, FollowingResponseStruct)) {
                     throw new Error(SocialServiceErrorMessage.FETCH_FOLLOWING_INVALID_RESPONSE);
                 }
@@ -816,17 +750,6 @@ export class SocialService extends BaseDataService {
         });
         return followingResponse;
     }
-    /**
-     * Fetches the list of traders the current user is following.
-     *
-     * Alias of {@link fetchFollowing}. Calls `GET ${baseUrl}/users/me/following`.
-     * Preferred name in new code so `/users/me` reads are both `fetchMy*`.
-     *
-     * @returns The following response.
-     */
-    async fetchMyFollowing() {
-        return this.fetchFollowing();
-    }
     /**
      * Fetches the list of traders following the current user.
      *
@@ -877,7 +800,7 @@ export class SocialService extends BaseDataService {
                     body: JSON.stringify({ targets }),
                 });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.FOLLOW_FAILED);
-                const followData = (await response.json());
+                const followData = await response.json();
                 if (!is(followData, FollowResponseStruct)) {
                     throw new Error(SocialServiceErrorMessage.FOLLOW_INVALID_RESPONSE);
                 }
@@ -914,7 +837,7 @@ export class SocialService extends BaseDataService {
                     headers: authHeaders,
                 });
                 _a.#throwIfNotOk(response, SocialServiceErrorMessage.UNFOLLOW_FAILED);
-                const unfollowData = (await response.json());
+                const unfollowData = await response.json();
                 if (!is(unfollowData, UnfollowResponseStruct)) {
                     throw new Error(SocialServiceErrorMessage.UNFOLLOW_INVALID_RESPONSE);
                 }
@@ -1139,7 +1062,7 @@ export class SocialService extends BaseDataService {
                     headers: authHeaders,
                 });
                 _a.#throwIfNotOk(response, failedMessage);
-                const positionsData = (await response.json());
+                const positionsData = await response.json();
                 if (!is(positionsData, PositionsResponseStruct)) {
                     throw new Error(invalidMessage);
                 }