@metamask-previews/seedless-onboarding-controller 2.5.1-preview-8a39b4da → 2.5.1-preview-eb8c7b7a

package/CHANGELOG.md

@@ -7,16 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-### Fixed
-
-- Apply controller level lock, mutex, on the `setLocked()` call. ([#6278](https://github.com/MetaMask/core/pull/6278))
-
-
 ### Changed
 
-- Refactor `setUnlocked` method from `createNewVaultWithAuthData` method. ([#6278](https://github.com/MetaMask/core/pull/6278))
 - Bump `@metamask/base-controller` from `^8.0.1` to `^8.1.0` ([#6284](https://github.com/MetaMask/core/pull/6284))
 
+### Fixed
+
+- Set `anonymous` to `false` for sensitive fields in the controller state. ([#6283](https://github.com/MetaMask/core/pull/6283))
+
 ## [2.5.1]
 
 ### Changed

package/dist/SeedlessOnboardingController.cjs

@@ -54,11 +54,11 @@ const seedlessOnboardingMetadata = {
     },
     socialBackupsMetadata: {
         persist: true,
-        anonymous: true,
+        anonymous: false,
     },
     nodeAuthTokens: {
         persist: true,
-        anonymous: true,
+        anonymous: false,
     },
     authConnection: {
         persist: true,
@@ -74,23 +74,23 @@ const seedlessOnboardingMetadata = {
     },
     userId: {
         persist: true,
-        anonymous: true,
+        anonymous: false,
     },
     socialLoginEmail: {
         persist: true,
-        anonymous: true,
+        anonymous: false,
     },
     vaultEncryptionKey: {
         persist: false,
-        anonymous: true,
+        anonymous: false,
     },
     vaultEncryptionSalt: {
         persist: false,
-        anonymous: true,
+        anonymous: false,
     },
     authPubKey: {
         persist: true,
-        anonymous: true,
+        anonymous: false,
     },
     passwordOutdatedCache: {
         persist: true,
@@ -98,30 +98,30 @@ const seedlessOnboardingMetadata = {
     },
     refreshToken: {
         persist: true,
-        anonymous: true,
+        anonymous: false,
     },
     revokeToken: {
         persist: false,
-        anonymous: true,
+        anonymous: false,
     },
     // stays in vault
     accessToken: {
         persist: false,
-        anonymous: true,
+        anonymous: false,
     },
     // stays outside of vault as this token is accessed by the metadata service
     // before the vault is created or unlocked.
     metadataAccessToken: {
         persist: true,
-        anonymous: true,
+        anonymous: false,
     },
     encryptedSeedlessEncryptionKey: {
         persist: true,
-        anonymous: true,
+        anonymous: false,
     },
     encryptedKeyringEncryptionKey: {
         persist: true,
-        anonymous: true,
+        anonymous: false,
     },
 };
 class SeedlessOnboardingController extends base_controller_1.BaseController {
@@ -176,8 +176,8 @@ class SeedlessOnboardingController extends base_controller_1.BaseController {
         __classPrivateFieldSet(this, _SeedlessOnboardingController_revokeRefreshToken, revokeRefreshToken, "f");
         // setup subscriptions to the keyring lock event
         // when the keyring is locked (wallet is locked), the controller will be cleared of its credentials
-        this.messagingSystem.subscribe('KeyringController:lock', async () => {
-            await this.setLocked();
+        this.messagingSystem.subscribe('KeyringController:lock', () => {
+            this.setLocked();
         });
         this.messagingSystem.subscribe('KeyringController:unlock', () => {
             __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_setUnlocked).call(this);
@@ -302,7 +302,6 @@ class SeedlessOnboardingController extends base_controller_1.BaseController {
                     rawToprfPwEncryptionKey: pwEncKey,
                     rawToprfAuthKeyPair: authKeyPair,
                 });
-                __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_setUnlocked).call(this);
             };
             await __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_executeWithTokenRefresh).call(this, performKeyCreationAndBackup, 'createToprfKeyAndBackupSeedPhrase');
         });
@@ -377,7 +376,6 @@ class SeedlessOnboardingController extends base_controller_1.BaseController {
                         rawToprfPwEncryptionKey: pwEncKey,
                         rawToprfAuthKeyPair: authKeyPair,
                     });
-                    __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_setUnlocked).call(this);
                 }
                 return secrets;
             };
@@ -504,16 +502,14 @@ class SeedlessOnboardingController extends base_controller_1.BaseController {
      *
      * When the controller is locked, the user will not be able to perform any operations on the controller/vault.
      */
-    async setLocked() {
-        await __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_withControllerLock).call(this, async () => {
-            this.update((state) => {
-                delete state.vaultEncryptionKey;
-                delete state.vaultEncryptionSalt;
-                delete state.revokeToken;
-                delete state.accessToken;
-            });
-            __classPrivateFieldSet(this, _SeedlessOnboardingController_isUnlocked, false, "f");
+    setLocked() {
+        this.update((state) => {
+            delete state.vaultEncryptionKey;
+            delete state.vaultEncryptionSalt;
+            delete state.revokeToken;
+            delete state.accessToken;
         });
+        __classPrivateFieldSet(this, _SeedlessOnboardingController_isUnlocked, false, "f");
     }
     /**
      * Sync the latest global password to the controller.
@@ -538,7 +534,6 @@ class SeedlessOnboardingController extends base_controller_1.BaseController {
                     rawToprfAuthKeyPair: authKeyPair,
                 });
                 __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_resetPasswordOutdatedCache).call(this);
-                __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_setUnlocked).call(this);
             };
             return await __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_executeWithTokenRefresh).call(this, doSyncPassword, 'syncLatestGlobalPassword');
         });
@@ -1227,6 +1222,7 @@ async function _SeedlessOnboardingController_createNewVaultWithAuthData({ passwo
     __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_persistAuthPubKey).call(this, {
         authPubKey: rawToprfAuthKeyPair.pk,
     });
+    __classPrivateFieldGet(this, _SeedlessOnboardingController_instances, "m", _SeedlessOnboardingController_setUnlocked).call(this);
 }, _SeedlessOnboardingController_updateVault = 
 /**
  * Encrypt and update the vault with the given authentication data.