@metamask-previews/perps-controller 5.0.0-preview-bd0d4d2e9 → 5.0.0-preview-938a7fe

package/CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **BREAKING:** Rename `AccountState.availableBalance` to `spendableBalance` and `AccountState.availableToTradeBalance` to `withdrawableBalance` for clearer semantics across abstraction modes ([#8678](https://github.com/MetaMask/core/pull/8678))
 - Mode-aware spot fold: `addSpotBalanceToAccountState` now folds free spot USDC into both `spendableBalance` and `withdrawableBalance` for Unified/Portfolio modes, while Standard/DEX-abstraction modes keep spot separate ([#8678](https://github.com/MetaMask/core/pull/8678))
 - Add throttled WS-driven `userAbstraction` refresh so HL-web mode flips propagate back without requiring a restart or account switch ([#8678](https://github.com/MetaMask/core/pull/8678))
+- Fix position direction display for flipped positions ([#8707](https://github.com/MetaMask/core/pull/8707))
 
 ## [5.0.0]
 

package/dist/providers/HyperLiquidProvider.cjs

@@ -283,6 +283,9 @@ class HyperLiquidProvider {
      * @returns A promise that resolves to the result.
      */
     async placeOrder(params, retryCount = 0) {
+        // Hoisted so the retry path in the catch block can use the fetched price
+        // even when the caller (e.g. flipPosition) omits currentPrice from params.
+        let effectivePrice;
         try {
             __classPrivateFieldGet(this, _HyperLiquidProvider_deps, "f").debugLogger.log('Placing order via HyperLiquid SDK:', params);
             // Basic sync validation (backward compatibility)
@@ -295,9 +298,37 @@ class HyperLiquidProvider {
             if (!validation.isValid) {
                 throw new Error(validation.error);
             }
-            // Validate order at provider level (enforces USD validation rules)
-            await __classPrivateFieldGet(this, _HyperLiquidProvider_instances, "m", _HyperLiquidProvider_validateOrderBeforePlacement).call(this, params);
-            // Ensure provider is ready for trading (includes signing operations)
+            // Extract DEX name for API calls (main DEX = null)
+            const { dex: dexName } = (0, hyperLiquidAdapter_1.parseAssetName)(params.symbol);
+            // 1. Get asset info and current price before validation so price-less
+            // callers (e.g. flipPosition) can validate against the live fetched price.
+            const { assetInfo, currentPrice, meta } = await __classPrivateFieldGet(this, _HyperLiquidProvider_instances, "m", _HyperLiquidProvider_getAssetInfo).call(this, {
+                symbol: params.symbol,
+                dexName,
+            });
+            // Allow override with UI-provided price (optimization to avoid API call).
+            effectivePrice =
+                params.currentPrice && params.currentPrice > 0
+                    ? params.currentPrice
+                    : currentPrice;
+            if (params.currentPrice && params.currentPrice > 0) {
+                __classPrivateFieldGet(this, _HyperLiquidProvider_deps, "f").debugLogger.log('Using provided current price:', {
+                    coin: params.symbol,
+                    providedPrice: effectivePrice,
+                    source: 'UI price feed',
+                });
+            }
+            // Validate order at provider level (enforces USD validation rules).
+            // Pass effectivePrice so price-less market orders (e.g. flipPosition)
+            // validate against the live fetched price instead of failing with
+            // ORDER_PRICE_REQUIRED.
+            await __classPrivateFieldGet(this, _HyperLiquidProvider_instances, "m", _HyperLiquidProvider_validateOrderBeforePlacement).call(this, {
+                ...params,
+                currentPrice: effectivePrice,
+            });
+            // Ensure provider is ready for trading (includes signing operations).
+            // Kept after validation so invalid orders never trigger signature prompts
+            // (builder-fee approval, DEX abstraction enablement, etc.).
             await __classPrivateFieldGet(this, _HyperLiquidProvider_instances, "m", _HyperLiquidProvider_ensureReadyForTrading).call(this);
             // Debug: Log asset map state before order placement
             const allMapKeys = Array.from(__classPrivateFieldGet(this, _HyperLiquidProvider_symbolToAssetId, "f").keys());
@@ -313,24 +344,6 @@ class HyperLiquidProvider {
                 allowlistMarkets: __classPrivateFieldGet(this, _HyperLiquidProvider_allowlistMarkets, "f"),
                 blocklistMarkets: __classPrivateFieldGet(this, _HyperLiquidProvider_blocklistMarkets, "f"),
             });
-            // Extract DEX name for API calls (main DEX = null)
-            const { dex: dexName } = (0, hyperLiquidAdapter_1.parseAssetName)(params.symbol);
-            // 1. Get asset info and current price
-            const { assetInfo, currentPrice, meta } = await __classPrivateFieldGet(this, _HyperLiquidProvider_instances, "m", _HyperLiquidProvider_getAssetInfo).call(this, {
-                symbol: params.symbol,
-                dexName,
-            });
-            // Allow override with UI-provided price (optimization to avoid API call)
-            const effectivePrice = params.currentPrice && params.currentPrice > 0
-                ? params.currentPrice
-                : currentPrice;
-            if (params.currentPrice && params.currentPrice > 0) {
-                __classPrivateFieldGet(this, _HyperLiquidProvider_deps, "f").debugLogger.log('Using provided current price:', {
-                    coin: params.symbol,
-                    providedPrice: effectivePrice,
-                    source: 'UI price feed',
-                });
-            }
             // 2. Calculate final position size with USD reconciliation
             const { finalPositionSize } = (0, orderCalculations_1.calculateFinalPositionSize)({
                 usdAmount: params.usdAmount,
@@ -423,10 +436,13 @@ class HyperLiquidProvider {
                     originalValue = params.usdAmount;
                     adjustedUsdAmount = (parseFloat(params.usdAmount) * 1.015).toFixed(2);
                 }
-                else if (params.currentPrice) {
-                    // Size-based order: calculate USD from size and adjust
+                else if (effectivePrice) {
+                    // Size-based order: calculate USD from size and adjust.
+                    // Use the hoisted effectivePrice (fetched live price) so callers that
+                    // omit currentPrice (e.g. flipPosition) can still recover from the
+                    // $10-minimum edge case.
                     const sizeValue = parseFloat(params.size);
-                    const estimatedUsd = sizeValue * params.currentPrice;
+                    const estimatedUsd = sizeValue * effectivePrice;
                     originalValue = `${estimatedUsd.toFixed(2)} (calculated from size ${params.size})`;
                     adjustedUsdAmount = (estimatedUsd * 1.015).toFixed(2);
                 }