@metamask-previews/perps-controller 20.0.0-preview-44b7ded21 → 20.0.0-preview-2750df1dc

package/dist/services/TradingService.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"TradingService.d.ts","sourceRoot":"","sources":["../../src/services/TradingService.ts"],"names":[],"mappings":"AAgBA,OAAO,KAAK,EACV,aAAa,EAEb,WAAW,EACX,WAAW,EACX,eAAe,EACf,iBAAiB,EACjB,iBAAiB,EACjB,kBAAkB,EAClB,kBAAkB,EAClB,mBAAmB,EACnB,oBAAoB,EACpB,oBAAoB,EACpB,QAAQ,EACR,YAAY,EACZ,wBAAwB,EAExB,yBAAyB,EAE1B,MAAM,mBAAmB,CAAC;AAO3B,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,gCAAgC,CAAC;AAChF,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AAE1D;;;GAGG;AACH,MAAM,MAAM,4BAA4B,GAAG;IACzC,yBAAyB,EAAE,yBAAyB,CAAC;CACtD,CAAC;AAwBF;;;;;;;;;GASG;AACH,qBAAa,cAAc;;IAezB;;;;OAIG;IACH,YAAY,IAAI,EAAE,yBAAyB,EAE1C;IAED;;;;;OAKG;IACH,yBAAyB,CACvB,cAAc,EAAE,4BAA4B,GAC3C,IAAI,CAEN;IAgbD;;;;;;;;;;OAUG;IACG,UAAU,CAAC,OAAO,EAAE;QACxB,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,WAAW,CAAC;QACpB,OAAO,EAAE,cAAc,CAAC;QACxB,qBAAqB,EAAE,CAAC,MAAM,EAAE;YAC9B,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC;YACzB,MAAM,EAAE,MAAM,CAAC;YACf,OAAO,CAAC,EAAE,MAAM,CAAC;YACjB,OAAO,CAAC,EAAE,MAAM,CAAC;SAClB,KAAK,OAAO,CAAC;YAAE,OAAO,EAAE,OAAO,CAAC;YAAC,KAAK,CAAC,EAAE,MAAM,CAAA;SAAE,CAAC,CAAC;KACrD,GAAG,OAAO,CAAC,WAAW,CAAC,CA8OvB;IAotBD;;;;;;;;;OASG;IACG,SAAS,CAAC,OAAO,EAAE;QACvB,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,eAAe,CAAC;QACxB,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC,WAAW,CAAC,CA2IvB;IAED;;;;;;;;;;OAUG;IACG,WAAW,CAAC,OAAO,EAAE;QACzB,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,iBAAiB,CAAC;QAC1B,OAAO,EAAE,cAAc,CAAC;QACxB,YAAY,CAAC,EAAE,MAAM,CAAC;KACvB,GAAG,OAAO,CAAC,iBAAiB,CAAC,CA4H7B;IAED;;;;;;;;;;OAUG;IACG,YAAY,CAAC,OAAO,EAAE;QAC1B,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,kBAAkB,CAAC;QAC3B,OAAO,EAAE,cAAc,CAAC;QACxB,eAAe,EAAE,CAAC,OAAO,EACvB,SAAS,EAAE,MAAM,OAAO,CAAC,OAAO,CAAC,EACjC,QAAQ,EAAE,MAAM,EAAE,KACf,OAAO,CAAC,OAAO,CAAC,CAAC;KACvB,GAAG,OAAO,CAAC,kBAAkB,CAAC,CAqL9B;IAED;;;;;;;;;;;OAWG;IACG,aAAa,CAAC,OAAO,EAAE;QAC3B,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,mBAAmB,CAAC;QAC5B,OAAO,EAAE,cAAc,CAAC;QACxB,qBAAqB,EAAE,CAAC,MAAM,EAAE;YAC9B,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC;YACzB,MAAM,EAAE,MAAM,CAAC;SAChB,KAAK,OAAO,CAAC;YAAE,OAAO,EAAE,OAAO,CAAC;YAAC,KAAK,CAAC,EAAE,MAAM,CAAA;SAAE,CAAC,CAAC;QACpD,YAAY,CAAC,EAAE,MAAM,CAAC;KACvB,GAAG,OAAO,CAAC,WAAW,CAAC,CAiKvB;IAED;;;;;;;;;OASG;IACG,cAAc,CAAC,OAAO,EAAE;QAC5B,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,oBAAoB,CAAC;QAC7B,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC,oBAAoB,CAAC,CA8LhC;IAED;;;;;;;;;OASG;IACG,kBAAkB,CAAC,OAAO,EAAE;QAChC,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,wBAAwB,CAAC;QACjC,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC,WAAW,CAAC,CA6MvB;IAED;;;;;;;;;OASG;IACG,YAAY,CAAC,OAAO,EAAE;QAC1B,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,MAAM,CAAC;QACf,MAAM,EAAE,MAAM,CAAC;QACf,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC;QAAE,OAAO,EAAE,OAAO,CAAC;QAAC,KAAK,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC,CAmGhD;IAED;;;;;;;;;OASG;IACG,YAAY,CAAC,OAAO,EAAE;QAC1B,QAAQ,EAAE,aAAa,CAAC;QACxB,QAAQ,EAAE,QAAQ,CAAC;QACnB,YAAY,CAAC,EAAE,YAAY,CAAC;QAC5B,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC,WAAW,CAAC,CA+LvB;CACF"}
+{"version":3,"file":"TradingService.d.ts","sourceRoot":"","sources":["../../src/services/TradingService.ts"],"names":[],"mappings":"AAgBA,OAAO,KAAK,EACV,aAAa,EAEb,WAAW,EACX,WAAW,EACX,eAAe,EACf,iBAAiB,EACjB,iBAAiB,EACjB,kBAAkB,EAClB,kBAAkB,EAClB,mBAAmB,EACnB,oBAAoB,EACpB,oBAAoB,EACpB,QAAQ,EACR,YAAY,EACZ,wBAAwB,EAExB,yBAAyB,EAG1B,MAAM,mBAAmB,CAAC;AAiB3B,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,gCAAgC,CAAC;AAChF,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AAE1D;;;GAGG;AACH,MAAM,MAAM,4BAA4B,GAAG;IACzC,yBAAyB,EAAE,yBAAyB,CAAC;CACtD,CAAC;AAkDF;;;;;;;;;GASG;AACH,qBAAa,cAAc;;IAezB;;;;OAIG;IACH,YAAY,IAAI,EAAE,yBAAyB,EAE1C;IAED;;;;;OAKG;IACH,yBAAyB,CACvB,cAAc,EAAE,4BAA4B,GAC3C,IAAI,CAEN;IAobD;;;;;;;;;;OAUG;IACG,UAAU,CAAC,OAAO,EAAE;QACxB,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,WAAW,CAAC;QACpB,OAAO,EAAE,cAAc,CAAC;QACxB,qBAAqB,EAAE,CAAC,MAAM,EAAE;YAC9B,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC;YACzB,MAAM,EAAE,MAAM,CAAC;YACf,OAAO,CAAC,EAAE,MAAM,CAAC;YACjB,OAAO,CAAC,EAAE,MAAM,CAAC;SAClB,KAAK,OAAO,CAAC;YAAE,OAAO,EAAE,OAAO,CAAC;YAAC,KAAK,CAAC,EAAE,MAAM,CAAA;SAAE,CAAC,CAAC;KACrD,GAAG,OAAO,CAAC,WAAW,CAAC,CA+OvB;IAitBD;;;;;;;;;OASG;IACG,SAAS,CAAC,OAAO,EAAE;QACvB,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,eAAe,CAAC;QACxB,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC,WAAW,CAAC,CA4IvB;IAED;;;;;;;;;;OAUG;IACG,WAAW,CAAC,OAAO,EAAE;QACzB,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,iBAAiB,CAAC;QAC1B,OAAO,EAAE,cAAc,CAAC;QACxB,YAAY,CAAC,EAAE,MAAM,CAAC;KACvB,GAAG,OAAO,CAAC,iBAAiB,CAAC,CA6I7B;IAED;;;;;;;;;;OAUG;IACG,YAAY,CAAC,OAAO,EAAE;QAC1B,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,kBAAkB,CAAC;QAC3B,OAAO,EAAE,cAAc,CAAC;QACxB,eAAe,EAAE,CAAC,OAAO,EACvB,SAAS,EAAE,MAAM,OAAO,CAAC,OAAO,CAAC,EACjC,QAAQ,EAAE,MAAM,EAAE,KACf,OAAO,CAAC,OAAO,CAAC,CAAC;KACvB,GAAG,OAAO,CAAC,kBAAkB,CAAC,CAqM9B;IAED;;;;;;;;;;;OAWG;IACG,aAAa,CAAC,OAAO,EAAE;QAC3B,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,mBAAmB,CAAC;QAC5B,OAAO,EAAE,cAAc,CAAC;QACxB,qBAAqB,EAAE,CAAC,MAAM,EAAE;YAC9B,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC;YACzB,MAAM,EAAE,MAAM,CAAC;SAChB,KAAK,OAAO,CAAC;YAAE,OAAO,EAAE,OAAO,CAAC;YAAC,KAAK,CAAC,EAAE,MAAM,CAAA;SAAE,CAAC,CAAC;QACpD,YAAY,CAAC,EAAE,MAAM,CAAC;KACvB,GAAG,OAAO,CAAC,WAAW,CAAC,CAuKvB;IAED;;;;;;;;;OASG;IACG,cAAc,CAAC,OAAO,EAAE;QAC5B,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,oBAAoB,CAAC;QAC7B,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC,oBAAoB,CAAC,CAmNhC;IAED;;;;;;;;;OASG;IACG,kBAAkB,CAAC,OAAO,EAAE;QAChC,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,wBAAwB,CAAC;QACjC,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC,WAAW,CAAC,CAsNvB;IAED;;;;;;;;;OASG;IACG,YAAY,CAAC,OAAO,EAAE;QAC1B,QAAQ,EAAE,aAAa,CAAC;QACxB,MAAM,EAAE,MAAM,CAAC;QACf,MAAM,EAAE,MAAM,CAAC;QACf,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC;QAAE,OAAO,EAAE,OAAO,CAAC;QAAC,KAAK,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC,CA6GhD;IAED;;;;;;;;;OASG;IACG,YAAY,CAAC,OAAO,EAAE;QAC1B,QAAQ,EAAE,aAAa,CAAC;QACxB,QAAQ,EAAE,QAAQ,CAAC;QACnB,YAAY,CAAC,EAAE,YAAY,CAAC;QAC5B,OAAO,EAAE,cAAc,CAAC;KACzB,GAAG,OAAO,CAAC,WAAW,CAAC,CAkOvB;CACF"}

package/dist/services/TradingService.js

@@ -6,6 +6,7 @@ import { PerpsMeasurementName } from '../constants/performanceMetrics.js';
 import { PERPS_CONSTANTS } from '../constants/perpsConfig.js';
 import { PERPS_ERROR_CODES } from '../perpsErrorCodes.js';
 import { PerpsAnalyticsEvent, PerpsTraceNames, PerpsTraceOperations, } from '../types/index.js';
+import { PERPS_ERROR_ACTION, PERPS_ERROR_OPERATION, createPerpsErrorContext, wasProviderErrorReported, } from '../utils/errorContext.js';
 import { ensureError } from '../utils/errorUtils.js';
 import { captureScaleOrderParams } from '../utils/lighterScaleOrders.js';
 import { isLimitExecutionOrderType, SCALE_ORDER_COUNT, } from '../utils/orderTypes.js';
@@ -20,6 +21,28 @@ import { isLimitExecutionOrderType, SCALE_ORDER_COUNT, } from '../utils/orderTyp
 function isSignerUnavailable(error) {
     return error === PERPS_ERROR_CODES.KEYRING_LOCKED;
 }
+/**
+ * Flip results that are expected account or signer states, not defects.
+ * A locked keyring is retried by the user. A missing exchange account is the
+ * pre-account state already kept out of error reporting by the provider.
+ *
+ * @param error - The provider result error.
+ * @returns True for `KEYRING_LOCKED` and `EXCHANGE_ACCOUNT_NOT_FOUND`.
+ */
+function isSilentFlipResult(error) {
+    return (isSignerUnavailable(error) ||
+        error === PERPS_ERROR_CODES.EXCHANGE_ACCOUNT_NOT_FOUND);
+}
+/**
+ * Convert an operation result into the bounded terminal trace status that
+ * platform adapters map to their tracing SDK.
+ *
+ * @param success - Whether the traced operation completed successfully.
+ * @returns The terminal trace status.
+ */
+function getTraceStatus(success) {
+    return success === true ? 'ok' : 'error';
+}
 /**
  * TradingService
  *
@@ -62,16 +85,21 @@ export class TradingService {
     /**
      * Error context helper for consistent logging
      *
+     * @param context - The active service context.
      * @param method - The method name.
+     * @param errorTags - Bounded tags used by error dashboards.
      * @param additionalContext - The additional context value.
      * @returns The resulting string value.
      */
-    #getErrorContext(method, additionalContext) {
-        return {
-            controller: 'TradingService',
+    #getErrorContext(context, method, errorTags, additionalContext) {
+        return createPerpsErrorContext({
+            contextName: 'TradingService',
             method,
-            ...additionalContext,
-        };
+            provider: context.tracingContext.provider,
+            network: context.tracingContext.isTestnet ? 'testnet' : 'mainnet',
+            errorTags,
+            data: additionalContext,
+        });
     }
     /**
      * Build discovery/attribution properties shared across trade/close/cancel/risk
@@ -344,21 +372,13 @@ export class TradingService {
                 ? parseFloat(params.takeProfitPrice)
                 : undefined,
         }).catch((error) => {
-            this.#deps.logger.error(ensureError(error, 'TradingService.handleOrderSuccess'), {
-                tags: {
-                    feature: PERPS_CONSTANTS.FeatureName,
-                    provider: context.tracingContext.provider,
-                    network: context.tracingContext.isTestnet ? 'testnet' : 'mainnet',
-                },
-                context: {
-                    name: context.errorContext.controller,
-                    data: {
-                        method: context.errorContext.method,
-                        operation: 'reportOrderToDataLake',
-                        symbol: params.symbol,
-                    },
-                },
-            });
+            this.#deps.logger.error(ensureError(error, 'TradingService.handleOrderSuccess'), this.#getErrorContext(context, context.errorContext.method, {
+                operation: PERPS_ERROR_OPERATION.OrderManagement,
+                action: PERPS_ERROR_ACTION.PlaceOrder,
+            }, {
+                operation: 'reportOrderToDataLake',
+                symbol: params.symbol,
+            }));
         });
     }
     /**
@@ -448,7 +468,7 @@ export class TradingService {
                 message: 'Order execution started',
                 level: 'info',
                 data: {
-                    payment_token: paymentToken,
+                    pay_token_symbol: paymentToken,
                     market: params.symbol,
                     orderType: params.orderType,
                 },
@@ -464,12 +484,12 @@ export class TradingService {
                     market: params.symbol,
                     leverage: String(params.leverage ?? 1),
                     isTestnet: String(context.tracingContext.isTestnet),
-                    payment_token: paymentToken,
+                    pay_token_symbol: paymentToken,
                 },
                 data: {
                     isBuy: params.isBuy,
                     orderPrice: params.price ?? '',
-                    payment_token: paymentToken,
+                    pay_token_symbol: paymentToken,
                 },
             });
             // Calculate fee discount at execution time (fresh, secure)
@@ -514,7 +534,7 @@ export class TradingService {
                     level: 'warning',
                     data: {
                         thresholdMs: PERPS_CONSTANTS.PlaceOrderTimeoutMs,
-                        payment_token: paymentToken,
+                        pay_token_symbol: paymentToken,
                         market: params.symbol,
                         orderType: params.orderType,
                     },
@@ -587,21 +607,13 @@ export class TradingService {
                 duration: completionDuration,
             });
             // withFeeDiscount handles fee discount cleanup automatically
-            this.#deps.logger.error(ensureError(error, 'TradingService.placeOrder'), {
-                tags: {
-                    feature: PERPS_CONSTANTS.FeatureName,
-                    provider: context.tracingContext.provider,
-                    network: context.tracingContext.isTestnet ? 'testnet' : 'mainnet',
-                },
-                context: {
-                    name: context.errorContext.controller,
-                    data: {
-                        method: context.errorContext.method,
-                        symbol: params.symbol,
-                        orderType: params.orderType,
-                    },
-                },
-            });
+            this.#deps.logger.error(ensureError(error, 'TradingService.placeOrder'), this.#getErrorContext(context, context.errorContext.method, {
+                operation: PERPS_ERROR_OPERATION.OrderManagement,
+                action: PERPS_ERROR_ACTION.PlaceOrder,
+            }, {
+                symbol: params.symbol,
+                orderType: params.orderType,
+            }));
             traceData = {
                 success: false,
                 reason: didExceedOrderSubmissionThreshold ? 'late_error' : 'error',
@@ -617,6 +629,7 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.PlaceOrder,
                 id: traceId,
+                status: getTraceStatus(traceData?.success),
                 data: traceData,
             });
         }
@@ -893,21 +906,13 @@ export class TradingService {
             action: 'close',
             symbol,
         }).catch((error) => {
-            this.#deps.logger.error(ensureError(error, 'TradingService.handleDataLakeReporting'), {
-                tags: {
-                    feature: PERPS_CONSTANTS.FeatureName,
-                    provider: context.tracingContext.provider,
-                    network: context.tracingContext.isTestnet ? 'testnet' : 'mainnet',
-                },
-                context: {
-                    name: context.errorContext.controller,
-                    data: {
-                        method: context.errorContext.method,
-                        operation: 'reportOrderToDataLake',
-                        symbol,
-                    },
-                },
-            });
+            this.#deps.logger.error(ensureError(error, 'TradingService.handleDataLakeReporting'), this.#getErrorContext(context, context.errorContext.method, {
+                operation: PERPS_ERROR_OPERATION.PositionManagement,
+                action: PERPS_ERROR_ACTION.ClosePosition,
+            }, {
+                operation: 'reportOrderToDataLake',
+                symbol,
+            }));
         });
     }
     /**
@@ -1246,20 +1251,12 @@ export class TradingService {
                 [PERPS_EVENT_PROPERTY.COMPLETION_DURATION]: completionDuration,
                 [PERPS_EVENT_PROPERTY.ERROR_MESSAGE]: error instanceof Error ? error.message : 'Unknown error',
             });
-            this.#deps.logger.error(ensureError(error, 'TradingService.editOrder'), {
-                tags: {
-                    feature: PERPS_CONSTANTS.FeatureName,
-                    provider: context.tracingContext.provider,
-                    network: context.tracingContext.isTestnet ? 'testnet' : 'mainnet',
-                },
-                context: {
-                    name: context.errorContext.controller,
-                    data: {
-                        method: context.errorContext.method,
-                        orderId: params.orderId,
-                    },
-                },
-            });
+            this.#deps.logger.error(ensureError(error, 'TradingService.editOrder'), this.#getErrorContext(context, context.errorContext.method, {
+                operation: PERPS_ERROR_OPERATION.OrderManagement,
+                action: PERPS_ERROR_ACTION.EditOrder,
+            }, {
+                orderId: params.orderId,
+            }));
             traceData = {
                 success: false,
                 error: error instanceof Error ? error.message : 'Unknown error',
@@ -1270,6 +1267,7 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.EditOrder,
                 id: traceId,
+                status: getTraceStatus(traceData?.success),
                 data: traceData,
             });
         }
@@ -1346,7 +1344,10 @@ export class TradingService {
                     ...cancelExtraProps,
                 });
                 if (!isSignerUnavailable(result.error)) {
-                    this.#deps.logger.error(ensureError(result.error, 'TradingService.cancelOrder'), this.#getErrorContext('cancelOrder', {
+                    this.#deps.logger.error(ensureError(result.error, 'TradingService.cancelOrder'), this.#getErrorContext(context, 'cancelOrder', {
+                        operation: PERPS_ERROR_OPERATION.OrderManagement,
+                        action: PERPS_ERROR_ACTION.CancelOrder,
+                    }, {
                         symbol: params.symbol,
                         orderId: params.orderId,
                         providerError: result.error ?? 'Unknown error',
@@ -1366,7 +1367,10 @@ export class TradingService {
                 [PERPS_EVENT_PROPERTY.ERROR_MESSAGE]: error instanceof Error ? error.message : 'Unknown error',
                 ...cancelExtraProps,
             });
-            this.#deps.logger.error(ensureError(error, 'TradingService.cancelOrder'), this.#getErrorContext('cancelOrder', { symbol: params.symbol }));
+            this.#deps.logger.error(ensureError(error, 'TradingService.cancelOrder'), this.#getErrorContext(context, 'cancelOrder', {
+                operation: PERPS_ERROR_OPERATION.OrderManagement,
+                action: PERPS_ERROR_ACTION.CancelOrder,
+            }, { symbol: params.symbol }));
             traceData = {
                 success: false,
                 error: error instanceof Error ? error.message : 'Unknown error',
@@ -1377,6 +1381,7 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.CancelOrder,
                 id: traceId,
+                status: getTraceStatus(traceData?.success),
                 data: traceData,
             });
         }
@@ -1494,7 +1499,10 @@ export class TradingService {
                 const failureSummary = reportedFailures
                     .map((result) => `${result.symbol}/${result.orderId}: ${result.error ?? 'Unknown error'}`)
                     .join('; ');
-                this.#deps.logger.error(new Error(`cancelOrders batch failure: ${operationResult.failureCount}/${operationResult.results.length} failed (${reportedFailures.length} reported) - ${failureSummary}`), this.#getErrorContext('cancelOrders', {
+                this.#deps.logger.error(new Error(`cancelOrders batch failure: ${operationResult.failureCount}/${operationResult.results.length} failed (${reportedFailures.length} reported) - ${failureSummary}`), this.#getErrorContext(context, 'cancelOrders', {
+                    operation: PERPS_ERROR_OPERATION.OrderManagement,
+                    action: PERPS_ERROR_ACTION.CancelOrder,
+                }, {
                     successCount: operationResult.successCount,
                     failureCount: operationResult.failureCount,
                     reportedFailureCount: reportedFailures.length,
@@ -1506,7 +1514,10 @@ export class TradingService {
         catch (error) {
             operationError =
                 error instanceof Error ? error : new Error(String(error));
-            this.#deps.logger.error(ensureError(error, 'TradingService.cancelOrders'), this.#getErrorContext('cancelOrders'));
+            this.#deps.logger.error(ensureError(error, 'TradingService.cancelOrders'), this.#getErrorContext(context, 'cancelOrders', {
+                operation: PERPS_ERROR_OPERATION.OrderManagement,
+                action: PERPS_ERROR_ACTION.CancelOrder,
+            }));
             throw error;
         }
         finally {
@@ -1527,6 +1538,11 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.CancelOrder,
                 id: traceId,
+                status: getTraceStatus(operationResult?.success),
+                data: {
+                    success: operationResult?.success === true,
+                    ...(operationError ? { error: operationError.message } : {}),
+                },
             });
         }
     }
@@ -1615,7 +1631,10 @@ export class TradingService {
             else {
                 traceData = { success: false, error: result.error ?? 'Unknown error' };
                 if (!isSignerUnavailable(result.error)) {
-                    this.#deps.logger.error(ensureError(result.error, 'TradingService.closePosition'), this.#getErrorContext('closePosition', {
+                    this.#deps.logger.error(ensureError(result.error, 'TradingService.closePosition'), this.#getErrorContext(context, 'closePosition', {
+                        operation: PERPS_ERROR_OPERATION.PositionManagement,
+                        action: PERPS_ERROR_ACTION.ClosePosition,
+                    }, {
                         symbol: params.symbol,
                         providerError: result.error ?? 'Unknown error',
                     }));
@@ -1648,20 +1667,12 @@ export class TradingService {
                 duration: completionDuration,
                 bulkActionId,
             });
-            this.#deps.logger.error(ensureError(error, 'TradingService.closePosition'), {
-                tags: {
-                    feature: PERPS_CONSTANTS.FeatureName,
-                    provider: context.tracingContext.provider,
-                    network: context.tracingContext.isTestnet ? 'testnet' : 'mainnet',
-                },
-                context: {
-                    name: context.errorContext.controller,
-                    data: {
-                        method: context.errorContext.method,
-                        symbol: params.symbol,
-                    },
-                },
-            });
+            this.#deps.logger.error(ensureError(error, 'TradingService.closePosition'), this.#getErrorContext(context, context.errorContext.method, {
+                operation: PERPS_ERROR_OPERATION.PositionManagement,
+                action: PERPS_ERROR_ACTION.ClosePosition,
+            }, {
+                symbol: params.symbol,
+            }));
             throw error;
         }
         finally {
@@ -1669,6 +1680,7 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.ClosePosition,
                 id: traceId,
+                status: getTraceStatus(traceData?.success),
                 data: traceData,
             });
         }
@@ -1786,7 +1798,10 @@ export class TradingService {
                 const failureSummary = reportedFailures
                     .map((result) => `${result.symbol}: ${result.error ?? 'Unknown error'}`)
                     .join('; ');
-                this.#deps.logger.error(new Error(`closePositions batch failure: ${operationResult.failureCount}/${operationResult.results.length} failed (${reportedFailures.length} reported) - ${failureSummary}`), this.#getErrorContext('closePositions', {
+                this.#deps.logger.error(new Error(`closePositions batch failure: ${operationResult.failureCount}/${operationResult.results.length} failed (${reportedFailures.length} reported) - ${failureSummary}`), this.#getErrorContext(context, 'closePositions', {
+                    operation: PERPS_ERROR_OPERATION.PositionManagement,
+                    action: PERPS_ERROR_ACTION.ClosePosition,
+                }, {
                     successCount: operationResult.successCount,
                     failureCount: operationResult.failureCount,
                     reportedFailureCount: reportedFailures.length,
@@ -1799,7 +1814,10 @@ export class TradingService {
         catch (error) {
             operationError =
                 error instanceof Error ? error : new Error(String(error));
-            this.#deps.logger.error(ensureError(error, 'TradingService.closePositions'), this.#getErrorContext('closePositions', {
+            this.#deps.logger.error(ensureError(error, 'TradingService.closePositions'), this.#getErrorContext(context, 'closePositions', {
+                operation: PERPS_ERROR_OPERATION.PositionManagement,
+                action: PERPS_ERROR_ACTION.ClosePosition,
+            }, {
                 symbols: params.symbols?.length ?? 0,
                 closeAll: params.closeAll,
             }));
@@ -1829,6 +1847,11 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.ClosePosition,
                 id: traceId,
+                status: getTraceStatus(operationResult?.success),
+                data: {
+                    success: operationResult?.success === true,
+                    ...(operationError ? { error: operationError.message } : {}),
+                },
             });
         }
     }
@@ -1935,7 +1958,10 @@ export class TradingService {
         catch (error) {
             errorMessage = error instanceof Error ? error.message : 'Unknown error';
             traceData = { success: false, error: errorMessage };
-            this.#deps.logger.error(ensureError(error, 'TradingService.updatePositionTPSL'), this.#getErrorContext('updatePositionTPSL', {
+            this.#deps.logger.error(ensureError(error, 'TradingService.updatePositionTPSL'), this.#getErrorContext(context, 'updatePositionTPSL', {
+                operation: PERPS_ERROR_OPERATION.PositionManagement,
+                action: PERPS_ERROR_ACTION.PositionTpslUpdate,
+            }, {
                 symbol: params.symbol,
                 hasTakeProfit: Boolean(params.takeProfitPrice),
                 hasStopLoss: Boolean(params.stopLossPrice),
@@ -2007,6 +2033,7 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.UpdateTpsl,
                 id: traceId,
+                status: getTraceStatus(traceData?.success),
                 data: traceData,
             });
         }
@@ -2078,6 +2105,7 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.UpdateMargin,
                 id: traceId,
+                status: getTraceStatus(result.success),
                 data: { success: result.success, error: result.error ?? '' },
             });
             return result;
@@ -2085,7 +2113,10 @@ export class TradingService {
         catch (error) {
             const completionDuration = this.#deps.performance.now() - startTime;
             const errorMessage = error instanceof Error ? error.message : 'Unknown error';
-            this.#deps.logger.error(ensureError(error, 'TradingService.updateMargin'), this.#getErrorContext('updateMargin', { symbol, amount }));
+            this.#deps.logger.error(ensureError(error, 'TradingService.updateMargin'), this.#getErrorContext(context, 'updateMargin', {
+                operation: PERPS_ERROR_OPERATION.PositionManagement,
+                action: PERPS_ERROR_ACTION.UpdateMargin,
+            }, { symbol, amount }));
             // Track failure analytics
             this.#deps.metrics.trackPerpsEvent(PerpsAnalyticsEvent.RiskManagement, {
                 [PERPS_EVENT_PROPERTY.STATUS]: PERPS_EVENT_VALUE.STATUS.FAILED,
@@ -2098,6 +2129,7 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.UpdateMargin,
                 id: traceId,
+                status: 'error',
                 data: { success: false, error: errorMessage },
             });
             throw error;
@@ -2150,6 +2182,10 @@ export class TradingService {
                 size: flipSize.toString(),
                 orderType: 'market',
                 leverage: position.leverage?.value,
+                // Lighter placeOrder otherwise logs order_management/place_order and
+                // marks the result reported, which drops this flip from flip filters.
+                // Close already suppresses that provider report. One Sentry event remains.
+                deferProviderErrorReport: true,
             };
             // Emit submitted event before the provider round-trip, keeping flip
             // trades aligned with the consolidated placeOrder pipeline.
@@ -2233,10 +2269,21 @@ export class TradingService {
                     }),
                     ...this.#buildAttributionProperties(trackingData),
                 });
+                if (!isSilentFlipResult(result.error) &&
+                    !wasProviderErrorReported(result)) {
+                    this.#deps.logger.error(ensureError(result.error, 'TradingService.flipPosition'), this.#getErrorContext(context, 'flipPosition', {
+                        operation: PERPS_ERROR_OPERATION.PositionManagement,
+                        action: PERPS_ERROR_ACTION.FlipPosition,
+                    }, {
+                        symbol: position.symbol,
+                        providerError: result.error ?? 'Unknown error',
+                    }));
+                }
             }
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.FlipPosition,
                 id: traceId,
+                status: getTraceStatus(result.success),
                 data: { success: result.success ?? false, error: result.error ?? '' },
             });
             return result;
@@ -2244,7 +2291,10 @@ export class TradingService {
         catch (error) {
             const completionDuration = this.#deps.performance.now() - startTime;
             const errorMessage = error instanceof Error ? error.message : 'Unknown error';
-            this.#deps.logger.error(ensureError(error, 'TradingService.flipPosition'), this.#getErrorContext('flipPosition', { symbol: position.symbol }));
+            this.#deps.logger.error(ensureError(error, 'TradingService.flipPosition'), this.#getErrorContext(context, 'flipPosition', {
+                operation: PERPS_ERROR_OPERATION.PositionManagement,
+                action: PERPS_ERROR_ACTION.FlipPosition,
+            }, { symbol: position.symbol }));
             // Track failure analytics with direction-specific flip action
             const wasLong = parseFloat(position.size) > 0;
             const failFlipAction = wasLong
@@ -2268,6 +2318,7 @@ export class TradingService {
             this.#deps.tracer.endTrace({
                 name: PerpsTraceNames.FlipPosition,
                 id: traceId,
+                status: 'error',
                 data: { success: false, error: errorMessage },
             });
             throw error;