@metamask-previews/notification-services-controller 25.0.0-preview-e196c24cd → 25.0.0-preview-8fd5dfabc

package/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Update `isOnChainRawNotification` to detect on-chain notifications using the v4 `notification_type` discriminator instead of legacy payload field checks, fixing web push notification handling after the v4 API migration ([#9407](https://github.com/MetaMask/core/pull/9407))
+
 ## [25.0.0]
 
 ### Added

package/dist/shared/is-onchain-notification.cjs

@@ -1,21 +1,15 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.isOnChainRawNotification = void 0;
+const notification_api_type_guards_1 = require("./notification-api-type-guards.cjs");
 /**
- * Checks if the given value is an OnChainRawNotification object.
+ * Checks if the given value is an on-chain notification using the v4 `notification_type` discriminator.
  *
  * @param notification - The value to check.
- * @returns True if the value is an OnChainRawNotification object, false otherwise.
+ * @returns True if the value is an on-chain notification, false otherwise.
  */
 function isOnChainRawNotification(notification) {
-    const assumed = notification;
-    // We don't have a validation/parsing library to check all possible types of an on chain notification
-    // It is safe enough just to check "some" fields, and catch any errors down the line if the shape is bad.
-    const isValidEnoughToBeOnChainNotification = [
-        assumed?.id,
-        assumed?.payload?.data,
-    ].every((field) => field !== undefined);
-    return isValidEnoughToBeOnChainNotification;
+    return (0, notification_api_type_guards_1.isOnChainNotification)(notification);
 }
 exports.isOnChainRawNotification = isOnChainRawNotification;
 //# sourceMappingURL=is-onchain-notification.cjs.map

package/dist/shared/is-onchain-notification.cjs.map

@@ -1 +1 @@
-{"version":3,"file":"is-onchain-notification.cjs","sourceRoot":"","sources":["../../src/shared/is-onchain-notification.ts"],"names":[],"mappings":";;;AAEA;;;;;GAKG;AACH,SAAgB,wBAAwB,CACtC,YAAqB;IAErB,MAAM,OAAO,GAAG,YAAsC,CAAC;IAEvD,qGAAqG;IACrG,yGAAyG;IACzG,MAAM,oCAAoC,GAAG;QAC3C,OAAO,EAAE,EAAE;QACX,OAAO,EAAE,OAAO,EAAE,IAAI;KACvB,CAAC,KAAK,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,KAAK,SAAS,CAAC,CAAC;IACxC,OAAO,oCAAoC,CAAC;AAC9C,CAAC;AAZD,4DAYC","sourcesContent":["import type { OnChainRawNotification } from '../NotificationServicesController';\n\n/**\n * Checks if the given value is an OnChainRawNotification object.\n *\n * @param notification - The value to check.\n * @returns True if the value is an OnChainRawNotification object, false otherwise.\n */\nexport function isOnChainRawNotification(\n  notification: unknown,\n): notification is OnChainRawNotification {\n  const assumed = notification as OnChainRawNotification;\n\n  // We don't have a validation/parsing library to check all possible types of an on chain notification\n  // It is safe enough just to check \"some\" fields, and catch any errors down the line if the shape is bad.\n  const isValidEnoughToBeOnChainNotification = [\n    assumed?.id,\n    assumed?.payload?.data,\n  ].every((field) => field !== undefined);\n  return isValidEnoughToBeOnChainNotification;\n}\n"]}
+{"version":3,"file":"is-onchain-notification.cjs","sourceRoot":"","sources":["../../src/shared/is-onchain-notification.ts"],"names":[],"mappings":";;;AAIA,qFAAuE;AAEvE;;;;;GAKG;AACH,SAAgB,wBAAwB,CACtC,YAAqB;IAErB,OAAO,IAAA,oDAAqB,EAAC,YAA0C,CAAC,CAAC;AAC3E,CAAC;AAJD,4DAIC","sourcesContent":["import type {\n  UnprocessedRawNotification,\n  OnChainNotification,\n} from '../NotificationServicesController/types/notification-api';\nimport { isOnChainNotification } from './notification-api-type-guards';\n\n/**\n * Checks if the given value is an on-chain notification using the v4 `notification_type` discriminator.\n *\n * @param notification - The value to check.\n * @returns True if the value is an on-chain notification, false otherwise.\n */\nexport function isOnChainRawNotification(\n  notification: unknown,\n): notification is OnChainNotification {\n  return isOnChainNotification(notification as UnprocessedRawNotification);\n}\n"]}

package/dist/shared/is-onchain-notification.d.cts

@@ -1,9 +1,9 @@
-import type { OnChainRawNotification } from "../NotificationServicesController/index.cjs";
+import type { OnChainNotification } from "../NotificationServicesController/types/notification-api/index.cjs";
 /**
- * Checks if the given value is an OnChainRawNotification object.
+ * Checks if the given value is an on-chain notification using the v4 `notification_type` discriminator.
  *
  * @param notification - The value to check.
- * @returns True if the value is an OnChainRawNotification object, false otherwise.
+ * @returns True if the value is an on-chain notification, false otherwise.
  */
-export declare function isOnChainRawNotification(notification: unknown): notification is OnChainRawNotification;
+export declare function isOnChainRawNotification(notification: unknown): notification is OnChainNotification;
 //# sourceMappingURL=is-onchain-notification.d.cts.map

package/dist/shared/is-onchain-notification.d.cts.map

@@ -1 +1 @@
-{"version":3,"file":"is-onchain-notification.d.cts","sourceRoot":"","sources":["../../src/shared/is-onchain-notification.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,sBAAsB,EAAE,oDAA0C;AAEhF;;;;;GAKG;AACH,wBAAgB,wBAAwB,CACtC,YAAY,EAAE,OAAO,GACpB,YAAY,IAAI,sBAAsB,CAUxC"}
+{"version":3,"file":"is-onchain-notification.d.cts","sourceRoot":"","sources":["../../src/shared/is-onchain-notification.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAEV,mBAAmB,EACpB,2EAAiE;AAGlE;;;;;GAKG;AACH,wBAAgB,wBAAwB,CACtC,YAAY,EAAE,OAAO,GACpB,YAAY,IAAI,mBAAmB,CAErC"}

package/dist/shared/is-onchain-notification.d.mts

@@ -1,9 +1,9 @@
-import type { OnChainRawNotification } from "../NotificationServicesController/index.mjs";
+import type { OnChainNotification } from "../NotificationServicesController/types/notification-api/index.mjs";
 /**
- * Checks if the given value is an OnChainRawNotification object.
+ * Checks if the given value is an on-chain notification using the v4 `notification_type` discriminator.
  *
  * @param notification - The value to check.
- * @returns True if the value is an OnChainRawNotification object, false otherwise.
+ * @returns True if the value is an on-chain notification, false otherwise.
  */
-export declare function isOnChainRawNotification(notification: unknown): notification is OnChainRawNotification;
+export declare function isOnChainRawNotification(notification: unknown): notification is OnChainNotification;
 //# sourceMappingURL=is-onchain-notification.d.mts.map

package/dist/shared/is-onchain-notification.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"is-onchain-notification.d.mts","sourceRoot":"","sources":["../../src/shared/is-onchain-notification.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,sBAAsB,EAAE,oDAA0C;AAEhF;;;;;GAKG;AACH,wBAAgB,wBAAwB,CACtC,YAAY,EAAE,OAAO,GACpB,YAAY,IAAI,sBAAsB,CAUxC"}
+{"version":3,"file":"is-onchain-notification.d.mts","sourceRoot":"","sources":["../../src/shared/is-onchain-notification.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAEV,mBAAmB,EACpB,2EAAiE;AAGlE;;;;;GAKG;AACH,wBAAgB,wBAAwB,CACtC,YAAY,EAAE,OAAO,GACpB,YAAY,IAAI,mBAAmB,CAErC"}

package/dist/shared/is-onchain-notification.mjs

@@ -1,17 +1,11 @@
+import { isOnChainNotification } from "./notification-api-type-guards.mjs";
 /**
- * Checks if the given value is an OnChainRawNotification object.
+ * Checks if the given value is an on-chain notification using the v4 `notification_type` discriminator.
  *
  * @param notification - The value to check.
- * @returns True if the value is an OnChainRawNotification object, false otherwise.
+ * @returns True if the value is an on-chain notification, false otherwise.
  */
 export function isOnChainRawNotification(notification) {
-    const assumed = notification;
-    // We don't have a validation/parsing library to check all possible types of an on chain notification
-    // It is safe enough just to check "some" fields, and catch any errors down the line if the shape is bad.
-    const isValidEnoughToBeOnChainNotification = [
-        assumed?.id,
-        assumed?.payload?.data,
-    ].every((field) => field !== undefined);
-    return isValidEnoughToBeOnChainNotification;
+    return isOnChainNotification(notification);
 }
 //# sourceMappingURL=is-onchain-notification.mjs.map

package/dist/shared/is-onchain-notification.mjs.map

@@ -1 +1 @@
-{"version":3,"file":"is-onchain-notification.mjs","sourceRoot":"","sources":["../../src/shared/is-onchain-notification.ts"],"names":[],"mappings":"AAEA;;;;;GAKG;AACH,MAAM,UAAU,wBAAwB,CACtC,YAAqB;IAErB,MAAM,OAAO,GAAG,YAAsC,CAAC;IAEvD,qGAAqG;IACrG,yGAAyG;IACzG,MAAM,oCAAoC,GAAG;QAC3C,OAAO,EAAE,EAAE;QACX,OAAO,EAAE,OAAO,EAAE,IAAI;KACvB,CAAC,KAAK,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,KAAK,SAAS,CAAC,CAAC;IACxC,OAAO,oCAAoC,CAAC;AAC9C,CAAC","sourcesContent":["import type { OnChainRawNotification } from '../NotificationServicesController';\n\n/**\n * Checks if the given value is an OnChainRawNotification object.\n *\n * @param notification - The value to check.\n * @returns True if the value is an OnChainRawNotification object, false otherwise.\n */\nexport function isOnChainRawNotification(\n  notification: unknown,\n): notification is OnChainRawNotification {\n  const assumed = notification as OnChainRawNotification;\n\n  // We don't have a validation/parsing library to check all possible types of an on chain notification\n  // It is safe enough just to check \"some\" fields, and catch any errors down the line if the shape is bad.\n  const isValidEnoughToBeOnChainNotification = [\n    assumed?.id,\n    assumed?.payload?.data,\n  ].every((field) => field !== undefined);\n  return isValidEnoughToBeOnChainNotification;\n}\n"]}
+{"version":3,"file":"is-onchain-notification.mjs","sourceRoot":"","sources":["../../src/shared/is-onchain-notification.ts"],"names":[],"mappings":"AAIA,OAAO,EAAE,qBAAqB,EAAE,2CAAuC;AAEvE;;;;;GAKG;AACH,MAAM,UAAU,wBAAwB,CACtC,YAAqB;IAErB,OAAO,qBAAqB,CAAC,YAA0C,CAAC,CAAC;AAC3E,CAAC","sourcesContent":["import type {\n  UnprocessedRawNotification,\n  OnChainNotification,\n} from '../NotificationServicesController/types/notification-api';\nimport { isOnChainNotification } from './notification-api-type-guards';\n\n/**\n * Checks if the given value is an on-chain notification using the v4 `notification_type` discriminator.\n *\n * @param notification - The value to check.\n * @returns True if the value is an on-chain notification, false otherwise.\n */\nexport function isOnChainRawNotification(\n  notification: unknown,\n): notification is OnChainNotification {\n  return isOnChainNotification(notification as UnprocessedRawNotification);\n}\n"]}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@metamask-previews/notification-services-controller",
-  "version": "25.0.0-preview-e196c24cd",
+  "version": "25.0.0-preview-8fd5dfabc",
   "description": "Manages New MetaMask decentralized Notification system",
   "keywords": [
     "Ethereum",