@metamask-previews/bridge-status-controller 68.1.0-preview-935b6049c → 68.1.0-preview-5d62ac60b

package/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Added more unit test coverage for intents and EVM transactions. Also refactored some mocks and code blocks to improve testability ([#8186](https://github.com/MetaMask/core/pull/8186))
+
 ## [68.1.0]
 
 ### Added

package/dist/bridge-status-controller.cjs

@@ -246,7 +246,7 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                 },
                 hasApprovalTx: Boolean(quoteResponse.approval),
                 approvalTxId,
-                isStxEnabled: isStxEnabled ?? false,
+                isStxEnabled: Boolean(isStxEnabled),
                 featureId: quoteResponse.featureId,
                 location,
                 ...(abTests && { abTests }),
@@ -382,9 +382,8 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
             try {
                 let status;
                 let validationFailures = [];
-                const isIntent = Boolean(historyItem.quote.intent);
-                if (isIntent) {
-                    const intentTxStatus = await __classPrivateFieldGet(this, _BridgeStatusController_intentManager, "f").getIntentTransactionStatus(bridgeTxMetaId, historyItem, __classPrivateFieldGet(this, _BridgeStatusController_clientId, "f"));
+                if (historyItem.quote.intent) {
+                    const intentTxStatus = await __classPrivateFieldGet(this, _BridgeStatusController_intentManager, "f").getIntentTransactionStatus(bridgeTxMetaId, historyItem.quote.srcChainId, historyItem.quote.intent.protocol, __classPrivateFieldGet(this, _BridgeStatusController_clientId, "f"), historyItem.status.srcChain.txHash);
                     if (intentTxStatus?.bridgeStatus === null ||
                         intentTxStatus?.bridgeStatus === undefined) {
                         return;
@@ -429,7 +428,7 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                 this.update((state) => {
                     state.txHistory[bridgeTxMetaId] = newBridgeHistoryItem;
                 });
-                if (isIntent) {
+                if (historyItem.quote.intent) {
                     __classPrivateFieldGet(this, _BridgeStatusController_intentManager, "f").syncTransactionFromIntentStatus(bridgeTxMetaId, historyItem);
                 }
                 // 5. After effects
@@ -563,7 +562,7 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
             });
         });
         _BridgeStatusController_handleApprovalTx.set(this, async (isBridgeTx, srcChainId, approval, resetApproval, requireApproval) => {
-            if (approval) {
+            if (approval && (0, bridge_controller_1.isEvmTxData)(approval)) {
                 const approveTx = async () => {
                     await __classPrivateFieldGet(this, _BridgeStatusController_handleUSDTAllowanceReset, "f").call(this, resetApproval);
                     const approvalTxMeta = await __classPrivateFieldGet(this, _BridgeStatusController_handleEvmTransaction, "f").call(this, {
@@ -650,8 +649,8 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
             // Convert to hex since txFee values from the quote are decimal strings
             if (txFee) {
                 return {
-                    maxFeePerGas: (0, controller_utils_1.toHex)(txFee.maxFeePerGas ?? 0),
-                    maxPriorityFeePerGas: (0, controller_utils_1.toHex)(txFee.maxPriorityFeePerGas ?? 0),
+                    maxFeePerGas: (0, controller_utils_1.toHex)(txFee.maxFeePerGas),
+                    maxPriorityFeePerGas: (0, controller_utils_1.toHex)(txFee.maxPriorityFeePerGas),
                     gas: gas ? (0, controller_utils_1.toHex)(gas) : undefined,
                 };
             }
@@ -755,7 +754,9 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                             return quoteResponse.approval &&
                                 (0, bridge_controller_1.isTronTrade)(quoteResponse.approval)
                                 ? await __classPrivateFieldGet(this, _BridgeStatusController_handleNonEvmTx, "f").call(this, quoteResponse.approval, quoteResponse, selectedAccount)
-                                : undefined;
+                                : /* c8 ignore start */
+                                    undefined;
+                            /* c8 ignore end */
                         }
                         catch (error) {
                             !quoteResponse.featureId &&
@@ -789,7 +790,7 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                     }
                     catch (error) {
                         !quoteResponse.featureId &&
-                            __classPrivateFieldGet(this, _BridgeStatusController_trackUnifiedSwapBridgeEvent, "f").call(this, bridge_controller_1.UnifiedSwapBridgeEventName.Failed, txMeta?.id, {
+                            __classPrivateFieldGet(this, _BridgeStatusController_trackUnifiedSwapBridgeEvent, "f").call(this, bridge_controller_1.UnifiedSwapBridgeEventName.Failed, undefined, {
                                 error_message: error?.message,
                                 ...preConfirmationProperties,
                             });
@@ -934,26 +935,21 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                 const intent = (0, transaction_1.getIntentFromQuote)(quoteResponse);
                 // If backend provided an approval tx for this intent quote, submit it first (on-chain),
                 // then proceed with off-chain intent submission.
-                let approvalTxId;
-                if (quoteResponse.approval) {
-                    const isBridgeTx = (0, bridge_controller_1.isCrossChain)(quoteResponse.quote.srcChainId, quoteResponse.quote.destChainId);
-                    // Handle approval silently for better UX in intent flows
-                    const approvalTxMeta = await __classPrivateFieldGet(this, _BridgeStatusController_handleApprovalTx, "f").call(this, isBridgeTx, quoteResponse.quote.srcChainId, quoteResponse.approval && (0, bridge_controller_1.isEvmTxData)(quoteResponse.approval)
-                        ? quoteResponse.approval
-                        : undefined, quoteResponse.resetApproval, 
-                    /* requireApproval */ false);
-                    approvalTxId = approvalTxMeta?.id;
-                    if (approvalTxId) {
-                        await __classPrivateFieldGet(this, _BridgeStatusController_waitForTxConfirmation, "f").call(this, approvalTxId);
-                    }
+                const isBridgeTx = (0, bridge_controller_1.isCrossChain)(quoteResponse.quote.srcChainId, quoteResponse.quote.destChainId);
+                const requireApproval = isHardwareAccount && __classPrivateFieldGet(this, _BridgeStatusController_clientId, "f") === types_1.BridgeClientId.MOBILE;
+                // Handle approval silently for better UX in intent flows
+                const approvalTxMeta = await __classPrivateFieldGet(this, _BridgeStatusController_handleApprovalTx, "f").call(this, isBridgeTx, quoteResponse.quote.srcChainId, quoteResponse.approval, quoteResponse.resetApproval, requireApproval);
+                const approvalTxId = approvalTxMeta?.id;
+                if (approvalTxId) {
+                    await __classPrivateFieldGet(this, _BridgeStatusController_waitForTxConfirmation, "f").call(this, approvalTxId);
                 }
-                const { srcChainId: chainId, requestId } = quoteResponse.quote;
+                const { srcChainId, requestId } = quoteResponse.quote;
                 const signature = await this.messenger.call('KeyringController:signTypedMessage', {
                     from: accountAddress,
                     data: intent.typedData,
                 }, keyring_controller_1.SignTypedDataVersion.V4);
                 const submissionParams = {
-                    srcChainId: chainId.toString(),
+                    srcChainId,
                     quoteId: requestId,
                     signature,
                     order: intent.order,
@@ -963,16 +959,17 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                 const intentOrder = await __classPrivateFieldGet(this, _BridgeStatusController_intentManager, "f").submitIntent(submissionParams, __classPrivateFieldGet(this, _BridgeStatusController_clientId, "f"));
                 const orderUid = intentOrder.id;
                 // Determine transaction type: swap for same-chain, bridge for cross-chain
-                const isCrossChainTx = (0, bridge_controller_1.isCrossChain)(quoteResponse.quote.srcChainId, quoteResponse.quote.destChainId);
-                const transactionType = isCrossChainTx
-                    ? transaction_controller_1.TransactionType.bridge
-                    : transaction_controller_1.TransactionType.swap;
+                const transactionType = isBridgeTx
+                    ? /* c8 ignore start */
+                        transaction_controller_1.TransactionType.bridge
+                    : /* c8 ignore end */
+                        transaction_controller_1.TransactionType.swap;
                 // Create actual transaction in Transaction Controller first
-                const networkClientId = this.messenger.call('NetworkController:findNetworkClientIdByChainId', (0, bridge_controller_1.formatChainIdToHex)(chainId));
+                const networkClientId = this.messenger.call('NetworkController:findNetworkClientIdByChainId', (0, bridge_controller_1.formatChainIdToHex)(srcChainId));
                 // This is a synthetic transaction whose purpose is to be able
                 // to track the order status via the history
                 const intentTransactionParams = {
-                    chainId: (0, bridge_controller_1.formatChainIdToHex)(chainId),
+                    chainId: (0, bridge_controller_1.formatChainIdToHex)(srcChainId),
                     from: accountAddress,
                     to: intent.settlementContract ??
                         '0x9008D19f58AAbd9eD0D60971565AA8510560ab41', // Default settlement contract
@@ -1002,7 +999,6 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                     ...statusUpdatedTxMeta,
                     isIntentTx: true,
                     orderUid,
-                    intentType: isCrossChainTx ? 'bridge' : 'swap',
                 };
                 // Record in bridge history with actual transaction metadata
                 try {