@metamask-previews/bridge-status-controller 68.0.0-preview-384cfdfef → 68.0.0-preview-15dd7d63f

package/CHANGELOG.md

@@ -7,9 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-### Added
-- Added optional `activeAbTests` context support so Unified SwapBridge events can include `active_ab_tests` independently of `ab_tests`. ([#8152](https://github.com/MetaMask/core/pull/8152))
-
 ### Changed
 
 - Bump `@metamask/transaction-controller` from `^62.19.0` to `^62.20.0` ([#8104](https://github.com/MetaMask/core/pull/8104))

package/dist/bridge-status-controller.cjs

@@ -208,7 +208,7 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
             });
         });
         _BridgeStatusController_addTxToHistory.set(this, (startPollingForBridgeTxStatusArgs, actionId) => {
-            const { bridgeTxMeta, statusRequest, quoteResponse, startTime, slippagePercentage, initialDestAssetBalance, targetContractAddress, approvalTxId, isStxEnabled, location, abTests, activeAbTests, accountAddress: selectedAddress, } = startPollingForBridgeTxStatusArgs;
+            const { bridgeTxMeta, statusRequest, quoteResponse, startTime, slippagePercentage, initialDestAssetBalance, targetContractAddress, approvalTxId, isStxEnabled, location, abTests, accountAddress: selectedAddress, } = startPollingForBridgeTxStatusArgs;
             // Determine the key for this history item:
             // - For pre-submission (non-batch EVM): use actionId
             // - For post-submission or other cases: use bridgeTxMeta.id
@@ -250,7 +250,6 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                 featureId: quoteResponse.featureId,
                 location,
                 ...(abTests && { abTests }),
-                ...(activeAbTests && { activeAbTests }),
             };
             this.update((state) => {
                 // Use actionId as key for pre-submission, or txMeta.id for post-submission
@@ -715,11 +714,10 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
          * @param isStxEnabledOnClient - Whether smart transactions are enabled on the client, for example the getSmartTransactionsEnabled selector value from the extension
          * @param quotesReceivedContext - The context for the QuotesReceived event
          * @param location - The entry point from which the user initiated the swap or bridge (e.g. Main View, Token View, Trending Explore)
-         * @param abTests - Legacy A/B test context for `ab_tests` (backward compatibility)
-         * @param activeAbTests - New A/B test context for `active_ab_tests` (migration target). Attributes events to specific experiments.
+         * @param abTests - A/B test context to attribute events to specific experiments
          * @returns The transaction meta
          */
-        this.submitTx = async (accountAddress, quoteResponse, isStxEnabledOnClient, quotesReceivedContext, location = bridge_controller_1.MetaMetricsSwapsEventSource.MainView, abTests, activeAbTests) => {
+        this.submitTx = async (accountAddress, quoteResponse, isStxEnabledOnClient, quotesReceivedContext, location = bridge_controller_1.MetaMetricsSwapsEventSource.MainView, abTests) => {
             this.messenger.call('BridgeController:stopPollingForQuotes', bridge_controller_1.AbortReason.TransactionSubmitted, 
             // If trade is submitted before all quotes are loaded, the QuotesReceived event is published
             // If the trade has a featureId, it means it was submitted outside of the Unified Swap and Bridge experience, so no QuotesReceived event is published
@@ -729,7 +727,7 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                 throw new Error('Failed to submit cross-chain swap transaction: undefined multichain account');
             }
             const isHardwareAccount = (0, bridge_controller_1.isHardwareWallet)(selectedAccount);
-            const preConfirmationProperties = (0, metrics_1.getPreConfirmationPropertiesFromQuote)(quoteResponse, isStxEnabledOnClient, isHardwareAccount, location, abTests, activeAbTests);
+            const preConfirmationProperties = (0, metrics_1.getPreConfirmationPropertiesFromQuote)(quoteResponse, isStxEnabledOnClient, isHardwareAccount, location, abTests);
             // Emit Submitted event after submit button is clicked
             !quoteResponse.featureId &&
                 __classPrivateFieldGet(this, _BridgeStatusController_trackUnifiedSwapBridgeEvent, "f").call(this, bridge_controller_1.UnifiedSwapBridgeEventName.Submitted, undefined, preConfirmationProperties);
@@ -852,7 +850,6 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                         approvalTxId,
                         location,
                         abTests,
-                        activeAbTests,
                     }, actionId);
                     // Pass txFee when gasIncluded is true to use the quote's gas fees
                     // instead of re-estimating (which would fail for max native token swaps)
@@ -894,7 +891,6 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                         approvalTxId,
                         location,
                         abTests,
-                        activeAbTests,
                     });
                 }
                 if ((0, bridge_controller_1.isNonEvmChainId)(quoteResponse.quote.srcChainId)) {
@@ -919,17 +915,16 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
          * @param params.quoteResponse - Quote carrying intent data
          * @param params.accountAddress - The EOA submitting the order
          * @param params.location - The entry point from which the user initiated the swap or bridge
-         * @param params.abTests - Legacy A/B test context for `ab_tests` (backward compatibility)
-         * @param params.activeAbTests - New A/B test context for `active_ab_tests` (migration target). Attributes events to specific experiments.
+         * @param params.abTests - A/B test context to attribute events to specific experiments
          * @returns A lightweight TransactionMeta-like object for history linking
          */
         this.submitIntent = async (params) => {
-            const { quoteResponse, accountAddress, location, abTests, activeAbTests } = params;
+            const { quoteResponse, accountAddress, location, abTests } = params;
             this.messenger.call('BridgeController:stopPollingForQuotes', bridge_controller_1.AbortReason.TransactionSubmitted);
             // Build pre-confirmation properties for error tracking parity with submitTx
             const account = __classPrivateFieldGet(this, _BridgeStatusController_instances, "m", _BridgeStatusController_getMultichainSelectedAccount).call(this, accountAddress);
             const isHardwareAccount = Boolean(account) && (0, bridge_controller_1.isHardwareWallet)(account);
-            const preConfirmationProperties = (0, metrics_1.getPreConfirmationPropertiesFromQuote)(quoteResponse, false, isHardwareAccount, location, abTests, activeAbTests);
+            const preConfirmationProperties = (0, metrics_1.getPreConfirmationPropertiesFromQuote)(quoteResponse, false, isHardwareAccount, location, abTests);
             try {
                 const intent = (0, transaction_1.getIntentFromQuote)(quoteResponse);
                 // If backend provided an approval tx for this intent quote, submit it first (on-chain),
@@ -1029,7 +1024,6 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                         startTime,
                         location,
                         abTests,
-                        activeAbTests,
                     });
                     // Start polling using the orderId key to route to intent manager
                     __classPrivateFieldGet(this, _BridgeStatusController_startPollingForTxId, "f").call(this, bridgeHistoryKey);
@@ -1056,15 +1050,11 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
          * @param eventProperties - The properties for the event
          */
         _BridgeStatusController_trackUnifiedSwapBridgeEvent.set(this, (eventName, txMetaId, eventProperties) => {
-            // Legacy/new metrics fields are intentionally kept independent during migration.
+            const { ab_tests: eventAbTests } = eventProperties ?? {};
             const historyAbTests = txMetaId
                 ? this.state.txHistory?.[txMetaId]?.abTests
                 : undefined;
-            const historyActiveAbTests = txMetaId
-                ? this.state.txHistory?.[txMetaId]?.activeAbTests
-                : undefined;
-            const resolvedAbTests = eventProperties?.ab_tests ?? historyAbTests;
-            const resolvedActiveAbTests = eventProperties?.active_ab_tests ?? historyActiveAbTests;
+            const resolvedAbTests = eventAbTests ?? historyAbTests ?? undefined;
             const baseProperties = {
                 action_type: bridge_controller_1.MetricsActionType.SWAPBRIDGE_V1,
                 location: eventProperties?.location ??
@@ -1075,10 +1065,6 @@ class BridgeStatusController extends (0, polling_controller_1.StaticIntervalPoll
                     Object.keys(resolvedAbTests).length > 0 && {
                     ab_tests: resolvedAbTests,
                 }),
-                ...(resolvedActiveAbTests &&
-                    Object.keys(resolvedActiveAbTests).length > 0 && {
-                    active_ab_tests: resolvedActiveAbTests,
-                }),
             };
             // This will publish events for PERPS dropped tx failures as well
             if (!txMetaId) {