@metamask-previews/assets-controller 5.0.0-preview-dff83af4c → 5.0.0-preview-6b4f746

package/CHANGELOG.md

@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- `AssetsController` no longer silently skips asset fetching on startup for returning users ([#8412](https://github.com/MetaMask/core/pull/8412))
+  - Previously, `#start()` was called at keyring unlock before `AccountTreeController.init()` had built the account tree, causing `#selectedAccounts` to return an empty array and all subscriptions and fetches to be skipped. `selectedAccountGroupChange` does not fire when the persisted selected group is unchanged, leaving the controller idle.
+  - Now subscribes to `AccountTreeController:stateChange` (the base-controller event guaranteed to fire when `init()` calls `this.update()`), so the controller re-evaluates its active state once accounts are available.
+  - `#start()` is now idempotent: it returns early when accounts or chains are not yet available, and when subscriptions are already active, preventing duplicate fetches from repeated events.
+
 ## [5.0.0]
 
 ### Changed

package/dist/AssetsController.cjs

@@ -928,6 +928,16 @@ _AssetsController_isEnabled = new WeakMap(), _AssetsController_isBasicFunctional
     this.messenger.subscribe('AccountTreeController:selectedAccountGroupChange', () => {
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_handleAccountGroupChanged).call(this).catch(console.error);
     });
+    // Catch the initial tree build. On returning users,
+    // `selectedAccountGroupChange` does NOT fire when the persisted group
+    // is unchanged, and `accountTreeChange` doesn't fire either (init()
+    // rebuilds from persisted accounts without publishing it).
+    // The base-controller `:stateChange` event is guaranteed to fire
+    // when init() calls this.update(). #start() is idempotent so
+    // repeated fires are safe.
+    this.messenger.subscribe('AccountTreeController:stateChange', () => {
+        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateActive).call(this);
+    });
     // Subscribe to network enablement changes (only enabledNetworkMap)
     this.messenger.subscribe('NetworkEnablementController:stateChange', ({ enabledNetworkMap }) => {
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_handleEnabledNetworksChanged).call(this, enabledNetworkMap).catch(console.error);
@@ -1343,14 +1353,22 @@ async function _AssetsController_executeMiddlewares(sources, request, initialRes
             return 'fungible';
     }
 }, _AssetsController_start = function _AssetsController_start() {
+    const accounts = __classPrivateFieldGet(this, _AssetsController_instances, "a", _AssetsController_selectedAccounts_get);
+    const chainIds = [...__classPrivateFieldGet(this, _AssetsController_enabledChains, "f")];
+    if (accounts.length === 0 || chainIds.length === 0) {
+        return;
+    }
+    if (__classPrivateFieldGet(this, _AssetsController_activeSubscriptions, "f").size > 0) {
+        return;
+    }
     log('Starting asset tracking', {
-        selectedAccountCount: __classPrivateFieldGet(this, _AssetsController_instances, "a", _AssetsController_selectedAccounts_get).length,
-        enabledChainCount: __classPrivateFieldGet(this, _AssetsController_enabledChains, "f").size,
+        selectedAccountCount: accounts.length,
+        enabledChainCount: chainIds.length,
     });
     __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_subscribeAssets).call(this);
     __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_ensureNativeBalancesDefaultZero).call(this);
-    this.getAssets(__classPrivateFieldGet(this, _AssetsController_instances, "a", _AssetsController_selectedAccounts_get), {
-        chainIds: [...__classPrivateFieldGet(this, _AssetsController_enabledChains, "f")],
+    this.getAssets(accounts, {
+        chainIds,
         forceUpdate: true,
     }).catch((error) => {
         log('Failed to fetch assets', error);