@metamask-previews/assets-controller 4.0.0-preview-2a71f636e → 4.0.0-preview-212d43f

package/CHANGELOG.md

@@ -9,6 +9,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- `TokenDetector` now fetches the token list directly from the Tokens API (`/v3/chains/{chain}/assets`) via a new `TokensApiClient` instead of reading from `TokenListController:getState` ([#8385](https://github.com/MetaMask/core/pull/8385))
+  - `TokenDetectorMessenger` type has been removed; `TokenDetector` constructor now takes a `TokensApiClient` instance as its second argument
+  - `RpcDataSource` no longer requires `TokenListController:getState` — `GetTokenListState` has been removed from `RpcDataSourceAllowedActions` and `AssetsControllerAllowedActions`
+  - Unknown ERC-20 metadata is no longer looked up from the token list as a fallback in `RpcDataSource`; `TokenDataSource` handles enrichment downstream
+- Split `getAssets` fetch pipeline into a fast awaited path and a parallel fire-and-forget background path to reduce perceived latency on unlock and onboarding ([#8383](https://github.com/MetaMask/core/pull/8383))
+  - Fast pipeline: AccountsApi + StakedBalance → Detection → Token + Price (awaited, committed to state immediately)
+  - Background pipeline: Snap + RPC run in parallel → Detection → Token + Price (fire-and-forget, merged into state)
+- `PriceDataSource` now batches spot-price API requests in chunks of 50 using `reduceInBatchesSerially` to avoid DynamoDB batch-limit errors ([#8383](https://github.com/MetaMask/core/pull/8383))
+- `TokenDataSource` now batches token metadata API requests in chunks of 50 using `reduceInBatchesSerially` to avoid DynamoDB batch-limit errors ([#8383](https://github.com/MetaMask/core/pull/8383))
+- `PriceDataSource` filters out all synthetic `slip44:NUMBER-*` staking-position asset IDs before calling the Price API ([#8383](https://github.com/MetaMask/core/pull/8383))
+- `TokenDataSource` filters EVM ERC-20 tokens by `occurrences >= 3` and treats missing occurrences as 0 ([#8383](https://github.com/MetaMask/core/pull/8383))
 - Bump `@metamask/keyring-controller` from `^25.1.1` to `^25.2.0` ([#8363](https://github.com/MetaMask/core/pull/8363))
 - Bump `@metamask/messenger` from `^1.0.0` to `^1.1.1` ([#8364](https://github.com/MetaMask/core/pull/8364), [#8373](https://github.com/MetaMask/core/pull/8373))
 

package/dist/AssetsController.cjs

@@ -356,12 +356,19 @@ class AssetsController extends base_controller_1.BaseController {
                 forceUpdate: true,
                 assetsForPriceUpdate: options?.assetsForPriceUpdate,
             });
-            const sources = __classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)
+            // Default to 'merge' when fetching a subset of chains so we don't wipe
+            // balances from chains that weren't included in this fetch.
+            const isPartialChainFetch = options?.chainIds !== undefined &&
+                options.chainIds.length < __classPrivateFieldGet(this, _AssetsController_enabledChains, "f").size;
+            const updateMode = options?.updateMode ?? (isPartialChainFetch ? 'merge' : 'full');
+            // Fast pipeline: accountsApi + stakedBalance → detection → token + price.
+            // Snap and RPC are excluded here due to their latency (snap triggers account
+            // creation, RPC is slow on many chains). Results are committed to state
+            // immediately so the UI can display balances without waiting for them.
+            const fastSources = __classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)
                 ? [
                     (0, ParallelMiddleware_1.createParallelBalanceMiddleware)([
                         __classPrivateFieldGet(this, _AssetsController_accountsApiDataSource, "f"),
-                        __classPrivateFieldGet(this, _AssetsController_snapDataSource, "f"),
-                        __classPrivateFieldGet(this, _AssetsController_rpcDataSource, "f"),
                         __classPrivateFieldGet(this, _AssetsController_stakedBalanceDataSource, "f"),
                     ]),
                     __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f"),
@@ -370,18 +377,25 @@ class AssetsController extends base_controller_1.BaseController {
                         __classPrivateFieldGet(this, _AssetsController_priceDataSource, "f"),
                     ]),
                 ]
-                : [
-                    __classPrivateFieldGet(this, _AssetsController_rpcDataSource, "f"),
-                    __classPrivateFieldGet(this, _AssetsController_stakedBalanceDataSource, "f"),
-                    __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f"),
-                ];
-            const { response, durationByDataSource } = await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_executeMiddlewares).call(this, sources, request);
-            // Default to 'merge' when fetching a subset of chains so we don't wipe
-            // balances from chains that weren't included in this fetch.
-            const isPartialChainFetch = options?.chainIds !== undefined &&
-                options.chainIds.length < __classPrivateFieldGet(this, _AssetsController_enabledChains, "f").size;
-            const updateMode = options?.updateMode ?? (isPartialChainFetch ? 'merge' : 'full');
+                : [__classPrivateFieldGet(this, _AssetsController_stakedBalanceDataSource, "f"), __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f")];
+            const { response, durationByDataSource } = await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_executeMiddlewares).call(this, fastSources, request);
             await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateState).call(this, { ...response, updateMode });
+            // Background pipeline: snap and RPC run in parallel after the fast path
+            // commits to state. Their balances are merged together before detection
+            // and metadata/price enrichment, then merged into state.
+            const slowSources = __classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)
+                ? [__classPrivateFieldGet(this, _AssetsController_snapDataSource, "f"), __classPrivateFieldGet(this, _AssetsController_rpcDataSource, "f")]
+                : [__classPrivateFieldGet(this, _AssetsController_rpcDataSource, "f")];
+            __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_executeMiddlewares).call(this, [
+                (0, ParallelMiddleware_1.createParallelBalanceMiddleware)(slowSources),
+                __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f"),
+                (0, ParallelMiddleware_1.createParallelMiddleware)([
+                    __classPrivateFieldGet(this, _AssetsController_tokenDataSource, "f"),
+                    __classPrivateFieldGet(this, _AssetsController_priceDataSource, "f"),
+                ]),
+            ], request)
+                .then(({ response: slowResponse }) => __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateState).call(this, { ...slowResponse, updateMode: 'merge' }))
+                .catch((error) => log('Background pipeline failed', { error }));
             const durationMs = performance.now() - startTime;
             // Emit trace for every full fetch (Assets Health dashboard)
             __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_FULL_FETCH, {