@metamask-previews/assets-controller 3.1.1-preview-dbd93752f → 3.1.1-preview-55f73f6ce

package/CHANGELOG.md

@@ -10,13 +10,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - Add Sentry traces for Assets Health dashboard ([#8310](https://github.com/MetaMask/core/pull/8310))
-  - `Assets Data Source Timing` — per-source latency for each middleware in the fetch pipeline
-  - `Assets Data Source Error` — tracks middleware failures with source names and error counts
-  - `Assets Full Fetch` — end-to-end fetch timing with asset/price/chain/account counts
-  - `Assets Update Pipeline` — enrichment pipeline timing for pushed data source updates
-  - `Assets Subscription Error` — subscription failure tracking per data source
-  - `Assets State Size` — entry counts for balances, metadata, prices, and custom assets (once on app start)
-  - `Aggregated Balance Selector` — balance selector computation time with asset/network/account counts
+  - `AssetsDataSourceTiming` — per-source latency for each middleware in the fetch pipeline
+  - `AssetsDataSourceError` — tracks middleware failures with source names and error counts
+  - `AssetsFullFetch` — end-to-end fetch timing with asset/price/chain/account counts
+  - `AssetsUpdatePipeline` — enrichment pipeline timing for pushed data source updates
+  - `AssetsSubscriptionError` — subscription failure tracking per data source
+  - `AssetsStateSize` — entry counts for balances, metadata, prices, custom assets, unique assets, and network count (once on app start)
+  - `AggregatedBalanceSelector` — balance selector computation time with asset/network/account counts
   - Add optional `trace` parameter to `getAggregatedBalanceForAccount` selector
 
 ### Changed

package/dist/AssetsController.cjs

@@ -53,6 +53,16 @@ const MESSENGER_EXPOSED_METHODS = [
 ];
 /** Default polling interval hint for data sources (30 seconds) */
 const DEFAULT_POLLING_INTERVAL_MS = 30000;
+// ============================================================================
+// TRACE NAMES — used in Sentry spans (search these strings in Discover)
+// ============================================================================
+const TRACE_FIRST_INIT_FETCH = 'AssetsControllerFirstInitFetch';
+const TRACE_FULL_FETCH = 'AssetsFullFetch';
+const TRACE_DATA_SOURCE_TIMING = 'AssetsDataSourceTiming';
+const TRACE_DATA_SOURCE_ERROR = 'AssetsDataSourceError';
+const TRACE_UPDATE_PIPELINE = 'AssetsUpdatePipeline';
+const TRACE_SUBSCRIPTION_ERROR = 'AssetsSubscriptionError';
+const TRACE_STATE_SIZE = 'AssetsStateSize';
 const log = (0, logger_1.createModuleLogger)(logger_1.projectLogger, CONTROLLER_NAME);
 /**
  * Returns the default state for AssetsController.
@@ -373,7 +383,7 @@ class AssetsController extends base_controller_1.BaseController {
             await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateState).call(this, { ...response, updateMode });
             const durationMs = Date.now() - startTime;
             // Emit trace for every full fetch (Assets Health dashboard)
-            __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, 'Assets Full Fetch', {
+            __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_FULL_FETCH, {
                 duration_ms: durationMs,
                 chain_count: chainIds.length,
                 account_count: accounts.length,
@@ -388,7 +398,7 @@ class AssetsController extends base_controller_1.BaseController {
             });
             if (!__classPrivateFieldGet(this, _AssetsController_firstInitFetchReported, "f")) {
                 __classPrivateFieldSet(this, _AssetsController_firstInitFetchReported, true, "f");
-                __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, 'AssetsController First Init Fetch', {
+                __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_FIRST_INIT_FETCH, {
                     duration_ms: durationMs,
                     chain_ids: JSON.stringify(chainIds),
                     ...durationByDataSource,
@@ -738,7 +748,7 @@ class AssetsController extends base_controller_1.BaseController {
             dataTypes: ['balance', 'metadata', 'price'],
         }, response);
         await __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_updateState).call(this, enrichedResponse);
-        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, 'Assets Update Pipeline', {
+        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_UPDATE_PIPELINE, {
             source: sourceId,
             duration_ms: Date.now() - updateStart,
             has_balance: Boolean(response.assetsBalance),
@@ -804,9 +814,21 @@ _AssetsController_isEnabled = new WeakMap(), _AssetsController_isBasicFunctional
     }
     __classPrivateFieldSet(this, _AssetsController_stateSizeReported, true, "f");
     const { assetsBalance: balances, customAssets, assetsInfo, assetsPrice, } = this.state;
+    // Count balance entries and collect unique asset IDs / chain IDs in one pass.
     let balanceEntries = 0;
+    const uniqueAssets = new Set();
+    const uniqueNetworks = new Set();
     for (const acct of Object.values(balances)) {
-        balanceEntries += Object.keys(acct).length;
+        const assetIds = Object.keys(acct);
+        balanceEntries += assetIds.length;
+        for (const assetId of assetIds) {
+            uniqueAssets.add(assetId);
+            // CAIP-19 format: "eip155:1/slip44:60" — chainId is everything before "/"
+            const slash = assetId.indexOf('/');
+            if (slash > 0) {
+                uniqueNetworks.add(assetId.slice(0, slash));
+            }
+        }
     }
     let customAssetEntries = 0;
     for (const ids of Object.values(customAssets)) {
@@ -814,9 +836,11 @@ _AssetsController_isEnabled = new WeakMap(), _AssetsController_isBasicFunctional
             customAssetEntries += ids.length;
         }
     }
-    __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, 'Assets State Size', {
+    __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_STATE_SIZE, {
         balance_entries: balanceEntries,
         balance_accounts: Object.keys(balances).length,
+        unique_asset_count: uniqueAssets.size,
+        network_count: uniqueNetworks.size,
         metadata_entries: Object.keys(assetsInfo).length,
         price_entries: Object.keys(assetsPrice).length,
         custom_asset_entries: customAssetEntries,
@@ -984,7 +1008,7 @@ async function _AssetsController_executeMiddlewares(sources, request, initialRes
     }
     // Emit per-source timing traces for the Assets Health dashboard
     for (const [sourceName, durationMs] of Object.entries(durationByDataSource)) {
-        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, 'Assets Data Source Timing', {
+        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_DATA_SOURCE_TIMING, {
             source: sourceName,
             duration_ms: durationMs,
             chain_count: request.chainIds.length,
@@ -993,7 +1017,7 @@ async function _AssetsController_executeMiddlewares(sources, request, initialRes
     }
     // Emit error traces for failed middlewares
     if (middlewareErrors.length > 0) {
-        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, 'Assets Data Source Error', {
+        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_DATA_SOURCE_ERROR, {
             failed_sources: middlewareErrors.join(','),
             error_count: middlewareErrors.length,
             chain_count: request.chainIds.length,
@@ -1405,7 +1429,7 @@ async function _AssetsController_executeMiddlewares(sources, request, initialRes
     };
     source.subscribe(subscribeReq).catch((error) => {
         console.error(`[AssetsController] Failed to subscribe to '${sourceId}':`, error);
-        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, 'Assets Subscription Error', {
+        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_emitTrace).call(this, TRACE_SUBSCRIPTION_ERROR, {
             source: sourceId,
             error_message: String(error),
         });