@metamask-previews/assets-controller 13.1.1-preview-613132754 → 13.1.1-preview-e57e5c3dc

package/CHANGELOG.md

@@ -9,19 +9,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
-- Bump `@metamask/transaction-controller` from `^69.5.0` to `^69.5.1` ([#9798](https://github.com/MetaMask/core/pull/9798))
 - Bump `@metamask/account-tree-controller` from `^7.6.0` to `^7.6.1` ([#9791](https://github.com/MetaMask/core/pull/9791))
 - Bump `@metamask/accounts-controller` from `^39.0.6` to `^39.0.7` ([#9791](https://github.com/MetaMask/core/pull/9791))
 - Bump `@metamask/keyring-controller` from `^27.1.0` to `^27.1.1` ([#9791](https://github.com/MetaMask/core/pull/9791))
 - Bump `@metamask/network-enablement-controller` from `^6.0.2` to `^6.0.3` ([#9791](https://github.com/MetaMask/core/pull/9791))
 - Bump `@metamask/assets-controllers` from `^111.0.0` to `^111.1.0` ([#9793](https://github.com/MetaMask/core/pull/9793))
 
-### Fixed
-
-- Apply occurrence-floor spam filtering to tokens received through account-activity (websocket) updates: new tokens are enriched with Token API occurrence counts before detection and dropped when below the per-chain suggested floor, and stub metadata of filtered-out assets is stripped from the pipeline response so spam tokens never persist to state ([#9803](https://github.com/MetaMask/core/pull/9803))
-- Checksum the lower-case ERC-20 asset IDs delivered by `AccountActivityDataSource` before they enter the assets pipeline, so middleware comparisons against state (which keys assets by checksummed ID) no longer treat an existing holding as a brand-new asset — previously such balance updates could be re-detected, or dropped entirely by spam filtering, and never reach state ([#9803](https://github.com/MetaMask/core/pull/9803))
-- Preserve pooled-staking balances across Accounts API chain-slice updates (e.g. network switch / `replaceCoveredChainBalances`): exclude staking contract asset IDs from `AccountsApiDataSource` v5/v6 balance processing, and keep prior staked amounts when a merge replace omits them so Accounts API cannot reset staked ETH to missing/0 ([#9753](https://github.com/MetaMask/core/pull/9753))
-
 ## [13.1.1]
 
 ### Changed

package/dist/AssetsController.cjs

@@ -24,7 +24,6 @@ const bignumber_js_1 = __importDefault(require("bignumber.js"));
 const lodash_1 = require("lodash");
 const AccountActivityDataSource_js_1 = require("./data-sources/AccountActivityDataSource.cjs");
 const AccountsApiDataSource_js_1 = require("./data-sources/AccountsApiDataSource.cjs");
-const index_js_1 = require("./data-sources/evm-rpc-services/index.cjs");
 const assets_js_1 = require("./data-sources/evm-rpc-services/utils/assets.cjs");
 const PriceDataSource_js_1 = require("./data-sources/PriceDataSource.cjs");
 const RpcDataSource_js_1 = require("./data-sources/RpcDataSource.cjs");
@@ -41,7 +40,7 @@ const RpcFallbackMiddleware_js_1 = require("./middlewares/RpcFallbackMiddleware.
 const healAssetsInfoMetadata_js_1 = require("./migrations/healAssetsInfoMetadata.cjs");
 const constants_js_1 = require("./utils/constants.cjs");
 const customAssetsRpcSupplement_js_1 = require("./utils/customAssetsRpcSupplement.cjs");
-const index_js_2 = require("./utils/index.cjs");
+const index_js_1 = require("./utils/index.cjs");
 const trace_js_1 = require("./utils/trace.cjs");
 const NATIVE_ASSETS_QUERY_KEY = ['nativeAssets'];
 /** Stable empty map so memoized formatters are not busted by `?? {}` identity churn. */
@@ -170,14 +169,14 @@ function normalizeResponse(response) {
     if (response.assetsInfo) {
         normalized.assetsInfo = {};
         for (const [assetId, metadata] of Object.entries(response.assetsInfo)) {
-            const normalizedId = (0, index_js_2.normalizeAssetId)(assetId);
+            const normalizedId = (0, index_js_1.normalizeAssetId)(assetId);
             normalized.assetsInfo[normalizedId] = metadata;
         }
     }
     if (response.assetsPrice) {
         normalized.assetsPrice = {};
         for (const [assetId, price] of Object.entries(response.assetsPrice)) {
-            const normalizedId = (0, index_js_2.normalizeAssetId)(assetId);
+            const normalizedId = (0, index_js_1.normalizeAssetId)(assetId);
             normalized.assetsPrice[normalizedId] = price;
         }
     }
@@ -186,7 +185,7 @@ function normalizeResponse(response) {
         for (const [accountId, balances] of Object.entries(response.assetsBalance)) {
             normalized.assetsBalance[accountId] = {};
             for (const [assetId, balance] of Object.entries(balances)) {
-                const normalizedId = (0, index_js_2.normalizeAssetId)(assetId);
+                const normalizedId = (0, index_js_1.normalizeAssetId)(assetId);
                 normalized.assetsBalance[accountId][normalizedId] = balance;
             }
         }
@@ -195,7 +194,7 @@ function normalizeResponse(response) {
     if (response.detectedAssets) {
         normalized.detectedAssets = {};
         for (const [accountId, assetIds] of Object.entries(response.detectedAssets)) {
-            normalized.detectedAssets[accountId] = assetIds.map((assetId) => (0, index_js_2.normalizeAssetId)(assetId));
+            normalized.detectedAssets[accountId] = assetIds.map((assetId) => (0, index_js_1.normalizeAssetId)(assetId));
         }
     }
     // Preserve errors (chain IDs don't need normalization)
@@ -238,15 +237,6 @@ function mergeAccountBalances(previousBalances, accountBalances, customAssetIds,
             next[customId] = prev ?? { amount: '0' };
         }
     }
-    // Staked vault balances are owned by StakedBalanceDataSource. When an
-    // Accounts API (or other) chain-slice replace omits them, keep the prior
-    // on-chain staked amount instead of clearing it to missing/0.
-    for (const [assetId, balance] of Object.entries(previousBalances)) {
-        if ((0, index_js_1.isStakingContractAssetId)(assetId) &&
-            !Object.prototype.hasOwnProperty.call(next, assetId)) {
-            next[assetId] = balance;
-        }
-    }
     return next;
 }
 // ============================================================================
@@ -756,7 +746,7 @@ class AssetsController extends base_controller_1.BaseController {
      */
     getExchangeRatesForBridge() {
         const { networkConfigurationsByChainId } = this.messenger.call('NetworkController:getState');
-        return (0, index_js_2.formatExchangeRatesForBridge)({
+        return (0, index_js_1.formatExchangeRatesForBridge)({
             assetsInfo: this.state.assetsInfo,
             assetsPrice: this.state.assetsPrice,
             selectedCurrency: this.state.selectedCurrency,
@@ -776,7 +766,7 @@ class AssetsController extends base_controller_1.BaseController {
     getStateForTransactionPay() {
         const accounts = __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_getSelectedAccounts).call(this);
         const { networkConfigurationsByChainId } = this.messenger.call('NetworkController:getState');
-        return (0, index_js_2.formatStateForTransactionPay)({
+        return (0, index_js_1.formatStateForTransactionPay)({
             assetsBalance: this.state.assetsBalance,
             assetsInfo: this.state.assetsInfo,
             assetsPrice: this.state.assetsPrice,
@@ -803,7 +793,7 @@ class AssetsController extends base_controller_1.BaseController {
      * @param pendingMetadata - Optional token metadata from the UI (pendingTokens format).
      */
     async addCustomAsset(accountId, assetId, pendingMetadata) {
-        const normalizedAssetId = (0, index_js_2.normalizeAssetId)(assetId);
+        const normalizedAssetId = (0, index_js_1.normalizeAssetId)(assetId);
         log('Adding custom asset', { accountId, assetId: normalizedAssetId });
         this.update((state) => {
             var _a;
@@ -875,7 +865,7 @@ class AssetsController extends base_controller_1.BaseController {
      * @param assetId - The CAIP-19 asset ID to remove.
      */
     removeCustomAsset(accountId, assetId) {
-        const normalizedAssetId = (0, index_js_2.normalizeAssetId)(assetId);
+        const normalizedAssetId = (0, index_js_1.normalizeAssetId)(assetId);
         log('Removing custom asset', { accountId, assetId: normalizedAssetId });
         this.update((state) => {
             if (state.customAssets[accountId]) {
@@ -910,7 +900,7 @@ class AssetsController extends base_controller_1.BaseController {
      * @param assetId - The CAIP-19 asset ID to hide.
      */
     hideAsset(assetId) {
-        const normalizedAssetId = (0, index_js_2.normalizeAssetId)(assetId);
+        const normalizedAssetId = (0, index_js_1.normalizeAssetId)(assetId);
         log('Hiding asset', { assetId: normalizedAssetId });
         this.update((state) => {
             if (!state.assetPreferences[normalizedAssetId]) {
@@ -925,7 +915,7 @@ class AssetsController extends base_controller_1.BaseController {
      * @param assetId - The CAIP-19 asset ID to unhide.
      */
     unhideAsset(assetId) {
-        const normalizedAssetId = (0, index_js_2.normalizeAssetId)(assetId);
+        const normalizedAssetId = (0, index_js_1.normalizeAssetId)(assetId);
         log('Unhiding asset', { assetId: normalizedAssetId });
         this.update((state) => {
             const prefs = state.assetPreferences[normalizedAssetId];
@@ -1086,23 +1076,10 @@ class AssetsController extends base_controller_1.BaseController {
                 // those.
                 const shouldGraduateCustomAssets = sourceId === 'AccountsApiDataSource' ||
                     sourceId === 'AccountActivityDataSource';
-                // Websocket updates can carry brand-new spam airdrops: enrich them
-                // with Token API occurrences and drop below-floor tokens BEFORE
-                // detection, so spam is never detected, enriched, priced or persisted.
-                const shouldFilterOccurrences = sourceId === 'AccountActivityDataSource' &&
-                    __classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this);
                 const enrichmentSources = [
                     ...(shouldGraduateCustomAssets
                         ? [__classPrivateFieldGet(this, _AssetsController_customAssetGraduationMiddleware, "f")]
                         : []),
-                    ...(shouldFilterOccurrences
-                        ? [
-                            {
-                                getName: () => 'OccurrenceFloorFilter',
-                                assetsMiddleware: __classPrivateFieldGet(this, _AssetsController_tokenDataSource, "f").occurrenceFilterMiddleware,
-                            },
-                        ]
-                        : []),
                     __classPrivateFieldGet(this, _AssetsController_detectionMiddleware, "f"),
                 ];
                 if (__classPrivateFieldGet(this, _AssetsController_isBasicFunctionality, "f").call(this)) {
@@ -1244,7 +1221,7 @@ _AssetsController_isEnabled = new WeakMap(), _AssetsController_isBasicFunctional
     queryApiClient.queryClient
         .fetchQuery({
         queryKey: NATIVE_ASSETS_QUERY_KEY,
-        queryFn: index_js_2.buildNativeAssetsFromApi,
+        queryFn: index_js_1.buildNativeAssetsFromApi,
         staleTime: Infinity,
         gcTime: Infinity,
     })
@@ -1257,7 +1234,7 @@ _AssetsController_isEnabled = new WeakMap(), _AssetsController_isBasicFunctional
     // #isNativeAsset, #resolveNativeAssetIds) have data available immediately.
     // When fetchQuery resolves (currently instant, future: API), it overwrites
     // this with potentially fresher data.
-    const initialNativeAssetMap = (0, index_js_2.buildNativeAssetsFromConstant)();
+    const initialNativeAssetMap = (0, index_js_1.buildNativeAssetsFromConstant)();
     queryApiClient.setCachedData(NATIVE_ASSETS_QUERY_KEY, initialNativeAssetMap);
 }, _AssetsController_initializeState = function _AssetsController_initializeState() {
     const { enabledNetworkMap } = this.messenger.call('NetworkEnablementController:getState');
@@ -1627,7 +1604,7 @@ async function _AssetsController_executeMiddlewares(params) {
     }
 }, _AssetsController_normalizeAssetIdOrThrow = function _AssetsController_normalizeAssetIdOrThrow(assetId, methodName) {
     try {
-        return (0, index_js_2.normalizeAssetId)(assetId);
+        return (0, index_js_1.normalizeAssetId)(assetId);
     }
     catch {
         throw new Error(`AssetsController.${methodName}: invalid CAIP-19 assetId "${assetId}"`);
@@ -1648,7 +1625,7 @@ async function _AssetsController_executeMiddlewares(params) {
             if (!chainFilter.has(assetId.split('/')[0])) {
                 continue;
             }
-            const normalizedAssetId = (0, index_js_2.normalizeAssetId)(assetId);
+            const normalizedAssetId = (0, index_js_1.normalizeAssetId)(assetId);
             if (prices[normalizedAssetId] ?? prices[assetId]) {
                 continue;
             }
@@ -1879,7 +1856,7 @@ async function _AssetsController_executeMiddlewares(params) {
                         // exponent form is rewritten) so balances arriving before
                         // their metadata aren't lossily truncated.
                         const assetDecimals = metadata[assetId]?.decimals;
-                        const newAmount = (0, index_js_2.normalizeAmountString)(balance.amount, assetDecimals);
+                        const newAmount = (0, index_js_1.normalizeAmountString)(balance.amount, assetDecimals);
                         effective[assetId] = { ...balance, amount: newAmount };
                         const oldAmount = previousBalance?.amount;
                         const isNewDefaultNativeZero = oldAmount === undefined &&