@metamask-previews/assets-controller 10.0.2-preview-4c12f04 → 10.1.0-preview-d52465c2b

package/CHANGELOG.md

@@ -7,12 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [10.0.2]
+## [10.1.0]
+
+### Added
+
+- Add temporary `tempMigrateAssetsInfoMetadataAssets3346` constructor option that heals `assetsInfo` metadata (and custom-asset tracking) wiped by a prior defect for tokens on niche EVM chains, using legacy `TokensController` state provided by the host ([#9393](https://github.com/MetaMask/core/pull/9393))
 
 ### Changed
 
-- Bump `@metamask/network-enablement-controller` from `^5.4.1` to `^5.4.2` ([#9383](https://github.com/MetaMask/core/pull/9383))
-- Bump `@metamask/assets-controllers` from `^109.3.0` to `^109.3.1` ([#9383](https://github.com/MetaMask/core/pull/9383))
+- Bump `@metamask/messenger` from `^1.2.0` to `^2.0.0` ([#9392](https://github.com/MetaMask/core/pull/9392))
+
+### Fixed
+
+- Fetch balances when switching account groups, enabling RPC-only networks, or after a new account is added to the account tree ([#9388](https://github.com/MetaMask/core/pull/9388))
 
 ## [10.0.1]
 
@@ -690,8 +697,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Refactor `RpcDataSource` to delegate polling to `BalanceFetcher` and `TokenDetector` services ([#7709](https://github.com/MetaMask/core/pull/7709))
 - Refactor `BalanceFetcher` and `TokenDetector` to extend `StaticIntervalPollingControllerOnly` for independent polling management ([#7709](https://github.com/MetaMask/core/pull/7709))
 
-[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@10.0.2...HEAD
-[10.0.2]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@10.0.1...@metamask/assets-controller@10.0.2
+[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@10.1.0...HEAD
+[10.1.0]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@10.0.1...@metamask/assets-controller@10.1.0
 [10.0.1]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@10.0.0...@metamask/assets-controller@10.0.1
 [10.0.0]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@9.1.0...@metamask/assets-controller@10.0.0
 [9.1.0]: https://github.com/MetaMask/core/compare/@metamask/assets-controller@9.0.2...@metamask/assets-controller@9.1.0

package/dist/AssetsController.cjs

@@ -37,6 +37,7 @@ const CustomAssetGraduationMiddleware_1 = require("./middlewares/CustomAssetGrad
 const DetectionMiddleware_1 = require("./middlewares/DetectionMiddleware.cjs");
 const ParallelMiddleware_1 = require("./middlewares/ParallelMiddleware.cjs");
 const RpcFallbackMiddleware_1 = require("./middlewares/RpcFallbackMiddleware.cjs");
+const healAssetsInfoMetadata_1 = require("./migrations/healAssetsInfoMetadata.cjs");
 const utils_2 = require("./utils/index.cjs");
 const constants_1 = require("./utils/constants.cjs");
 const customAssetsRpcSupplement_1 = require("./utils/customAssetsRpcSupplement.cjs");
@@ -259,7 +260,7 @@ function mergeAccountBalances(previousBalances, accountBalances, customAssetIds,
  * - The controller does NOT manage polling - it simply receives pushed updates
  */
 class AssetsController extends base_controller_1.BaseController {
-    constructor({ messenger, state = {}, defaultUpdateInterval = DEFAULT_POLLING_INTERVAL_MS, isEnabled = () => true, isBasicFunctionality, subscribeToBasicFunctionalityChange, queryApiClient, rpcDataSourceConfig, trace, captureException, accountsApiDataSourceConfig, priceDataSourceConfig, stakedBalanceDataSourceConfig, isOnboarded, }) {
+    constructor({ messenger, state = {}, defaultUpdateInterval = DEFAULT_POLLING_INTERVAL_MS, isEnabled = () => true, isBasicFunctionality, subscribeToBasicFunctionalityChange, queryApiClient, rpcDataSourceConfig, trace, captureException, accountsApiDataSourceConfig, priceDataSourceConfig, stakedBalanceDataSourceConfig, isOnboarded, tempMigrateAssetsInfoMetadataAssets3346, }) {
         super({
             name: CONTROLLER_NAME,
             messenger,
@@ -326,6 +327,15 @@ class AssetsController extends base_controller_1.BaseController {
         __classPrivateFieldSet(this, _AssetsController_captureException, captureException, "f");
         __classPrivateFieldSet(this, _AssetsController_queryApiClient, queryApiClient, "f");
         const rpcConfig = rpcDataSourceConfig ?? {};
+        // TEMPORARY: heal assetsInfo metadata wiped by a prior defect
+        // (see extension migration #215 / ASSETS-3346). Remove in a future release.
+        if (tempMigrateAssetsInfoMetadataAssets3346) {
+            this.update(() => (0, healAssetsInfoMetadata_1.tempHealAssetsInfoMetadata)({
+                state: this.state,
+                getMigrationState: tempMigrateAssetsInfoMetadataAssets3346,
+                captureException,
+            }));
+        }
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_initializeNativeAssetsMap).call(this, queryApiClient);
         __classPrivateFieldSet(this, _AssetsController_onActiveChainsUpdated, (dataSourceName, chains, previousChains) => {
             try {
@@ -1237,17 +1247,18 @@ _AssetsController_isEnabled = new WeakMap(), _AssetsController_isBasicFunctional
             previousCount: __classPrivateFieldGet(this, _AssetsController_lastKnownAccountIds, "f").size,
             currentCount: currentIds.size,
         });
+        const newAccounts = accounts.filter((account) => !__classPrivateFieldGet(this, _AssetsController_lastKnownAccountIds, "f").has(account.id));
         __classPrivateFieldSet(this, _AssetsController_lastKnownAccountIds, currentIds, "f");
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_ensureNativeBalancesDefaultZero).call(this);
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_ensureDefaultTrackedAssetsSeeded).call(this);
-        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_runAccountTreeRefresh).call(this, accounts).catch((error) => {
+        __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_runAccountTreeRefresh).call(this, accounts, newAccounts).catch((error) => {
             log('Failed to refresh assets after tree change', error);
         });
     }
     else {
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_start).call(this);
     }
-}, _AssetsController_runAccountTreeRefresh = async function _AssetsController_runAccountTreeRefresh(accounts) {
+}, _AssetsController_runAccountTreeRefresh = async function _AssetsController_runAccountTreeRefresh(accounts, newAccounts = []) {
     const releaseLock = await __classPrivateFieldGet(this, _AssetsController_accountRefreshMutex, "f").acquire();
     try {
         await this.getAssets(accounts, {
@@ -1255,6 +1266,12 @@ _AssetsController_isEnabled = new WeakMap(), _AssetsController_isBasicFunctional
             forceUpdate: true,
         });
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_subscribeAssets).call(this);
+        if (newAccounts.length > 0) {
+            await this.getAssets(newAccounts, {
+                chainIds: [...__classPrivateFieldGet(this, _AssetsController_enabledChains, "f")],
+                forceUpdate: true,
+            });
+        }
     }
     catch (error) {
         log('Failed to fetch assets after tree change', error);
@@ -2090,19 +2107,25 @@ async function _AssetsController_executeMiddlewares(sources, request, initialRes
 // EVENT HANDLERS
 // ============================================================================
 async function _AssetsController_handleAccountGroupChanged() {
+    const gutoStart = Date.now();
+    console.log('[GUTO PERFORMANCE LOG] AssetsController.#handleAccountGroupChanged START');
     const accounts = __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_getSelectedAccounts).call(this);
     log('Account group changed', {
         accountCount: accounts.length,
         accountIds: accounts.map((a) => a.id),
     });
     __classPrivateFieldSet(this, _AssetsController_lastKnownAccountIds, new Set(accounts.map((a) => a.id)), "f");
+    const gutoMutexStart = Date.now();
     const releaseLock = await __classPrivateFieldGet(this, _AssetsController_accountRefreshMutex, "f").acquire();
+    console.log(`[GUTO PERFORMANCE LOG] AssetsController accountRefreshMutex wait took ${Date.now() - gutoMutexStart}ms`);
     try {
         if (accounts.length > 0) {
+            const gutoGetAssetsStart = Date.now();
             await this.getAssets(accounts, {
                 chainIds: [...__classPrivateFieldGet(this, _AssetsController_enabledChains, "f")],
                 forceUpdate: true,
             });
+            console.log(`[GUTO PERFORMANCE LOG] AssetsController.getAssets (accounts=${accounts.length}, chains=${__classPrivateFieldGet(this, _AssetsController_enabledChains, "f").size}) took ${Date.now() - gutoGetAssetsStart}ms`);
         }
         // Subscribe after fetch so WS notifications can recover state
         __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_subscribeAssets).call(this);
@@ -2112,6 +2135,7 @@ async function _AssetsController_handleAccountGroupChanged() {
     finally {
         releaseLock();
     }
+    console.log(`[GUTO PERFORMANCE LOG] AssetsController.#handleAccountGroupChanged END (total) took ${Date.now() - gutoStart}ms`);
 }, _AssetsController_handleEnabledNetworksChanged = async function _AssetsController_handleEnabledNetworksChanged(enabledNetworkMap) {
     const previousChains = __classPrivateFieldGet(this, _AssetsController_enabledChains, "f");
     __classPrivateFieldSet(this, _AssetsController_enabledChains, __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_extractEnabledChains).call(this, enabledNetworkMap), "f");
@@ -2141,8 +2165,9 @@ async function _AssetsController_handleAccountGroupChanged() {
     // Refresh subscriptions for new chain set
     __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_subscribeAssets).call(this);
     // Do one-time fetch for newly enabled chains; merge so we keep existing chain balances
-    if (addedChains.length > 0 && __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_getSelectedAccounts).call(this).length > 0) {
-        await this.getAssets(__classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_getSelectedAccounts).call(this), {
+    const accounts = __classPrivateFieldGet(this, _AssetsController_instances, "m", _AssetsController_getSelectedAccounts).call(this);
+    if (addedChains.length > 0 && accounts.length > 0) {
+        await this.getAssets(accounts, {
             chainIds: addedChains,
             forceUpdate: true,
             updateMode: 'merge',