@mestreyoda/fabrica 0.2.7 → 0.2.9

package/defaults/fabrica/prompts/reviewer.md

@@ -91,49 +91,31 @@ If you discover unrelated bugs or needed improvements, call `task_create`:
 
 ## Completing Your Task
 
-When you are done, submit your review using **Method A** if the tools are available, or **Method B** otherwise.
-
-### Method A — Fabrica tools (preferred)
-
-1. Call `review_submit` to write the review artifact to the PR:
-   - **Approve:** `review_submit({ channelId: "<project slug>", issueId: <issue number>, result: "approve", body: "<what you checked>" })`
-   - **Reject:** `review_submit({ channelId: "<project slug>", issueId: <issue number>, result: "reject", body: "<specific issues>" })`
-   - Capture the returned `artifactId` and `artifactType`.
-2. Then call `work_finish`:
-   - **Approve:** `work_finish({ role: "reviewer", result: "approve", channelId: "<project slug>", summary: "<what you checked>", reviewArtifactId: <artifactId>, reviewArtifactType: "<artifactType>" })`
-   - **Reject:** `work_finish({ role: "reviewer", result: "reject", channelId: "<project slug>", summary: "<specific issues>", reviewArtifactId: <artifactId>, reviewArtifactType: "<artifactType>" })`
-   - **Blocked:** `work_finish({ role: "reviewer", result: "blocked", channelId: "<project slug>", summary: "<what you need>" })`
-
-> **IMPORTANT:** The `channelId` parameter accepts the project slug (e.g., "gestao-notas").
-> Extract it from the "Project: <name>" line in your task message. Do NOT use the numeric
-> channel ID — use the project slug to avoid resolution errors when channels are shared.
-
-### Method B — GitHub CLI fallback (use only if `review_submit` / `work_finish` are unavailable)
-
-Extract from your task message:
-- `OWNER/REPO` from the `Repo:` line
-- `PR_NUMBER` from the PR URL in the diff header or the `Branch:` line
-- `ISSUE_NUMBER` from the `Issue:` field
-
-**Approve:**
-```bash
-gh pr review PR_NUMBER --repo OWNER/REPO --approve -b "$(cat <<'EOF'
-<your full review body here>
-EOF
-)"
-```
+After writing your review, you **MUST** output your final decision on a dedicated line in **exactly** one of these two formats:
 
-**Reject (request changes):**
-```bash
-gh pr review PR_NUMBER --repo OWNER/REPO --request-changes -b "$(cat <<'EOF'
-<specific issues and how to fix them>
-EOF
-)"
 ```
+Review result: APPROVE
+```
+```
+Review result: REJECT
+```
+
+The Fabrica orchestrator reads your session output and advances the pipeline automatically based on this line. **You do not need to call any tool or run any CLI command.** Just output the line above and your work is done.
+
+- Output `Review result: APPROVE` if all quality gates pass and the code is ready to proceed.
+- Output `Review result: REJECT` if any blocking issue was found that the developer must fix.
 
-After submitting via `gh pr review`, the Fabrica heartbeat will detect the PR review state and advance the pipeline automatically. **Do NOT manually edit issue labels.**
+> **IMPORTANT:** The decision line must appear in your response text, not inside a code block. It is case-insensitive but must follow the `Review result: APPROVE/REJECT` format exactly.
+
+### Optional: submit PR comment (best-effort)
+
+If `gh` is available and the PR author is not the same GitHub account you are logged in as, you may optionally leave a PR comment for visibility:
+
+```
+gh pr comment <PR_NUMBER> --repo <OWNER/REPO> --body "<summary of your findings>"
+```
 
-**Never call `task_comment` for review findings.** Your review must be posted on the PR itself.
+This is informational only — the orchestrator does not require it to advance the pipeline.
 
 ## Tools You Should NOT Use
 

package/dist/index.js

@@ -111330,8 +111330,8 @@ import fsSync from "node:fs";
 import path5 from "node:path";
 import { fileURLToPath as fileURLToPath3 } from "node:url";
 function getCurrentVersion() {
-  if ("0.2.7") {
-    return "0.2.7";
+  if ("0.2.9") {
+    return "0.2.9";
   }
   try {
     const pkgPath = path5.join(THIS_DIR, "..", "..", "package.json");
@@ -139562,6 +139562,36 @@ function registerReactiveDispatchHooks(api, ctx) {
 
 // lib/dispatch/subagent-lifecycle-hook.ts
 init_workflow();
+init_labels();
+async function parseReviewerSessionResult(ctx, sessionKey) {
+  try {
+    const messagesResult = await ctx.runtime.subagent?.getSessionMessages?.({ sessionKey });
+    if (!messagesResult) return null;
+    const messages = Array.isArray(messagesResult) ? messagesResult : Array.isArray(messagesResult?.messages) ? messagesResult.messages : [];
+    const assistantTexts = messages.filter((m2) => m2.role === "assistant").map((m2) => {
+      const raw = m2.content;
+      if (typeof raw === "string") return raw;
+      if (Array.isArray(raw)) {
+        return raw.find((b) => b.type === "text")?.text ?? "";
+      }
+      return "";
+    }).filter(Boolean).reverse();
+    for (const text of assistantTexts) {
+      const lower2 = text.toLowerCase();
+      if (/review\s+result\s*:\s*approve/i.test(text)) return "approve";
+      if (/review\s+result\s*:\s*reject/i.test(text)) return "reject";
+      if (/\*\*approved\*\*/i.test(text)) return "approve";
+      if (/\*\*rejected\*\*/i.test(text)) return "reject";
+      const approveMatch = lower2.match(/\b(approve|approved|lgtm|looks good)\b/);
+      const rejectMatch = lower2.match(/\b(reject|rejected|request[s]?\s+changes?|changes\s+requested)\b/);
+      if (approveMatch && !rejectMatch) return "approve";
+      if (rejectMatch && !approveMatch) return "reject";
+    }
+    return null;
+  } catch {
+    return null;
+  }
+}
 function registerSubagentLifecycleHook(api, ctx) {
   const workspaceDir = resolveWorkspaceDir(ctx.config);
   if (!workspaceDir) return;
@@ -139625,7 +139655,42 @@ function registerSubagentLifecycleHook(api, ctx) {
             runCommand: ctx.runCommand
           });
           const issue2 = await provider.getIssue(Number(issueId));
-          if (issue2.labels.includes(activeLabel)) {
+          if (!issue2.labels.includes(activeLabel)) {
+          } else if (role === "reviewer") {
+            const reviewResult = await parseReviewerSessionResult(ctx, sessionKey);
+            if (reviewResult === "approve" || reviewResult === "reject") {
+              const reviewingState = findStateByLabel(config2.workflow, activeLabel);
+              const eventKey = reviewResult === "approve" ? WorkflowEvent.APPROVED : WorkflowEvent.CHANGES_REQUESTED;
+              const transition2 = reviewingState?.on?.[eventKey];
+              const targetKey = typeof transition2 === "string" ? transition2 : transition2?.target;
+              const targetState = targetKey ? config2.workflow.states[targetKey] : void 0;
+              if (targetState) {
+                await resilientLabelTransition(provider, Number(issueId), activeLabel, targetState.label);
+                await log(workspaceDir, "reviewer_session_transition", {
+                  sessionKey,
+                  project: projectName,
+                  issueId,
+                  result: reviewResult,
+                  from: activeLabel,
+                  to: targetState.label
+                }).catch(() => {
+                });
+                ctx.logger.info(
+                  `reviewer_session_transition: issue #${issueId} \u2192 ${targetState.label} (result=${reviewResult})`
+                );
+              } else {
+                await provider.transitionLabel(Number(issueId), activeLabel, revertLabel);
+              }
+            } else {
+              await provider.transitionLabel(Number(issueId), activeLabel, revertLabel);
+              await log(workspaceDir, "reviewer_session_no_result", {
+                sessionKey,
+                project: projectName,
+                issueId
+              }).catch(() => {
+              });
+            }
+          } else {
             await provider.transitionLabel(Number(issueId), activeLabel, revertLabel);
           }
         } catch {