@meshconnect/uwc-core 1.0.3 → 1.1.0

package/src/universal-wallet-connector.test.ts

@@ -65,7 +65,8 @@ const mockSignatureService = {
 }
 
 const mockTransactionService = {
-  sendTransaction: vi.fn()
+  sendTransaction: vi.fn(),
+  signSolanaTransactionBytes: vi.fn()
 }
 
 // Mock the dependencies
@@ -513,16 +514,24 @@ describe('UniversalWalletConnector', () => {
 
   describe('error handling', () => {
     it('should handle signMessage errors gracefully', async () => {
+      // Validation lives in the (mocked-out) SignatureService now, so drive the
+      // failure from the service and assert the facade propagates it.
+      mockSignatureService.signMessage.mockRejectedValueOnce(
+        new Error('No active wallet')
+      )
       const connector = new UniversalWalletConnector(mockNetworks, mockWallets)
 
-      // This should not throw an error, but should handle the case where session manager is not properly mocked
-      await expect(connector.signMessage('test')).rejects.toThrow()
+      await expect(connector.signMessage('test')).rejects.toThrow(
+        'No active wallet'
+      )
     })
 
     it('should handle sendTransaction errors gracefully', async () => {
+      mockTransactionService.sendTransaction.mockRejectedValueOnce(
+        new Error('No active wallet')
+      )
       const connector = new UniversalWalletConnector(mockNetworks, mockWallets)
 
-      // This should not throw an error, but should handle the case where session manager is not properly mocked
       await expect(
         connector.sendTransaction({
           to: '0x123',
@@ -656,162 +665,34 @@ describe('UniversalWalletConnector', () => {
   })
 
   describe('signSolanaTransaction', () => {
-    const SERIALIZED_TX = new Uint8Array([1, 2, 3, 4, 5])
-    const SIGNED_TX = new Uint8Array([6, 7, 8, 9, 10])
-
-    it('throws "No active wallet" when session has no activeWallet', async () => {
-      mockSessionManager.getSession.mockReturnValue({
-        connectionMode: 'injected',
-        activeWallet: null,
-        activeNetwork: null,
-        activeAddress: null,
-        availableNetworks: [],
-        availableAddresses: [],
-        activeWalletCapabilities: null
-      })
-      const uwc = new UniversalWalletConnector(mockNetworks, mockWallets)
-
-      await expect(uwc.signSolanaTransaction(SERIALIZED_TX)).rejects.toThrow(
-        'No active wallet'
-      )
-    })
-
-    it('throws "No active connection" when session has no connectionMode', async () => {
-      mockSessionManager.getSession.mockReturnValue({
-        connectionMode: null,
-        activeWallet: mockWallets[0],
-        activeNetwork: null,
-        activeAddress: null,
-        availableNetworks: [],
-        availableAddresses: [],
-        activeWalletCapabilities: null
-      })
-      const uwc = new UniversalWalletConnector(mockNetworks, mockWallets)
-
-      await expect(uwc.signSolanaTransaction(SERIALIZED_TX)).rejects.toThrow(
-        'No active connection'
-      )
-    })
-
-    it('throws "not supported" when the active connector lacks signSolanaTransactionBytes (tonConnect)', async () => {
-      mockSessionManager.getSession.mockReturnValue({
-        connectionMode: 'tonConnect',
-        activeWallet: mockWallets[0],
-        activeNetwork: null,
-        activeAddress: null,
-        availableNetworks: [],
-        availableAddresses: [],
-        activeWalletCapabilities: null
-      })
-      const uwc = new UniversalWalletConnector(
-        mockNetworks,
-        mockWallets,
-        false,
-        undefined,
-        { manifestUrl: 'https://example.com/manifest.json' }
-      )
-
-      await expect(uwc.signSolanaTransaction(SERIALIZED_TX)).rejects.toThrow(
-        'signSolanaTransaction is not supported for connection mode "tonConnect"'
-      )
-    })
-
-    it('throws "not supported" when connectionMode maps to no registered connector', async () => {
-      // UWC built without walletConnect config — the connectors map has no
-      // 'walletConnect' entry, so the lookup returns undefined.
-      mockSessionManager.getSession.mockReturnValue({
-        connectionMode: 'walletConnect' as any,
-        activeWallet: mockWallets[0],
-        activeNetwork: null,
-        activeAddress: null,
-        availableNetworks: [],
-        availableAddresses: [],
-        activeWalletCapabilities: null
-      })
-      const uwc = new UniversalWalletConnector(mockNetworks, mockWallets)
-
-      await expect(uwc.signSolanaTransaction(SERIALIZED_TX)).rejects.toThrow(
-        'signSolanaTransaction is not supported for connection mode "walletConnect"'
-      )
-    })
-
-    it('routes serializedTx to injected connector.signSolanaTransactionBytes', async () => {
-      mockInjectedConnector.signSolanaTransactionBytes.mockResolvedValue(
+    // Validation, routing, and the sign-only invariant live in
+    // TransactionService.signSolanaTransactionBytes (transaction-service.test.ts).
+    // The facade only delegates and propagates.
+    it('delegates to TransactionService and propagates the signed bytes', async () => {
+      const SERIALIZED_TX = new Uint8Array([1, 2, 3, 4, 5])
+      const SIGNED_TX = new Uint8Array([6, 7, 8, 9, 10])
+      mockTransactionService.signSolanaTransactionBytes.mockResolvedValueOnce(
         SIGNED_TX
       )
-      mockSessionManager.getSession.mockReturnValue({
-        connectionMode: 'injected',
-        activeWallet: mockWallets[0],
-        activeNetwork: null,
-        activeAddress: null,
-        availableNetworks: [],
-        availableAddresses: [],
-        activeWalletCapabilities: null
-      })
       const uwc = new UniversalWalletConnector(mockNetworks, mockWallets)
 
       const result = await uwc.signSolanaTransaction(SERIALIZED_TX)
 
       expect(
-        mockInjectedConnector.signSolanaTransactionBytes
-      ).toHaveBeenCalledOnce()
-      expect(
-        mockInjectedConnector.signSolanaTransactionBytes
-      ).toHaveBeenCalledWith(SERIALIZED_TX)
-      expect(result).toBe(SIGNED_TX)
-    })
-
-    it('routes serializedTx to walletConnect connector.signSolanaTransactionBytes', async () => {
-      mockWalletConnectConnector.signSolanaTransactionBytes.mockResolvedValue(
-        SIGNED_TX
-      )
-      mockSessionManager.getSession.mockReturnValue({
-        connectionMode: 'walletConnect',
-        activeWallet: mockWallets[0],
-        activeNetwork: null,
-        activeAddress: null,
-        availableNetworks: [],
-        availableAddresses: [],
-        activeWalletCapabilities: null
-      })
-      const uwc = new UniversalWalletConnector(
-        mockNetworks,
-        mockWallets,
-        false,
-        mockWalletConnectConfig
-      )
-
-      const result = await uwc.signSolanaTransaction(SERIALIZED_TX)
-
-      expect(
-        mockWalletConnectConnector.signSolanaTransactionBytes
-      ).toHaveBeenCalledOnce()
-      expect(
-        mockWalletConnectConnector.signSolanaTransactionBytes
+        mockTransactionService.signSolanaTransactionBytes
       ).toHaveBeenCalledWith(SERIALIZED_TX)
       expect(result).toBe(SIGNED_TX)
     })
 
-    it('INVARIANT: injected connector.sendTransaction is never called on the sign-only path', async () => {
-      const sendTx = vi.fn()
-      ;(mockInjectedConnector as any).sendTransaction = sendTx
-      mockInjectedConnector.signSolanaTransactionBytes.mockResolvedValue(
-        SIGNED_TX
+    it('propagates a service rejection', async () => {
+      mockTransactionService.signSolanaTransactionBytes.mockRejectedValueOnce(
+        new Error('No active wallet')
       )
-      mockSessionManager.getSession.mockReturnValue({
-        connectionMode: 'injected',
-        activeWallet: mockWallets[0],
-        activeNetwork: null,
-        activeAddress: null,
-        availableNetworks: [],
-        availableAddresses: [],
-        activeWalletCapabilities: null
-      })
       const uwc = new UniversalWalletConnector(mockNetworks, mockWallets)
 
-      await uwc.signSolanaTransaction(SERIALIZED_TX)
-
-      expect(sendTx).not.toHaveBeenCalled()
+      await expect(
+        uwc.signSolanaTransaction(new Uint8Array([1]))
+      ).rejects.toThrow('No active wallet')
     })
   })
 })