@mergesignal/shared 0.5.0 → 0.7.0

package/dist/presentation/buildGitHubCheckRunOutput.test.js

@@ -0,0 +1,163 @@
+import { describe, expect, it } from "vitest";
+import { assessmentFastifyRuntime, assessmentTypescriptPatch, } from "../fixtures/assessmentFixtures.js";
+import { withAssessmentScope, minimalReviewFocalPoint, emptyReachScope, emptyVerificationScope, reachScopeFor, } from "../fixtures/assessmentScopeFixtures.js";
+import { buildScanPresentationBundle, presentDashboardCard } from "./index.js";
+import { buildGitHubCheckRunOutput } from "./buildGitHubCheckRunOutput.js";
+const safeAssessment = assessmentTypescriptPatch;
+const baselineAssessment = withAssessmentScope({
+    posture: "safe",
+    confidence: "medium",
+    primaryConcern: "graph_baseline_only",
+    concerns: [
+        {
+            kind: "graph_baseline_only",
+            rank: 1,
+            evidenceRefs: ["fixture:baseline"],
+        },
+    ],
+    factors: ["graph_baseline_only"],
+    changeClasses: ["tooling_maintenance"],
+    presentation: {
+        narrativeIntensity: "minimal",
+        reachVisibility: "hidden",
+        verificationIntensity: "none",
+        insightEmissionFloor: "none",
+        reportMode: "lightweight_pr_graph_baseline",
+    },
+}, {
+    reviewFocalPoint: minimalReviewFocalPoint(["@types/minimist"]),
+    reachScope: emptyReachScope(),
+    verificationScope: emptyVerificationScope(),
+});
+const needsReviewAssessment = assessmentFastifyRuntime;
+const riskyAssessment = withAssessmentScope({
+    posture: "risky",
+    confidence: "high",
+    primaryConcern: "breaking_or_major",
+    concerns: [
+        {
+            kind: "breaking_or_major",
+            rank: 1,
+            packages: ["react"],
+            evidenceRefs: ["fixture:breaking"],
+        },
+    ],
+    factors: ["breaking_or_major"],
+    changeClasses: ["breaking_change"],
+    presentation: {
+        narrativeIntensity: "elevated",
+        reachVisibility: "prominent",
+        verificationIntensity: "required",
+        insightEmissionFloor: "full",
+        reportMode: "high_signal_pr",
+    },
+}, {
+    reviewFocalPoint: minimalReviewFocalPoint(["react"]),
+    reachScope: reachScopeFor(["react"], "high"),
+    verificationScope: emptyVerificationScope(),
+});
+function assertNoLegacyCheckRunMarkers(summary) {
+    expect(summary).not.toContain("Risk index");
+    expect(summary).not.toContain("Layer scores");
+    expect(summary).not.toContain("<details>");
+    expect(summary).not.toMatch(/\d+\/100/);
+}
+function minimalScanResult(overrides = {}) {
+    return {
+        totalScore: 72,
+        layerScores: {
+            security: 10,
+            maintainability: 20,
+            ecosystem: 30,
+            upgradeImpact: 15,
+        },
+        findings: [],
+        methodologyVersion: "mergesignal-engine/test",
+        generatedAt: new Date().toISOString(),
+        assessment: safeAssessment,
+        decision: {
+            recommendation: "safe",
+            confidence: "medium",
+            reasoning: [],
+        },
+        ...overrides,
+    };
+}
+describe("buildGitHubCheckRunOutput", () => {
+    it("maps safe posture to success conclusion with scan link", () => {
+        const out = buildGitHubCheckRunOutput(minimalScanResult(), {
+            scanId: "scan-safe",
+            webAppOrigin: "https://app.test",
+        });
+        expect(out.conclusion).toBe("success");
+        expect(out.summary).toContain("/scan/scan-safe");
+        expect(out.summary).toContain("Full scan:");
+        assertNoLegacyCheckRunMarkers(out.summary);
+    });
+    it("maps needs_review posture to neutral conclusion", () => {
+        const out = buildGitHubCheckRunOutput(minimalScanResult({
+            assessment: needsReviewAssessment,
+            decision: {
+                recommendation: "needs_review",
+                confidence: "medium",
+                reasoning: ["Runtime usage confirmed"],
+            },
+            changedPackages: ["fastify"],
+        }), { scanId: "scan-review", webAppOrigin: "https://app.test" });
+        expect(out.conclusion).toBe("neutral");
+        expect(out.summary).toContain("/scan/scan-review");
+        assertNoLegacyCheckRunMarkers(out.summary);
+    });
+    it("maps risky posture to failure conclusion", () => {
+        const out = buildGitHubCheckRunOutput(minimalScanResult({
+            assessment: riskyAssessment,
+            decision: {
+                recommendation: "risky",
+                confidence: "high",
+                reasoning: ["Breaking change"],
+            },
+        }), { scanId: "scan-risky", webAppOrigin: "https://app.test" });
+        expect(out.conclusion).toBe("failure");
+        assertNoLegacyCheckRunMarkers(out.summary);
+    });
+    it("produces success conclusion for lightweight baseline presentation", () => {
+        const out = buildGitHubCheckRunOutput(minimalScanResult({
+            assessment: baselineAssessment,
+            reportPresentation: { mode: "lightweight_pr_graph_baseline" },
+            changedPackages: ["@types/minimist"],
+            decision: {
+                recommendation: "safe",
+                confidence: "medium",
+                reasoning: [],
+            },
+        }), { scanId: "scan-lw", webAppOrigin: "https://app.test" });
+        expect(out.conclusion).toBe("success");
+        expect(out.summary).toContain("/scan/scan-lw");
+        assertNoLegacyCheckRunMarkers(out.summary);
+    });
+    it("throws when assessment is missing", () => {
+        expect(() => buildGitHubCheckRunOutput(minimalScanResult({ assessment: undefined }), "scan-no-assessment")).toThrow(/assessment/i);
+    });
+    it("title matches dashboard card headline from the same bundle", () => {
+        const result = minimalScanResult({
+            assessment: needsReviewAssessment,
+            decision: {
+                recommendation: "needs_review",
+                confidence: "medium",
+                reasoning: ["Runtime usage confirmed"],
+            },
+            changedPackages: ["fastify"],
+        });
+        const out = buildGitHubCheckRunOutput(result, {
+            scanId: "scan-parity",
+            webAppOrigin: "https://app.test",
+        });
+        const bundle = buildScanPresentationBundle({
+            result,
+            pipelineStatus: "done",
+        });
+        expect(bundle).not.toBeNull();
+        const card = presentDashboardCard(bundle);
+        expect(out.title).toBe(card.headline);
+    });
+});

package/dist/presentation/compose/narrativeChannels.js

@@ -19,7 +19,7 @@ export function buildNarrativeChannels(bundle) {
     const { assessment, presentation, profile, result } = bundle;
     const reachLabel = reachVisibilityLabel(presentation.reachVisibility);
     return {
-        headline: formatAssessmentHeadline(assessment, result, profile.status),
+        headline: formatAssessmentHeadline(assessment, profile.status),
         limitedContextMessage: profile.degradedMessage ?? undefined,
         reachLabel,
         insights: projectInsightLines(assessment, result),

package/dist/presentation/dto/assessmentPresentationFields.d.ts

@@ -1,5 +1,4 @@
-import type { MergeConcernKind } from "../../assessmentSchema.js";
-import type { NarrativeIntensity, ReachVisibility } from "../../assessmentSchema.js";
+import type { MergeConcernKind, NarrativeIntensity, ReachVisibility } from "@mergesignal/contracts";
 /** Assessment-aligned fields projected identically across surfaces. */
 export type AssessmentPresentationFields = {
     posture: "safe" | "needs_review" | "risky";

package/dist/presentation/dto/assessmentPresentationFields.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"assessmentPresentationFields.d.ts","sourceRoot":"","sources":["../../../src/presentation/dto/assessmentPresentationFields.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,2BAA2B,CAAC;AAClE,OAAO,KAAK,EACV,kBAAkB,EAClB,eAAe,EAEhB,MAAM,2BAA2B,CAAC;AAEnC,uEAAuE;AACvE,MAAM,MAAM,4BAA4B,GAAG;IACzC,OAAO,EAAE,MAAM,GAAG,cAAc,GAAG,OAAO,CAAC;IAC3C,cAAc,EAAE,gBAAgB,GAAG,IAAI,CAAC;IACxC,OAAO,EAAE,MAAM,EAAE,CAAC;IAClB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,iBAAiB,EAAE,MAAM,EAAE,CAAC;IAC5B,eAAe,EAAE,eAAe,CAAC;IACjC,kBAAkB,EAAE,kBAAkB,CAAC;CACxC,CAAC"}
+{"version":3,"file":"assessmentPresentationFields.d.ts","sourceRoot":"","sources":["../../../src/presentation/dto/assessmentPresentationFields.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,gBAAgB,EAChB,kBAAkB,EAClB,eAAe,EAEhB,MAAM,wBAAwB,CAAC;AAEhC,uEAAuE;AACvE,MAAM,MAAM,4BAA4B,GAAG;IACzC,OAAO,EAAE,MAAM,GAAG,cAAc,GAAG,OAAO,CAAC;IAC3C,cAAc,EAAE,gBAAgB,GAAG,IAAI,CAAC;IACxC,OAAO,EAAE,MAAM,EAAE,CAAC;IAClB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,iBAAiB,EAAE,MAAM,EAAE,CAAC;IAC5B,eAAe,EAAE,eAAe,CAAC;IACjC,kBAAkB,EAAE,kBAAkB,CAAC;CACxC,CAAC"}

package/dist/presentation/index.d.ts

@@ -14,13 +14,14 @@ export type { DashboardCardLayout } from "./dto/dashboardCardPresentation.js";
 export type { DashboardCardPresentation as ScanCardPresentation } from "./dto/dashboardCardPresentation.js";
 export type { ScanDetailsPresentation } from "./dto/scanDetailsPresentation.js";
 export type { GitHubCheckRunPresentation, GitHubPrCommentPresentation, CliScanPresentation, } from "./dto/githubAndCliPresentation.js";
-export { presentDashboardCard, presentPipelineDashboardCard, } from "./presenters/presentDashboardCard.js";
+export { presentDashboardCard, presentPipelineDashboardCard, presentSurfacesIncompleteDashboardCard, } from "./presenters/presentDashboardCard.js";
 export { presentScanDetails } from "./presenters/presentScanDetails.js";
 export type { PresentScanDetailsContext } from "./presenters/presentScanDetails.js";
 export { presentGitHubCheckRun } from "./presenters/presentGitHubCheckRun.js";
 export { presentGitHubPrComment } from "./presenters/presentGitHubPrComment.js";
 export { presentCliScanSummary } from "./presenters/presentCliScanSummary.js";
 export { renderGitHubCheckRunMarkdown } from "./render/renderGitHubCheckRunMarkdown.js";
+export { buildGitHubCheckRunOutput, resolveWebAppOrigin, type GitHubCheckRunConclusion, type GitHubCheckRunOutput, type BuildGitHubCheckRunOutputOptions, } from "./buildGitHubCheckRunOutput.js";
 export { renderGitHubPrCommentMarkdown } from "./render/renderGitHubPrCommentMarkdown.js";
 export { renderCliScanSummaryText } from "./render/renderCliScanSummaryText.js";
 export { buildNarrativeChannels, projectCompactKeyPoints, composeHeadline, composeSubheadline, composeKeyPoints, composeVerificationActions, composeAffectedAreaLabels, composeEvidenceRows, composeSupportingContext, evidenceContextFromProfile, } from "./compose/narrativeCompose.js";

package/dist/presentation/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/presentation/index.ts"],"names":[],"mappings":"AAAA,YAAY,EAAE,sBAAsB,EAAE,MAAM,2CAA2C,CAAC;AACxF,OAAO,EAAE,2BAA2B,EAAE,MAAM,gDAAgD,CAAC;AAC7F,YAAY,EAAE,gCAAgC,EAAE,MAAM,gDAAgD,CAAC;AACvG,OAAO,EAAE,yBAAyB,EAAE,MAAM,8CAA8C,CAAC;AACzF,YAAY,EAAE,8BAA8B,EAAE,MAAM,8CAA8C,CAAC;AACnG,OAAO,EAAE,4BAA4B,EAAE,MAAM,iDAAiD,CAAC;AAC/F,YAAY,EAAE,iCAAiC,EAAE,MAAM,iDAAiD,CAAC;AAEzG,YAAY,EAAE,mBAAmB,EAAE,MAAM,kCAAkC,CAAC;AAC5E,YAAY,EACV,kBAAkB,EAClB,0BAA0B,GAC3B,MAAM,gCAAgC,CAAC;AACxC,YAAY,EACV,cAAc,EACd,kBAAkB,EAClB,mBAAmB,EACnB,sBAAsB,EACtB,oBAAoB,EACpB,2BAA2B,EAC3B,uBAAuB,GACxB,MAAM,gBAAgB,CAAC;AAExB,YAAY,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AACpF,YAAY,EAAE,mBAAmB,EAAE,MAAM,oCAAoC,CAAC;AAC9E,gDAAgD;AAChD,YAAY,EAAE,yBAAyB,IAAI,oBAAoB,EAAE,MAAM,oCAAoC,CAAC;AAC5G,YAAY,EAAE,uBAAuB,EAAE,MAAM,kCAAkC,CAAC;AAChF,YAAY,EACV,0BAA0B,EAC1B,2BAA2B,EAC3B,mBAAmB,GACpB,MAAM,mCAAmC,CAAC;AAE3C,OAAO,EACL,oBAAoB,EACpB,4BAA4B,GAC7B,MAAM,sCAAsC,CAAC;AAC9C,OAAO,EAAE,kBAAkB,EAAE,MAAM,oCAAoC,CAAC;AACxE,YAAY,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AACpF,OAAO,EAAE,qBAAqB,EAAE,MAAM,uCAAuC,CAAC;AAC9E,OAAO,EAAE,sBAAsB,EAAE,MAAM,wCAAwC,CAAC;AAChF,OAAO,EAAE,qBAAqB,EAAE,MAAM,uCAAuC,CAAC;AAE9E,OAAO,EAAE,4BAA4B,EAAE,MAAM,0CAA0C,CAAC;AACxF,OAAO,EAAE,6BAA6B,EAAE,MAAM,2CAA2C,CAAC;AAC1F,OAAO,EAAE,wBAAwB,EAAE,MAAM,sCAAsC,CAAC;AAEhF,OAAO,EACL,sBAAsB,EACtB,uBAAuB,EACvB,eAAe,EACf,kBAAkB,EAClB,gBAAgB,EAChB,0BAA0B,EAC1B,yBAAyB,EACzB,mBAAmB,EACnB,wBAAwB,EACxB,0BAA0B,GAC3B,MAAM,+BAA+B,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/presentation/index.ts"],"names":[],"mappings":"AAAA,YAAY,EAAE,sBAAsB,EAAE,MAAM,2CAA2C,CAAC;AACxF,OAAO,EAAE,2BAA2B,EAAE,MAAM,gDAAgD,CAAC;AAC7F,YAAY,EAAE,gCAAgC,EAAE,MAAM,gDAAgD,CAAC;AACvG,OAAO,EAAE,yBAAyB,EAAE,MAAM,8CAA8C,CAAC;AACzF,YAAY,EAAE,8BAA8B,EAAE,MAAM,8CAA8C,CAAC;AACnG,OAAO,EAAE,4BAA4B,EAAE,MAAM,iDAAiD,CAAC;AAC/F,YAAY,EAAE,iCAAiC,EAAE,MAAM,iDAAiD,CAAC;AAEzG,YAAY,EAAE,mBAAmB,EAAE,MAAM,kCAAkC,CAAC;AAC5E,YAAY,EACV,kBAAkB,EAClB,0BAA0B,GAC3B,MAAM,gCAAgC,CAAC;AACxC,YAAY,EACV,cAAc,EACd,kBAAkB,EAClB,mBAAmB,EACnB,sBAAsB,EACtB,oBAAoB,EACpB,2BAA2B,EAC3B,uBAAuB,GACxB,MAAM,gBAAgB,CAAC;AAExB,YAAY,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AACpF,YAAY,EAAE,mBAAmB,EAAE,MAAM,oCAAoC,CAAC;AAC9E,gDAAgD;AAChD,YAAY,EAAE,yBAAyB,IAAI,oBAAoB,EAAE,MAAM,oCAAoC,CAAC;AAC5G,YAAY,EAAE,uBAAuB,EAAE,MAAM,kCAAkC,CAAC;AAChF,YAAY,EACV,0BAA0B,EAC1B,2BAA2B,EAC3B,mBAAmB,GACpB,MAAM,mCAAmC,CAAC;AAE3C,OAAO,EACL,oBAAoB,EACpB,4BAA4B,EAC5B,sCAAsC,GACvC,MAAM,sCAAsC,CAAC;AAC9C,OAAO,EAAE,kBAAkB,EAAE,MAAM,oCAAoC,CAAC;AACxE,YAAY,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AACpF,OAAO,EAAE,qBAAqB,EAAE,MAAM,uCAAuC,CAAC;AAC9E,OAAO,EAAE,sBAAsB,EAAE,MAAM,wCAAwC,CAAC;AAChF,OAAO,EAAE,qBAAqB,EAAE,MAAM,uCAAuC,CAAC;AAE9E,OAAO,EAAE,4BAA4B,EAAE,MAAM,0CAA0C,CAAC;AACxF,OAAO,EACL,yBAAyB,EACzB,mBAAmB,EACnB,KAAK,wBAAwB,EAC7B,KAAK,oBAAoB,EACzB,KAAK,gCAAgC,GACtC,MAAM,gCAAgC,CAAC;AACxC,OAAO,EAAE,6BAA6B,EAAE,MAAM,2CAA2C,CAAC;AAC1F,OAAO,EAAE,wBAAwB,EAAE,MAAM,sCAAsC,CAAC;AAEhF,OAAO,EACL,sBAAsB,EACtB,uBAAuB,EACvB,eAAe,EACf,kBAAkB,EAClB,gBAAgB,EAChB,0BAA0B,EAC1B,yBAAyB,EACzB,mBAAmB,EACnB,wBAAwB,EACxB,0BAA0B,GAC3B,MAAM,+BAA+B,CAAC"}

package/dist/presentation/index.js

@@ -1,12 +1,13 @@
 export { buildScanPresentationBundle } from "./orchestration/buildScanPresentationBundle.js";
 export { buildScanCardPresentation } from "./orchestration/buildScanCardPresentation.js";
 export { buildScanDetailsPresentation } from "./orchestration/buildScanDetailsPresentation.js";
-export { presentDashboardCard, presentPipelineDashboardCard, } from "./presenters/presentDashboardCard.js";
+export { presentDashboardCard, presentPipelineDashboardCard, presentSurfacesIncompleteDashboardCard, } from "./presenters/presentDashboardCard.js";
 export { presentScanDetails } from "./presenters/presentScanDetails.js";
 export { presentGitHubCheckRun } from "./presenters/presentGitHubCheckRun.js";
 export { presentGitHubPrComment } from "./presenters/presentGitHubPrComment.js";
 export { presentCliScanSummary } from "./presenters/presentCliScanSummary.js";
 export { renderGitHubCheckRunMarkdown } from "./render/renderGitHubCheckRunMarkdown.js";
+export { buildGitHubCheckRunOutput, resolveWebAppOrigin, } from "./buildGitHubCheckRunOutput.js";
 export { renderGitHubPrCommentMarkdown } from "./render/renderGitHubPrCommentMarkdown.js";
 export { renderCliScanSummaryText } from "./render/renderCliScanSummaryText.js";
 export { buildNarrativeChannels, projectCompactKeyPoints, composeHeadline, composeSubheadline, composeKeyPoints, composeVerificationActions, composeAffectedAreaLabels, composeEvidenceRows, composeSupportingContext, evidenceContextFromProfile, } from "./compose/narrativeCompose.js";

package/dist/presentation/orchestration/buildScanPresentationBundle.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"buildScanPresentationBundle.d.ts","sourceRoot":"","sources":["../../../src/presentation/orchestration/buildScanPresentationBundle.ts"],"names":[],"mappings":"AAKA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AACjD,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEtD,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,6BAA6B,CAAC;AAE1E,MAAM,MAAM,gCAAgC,GAAG;IAC7C,MAAM,EAAE,UAAU,CAAC;IACnB,cAAc,EAAE,cAAc,CAAC;IAC/B,QAAQ,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,UAAU,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CAC5B,CAAC;AAEF;;;GAGG;AACH,wBAAgB,2BAA2B,CACzC,KAAK,EAAE,gCAAgC,GACtC,sBAAsB,GAAG,IAAI,CAsB/B"}
+{"version":3,"file":"buildScanPresentationBundle.d.ts","sourceRoot":"","sources":["../../../src/presentation/orchestration/buildScanPresentationBundle.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AACjD,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEtD,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,6BAA6B,CAAC;AAE1E,MAAM,MAAM,gCAAgC,GAAG;IAC7C,MAAM,EAAE,UAAU,CAAC;IACnB,cAAc,EAAE,cAAc,CAAC;IAC/B,QAAQ,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,UAAU,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CAC5B,CAAC;AAEF;;;GAGG;AACH,wBAAgB,2BAA2B,CACzC,KAAK,EAAE,gCAAgC,GACtC,sBAAsB,GAAG,IAAI,CA4B/B"}

package/dist/presentation/orchestration/buildScanPresentationBundle.js

@@ -1,4 +1,5 @@
-import { parseAssessmentOrThrow, toPublicPresentation, } from "../../assessmentSchema.js";
+import { parseAssessmentOrThrow } from "@mergesignal/contracts";
+import { toPublicPresentation } from "../../assessmentPresentationUtils.js";
 import { deriveScanNarrative } from "../../deriveScanNarrative.js";
 import { buildProfileFromAssessment } from "../profile/buildProfileFromAssessment.js";
 /**
@@ -11,12 +12,18 @@ export function buildScanPresentationBundle(input) {
     const assessment = input.result.assessment;
     if (!assessment)
         return null;
-    parseAssessmentOrThrow(assessment);
-    const presentation = toPublicPresentation(assessment.presentation);
-    const profile = buildProfileFromAssessment(assessment, presentation, input.result);
+    let normalized;
+    try {
+        normalized = parseAssessmentOrThrow(assessment);
+    }
+    catch {
+        return null;
+    }
+    const presentation = toPublicPresentation(normalized.presentation);
+    const profile = buildProfileFromAssessment(normalized, presentation, input.result);
     const facts = deriveScanNarrative(input.result);
     return {
-        assessment,
+        assessment: normalized,
         presentation,
         profile,
         facts,

package/dist/presentation/orchestration/buildScanPresentationBundle.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=buildScanPresentationBundle.test.d.ts.map

package/dist/presentation/orchestration/buildScanPresentationBundle.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"buildScanPresentationBundle.test.d.ts","sourceRoot":"","sources":["../../../src/presentation/orchestration/buildScanPresentationBundle.test.ts"],"names":[],"mappings":""}

package/dist/presentation/orchestration/buildScanPresentationBundle.test.js

@@ -0,0 +1,99 @@
+import { parseAssessmentOrThrow } from "@mergesignal/contracts";
+import { describe, expect, it } from "vitest";
+import { assessmentTypescriptPatch } from "../../fixtures/assessmentFixtures.js";
+import { buildScanCardPresentation } from "./buildScanCardPresentation.js";
+import { buildScanPresentationBundle } from "./buildScanPresentationBundle.js";
+const abi1Assessment = {
+    posture: "safe",
+    confidence: "high",
+    primaryConcern: null,
+    concerns: [],
+    factors: ["tooling_maintenance"],
+    changeClasses: ["tooling_maintenance"],
+    presentation: {
+        narrativeIntensity: "minimal",
+        reachVisibility: "hidden",
+        verificationIntensity: "advisory",
+        insightEmissionFloor: "none",
+        reportMode: "high_signal_pr",
+    },
+};
+function minimalScanResult(assessment) {
+    return {
+        totalScore: 42,
+        layerScores: {
+            security: 10,
+            maintainability: 20,
+            ecosystem: 30,
+            upgradeImpact: 40,
+        },
+        findings: [],
+        generatedAt: "2026-01-01T00:00:00.000Z",
+        decision: {
+            recommendation: "safe",
+            confidence: "high",
+            reasoning: [],
+        },
+        assessment,
+    };
+}
+describe("buildScanPresentationBundle (presentation boundary)", () => {
+    it("ABI-2 assessment produces a bundle", () => {
+        const result = minimalScanResult(assessmentTypescriptPatch);
+        const bundle = buildScanPresentationBundle({
+            result,
+            pipelineStatus: "done",
+        });
+        expect(bundle).not.toBeNull();
+        expect(bundle.assessment.reviewFocalPoint.anchors).toContain("typescript");
+    });
+    it("ABI-2 assessment renders a dashboard card headline", () => {
+        const result = minimalScanResult(assessmentTypescriptPatch);
+        const card = buildScanCardPresentation({
+            pipelineStatus: "done",
+            result,
+        });
+        expect(card.headline.length).toBeGreaterThan(0);
+    });
+    it("ABI-1 assessment returns null without throwing", () => {
+        const result = minimalScanResult(abi1Assessment);
+        expect(() => buildScanPresentationBundle({
+            result,
+            pipelineStatus: "done",
+        })).not.toThrow();
+        expect(buildScanPresentationBundle({
+            result,
+            pipelineStatus: "done",
+        })).toBeNull();
+    });
+    it("ABI-1 assessment does not mutate stored assessment JSON", () => {
+        const result = minimalScanResult(structuredClone(abi1Assessment));
+        const before = JSON.stringify(result.assessment);
+        buildScanPresentationBundle({ result, pipelineStatus: "done" });
+        expect(JSON.stringify(result.assessment)).toBe(before);
+        expect(result.assessment).not.toHaveProperty("reviewFocalPoint");
+    });
+    it("ABI-1 direct parseAssessmentOrThrow still throws (contracts strict)", () => {
+        expect(() => parseAssessmentOrThrow(abi1Assessment)).toThrow();
+    });
+    it("mixed PR index: ABI-2 ok and ABI-1 degraded without throw", () => {
+        const abi2 = minimalScanResult(assessmentTypescriptPatch);
+        const abi1 = minimalScanResult(abi1Assessment);
+        for (const result of [abi2, abi1]) {
+            expect(() => buildScanCardPresentation({
+                pipelineStatus: "done",
+                result,
+            })).not.toThrow();
+        }
+        const abi2Card = buildScanCardPresentation({
+            pipelineStatus: "done",
+            result: abi2,
+        });
+        const abi1Card = buildScanCardPresentation({
+            pipelineStatus: "done",
+            result: abi1,
+        });
+        expect(abi2Card.headline.length).toBeGreaterThan(0);
+        expect(abi1Card.pipeline?.status).toBe("failed");
+    });
+});

package/dist/presentation/orchestration/scanPresentationBundle.d.ts

@@ -1,4 +1,4 @@
-import type { Assessment, AssessmentPresentationPublic } from "../../assessmentSchema.js";
+import type { Assessment, AssessmentPresentationPublic } from "@mergesignal/contracts";
 import type { ScanNarrativeFacts } from "../../scanNarrativeFacts.js";
 import type { ScanResult } from "../../types.js";
 import type { PresentationProfile } from "../profile/presentationProfile.js";

package/dist/presentation/orchestration/scanPresentationBundle.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"scanPresentationBundle.d.ts","sourceRoot":"","sources":["../../../src/presentation/orchestration/scanPresentationBundle.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,UAAU,EACV,4BAA4B,EAC7B,MAAM,2BAA2B,CAAC;AACnC,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,6BAA6B,CAAC;AACtE,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AACjD,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,mCAAmC,CAAC;AAE7E,MAAM,MAAM,sBAAsB,GAAG;IACnC,UAAU,EAAE,UAAU,CAAC;IACvB,YAAY,EAAE,4BAA4B,CAAC;IAC3C,OAAO,EAAE,mBAAmB,CAAC;IAC7B;;;OAGG;IACH,KAAK,EAAE,kBAAkB,CAAC;IAC1B;;;OAGG;IACH,MAAM,EAAE,UAAU,CAAC;CACpB,CAAC"}
+{"version":3,"file":"scanPresentationBundle.d.ts","sourceRoot":"","sources":["../../../src/presentation/orchestration/scanPresentationBundle.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,UAAU,EACV,4BAA4B,EAC7B,MAAM,wBAAwB,CAAC;AAChC,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,6BAA6B,CAAC;AACtE,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AACjD,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,mCAAmC,CAAC;AAE7E,MAAM,MAAM,sBAAsB,GAAG;IACnC,UAAU,EAAE,UAAU,CAAC;IACvB,YAAY,EAAE,4BAA4B,CAAC;IAC3C,OAAO,EAAE,mBAAmB,CAAC;IAC7B;;;OAGG;IACH,KAAK,EAAE,kBAAkB,CAAC;IAC1B;;;OAGG;IACH,MAAM,EAAE,UAAU,CAAC;CACpB,CAAC"}

package/dist/presentation/presentation.test.js

@@ -66,7 +66,7 @@ describe("presentDashboardCard personas", () => {
         expect(card.verdict?.posture).toBe("safe");
         expect(card.headline).toMatch(/patch upgrade/i);
         expect(card.headline).not.toMatch(/needs review/i);
-        expect(card.verification.length).toBeGreaterThan(0);
+        expect(card.verification.length).toBe(0);
     });
 });
 describe("presentation parity across surfaces", () => {

package/dist/presentation/presentationPersonas.test.js

@@ -16,8 +16,6 @@ const personas = [
         density: "minimal",
         headlineMatch: /patch upgrade/i,
         headlineMustNot: /needs review/i,
-        verificationIncludes: ["CI", "typecheck"],
-        verificationMustNot: /auth flow/i,
     },
     {
         name: "eslint",
@@ -27,7 +25,6 @@ const personas = [
         density: "minimal",
         headlineMatch: /patch upgrade/i,
         headlineMustNot: /needs review/i,
-        verificationIncludes: ["ci", "lint"],
     },
     {
         name: "prettier",
@@ -37,7 +34,6 @@ const personas = [
         density: "minimal",
         headlineMatch: /patch upgrade/i,
         headlineMustNot: /needs review/i,
-        verificationIncludes: ["format"],
     },
     {
         name: "vitest",
@@ -47,7 +43,6 @@ const personas = [
         density: "minimal",
         headlineMatch: /patch upgrade|dependency upgrade/i,
         headlineMustNot: /needs review/i,
-        verificationIncludes: ["test"],
     },
     {
         name: "fastify runtime",

package/dist/presentation/presenters/presentDashboardCard.d.ts

@@ -1,5 +1,6 @@
 import type { DashboardCardPresentation } from "../dto/dashboardCardPresentation.js";
 import type { ScanPresentationBundle } from "../orchestration/scanPresentationBundle.js";
 export declare function presentDashboardCard(bundle: ScanPresentationBundle): DashboardCardPresentation;
+export declare function presentSurfacesIncompleteDashboardCard(): DashboardCardPresentation;
 export declare function presentPipelineDashboardCard(pipelineStatus: "queued" | "running" | "failed"): DashboardCardPresentation;
 //# sourceMappingURL=presentDashboardCard.d.ts.map

package/dist/presentation/presenters/presentDashboardCard.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"presentDashboardCard.d.ts","sourceRoot":"","sources":["../../../src/presentation/presenters/presentDashboardCard.ts"],"names":[],"mappings":"AASA,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,qCAAqC,CAAC;AAErF,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,4CAA4C,CAAC;AAoEzF,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,sBAAsB,GAC7B,yBAAyB,CA8C3B;AAED,wBAAgB,4BAA4B,CAC1C,cAAc,EAAE,QAAQ,GAAG,SAAS,GAAG,QAAQ,GAC9C,yBAAyB,CAqB3B"}
+{"version":3,"file":"presentDashboardCard.d.ts","sourceRoot":"","sources":["../../../src/presentation/presenters/presentDashboardCard.ts"],"names":[],"mappings":"AASA,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,qCAAqC,CAAC;AAErF,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,4CAA4C,CAAC;AAoEzF,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,sBAAsB,GAC7B,yBAAyB,CA8C3B;AAED,wBAAgB,sCAAsC,IAAI,yBAAyB,CAelF;AAED,wBAAgB,4BAA4B,CAC1C,cAAc,EAAE,QAAQ,GAAG,SAAS,GAAG,QAAQ,GAC9C,yBAAyB,CAqB3B"}

package/dist/presentation/presenters/presentDashboardCard.js

@@ -96,6 +96,22 @@ export function presentDashboardCard(bundle) {
     };
     return normalizeDashboardCard(card);
 }
+export function presentSurfacesIncompleteDashboardCard() {
+    const headline = scanSurfaceCopy.pipeline.surfacesNotSynchronized;
+    return normalizeDashboardCard({
+        pipeline: {
+            status: "failed",
+            headline,
+            subheadline: scanSurfaceCopy.pipeline.surfacesNotSynchronizedDetail,
+        },
+        headline,
+        insights: [],
+        verification: [],
+        layout: "standard",
+        detailActionLabel: scanSurfaceCopy.presentation.actionLabelReview,
+        sortKey: { postureRank: -1, riskIndex: -1 },
+    });
+}
 export function presentPipelineDashboardCard(pipelineStatus) {
     const isRunning = pipelineStatus === "queued" || pipelineStatus === "running";
     const headline = isRunning

package/dist/presentation/profile/buildProfileFromAssessment.d.ts

@@ -1,4 +1,4 @@
-import type { Assessment, AssessmentPresentationPublic } from "../../assessmentSchema.js";
+import type { Assessment, AssessmentPresentationPublic } from "@mergesignal/contracts";
 import type { ScanResult } from "../../types.js";
 import type { PresentationProfile } from "./presentationProfile.js";
 export declare function buildProfileFromAssessment(assessment: Assessment, presentation: AssessmentPresentationPublic, result: ScanResult): PresentationProfile;

package/dist/presentation/profile/buildProfileFromAssessment.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"buildProfileFromAssessment.d.ts","sourceRoot":"","sources":["../../../src/presentation/profile/buildProfileFromAssessment.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,UAAU,EACV,4BAA4B,EAC7B,MAAM,2BAA2B,CAAC;AAEnC,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AAIjD,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,0BAA0B,CAAC;AAwCpE,wBAAgB,0BAA0B,CACxC,UAAU,EAAE,UAAU,EACtB,YAAY,EAAE,4BAA4B,EAC1C,MAAM,EAAE,UAAU,GACjB,mBAAmB,CAuBrB"}
+{"version":3,"file":"buildProfileFromAssessment.d.ts","sourceRoot":"","sources":["../../../src/presentation/profile/buildProfileFromAssessment.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,UAAU,EACV,4BAA4B,EAC7B,MAAM,wBAAwB,CAAC;AAEhC,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AAIjD,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,0BAA0B,CAAC;AAiDpE,wBAAgB,0BAA0B,CACxC,UAAU,EAAE,UAAU,EACtB,YAAY,EAAE,4BAA4B,EAC1C,MAAM,EAAE,UAAU,GACjB,mBAAmB,CAuBrB"}

package/dist/presentation/profile/buildProfileFromAssessment.js

@@ -1,10 +1,21 @@
-import { narrativeIntensityToDensity } from "../../assessmentSchema.js";
+import { narrativeIntensityToDensity } from "../../assessmentPresentationUtils.js";
 import { safeParseRepoIntelligence } from "../../repoIntelligenceSchema.js";
 import { scanSurfaceCopy } from "../../scanSurfaceCopy.js";
 import { collectVerificationFocus } from "../../assessmentProjection.js";
+function focalAnchorPackage(assessment) {
+    const anchors = assessment.reviewFocalPoint.anchors;
+    if (!anchors.length)
+        return null;
+    const token = anchors[0];
+    if (token === "dependency_graph")
+        return null;
+    if (token.includes("+"))
+        return token.split("+")[0];
+    return token;
+}
 function buildInterpretation(assessment, presentation, result) {
     const verificationLabels = collectVerificationFocus(result);
-    const anchorPackage = result.changedPackages?.[0] ?? null;
+    const anchorPackage = focalAnchorPackage(assessment);
     const suppressRuntimeNarrative = presentation.reachVisibility === "hidden";
     let intent = "unknown_upgrade";
     if (assessment.primaryConcern === "insufficient_evidence") {

package/dist/presentation/surfaceParity.test.js

@@ -8,14 +8,34 @@ import { renderGitHubCheckRunMarkdown } from "./render/renderGitHubCheckRunMarkd
 import { renderGitHubPrCommentMarkdown } from "./render/renderGitHubPrCommentMarkdown.js";
 import { scanResultBullmq, scanResultEslint, scanResultFastifyRuntime, scanResultMixedTypescriptFastify, scanResultPrettier, scanResultTypescriptPatch, scanResultVitest, } from "./fixtures/presentationPersonaFixtures.js";
 import { projectAssessmentFields } from "./projectAssessmentFields.js";
+import { buildNarrativeChannels } from "./compose/narrativeChannels.js";
 const SCAN_ID = "22222222-2222-4222-8222-222222222222";
 const ORIGIN = "https://app.example.com";
+const validationPersonasCore = [
+    {
+        id: "validation-pr-26",
+        name: "PR #26 mixed",
+        result: scanResultMixedTypescriptFastify,
+    },
+    {
+        id: "validation-pr-27",
+        name: "PR #27 fastify",
+        result: scanResultFastifyRuntime,
+    },
+    {
+        id: "validation-pr-28",
+        name: "PR #28 typescript",
+        result: scanResultTypescriptPatch,
+    },
+    {
+        id: "validation-pr-29",
+        name: "PR #29 prettier",
+        result: scanResultPrettier,
+    },
+    { id: "validation-pr-30", name: "PR #30 bullmq", result: scanResultBullmq },
+];
 const validationPersonas = [
-    { name: "PR #26 mixed", result: scanResultMixedTypescriptFastify },
-    { name: "PR #27 fastify", result: scanResultFastifyRuntime },
-    { name: "PR #28 typescript", result: scanResultTypescriptPatch },
-    { name: "PR #29 prettier", result: scanResultPrettier },
-    { name: "PR #30 bullmq", result: scanResultBullmq },
+    ...validationPersonasCore,
     { name: "eslint", result: scanResultEslint },
     { name: "vitest", result: scanResultVitest },
 ];
@@ -71,4 +91,52 @@ describe("surfaceParity guardrail", () => {
             expect(s.details.hero.headline).toBe(s.card.headline);
         });
     }
+    it("validation personas #26–#30: pairwise distinct reviewFocalPoint and headlines", () => {
+        const focalPoints = [];
+        const headlines = [];
+        for (const persona of validationPersonasCore) {
+            const s = surfacesFor(persona.result);
+            focalPoints.push(persona.result.assessment.reviewFocalPoint);
+            headlines.push(s.card.headline);
+            expect(s.check.title).toBe(s.card.headline);
+        }
+        for (let i = 0; i < headlines.length; i++) {
+            for (let j = i + 1; j < headlines.length; j++) {
+                expect(headlines[i]).not.toBe(headlines[j]);
+            }
+        }
+        for (let i = 0; i < focalPoints.length; i++) {
+            for (let j = i + 1; j < focalPoints.length; j++) {
+                expect(focalPoints[i]).not.toEqual(focalPoints[j]);
+            }
+        }
+    });
+    it("PR #26: headline uses focal fastify, not changedPackages[0] typescript", () => {
+        const result = scanResultMixedTypescriptFastify;
+        expect(result.changedPackages?.[0]).toBe("typescript");
+        const s = surfacesFor(result);
+        expect(s.card.headline.toLowerCase()).toContain("fastify");
+        expect(s.card.headline.toLowerCase()).not.toContain("typescript");
+    });
+    it("validation personas #28–#30: reach and verification channels differ by scope", () => {
+        const channelsById = new Map(validationPersonasCore.map((p) => {
+            const bundle = buildScanPresentationBundle({
+                result: p.result,
+                pipelineStatus: "done",
+            });
+            return [p.id, buildNarrativeChannels(bundle)];
+        }));
+        const ch28 = channelsById.get("validation-pr-28");
+        const ch29 = channelsById.get("validation-pr-29");
+        const ch27 = channelsById.get("validation-pr-27");
+        const ch30 = channelsById.get("validation-pr-30");
+        const ch26 = channelsById.get("validation-pr-26");
+        expect(ch28.reachLabel).toBeUndefined();
+        expect(ch29.reachLabel).toBeUndefined();
+        expect(ch27.verification.length).toBeGreaterThan(0);
+        expect(ch30.verification.length).toBeGreaterThan(0);
+        expect(ch27.verification).not.toEqual(ch30.verification);
+        expect(ch26.verification).not.toEqual(ch27.verification);
+        expect(ch26.scopeAreas.length).toBeGreaterThan(0);
+    });
 });

package/dist/repoIntelligenceSchema.d.ts

@@ -35,16 +35,17 @@ export declare const repoIntelligenceWireSchema: z.ZodObject<{
         }, z.core.$strip>;
         areas: z.ZodOptional<z.ZodArray<z.ZodString>>;
         dependencyClass: z.ZodOptional<z.ZodEnum<{
-            format: "format";
             unknown: "unknown";
             runtime: "runtime";
             build: "build";
             test: "test";
             tooling: "tooling";
             lint: "lint";
+            format: "format";
             ci: "ci";
         }>>;
         packageRole: z.ZodOptional<z.ZodEnum<{
+            queue: "queue";
             unknown: "unknown";
             typechecker: "typechecker";
             compiler: "compiler";
@@ -54,7 +55,6 @@ export declare const repoIntelligenceWireSchema: z.ZodObject<{
             test_runner: "test_runner";
             http_framework: "http_framework";
             auth: "auth";
-            queue: "queue";
             orm: "orm";
         }>>;
         lockfileKind: z.ZodOptional<z.ZodEnum<{
@@ -79,8 +79,8 @@ export declare const repoIntelligenceWireSchema: z.ZodObject<{
         }>>;
         evidenceStrength: z.ZodOptional<z.ZodEnum<{
             low: "low";
-            medium: "medium";
             high: "high";
+            medium: "medium";
         }>>;
         confidenceReason: z.ZodOptional<z.ZodString>;
         verificationFocus: z.ZodOptional<z.ZodArray<z.ZodString>>;