@mergesignal/shared 0.2.2 → 0.2.3

package/dist/scanCardSummary.test.js

@@ -1,4 +1,5 @@
 import { describe, it, expect } from "vitest";
+import { isCatalogPhrase } from "./cardObservationCatalog.js";
 import { aggregateFindingCounts, deriveRiskIndexBand, deriveScanCardSummary, deriveScanCardSummaryFromDenormalized, isPipelineCardSummary, isPipelinePlaceholderCopy, resolvePipelineStatus, resolvePrScanCardSummary, staleScanSubline, } from "./scanCardSummary.js";
 const baseResult = {
     totalScore: 10,
@@ -71,15 +72,26 @@ describe("deriveScanCardSummary", () => {
                 confidence: "high",
                 reasoning: ["Auth boundary change"],
             },
+            explain: {
+                reasons: [
+                    {
+                        id: "upgrade.1",
+                        layer: "upgradeImpact",
+                        title: "Large upgrade blast radius",
+                        scoreImpact: 20,
+                    },
+                ],
+            },
         };
         const summary = deriveScanCardSummary(r, "done");
         expect(summary.mergePosture).toBe("risky");
         expect(summary.headline).toBe("Risky");
         expect(summary.riskIndex).toBe(72);
         expect(summary.riskIndexBand).toBe("high");
-        expect(summary.summaryLine).toBe("Auth boundary change");
+        expect(summary.summaryLine).toBeNull();
+        expect(summary.operationalObservations).toContain("Large upgrade blast radius");
     });
-    it("uses safe copy when posture is safe and no findings", () => {
+    it("keeps quiet safe cards posture-only without observations", () => {
         const r = {
             ...baseResult,
             totalScore: 12,
@@ -90,9 +102,10 @@ describe("deriveScanCardSummary", () => {
             },
         };
         const summary = deriveScanCardSummary(r, "done");
-        expect(summary.summaryLine).toBe("No merge blockers detected");
+        expect(summary.summaryLine).toBeNull();
+        expect(summary.operationalObservations).toEqual([]);
     });
-    it("caps top affected areas at 2", () => {
+    it("surfaces catalog observations from explain signals", () => {
         const r = {
             ...baseResult,
             decision: {
@@ -102,14 +115,28 @@ describe("deriveScanCardSummary", () => {
             },
             explain: {
                 reasons: [
-                    { id: "1", layer: "security", title: "A", scoreImpact: -10 },
-                    { id: "2", layer: "security", title: "B", scoreImpact: -9 },
+                    {
+                        id: "1",
+                        layer: "ecosystem",
+                        title: "graph.transitive volume",
+                        scoreImpact: 18,
+                    },
+                    {
+                        id: "2",
+                        layer: "ecosystem",
+                        title: "graph.duplicates",
+                        scoreImpact: 12,
+                    },
                     { id: "3", layer: "security", title: "C", scoreImpact: -8 },
                 ],
             },
         };
         const summary = deriveScanCardSummary(r, "done");
         expect(summary.topAffectedAreas).toHaveLength(2);
+        expect(summary.operationalObservations.length).toBeGreaterThan(0);
+        for (const phrase of summary.operationalObservations) {
+            expect(isCatalogPhrase(phrase)).toBe(true);
+        }
     });
     it("exports stale subline constant", () => {
         expect(staleScanSubline()).toBe("Based on earlier commit");
@@ -149,6 +176,8 @@ describe("isPipelineCardSummary", () => {
             summaryLine: "Waiting for results…",
             findingCounts: null,
             topAffectedAreas: [],
+            operationalObservations: [],
+            supportingLine: null,
         })).toBe(true);
     });
     it("detects hybrid completed posture with pipeline summary line", () => {
@@ -160,6 +189,8 @@ describe("isPipelineCardSummary", () => {
             summaryLine: "Waiting for results…",
             findingCounts: null,
             topAffectedAreas: [],
+            operationalObservations: [],
+            supportingLine: null,
         })).toBe(true);
     });
 });
@@ -170,18 +201,24 @@ describe("isPipelinePlaceholderCopy", () => {
     });
 });
 describe("deriveScanCardSummaryFromDenormalized", () => {
-    it("builds risky summary from denormalized columns", () => {
+    it("builds risky summary from denormalized columns without generic narration", () => {
         const summary = deriveScanCardSummaryFromDenormalized("risky", 72, "Auth boundary change", "done");
         expect(summary.mergePosture).toBe("risky");
         expect(summary.headline).toBe("Risky");
         expect(summary.riskIndex).toBe(72);
-        expect(summary.summaryLine).toBe("Auth boundary change");
+        expect(summary.summaryLine).toBeNull();
+        expect(summary.operationalObservations).toEqual([]);
     });
     it("does not inject pipeline placeholder summaryText", () => {
         const summary = deriveScanCardSummaryFromDenormalized("risky", 72, "Waiting for results…", "done");
         expect(summary.mergePosture).toBe("risky");
         expect(summary.summaryLine).not.toBe("Waiting for results…");
     });
+    it("does not inject raw generic summaryText on quiet safe cards", () => {
+        const summary = deriveScanCardSummaryFromDenormalized("safe", 12, "No high-confidence merge risks from this PR dependency change", "done");
+        expect(summary.mergePosture).toBe("safe");
+        expect(summary.summaryLine).toBeNull();
+    });
 });
 describe("resolvePrScanCardSummary", () => {
     it("returns risk summary when wire status is running but decision exists", () => {

package/dist/truncateCardSummary.d.ts

@@ -0,0 +1,5 @@
+/**
+ * Semantic truncation for dashboard card summaries (~90 chars default).
+ */
+export declare function truncateCardSummary(text: string, maxLen?: number): string;
+//# sourceMappingURL=truncateCardSummary.d.ts.map

package/dist/truncateCardSummary.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"truncateCardSummary.d.ts","sourceRoot":"","sources":["../src/truncateCardSummary.ts"],"names":[],"mappings":"AAAA;;GAEG;AAIH,wBAAgB,mBAAmB,CACjC,IAAI,EAAE,MAAM,EACZ,MAAM,GAAE,MAAoB,GAC3B,MAAM,CA+BR"}

package/dist/truncateCardSummary.js

@@ -0,0 +1,23 @@
+/**
+ * Semantic truncation for dashboard card summaries (~90 chars default).
+ */
+const DEFAULT_MAX = 90;
+export function truncateCardSummary(text, maxLen = DEFAULT_MAX) {
+    const trimmed = text.trim();
+    if (trimmed.length <= maxLen)
+        return trimmed;
+    const slice = trimmed.slice(0, maxLen + 1);
+    const sentenceEnd = Math.max(slice.lastIndexOf(". "), slice.lastIndexOf("! "), slice.lastIndexOf("? "));
+    if (sentenceEnd >= Math.floor(maxLen * 0.45)) {
+        return trimmed.slice(0, sentenceEnd + 1).trim();
+    }
+    const clauseEnd = Math.max(slice.lastIndexOf(", "), slice.lastIndexOf("; "), slice.lastIndexOf(" — "), slice.lastIndexOf(" - "));
+    if (clauseEnd >= Math.floor(maxLen * 0.45)) {
+        return `${trimmed.slice(0, clauseEnd).trim()}…`;
+    }
+    const lastSpace = slice.lastIndexOf(" ");
+    if (lastSpace >= Math.floor(maxLen * 0.6)) {
+        return `${trimmed.slice(0, lastSpace).trim()}…`;
+    }
+    return `${trimmed.slice(0, maxLen).trim()}…`;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mergesignal/shared",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "description": "MergeSignal shared scan contract, presentation policy, and trusted validation",
   "type": "module",
   "main": "./dist/index.js",