@mergesignal/shared 0.11.0 → 0.12.1

package/dist/presentation/abi3Expression.test.js

@@ -0,0 +1,392 @@
+/**
+ * Wave 2.D — ABI 3 expression validation.
+ *
+ * Validates that:
+ * 1. projectReasoningLines reads from assessment.reasoning (ABI 3) when present
+ * 2. projectVerificationActions returns assessment.verificationScope.guidance when present
+ * 3. PR comment includes reviewFocalPoint.electionSummary when present
+ * 4. Check run "Why" section uses assessment.reasoning lines directly
+ * 5. No prohibited vocabulary appears in rendered surfaces
+ * 6. assessment.reasoning takes priority over decision.reasoning
+ */
+import { describe, expect, it } from "vitest";
+import { minimalReviewFocalPoint, reachScopeFor, verificationScopeFor, withAssessmentScope, } from "../fixtures/assessmentScopeFixtures.js";
+import { projectReasoningLines, projectVerificationActions, } from "../assessmentProjection.js";
+import { toPublicPresentation } from "../assessmentPresentationUtils.js";
+import { projectAssessmentFields } from "./projectAssessmentFields.js";
+import { buildScanPresentationBundle } from "./orchestration/buildScanPresentationBundle.js";
+import { presentGitHubPrComment } from "./presenters/presentGitHubPrComment.js";
+import { presentGitHubCheckRun } from "./presenters/presentGitHubCheckRun.js";
+import { buildGitHubCheckRunOutput } from "./buildGitHubCheckRunOutput.js";
+import { presentGitHubPrCommentMarkdownFromResult } from "../presentGitHubPrComment.js";
+// ---------------------------------------------------------------------------
+// ABI 3 — Canonical express/confirmed_runtime_usage fixture
+// ---------------------------------------------------------------------------
+const expressReasoning = [
+    "express is used in HTTP request handling in this repository via middleware chains.",
+    "Import paths to application entry points were directly observed.",
+    "Verification is required: review HTTP route definitions and middleware implementation.",
+];
+const expressGuidance = [
+    "Review HTTP route definitions and middleware implementation in src/app.ts and src/server.ts.",
+    "Review handler implementations that use express routing.",
+];
+const expressElectionSummary = "express was selected as the primary review anchor because it has the highest repository reach among changed packages and confirmed runtime usage in HTTP request handling.";
+const assessmentExpressAbi3 = withAssessmentScope({
+    posture: "needs_review",
+    confidence: "high",
+    primaryConcern: "confirmed_runtime_usage",
+    concerns: [
+        {
+            kind: "confirmed_runtime_usage",
+            rank: 1,
+            packages: ["express"],
+            evidenceRefs: ["fixture:express"],
+            context: "express participates in HTTP request handling across 12 files.",
+        },
+    ],
+    factors: ["confirmed_runtime_usage", "http_framework_infrastructure"],
+    changeClasses: ["runtime_upgrade"],
+    presentation: {
+        narrativeIntensity: "elevated",
+        reachVisibility: "prominent",
+        verificationIntensity: "required",
+        insightEmissionFloor: "full",
+        reportMode: "high_signal_pr",
+    },
+    reasoning: expressReasoning,
+    confidenceRationale: "Confidence is high: propagation from express to application entry points was directly observed.",
+}, {
+    reviewFocalPoint: {
+        ...minimalReviewFocalPoint(["express"]),
+        electionSummary: expressElectionSummary,
+    },
+    reachScope: reachScopeFor(["express"], "high"),
+    verificationScope: verificationScopeFor(["express"], ["routes", "middleware"], undefined),
+});
+const assessmentExpressAbi3WithGuidance = {
+    ...assessmentExpressAbi3,
+    verificationScope: {
+        ...assessmentExpressAbi3.verificationScope,
+        guidance: expressGuidance,
+    },
+};
+function scanResultWithAssessment(assessment, overrides = {}) {
+    return {
+        totalScore: 63,
+        layerScores: {
+            security: 10,
+            maintainability: 20,
+            ecosystem: 30,
+            upgradeImpact: 15,
+        },
+        findings: [],
+        generatedAt: "2026-01-01T00:00:00.000Z",
+        changedPackages: ["express"],
+        assessment,
+        decision: {
+            recommendation: "needs_review",
+            confidence: "high",
+            reasoning: ["Old generic decision reasoning — should not appear."],
+        },
+        ...overrides,
+    };
+}
+// ---------------------------------------------------------------------------
+// projectReasoningLines — ABI 3 priority
+// ---------------------------------------------------------------------------
+describe("projectReasoningLines — ABI 3", () => {
+    it("returns assessment.reasoning when present (ABI 3 takes priority)", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3);
+        const lines = projectReasoningLines(result);
+        expect(lines).toEqual(expressReasoning);
+    });
+    it("assessment.reasoning takes priority over decision.reasoning", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3);
+        const lines = projectReasoningLines(result);
+        expect(lines).not.toContain("Old generic decision reasoning — should not appear.");
+    });
+    it("falls back to decision.reasoning when assessment.reasoning is empty", () => {
+        const assessmentWithoutReasoning = {
+            ...assessmentExpressAbi3,
+            reasoning: [],
+        };
+        const result = scanResultWithAssessment(assessmentWithoutReasoning);
+        const lines = projectReasoningLines(result);
+        expect(lines).toEqual([
+            "Old generic decision reasoning — should not appear.",
+        ]);
+    });
+    it("returns empty array when both reasoning sources are absent", () => {
+        const assessmentEmpty = {
+            ...assessmentExpressAbi3,
+            reasoning: [],
+        };
+        const result = scanResultWithAssessment(assessmentEmpty, {
+            decision: {
+                recommendation: "needs_review",
+                confidence: "high",
+                reasoning: [],
+            },
+        });
+        const lines = projectReasoningLines(result);
+        expect(lines).toEqual([]);
+    });
+    it("reasoning lines contain no prohibited vocabulary", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3);
+        const lines = projectReasoningLines(result);
+        const joined = lines.join(" ");
+        const prohibited = [
+            "qualityClass",
+            "qualityBasis",
+            "proofFingerprint",
+            "observationId",
+            "propagationQualityRank",
+            "AssessmentEvidenceBundle",
+            "DenseEvidenceHighlight",
+            "will affect",
+            "will break",
+            "breaks compatibility",
+            "remain compatible",
+            "critical path",
+        ];
+        for (const term of prohibited) {
+            expect(joined).not.toContain(term);
+        }
+    });
+});
+// ---------------------------------------------------------------------------
+// projectVerificationActions — guidance priority
+// ---------------------------------------------------------------------------
+describe("projectVerificationActions — ABI 3 guidance", () => {
+    const presentation = toPublicPresentation(assessmentExpressAbi3WithGuidance.presentation);
+    it("returns guidance prose when verificationScope.guidance is present", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3WithGuidance);
+        const actions = projectVerificationActions(assessmentExpressAbi3WithGuidance, presentation, result, 6);
+        expect(actions).toEqual(expressGuidance);
+    });
+    it("guidance respects max limit", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3WithGuidance);
+        const actions = projectVerificationActions(assessmentExpressAbi3WithGuidance, presentation, result, 1);
+        expect(actions).toHaveLength(1);
+        expect(actions[0]).toBe(expressGuidance[0]);
+    });
+    it("falls back to focus tokens when guidance is absent", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3);
+        const actions = projectVerificationActions(assessmentExpressAbi3, presentation, result, 6);
+        // No guidance — falls back to runtime focus tokens
+        expect(actions).toEqual(expect.arrayContaining(["routes", "middleware"]));
+    });
+    it("returns empty when verificationIntensity is none", () => {
+        const noneAssessment = {
+            ...assessmentExpressAbi3WithGuidance,
+            presentation: {
+                ...assessmentExpressAbi3WithGuidance.presentation,
+                verificationIntensity: "none",
+            },
+        };
+        const result = scanResultWithAssessment(noneAssessment);
+        const actions = projectVerificationActions(noneAssessment, toPublicPresentation(noneAssessment.presentation), result, 6);
+        expect(actions).toEqual([]);
+    });
+});
+// ---------------------------------------------------------------------------
+// projectAssessmentFields — ABI 3 expression projection
+// ---------------------------------------------------------------------------
+describe("projectAssessmentFields — ABI 3 expression", () => {
+    it("projects confidenceRationale and electionSummary from assessment", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3);
+        const bundle = buildScanPresentationBundle({
+            result,
+            pipelineStatus: "done",
+        });
+        const fields = projectAssessmentFields(bundle);
+        expect(fields.confidenceRationale).toBe("Confidence is high: propagation from express to application entry points was directly observed.");
+        expect(fields.electionSummary).toBe(expressElectionSummary);
+        expect(fields.reasoning).toEqual(expressReasoning);
+    });
+    it("omits empty confidenceRationale and electionSummary after trim", () => {
+        const assessment = {
+            ...assessmentExpressAbi3,
+            confidenceRationale: "   ",
+            reviewFocalPoint: {
+                ...assessmentExpressAbi3.reviewFocalPoint,
+                electionSummary: "",
+            },
+        };
+        const result = scanResultWithAssessment(assessment);
+        const bundle = buildScanPresentationBundle({
+            result,
+            pipelineStatus: "done",
+        });
+        const fields = projectAssessmentFields(bundle);
+        expect(fields.confidenceRationale).toBeUndefined();
+        expect(fields.electionSummary).toBeUndefined();
+    });
+    it("projects reasoning when assessment has concerns", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3);
+        const bundle = buildScanPresentationBundle({
+            result,
+            pipelineStatus: "done",
+        });
+        const fields = projectAssessmentFields(bundle);
+        expect(assessmentExpressAbi3.concerns.length).toBeGreaterThan(0);
+        expect(fields.reasoning.length).toBeGreaterThan(0);
+        expect(fields.reasoning).toEqual(expressReasoning);
+    });
+});
+// ---------------------------------------------------------------------------
+// PR comment — electionSummary and reasoning
+// ---------------------------------------------------------------------------
+describe("presentGitHubPrComment — ABI 3 expression", () => {
+    function buildBundle(assessment) {
+        const result = scanResultWithAssessment(assessment, {
+            changedPackages: ["express"],
+        });
+        return buildScanPresentationBundle({ result, pipelineStatus: "done" });
+    }
+    it("introLines include electionSummary when present", () => {
+        const bundle = buildBundle(assessmentExpressAbi3);
+        const comment = presentGitHubPrComment(bundle);
+        expect(comment.introLines).toContain(expressElectionSummary);
+    });
+    it("introLines include assessment.reasoning sentences", () => {
+        const bundle = buildBundle(assessmentExpressAbi3);
+        const comment = presentGitHubPrComment(bundle);
+        const joined = comment.introLines.join(" ");
+        expect(joined).toContain("express is used in HTTP request handling");
+        expect(joined).toContain("Import paths to application entry points");
+    });
+    it("electionSummary is absent from introLines when not set", () => {
+        const assessmentNoElection = {
+            ...assessmentExpressAbi3,
+            reviewFocalPoint: {
+                ...assessmentExpressAbi3.reviewFocalPoint,
+                electionSummary: undefined,
+            },
+        };
+        const bundle = buildBundle(assessmentNoElection);
+        const comment = presentGitHubPrComment(bundle);
+        expect(comment.introLines).not.toContain(expressElectionSummary);
+    });
+    it("introLines contain no prohibited vocabulary", () => {
+        const bundle = buildBundle(assessmentExpressAbi3);
+        const comment = presentGitHubPrComment(bundle);
+        const joined = comment.introLines.join(" ");
+        const prohibited = [
+            "qualityClass",
+            "qualityBasis",
+            "proofFingerprint",
+            "observationId",
+            "propagationQualityRank",
+        ];
+        for (const term of prohibited) {
+            expect(joined).not.toContain(term);
+        }
+    });
+});
+// ---------------------------------------------------------------------------
+// Check run — Why section uses assessment.reasoning
+// ---------------------------------------------------------------------------
+describe("presentGitHubCheckRun — ABI 3 Why section", () => {
+    const SCAN_ID = "scan-abi3-test";
+    const ORIGIN = "https://app.test";
+    function buildBundle(assessment) {
+        const result = scanResultWithAssessment(assessment, {
+            changedPackages: ["express"],
+        });
+        return buildScanPresentationBundle({ result, pipelineStatus: "done" });
+    }
+    it("Why section bullets come from assessment.reasoning (ABI 3)", () => {
+        const bundle = buildBundle(assessmentExpressAbi3);
+        const checkRun = presentGitHubCheckRun(bundle, {
+            scanId: SCAN_ID,
+            webAppOrigin: ORIGIN,
+        });
+        const whySection = checkRun.sections.find((s) => s.id === "why" && s.title === "Why");
+        expect(whySection).toBeDefined();
+        expect(whySection.bullets).toEqual(expect.arrayContaining([
+            "express is used in HTTP request handling in this repository via middleware chains.",
+        ]));
+    });
+    it("Why section does not contain old generic decision reasoning", () => {
+        const bundle = buildBundle(assessmentExpressAbi3);
+        const checkRun = presentGitHubCheckRun(bundle, {
+            scanId: SCAN_ID,
+            webAppOrigin: ORIGIN,
+        });
+        const whySection = checkRun.sections.find((s) => s.id === "why" && s.title === "Why");
+        const bulletText = whySection?.bullets.join(" ") ?? "";
+        expect(bulletText).not.toContain("Old generic decision reasoning");
+    });
+    it("check run summary contains no prohibited vocabulary", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3, {
+            changedPackages: ["express"],
+            methodologyVersion: "mergesignal-engine/test",
+        });
+        const output = buildGitHubCheckRunOutput(result, {
+            scanId: SCAN_ID,
+            webAppOrigin: ORIGIN,
+        });
+        const prohibited = [
+            "qualityClass",
+            "qualityBasis",
+            "proofFingerprint",
+            "observationId",
+            "propagationQualityRank",
+            "AssessmentEvidenceBundle",
+        ];
+        for (const term of prohibited) {
+            expect(output.summary).not.toContain(term);
+        }
+    });
+    it("Why section respects 3-line limit", () => {
+        const bundle = buildBundle(assessmentExpressAbi3);
+        const checkRun = presentGitHubCheckRun(bundle, {
+            scanId: SCAN_ID,
+            webAppOrigin: ORIGIN,
+        });
+        const whySection = checkRun.sections.find((s) => s.title === "Why");
+        if (whySection) {
+            expect(whySection.bullets.length).toBeLessThanOrEqual(3);
+        }
+    });
+});
+// ---------------------------------------------------------------------------
+// End-to-end markdown snapshot — PR comment with ABI 3 fixture
+// ---------------------------------------------------------------------------
+describe("PR comment markdown — ABI 3 end-to-end", () => {
+    it("rendered markdown includes repository-specific reasoning", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3, {
+            changedPackages: ["express"],
+        });
+        const markdown = presentGitHubPrCommentMarkdownFromResult(result);
+        expect(markdown).toContain("express is used in HTTP request handling");
+        expect(markdown).toContain("Import paths to application entry points");
+    });
+    it("rendered markdown includes electionSummary", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3, {
+            changedPackages: ["express"],
+        });
+        const markdown = presentGitHubPrCommentMarkdownFromResult(result);
+        expect(markdown).toContain("express was selected as the primary review anchor");
+    });
+    it("rendered markdown contains no prohibited vocabulary", () => {
+        const result = scanResultWithAssessment(assessmentExpressAbi3, {
+            changedPackages: ["express"],
+        });
+        const markdown = presentGitHubPrCommentMarkdownFromResult(result);
+        const prohibited = [
+            "qualityClass",
+            "qualityBasis",
+            "proofFingerprint",
+            "observationId",
+            "propagationQualityRank",
+            "AssessmentEvidenceBundle",
+            "DenseEvidenceHighlight",
+        ];
+        for (const term of prohibited) {
+            expect(markdown).not.toContain(term);
+        }
+    });
+});

package/dist/presentation/cliParity.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=cliParity.test.d.ts.map

package/dist/presentation/cliParity.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"cliParity.test.d.ts","sourceRoot":"","sources":["../../src/presentation/cliParity.test.ts"],"names":[],"mappings":""}

package/dist/presentation/cliParity.test.js

@@ -0,0 +1,49 @@
+import { describe, expect, it } from "vitest";
+import { buildScanPresentationBundle } from "./orchestration/buildScanPresentationBundle.js";
+import { presentCliScanSummary } from "./presenters/presentCliScanSummary.js";
+import { presentDashboardCard } from "./presenters/presentDashboardCard.js";
+import { presentGitHubCheckRun } from "./presenters/presentGitHubCheckRun.js";
+import { presentGitHubPrComment } from "./presenters/presentGitHubPrComment.js";
+import { presentScanDetails } from "./presenters/presentScanDetails.js";
+import { projectAssessmentFields } from "./projectAssessmentFields.js";
+import { scanResultBullmq, scanResultEslint, scanResultFastifyRuntime, scanResultMixedTypescriptFastify, scanResultPrettier, scanResultTypescriptPatch, scanResultVitest, } from "./fixtures/presentationPersonaFixtures.js";
+const SCAN_ID = "22222222-2222-4222-8222-222222222222";
+const ORIGIN = "https://app.example.com";
+const validationPersonas = [
+    { name: "mixed-ts-fastify", result: scanResultMixedTypescriptFastify },
+    { name: "fastify-runtime", result: scanResultFastifyRuntime },
+    { name: "typescript-patch", result: scanResultTypescriptPatch },
+    { name: "prettier", result: scanResultPrettier },
+    { name: "bullmq", result: scanResultBullmq },
+    { name: "eslint", result: scanResultEslint },
+    { name: "vitest", result: scanResultVitest },
+];
+describe("cliParity guardrail", () => {
+    for (const persona of validationPersonas) {
+        it(`${persona.name}: CLI shares assessment fields with other surfaces`, () => {
+            const bundle = buildScanPresentationBundle({
+                result: persona.result,
+                pipelineStatus: "done",
+            });
+            const fields = projectAssessmentFields(bundle);
+            const cli = presentCliScanSummary(bundle, { repoLabel: "acme/api" });
+            const card = presentDashboardCard(bundle);
+            const details = presentScanDetails(bundle, { scanId: SCAN_ID });
+            const check = presentGitHubCheckRun(bundle, {
+                scanId: SCAN_ID,
+                webAppOrigin: ORIGIN,
+            });
+            const comment = presentGitHubPrComment(bundle);
+            expect(cli.posture).toBe(fields.posture);
+            expect(cli.reasoning).toEqual(fields.reasoning);
+            expect(cli.verificationChannel).toBe(fields.verificationChannel);
+            expect(cli.verificationFocus).toEqual(fields.verificationFocus);
+            expect(cli.confidenceRationale).toBe(fields.confidenceRationale);
+            expect(cli.electionSummary).toBe(fields.electionSummary);
+            expect(cli.reasoning).toEqual(card.reasoning);
+            expect(cli.reasoning).toEqual(details.reasoning);
+            expect(cli.reasoning).toEqual(check.reasoning);
+            expect(cli.reasoning).toEqual(comment.reasoning);
+        });
+    }
+});

package/dist/presentation/compose/narrativeCompose.d.ts

@@ -5,10 +5,6 @@ export declare function composeSubheadline(bundle: ScanPresentationBundle): stri
 export declare function composeKeyPoints(bundle: ScanPresentationBundle, max: number): string[];
 export declare function composeVerificationActions(bundle: ScanPresentationBundle, max: number): string[];
 export declare function composeAffectedAreaLabels(bundle: ScanPresentationBundle, max: number): string[];
-export declare function composeEvidenceRows(bundle: ScanPresentationBundle, max: number): Array<{
-    label: string;
-    value: string;
-}>;
 export declare function composeSupportingContext(bundle: ScanPresentationBundle): string[] | undefined;
 export declare function evidenceContextFromProfile(bundle: ScanPresentationBundle): {
     priority: "pr_intelligence" | "limited";

package/dist/presentation/compose/narrativeCompose.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"narrativeCompose.d.ts","sourceRoot":"","sources":["../../../src/presentation/compose/narrativeCompose.ts"],"names":[],"mappings":"AAQA,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,4CAA4C,CAAC;AAMzF,OAAO,EACL,sBAAsB,EACtB,uBAAuB,GACxB,MAAM,wBAAwB,CAAC;AAShC,wBAAgB,eAAe,CAAC,MAAM,EAAE,sBAAsB,GAAG,MAAM,CAEtE;AAED,wBAAgB,kBAAkB,CAChC,MAAM,EAAE,sBAAsB,GAC7B,MAAM,GAAG,SAAS,CAIpB;AAED,wBAAgB,gBAAgB,CAC9B,MAAM,EAAE,sBAAsB,EAC9B,GAAG,EAAE,MAAM,GACV,MAAM,EAAE,CAEV;AAED,wBAAgB,0BAA0B,CACxC,MAAM,EAAE,sBAAsB,EAC9B,GAAG,EAAE,MAAM,GACV,MAAM,EAAE,CAEV;AAED,wBAAgB,yBAAyB,CACvC,MAAM,EAAE,sBAAsB,EAC9B,GAAG,EAAE,MAAM,GACV,MAAM,EAAE,CAQV;AAED,wBAAgB,mBAAmB,CACjC,MAAM,EAAE,sBAAsB,EAC9B,GAAG,EAAE,MAAM,GACV,KAAK,CAAC;IAAE,KAAK,EAAE,MAAM,CAAC;IAAC,KAAK,EAAE,MAAM,CAAA;CAAE,CAAC,CAmBzC;AAED,wBAAgB,wBAAwB,CACtC,MAAM,EAAE,sBAAsB,GAC7B,MAAM,EAAE,GAAG,SAAS,CAwBtB;AAED,wBAAgB,0BAA0B,CAAC,MAAM,EAAE,sBAAsB,GAAG;IAC1E,QAAQ,EAAE,iBAAiB,GAAG,SAAS,CAAC;IACxC,eAAe,CAAC,EAAE,MAAM,CAAC;CAC1B,CAKA"}
+{"version":3,"file":"narrativeCompose.d.ts","sourceRoot":"","sources":["../../../src/presentation/compose/narrativeCompose.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,4CAA4C,CAAC;AAMzF,OAAO,EACL,sBAAsB,EACtB,uBAAuB,GACxB,MAAM,wBAAwB,CAAC;AAShC,wBAAgB,eAAe,CAAC,MAAM,EAAE,sBAAsB,GAAG,MAAM,CAEtE;AAED,wBAAgB,kBAAkB,CAChC,MAAM,EAAE,sBAAsB,GAC7B,MAAM,GAAG,SAAS,CAIpB;AAED,wBAAgB,gBAAgB,CAC9B,MAAM,EAAE,sBAAsB,EAC9B,GAAG,EAAE,MAAM,GACV,MAAM,EAAE,CAEV;AAED,wBAAgB,0BAA0B,CACxC,MAAM,EAAE,sBAAsB,EAC9B,GAAG,EAAE,MAAM,GACV,MAAM,EAAE,CAEV;AAED,wBAAgB,yBAAyB,CACvC,MAAM,EAAE,sBAAsB,EAC9B,GAAG,EAAE,MAAM,GACV,MAAM,EAAE,CAQV;AAED,wBAAgB,wBAAwB,CACtC,MAAM,EAAE,sBAAsB,GAC7B,MAAM,EAAE,GAAG,SAAS,CAwBtB;AAED,wBAAgB,0BAA0B,CAAC,MAAM,EAAE,sBAAsB,GAAG;IAC1E,QAAQ,EAAE,iBAAiB,GAAG,SAAS,CAAC;IACxC,eAAe,CAAC,EAAE,MAAM,CAAC;CAC1B,CAKA"}

package/dist/presentation/compose/narrativeCompose.js

@@ -1,5 +1,4 @@
 import { formatCardAreaLabels } from "../../formatCardAreaLabels.js";
-import { formatChangedPackagesShort, labelBlastRadiusLevel, labelReachabilityKind, labelRuntimeSurface, } from "../../narrativePresentation.js";
 import { scanSurfaceCopy } from "../../scanSurfaceCopy.js";
 import { buildNarrativeChannels, projectCompactKeyPoints, } from "./narrativeChannels.js";
 export { buildNarrativeChannels, projectCompactKeyPoints, } from "./narrativeChannels.js";
@@ -36,25 +35,6 @@ export function composeAffectedAreaLabels(bundle, max) {
     }
     return labels;
 }
-export function composeEvidenceRows(bundle, max) {
-    const { facts, profile } = bundle;
-    const rows = [];
-    if (!profile.interpretation.suppressRuntimeNarrative) {
-        const runtime = labelRuntimeSurface(facts);
-        if (runtime)
-            rows.push({ label: "Runtime", value: runtime });
-        const reach = labelReachabilityKind(facts);
-        if (reach)
-            rows.push({ label: "Reachability", value: reach });
-    }
-    const blast = labelBlastRadiusLevel(facts);
-    if (blast)
-        rows.push({ label: "Blast radius", value: blast });
-    const changed = formatChangedPackagesShort(facts, 3);
-    if (changed)
-        rows.push({ label: "Changed", value: changed });
-    return rows.slice(0, max);
-}
 export function composeSupportingContext(bundle) {
     const { facts, profile, result } = bundle;
     if (profile.density === "minimal")

package/dist/presentation/dto/assessmentPresentationFields.d.ts

@@ -10,5 +10,9 @@ export type AssessmentPresentationFields = {
     verificationChannel: VerificationChannel;
     reachVisibility: ReachVisibility;
     narrativeIntensity: NarrativeIntensity;
+    /** ABI 3 expression — optional confidence explanation. */
+    confidenceRationale?: string;
+    /** ABI 3 expression — optional focal-election narrative. */
+    electionSummary?: string;
 };
 //# sourceMappingURL=assessmentPresentationFields.d.ts.map

package/dist/presentation/dto/assessmentPresentationFields.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"assessmentPresentationFields.d.ts","sourceRoot":"","sources":["../../../src/presentation/dto/assessmentPresentationFields.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,gBAAgB,EAChB,kBAAkB,EAClB,eAAe,EAEhB,MAAM,wBAAwB,CAAC;AAChC,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,+BAA+B,CAAC;AAEzE,uEAAuE;AACvE,MAAM,MAAM,4BAA4B,GAAG;IACzC,OAAO,EAAE,MAAM,GAAG,cAAc,GAAG,OAAO,CAAC;IAC3C,cAAc,EAAE,gBAAgB,GAAG,IAAI,CAAC;IACxC,OAAO,EAAE,MAAM,EAAE,CAAC;IAClB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,iBAAiB,EAAE,MAAM,EAAE,CAAC;IAC5B,mBAAmB,EAAE,mBAAmB,CAAC;IACzC,eAAe,EAAE,eAAe,CAAC;IACjC,kBAAkB,EAAE,kBAAkB,CAAC;CACxC,CAAC"}
+{"version":3,"file":"assessmentPresentationFields.d.ts","sourceRoot":"","sources":["../../../src/presentation/dto/assessmentPresentationFields.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,gBAAgB,EAChB,kBAAkB,EAClB,eAAe,EAEhB,MAAM,wBAAwB,CAAC;AAChC,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,+BAA+B,CAAC;AAEzE,uEAAuE;AACvE,MAAM,MAAM,4BAA4B,GAAG;IACzC,OAAO,EAAE,MAAM,GAAG,cAAc,GAAG,OAAO,CAAC;IAC3C,cAAc,EAAE,gBAAgB,GAAG,IAAI,CAAC;IACxC,OAAO,EAAE,MAAM,EAAE,CAAC;IAClB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,iBAAiB,EAAE,MAAM,EAAE,CAAC;IAC5B,mBAAmB,EAAE,mBAAmB,CAAC;IACzC,eAAe,EAAE,eAAe,CAAC;IACjC,kBAAkB,EAAE,kBAAkB,CAAC;IACvC,0DAA0D;IAC1D,mBAAmB,CAAC,EAAE,MAAM,CAAC;IAC7B,4DAA4D;IAC5D,eAAe,CAAC,EAAE,MAAM,CAAC;CAC1B,CAAC"}

package/dist/presentation/index.d.ts

@@ -24,5 +24,5 @@ export { renderGitHubCheckRunMarkdown } from "./render/renderGitHubCheckRunMarkd
 export { buildGitHubCheckRunOutput, resolveWebAppOrigin, type GitHubCheckRunConclusion, type GitHubCheckRunOutput, type BuildGitHubCheckRunOutputOptions, } from "./buildGitHubCheckRunOutput.js";
 export { renderGitHubPrCommentMarkdown } from "./render/renderGitHubPrCommentMarkdown.js";
 export { renderCliScanSummaryText } from "./render/renderCliScanSummaryText.js";
-export { buildNarrativeChannels, projectCompactKeyPoints, composeHeadline, composeSubheadline, composeKeyPoints, composeVerificationActions, composeAffectedAreaLabels, composeEvidenceRows, composeSupportingContext, evidenceContextFromProfile, } from "./compose/narrativeCompose.js";
+export { buildNarrativeChannels, projectCompactKeyPoints, composeHeadline, composeSubheadline, composeKeyPoints, composeVerificationActions, composeAffectedAreaLabels, composeSupportingContext, evidenceContextFromProfile, } from "./compose/narrativeCompose.js";
 //# sourceMappingURL=index.d.ts.map

package/dist/presentation/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/presentation/index.ts"],"names":[],"mappings":"AAAA,YAAY,EAAE,sBAAsB,EAAE,MAAM,2CAA2C,CAAC;AACxF,OAAO,EAAE,2BAA2B,EAAE,MAAM,gDAAgD,CAAC;AAC7F,YAAY,EAAE,gCAAgC,EAAE,MAAM,gDAAgD,CAAC;AACvG,OAAO,EAAE,yBAAyB,EAAE,MAAM,8CAA8C,CAAC;AACzF,YAAY,EAAE,8BAA8B,EAAE,MAAM,8CAA8C,CAAC;AACnG,OAAO,EAAE,4BAA4B,EAAE,MAAM,iDAAiD,CAAC;AAC/F,YAAY,EAAE,iCAAiC,EAAE,MAAM,iDAAiD,CAAC;AAEzG,YAAY,EAAE,mBAAmB,EAAE,MAAM,kCAAkC,CAAC;AAC5E,YAAY,EACV,kBAAkB,EAClB,0BAA0B,GAC3B,MAAM,gCAAgC,CAAC;AACxC,YAAY,EACV,cAAc,EACd,kBAAkB,EAClB,mBAAmB,EACnB,sBAAsB,EACtB,oBAAoB,EACpB,2BAA2B,EAC3B,uBAAuB,GACxB,MAAM,gBAAgB,CAAC;AAExB,YAAY,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AACpF,YAAY,EAAE,mBAAmB,EAAE,MAAM,oCAAoC,CAAC;AAC9E,gDAAgD;AAChD,YAAY,EAAE,yBAAyB,IAAI,oBAAoB,EAAE,MAAM,oCAAoC,CAAC;AAC5G,YAAY,EAAE,uBAAuB,EAAE,MAAM,kCAAkC,CAAC;AAChF,YAAY,EACV,0BAA0B,EAC1B,2BAA2B,EAC3B,mBAAmB,GACpB,MAAM,mCAAmC,CAAC;AAE3C,OAAO,EACL,oBAAoB,EACpB,4BAA4B,EAC5B,sCAAsC,GACvC,MAAM,sCAAsC,CAAC;AAC9C,OAAO,EAAE,kBAAkB,EAAE,MAAM,oCAAoC,CAAC;AACxE,YAAY,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AACpF,OAAO,EAAE,qBAAqB,EAAE,MAAM,uCAAuC,CAAC;AAC9E,OAAO,EAAE,sBAAsB,EAAE,MAAM,wCAAwC,CAAC;AAChF,OAAO,EAAE,qBAAqB,EAAE,MAAM,uCAAuC,CAAC;AAE9E,OAAO,EAAE,4BAA4B,EAAE,MAAM,0CAA0C,CAAC;AACxF,OAAO,EACL,yBAAyB,EACzB,mBAAmB,EACnB,KAAK,wBAAwB,EAC7B,KAAK,oBAAoB,EACzB,KAAK,gCAAgC,GACtC,MAAM,gCAAgC,CAAC;AACxC,OAAO,EAAE,6BAA6B,EAAE,MAAM,2CAA2C,CAAC;AAC1F,OAAO,EAAE,wBAAwB,EAAE,MAAM,sCAAsC,CAAC;AAEhF,OAAO,EACL,sBAAsB,EACtB,uBAAuB,EACvB,eAAe,EACf,kBAAkB,EAClB,gBAAgB,EAChB,0BAA0B,EAC1B,yBAAyB,EACzB,mBAAmB,EACnB,wBAAwB,EACxB,0BAA0B,GAC3B,MAAM,+BAA+B,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/presentation/index.ts"],"names":[],"mappings":"AAAA,YAAY,EAAE,sBAAsB,EAAE,MAAM,2CAA2C,CAAC;AACxF,OAAO,EAAE,2BAA2B,EAAE,MAAM,gDAAgD,CAAC;AAC7F,YAAY,EAAE,gCAAgC,EAAE,MAAM,gDAAgD,CAAC;AACvG,OAAO,EAAE,yBAAyB,EAAE,MAAM,8CAA8C,CAAC;AACzF,YAAY,EAAE,8BAA8B,EAAE,MAAM,8CAA8C,CAAC;AACnG,OAAO,EAAE,4BAA4B,EAAE,MAAM,iDAAiD,CAAC;AAC/F,YAAY,EAAE,iCAAiC,EAAE,MAAM,iDAAiD,CAAC;AAEzG,YAAY,EAAE,mBAAmB,EAAE,MAAM,kCAAkC,CAAC;AAC5E,YAAY,EACV,kBAAkB,EAClB,0BAA0B,GAC3B,MAAM,gCAAgC,CAAC;AACxC,YAAY,EACV,cAAc,EACd,kBAAkB,EAClB,mBAAmB,EACnB,sBAAsB,EACtB,oBAAoB,EACpB,2BAA2B,EAC3B,uBAAuB,GACxB,MAAM,gBAAgB,CAAC;AAExB,YAAY,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AACpF,YAAY,EAAE,mBAAmB,EAAE,MAAM,oCAAoC,CAAC;AAC9E,gDAAgD;AAChD,YAAY,EAAE,yBAAyB,IAAI,oBAAoB,EAAE,MAAM,oCAAoC,CAAC;AAC5G,YAAY,EAAE,uBAAuB,EAAE,MAAM,kCAAkC,CAAC;AAChF,YAAY,EACV,0BAA0B,EAC1B,2BAA2B,EAC3B,mBAAmB,GACpB,MAAM,mCAAmC,CAAC;AAE3C,OAAO,EACL,oBAAoB,EACpB,4BAA4B,EAC5B,sCAAsC,GACvC,MAAM,sCAAsC,CAAC;AAC9C,OAAO,EAAE,kBAAkB,EAAE,MAAM,oCAAoC,CAAC;AACxE,YAAY,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AACpF,OAAO,EAAE,qBAAqB,EAAE,MAAM,uCAAuC,CAAC;AAC9E,OAAO,EAAE,sBAAsB,EAAE,MAAM,wCAAwC,CAAC;AAChF,OAAO,EAAE,qBAAqB,EAAE,MAAM,uCAAuC,CAAC;AAE9E,OAAO,EAAE,4BAA4B,EAAE,MAAM,0CAA0C,CAAC;AACxF,OAAO,EACL,yBAAyB,EACzB,mBAAmB,EACnB,KAAK,wBAAwB,EAC7B,KAAK,oBAAoB,EACzB,KAAK,gCAAgC,GACtC,MAAM,gCAAgC,CAAC;AACxC,OAAO,EAAE,6BAA6B,EAAE,MAAM,2CAA2C,CAAC;AAC1F,OAAO,EAAE,wBAAwB,EAAE,MAAM,sCAAsC,CAAC;AAEhF,OAAO,EACL,sBAAsB,EACtB,uBAAuB,EACvB,eAAe,EACf,kBAAkB,EAClB,gBAAgB,EAChB,0BAA0B,EAC1B,yBAAyB,EACzB,wBAAwB,EACxB,0BAA0B,GAC3B,MAAM,+BAA+B,CAAC"}

package/dist/presentation/index.js

@@ -10,4 +10,4 @@ export { renderGitHubCheckRunMarkdown } from "./render/renderGitHubCheckRunMarkd
 export { buildGitHubCheckRunOutput, resolveWebAppOrigin, } from "./buildGitHubCheckRunOutput.js";
 export { renderGitHubPrCommentMarkdown } from "./render/renderGitHubPrCommentMarkdown.js";
 export { renderCliScanSummaryText } from "./render/renderCliScanSummaryText.js";
-export { buildNarrativeChannels, projectCompactKeyPoints, composeHeadline, composeSubheadline, composeKeyPoints, composeVerificationActions, composeAffectedAreaLabels, composeEvidenceRows, composeSupportingContext, evidenceContextFromProfile, } from "./compose/narrativeCompose.js";
+export { buildNarrativeChannels, projectCompactKeyPoints, composeHeadline, composeSubheadline, composeKeyPoints, composeVerificationActions, composeAffectedAreaLabels, composeSupportingContext, evidenceContextFromProfile, } from "./compose/narrativeCompose.js";

package/dist/presentation/orchestration/buildScanPresentationBundle.d.ts

@@ -9,6 +9,7 @@ export type BuildScanPresentationBundleInput = {
 /**
  * Mandatory orchestration entrypoint for completed-scan presentation.
  * Assessment is the sole authority; profile is a thin projection.
+ * Consumes only the public ScanResult contract — see docs/engineering/presentation-ownership.md.
  */
 export declare function buildScanPresentationBundle(input: BuildScanPresentationBundleInput): ScanPresentationBundle | null;
 //# sourceMappingURL=buildScanPresentationBundle.d.ts.map

package/dist/presentation/orchestration/buildScanPresentationBundle.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"buildScanPresentationBundle.d.ts","sourceRoot":"","sources":["../../../src/presentation/orchestration/buildScanPresentationBundle.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AACjD,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEtD,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,6BAA6B,CAAC;AAE1E,MAAM,MAAM,gCAAgC,GAAG;IAC7C,MAAM,EAAE,UAAU,CAAC;IACnB,cAAc,EAAE,cAAc,CAAC;IAC/B,QAAQ,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CAC1B,CAAC;AAEF;;;GAGG;AACH,wBAAgB,2BAA2B,CACzC,KAAK,EAAE,gCAAgC,GACtC,sBAAsB,GAAG,IAAI,CA4B/B"}
+{"version":3,"file":"buildScanPresentationBundle.d.ts","sourceRoot":"","sources":["../../../src/presentation/orchestration/buildScanPresentationBundle.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AACjD,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEtD,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,6BAA6B,CAAC;AAE1E,MAAM,MAAM,gCAAgC,GAAG;IAC7C,MAAM,EAAE,UAAU,CAAC;IACnB,cAAc,EAAE,cAAc,CAAC;IAC/B,QAAQ,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CAC1B,CAAC;AAEF;;;;GAIG;AACH,wBAAgB,2BAA2B,CACzC,KAAK,EAAE,gCAAgC,GACtC,sBAAsB,GAAG,IAAI,CA4B/B"}

package/dist/presentation/orchestration/buildScanPresentationBundle.js

@@ -5,6 +5,7 @@ import { buildProfileFromAssessment } from "../profile/buildProfileFromAssessmen
 /**
  * Mandatory orchestration entrypoint for completed-scan presentation.
  * Assessment is the sole authority; profile is a thin projection.
+ * Consumes only the public ScanResult contract — see docs/engineering/presentation-ownership.md.
  */
 export function buildScanPresentationBundle(input) {
     if (input.pipelineStatus !== "done" || !input.result)

package/dist/presentation/presenters/presentCliScanSummary.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"presentCliScanSummary.d.ts","sourceRoot":"","sources":["../../../src/presentation/presenters/presentCliScanSummary.ts"],"names":[],"mappings":"AAWA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oCAAoC,CAAC;AAC9E,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,4CAA4C,CAAC;AAGzF,wBAAgB,qBAAqB,CACnC,MAAM,EAAE,sBAAsB,EAC9B,GAAG,GAAE;IAAE,SAAS,CAAC,EAAE,MAAM,CAAA;CAAO,GAC/B,mBAAmB,CAiCrB"}
+{"version":3,"file":"presentCliScanSummary.d.ts","sourceRoot":"","sources":["../../../src/presentation/presenters/presentCliScanSummary.ts"],"names":[],"mappings":"AASA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oCAAoC,CAAC;AAC9E,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,4CAA4C,CAAC;AAGzF,wBAAgB,qBAAqB,CACnC,MAAM,EAAE,sBAAsB,EAC9B,GAAG,GAAE;IAAE,SAAS,CAAC,EAAE,MAAM,CAAA;CAAO,GAC/B,mBAAmB,CAmCrB"}

package/dist/presentation/presenters/presentCliScanSummary.js

@@ -1,14 +1,16 @@
-import { scoreToBandLabel } from "../../prRiskBand.js";
+import { formatPrRiskSummary } from "../../prRiskBand.js";
 import { resolvePrRiskLayerScores } from "../../prRiskWire.js";
-import { buildNarrativeChannels, composeHeadline, composeSubheadline, composeSupportingContext, composeVerificationActions, evidenceContextFromProfile, projectCompactKeyPoints, } from "../compose/narrativeCompose.js";
+import { buildNarrativeChannels, composeSubheadline, composeSupportingContext, evidenceContextFromProfile, projectCompactKeyPoints, } from "../compose/narrativeCompose.js";
 import { projectAssessmentFields } from "../projectAssessmentFields.js";
 export function presentCliScanSummary(bundle, ctx = {}) {
     const { facts, profile, result } = bundle;
+    const channels = buildNarrativeChannels(bundle);
     const layerScores = resolvePrRiskLayerScores(result);
     const layerLine = layerScores
         ? `security=${layerScores.security} maintainability=${layerScores.maintainability} ecosystem=${layerScores.ecosystem} upgradeImpact=${layerScores.upgradeImpact}`
         : "";
-    const prRiskScore = facts.riskSignals?.riskIndex ?? facts.riskIndex ?? 0;
+    const prRisk = formatPrRiskSummary(facts);
+    const prRiskScore = prRisk?.prRiskScore ?? facts.riskIndex ?? 0;
     return {
         ...projectAssessmentFields(bundle),
         header: {
@@ -20,13 +22,13 @@ export function presentCliScanSummary(bundle, ctx = {}) {
         density: profile.density,
         confidence: profile.confidence,
         evidenceContext: evidenceContextFromProfile(bundle),
-        headline: composeHeadline(bundle),
+        headline: channels.headline,
         subheadline: composeSubheadline(bundle),
-        keyPoints: projectCompactKeyPoints(buildNarrativeChannels(bundle), 6),
-        verificationActions: composeVerificationActions(bundle, 5),
+        keyPoints: projectCompactKeyPoints(channels, 6),
+        verificationActions: channels.verification.slice(0, 5),
         metrics: {
             prRiskScore,
-            prRiskBandLabel: scoreToBandLabel(prRiskScore) ?? undefined,
+            prRiskBandLabel: prRisk?.prRiskBandLabel ?? undefined,
             riskIndex: prRiskScore,
             layerLine,
             findingCount: result.findings?.length ?? 0,

package/dist/presentation/presenters/presentGitHubCheckRun.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"presentGitHubCheckRun.d.ts","sourceRoot":"","sources":["../../../src/presentation/presenters/presentGitHubCheckRun.ts"],"names":[],"mappings":"AASA,OAAO,KAAK,EAAE,0BAA0B,EAAE,MAAM,oCAAoC,CAAC;AACrF,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,4CAA4C,CAAC;AAGzF,wBAAgB,qBAAqB,CACnC,MAAM,EAAE,sBAAsB,EAC9B,GAAG,EAAE;IAAE,MAAM,EAAE,MAAM,CAAC;IAAC,YAAY,EAAE,MAAM,CAAC;IAAC,QAAQ,CAAC,EAAE,OAAO,CAAA;CAAE,GAChE,0BAA0B,CA4C5B"}
+{"version":3,"file":"presentGitHubCheckRun.d.ts","sourceRoot":"","sources":["../../../src/presentation/presenters/presentGitHubCheckRun.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,EAAE,0BAA0B,EAAE,MAAM,oCAAoC,CAAC;AACrF,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,4CAA4C,CAAC;AAGzF,wBAAgB,qBAAqB,CACnC,MAAM,EAAE,sBAAsB,EAC9B,GAAG,EAAE;IAAE,MAAM,EAAE,MAAM,CAAC;IAAC,YAAY,EAAE,MAAM,CAAC;IAAC,QAAQ,CAAC,EAAE,OAAO,CAAA;CAAE,GAChE,0BAA0B,CAkD5B"}