@merchi/sdk 1.42.21 → 1.42.22

package/dist/constants/errors.d.ts

@@ -23,4 +23,4 @@ export declare enum ErrorType {
     BAD_SMS_TOKEN = 21,
     DOMAIN_NOT_FOUND = 22
 }
-export declare function getErrorFromCode(code: number): ErrorType;
+export declare function getErrorFromCode(code: unknown): number;

package/dist/constants/errors.js

@@ -25,7 +25,9 @@ export var ErrorType;
     ErrorType[ErrorType["DOMAIN_NOT_FOUND"] = 22] = "DOMAIN_NOT_FOUND";
 })(ErrorType || (ErrorType = {}));
 export function getErrorFromCode(code) {
-    if (code in ErrorType) {
+    // The API can add error codes before this SDK's named constants are updated.
+    // Preserve those numeric diagnostics instead of turning them into UNKNOWN.
+    if (typeof code === 'number' && Number.isSafeInteger(code) && code >= 0) {
         return code;
     }
     return ErrorType.UNKNOWN_ERROR;

package/dist/constants/errors.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/constants/errors.test.js

@@ -0,0 +1,16 @@
+import { ErrorType, getErrorFromCode } from './errors.js';
+test.each([ErrorType.UNKNOWN_ERROR, ErrorType.INVALID_PHONE_NUMBER, ErrorType.DOMAIN_NOT_FOUND])('preserves known API error code %s', function (code) {
+    expect(getErrorFromCode(code)).toBe(code);
+});
+// INVALID_HCAPTCHA and SPAM_DETECTED exist in the API's Python SDK but not
+// this SDK's legacy enum. Future codes must remain diagnosable too.
+test.each([226, 227, 1000, Number.MAX_SAFE_INTEGER])('preserves forward-compatible numeric API error code %s', function (code) {
+    expect(getErrorFromCode(code)).toBe(code);
+});
+test.each([
+    undefined, null, -1, 1.5, NaN, Infinity, -Infinity,
+    Number.MAX_SAFE_INTEGER + 1, '227', 'INVALID_PHONE_NUMBER',
+    'toString', '__proto__', true, {}, [],
+])('uses UNKNOWN_ERROR for malformed API code %p', function (code) {
+    expect(getErrorFromCode(code)).toBe(ErrorType.UNKNOWN_ERROR);
+});

package/dist/request.d.ts

@@ -1,4 +1,3 @@
-import { ErrorType } from './constants/errors.js';
 export interface RequestOptions extends RequestInit {
     query?: string[][];
 }
@@ -37,7 +36,8 @@ export interface ApiErrorDetails {
 }
 export declare class ApiError extends Error {
     statusCode?: number;
-    errorCode?: ErrorType;
+    /** Numeric API code, including values added after this SDK was published. */
+    errorCode?: number;
     errorMessage: string;
     /**
      * Structured context the API may include alongside the error

package/dist/request.js

@@ -71,7 +71,6 @@ var __values = (this && this.__values) || function(o) {
     };
     throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
-// eslint-disable-next-line no-unused-vars
 import { getErrorFromCode } from './constants/errors.js';
 function resolveApiErrorMessage(err) {
     if (err && typeof err === 'object' && typeof err.message === 'string' && err.message) {

package/dist/request.test.js

@@ -83,6 +83,41 @@ test('will get default errorCode', function () {
         expect(e.message).toBe('just a test');
     });
 });
+test('lead spam rejection keeps its API code through apiFetch', function () { return __awaiter(void 0, void 0, void 0, function () {
+    return __generator(this, function (_a) {
+        switch (_a.label) {
+            case 0:
+                mockFetch(false, {
+                    statusCode: 400,
+                    errorCode: 227,
+                    message: 'Invalid submission',
+                }, 400);
+                return [4 /*yield*/, expect(apiFetch('https://api.merchi.co/', '/create_new_lead/', {
+                        method: 'POST',
+                    })).rejects.toMatchObject({
+                        name: 'ApiError',
+                        statusCode: 400,
+                        errorCode: 227,
+                        message: 'Invalid submission',
+                        errorMessage: 'Invalid submission',
+                    })];
+            case 1:
+                _a.sent();
+                return [2 /*return*/];
+        }
+    });
+}); });
+test.each([226, 1000])('ApiError preserves new numeric API code %s', function (errorCode) {
+    var error = new ApiError({ statusCode: 400, errorCode: errorCode, message: 'Rejected' });
+    expect(error.errorCode).toBe(errorCode);
+    expect(error.original.errorCode).toBe(errorCode);
+});
+test.each(['227', 'INVALID_PHONE_NUMBER', NaN, -1])('ApiError rejects malformed API code %p', function (errorCode) {
+    var error = new ApiError({ statusCode: 400, errorCode: errorCode, message: 'Rejected' });
+    expect(error.errorCode).toBe(ErrorType.UNKNOWN_ERROR);
+    expect(error.statusCode).toBe(400);
+    expect(error.message).toBe('Rejected');
+});
 test('ApiError keeps plain string messages', function () {
     var e = new ApiError('empty response');
     expect(e.message).toBe('empty response');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@merchi/sdk",
-  "version": "1.42.21",
+  "version": "1.42.22",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "type": "module",

package/src/constants/errors.test.ts

@@ -0,0 +1,23 @@
+import { ErrorType, getErrorFromCode } from './errors.js';
+
+test.each([ErrorType.UNKNOWN_ERROR, ErrorType.INVALID_PHONE_NUMBER, ErrorType.DOMAIN_NOT_FOUND])(
+  'preserves known API error code %s', code => {
+    expect(getErrorFromCode(code)).toBe(code);
+  },
+);
+
+// INVALID_HCAPTCHA and SPAM_DETECTED exist in the API's Python SDK but not
+// this SDK's legacy enum. Future codes must remain diagnosable too.
+test.each([226, 227, 1000, Number.MAX_SAFE_INTEGER])(
+  'preserves forward-compatible numeric API error code %s', code => {
+    expect(getErrorFromCode(code)).toBe(code);
+  },
+);
+
+test.each([
+  undefined, null, -1, 1.5, NaN, Infinity, -Infinity,
+  Number.MAX_SAFE_INTEGER + 1, '227', 'INVALID_PHONE_NUMBER',
+  'toString', '__proto__', true, {}, [],
+])('uses UNKNOWN_ERROR for malformed API code %p', code => {
+  expect(getErrorFromCode(code)).toBe(ErrorType.UNKNOWN_ERROR);
+});

package/src/constants/errors.ts

@@ -24,8 +24,10 @@ export enum ErrorType {
   DOMAIN_NOT_FOUND = 22,
 }
 
-export function getErrorFromCode(code: number): ErrorType {
-  if (code in ErrorType) {
+export function getErrorFromCode(code: unknown): number {
+  // The API can add error codes before this SDK's named constants are updated.
+  // Preserve those numeric diagnostics instead of turning them into UNKNOWN.
+  if (typeof code === 'number' && Number.isSafeInteger(code) && code >= 0) {
     return code;
   }
   return ErrorType.UNKNOWN_ERROR;

package/src/request.test.ts

@@ -43,6 +43,38 @@ test('will get default errorCode', () => {
   });
 });
 
+test('lead spam rejection keeps its API code through apiFetch', async () => {
+  mockFetch(false, {
+    statusCode: 400,
+    errorCode: 227,
+    message: 'Invalid submission',
+  }, 400);
+  await expect(apiFetch('https://api.merchi.co/', '/create_new_lead/', {
+    method: 'POST',
+  })).rejects.toMatchObject({
+    name: 'ApiError',
+    statusCode: 400,
+    errorCode: 227,
+    message: 'Invalid submission',
+    errorMessage: 'Invalid submission',
+  });
+});
+
+test.each([226, 1000])('ApiError preserves new numeric API code %s', errorCode => {
+  const error = new ApiError({ statusCode: 400, errorCode, message: 'Rejected' });
+  expect(error.errorCode).toBe(errorCode);
+  expect(error.original.errorCode).toBe(errorCode);
+});
+
+test.each(['227', 'INVALID_PHONE_NUMBER', NaN, -1])(
+  'ApiError rejects malformed API code %p', errorCode => {
+    const error = new ApiError({ statusCode: 400, errorCode, message: 'Rejected' });
+    expect(error.errorCode).toBe(ErrorType.UNKNOWN_ERROR);
+    expect(error.statusCode).toBe(400);
+    expect(error.message).toBe('Rejected');
+  },
+);
+
 test('ApiError keeps plain string messages', () => {
   const e = new ApiError('empty response');
   expect(e.message).toBe('empty response');

package/src/request.ts

@@ -1,5 +1,4 @@
-// eslint-disable-next-line no-unused-vars
-import { ErrorType, getErrorFromCode } from './constants/errors.js';
+import { getErrorFromCode } from './constants/errors.js';
 
 export interface RequestOptions extends RequestInit {
   query?: string[][];
@@ -50,7 +49,8 @@ function resolveApiErrorMessage(err: any): string {
 
 export class ApiError extends Error {
   public statusCode?: number;
-  public errorCode?: ErrorType;
+  /** Numeric API code, including values added after this SDK was published. */
+  public errorCode?: number;
   public errorMessage: string;
   /**
    * Structured context the API may include alongside the error