@merchi/sdk 1.42.20 → 1.42.21

package/dist/entities/cart.test.js

@@ -1,3 +1,18 @@
+var __extends = (this && this.__extends) || (function () {
+    var extendStatics = function (d, b) {
+        extendStatics = Object.setPrototypeOf ||
+            ({ __proto__: [] } instanceof Array && function (d, b) { d.__proto__ = b; }) ||
+            function (d, b) { for (var p in b) if (Object.prototype.hasOwnProperty.call(b, p)) d[p] = b[p]; };
+        return extendStatics(d, b);
+    };
+    return function (d, b) {
+        if (typeof b !== "function" && b !== null)
+            throw new TypeError("Class extends value " + String(b) + " is not a constructor or null");
+        extendStatics(d, b);
+        function __() { this.constructor = d; }
+        d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
+    };
+})();
 import { Merchi } from '../merchi.js';
 import { setup, mockFetch } from '../test_util.js';
 setup();
@@ -55,6 +70,60 @@ test('preserves isTest', function () {
     entity.fromJson({ id: 1, isTest: true });
     expect(entity.toJson()).toMatchObject({ isTest: true });
 });
+test('serialises a new cart when FormData has no set', function () {
+    var AppendOnlyFormData = /** @class */ (function () {
+        function AppendOnlyFormData() {
+            this.fields = new Map();
+        }
+        AppendOnlyFormData.prototype.append = function (name, value) {
+            this.fields.set(name, String(value));
+        };
+        AppendOnlyFormData.prototype.get = function (name) {
+            return this.fields.has(name) ? this.fields.get(name) : null;
+        };
+        AppendOnlyFormData.prototype.entries = function () {
+            return this.fields.entries();
+        };
+        return AppendOnlyFormData;
+    }());
+    var ReplacingFormData = /** @class */ (function (_super) {
+        __extends(ReplacingFormData, _super);
+        function ReplacingFormData() {
+            var _this = _super !== null && _super.apply(this, arguments) || this;
+            _this.ready = false;
+            return _this;
+        }
+        ReplacingFormData.prototype.append = function (name, value) {
+            if (!this.ready) {
+                throw new Error("delete was not called before append(".concat(name, ")"));
+            }
+            this.ready = false;
+            _super.prototype.append.call(this, name, value);
+        };
+        ReplacingFormData.prototype.delete = function () {
+            this.ready = true;
+        };
+        return ReplacingFormData;
+    }(AppendOnlyFormData));
+    var serialise = function (form) {
+        var merchi = new Merchi();
+        var cart = new merchi.Cart();
+        cart.isTest = false;
+        var domain = new merchi.Domain();
+        domain.id = 9;
+        cart.domain = domain;
+        cart.toFormData({ existing: form });
+        return form;
+    };
+    var appended = serialise(new AppendOnlyFormData());
+    expect(appended.get('isTest')).toBe('false');
+    expect(appended.get('domain-0-id')).toBe('9');
+    expect(appended.get('domain-count')).toBe('1');
+    var replaced = serialise(new ReplacingFormData());
+    expect(replaced.get('isTest')).toBe('false');
+    expect(replaced.get('domain-0-id')).toBe('9');
+    expect(replaced.get('domain-count')).toBe('1');
+});
 test('preserves source attribution', function () {
     var merchi = new Merchi();
     var entity = new merchi.Cart();

package/dist/entity.js

@@ -302,6 +302,19 @@ var Entity = /** @class */ (function () {
             if (fileIndex === undefined) {
                 fileIndex = { value: 0 };
             }
+            // Prefer set so a repeated key is replaced. Fall back to append for
+            // FormData implementations that never added set.
+            var writeField = function (target, name, value) {
+                if (typeof target.set === 'function') {
+                    target.set(name, value);
+                    return;
+                }
+                var legacy = target;
+                if (typeof legacy.delete === 'function') {
+                    legacy.delete(name);
+                }
+                target.append(name, value);
+            };
             var appendData = function (name, value) {
                 /* istanbul ignore next */
                 if (name === undefined || value === undefined) {
@@ -311,10 +324,10 @@ var Entity = /** @class */ (function () {
                 if (prefix) {
                     name = prefix + '-' + name;
                 }
-                result.set(name, value);
+                writeField(result, name, value);
             };
             if (_this.fileData !== undefined) {
-                result.set(String(fileIndex.value), _this.fileData);
+                writeField(result, String(fileIndex.value), _this.fileData);
                 appendData('fileDataIndex', fileIndex.value);
                 fileIndex.value++;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@merchi/sdk",
-  "version": "1.42.20",
+  "version": "1.42.21",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "type": "module",

package/src/entities/cart.test.ts

@@ -63,6 +63,54 @@ test('preserves isTest', () => {
   expect(entity.toJson()).toMatchObject({ isTest: true });
 });
 
+test('serialises a new cart when FormData has no set', () => {
+  class AppendOnlyFormData {
+    fields = new Map<string, string>();
+    append(name: string, value: any) {
+      this.fields.set(name, String(value));
+    }
+    get(name: string) {
+      return this.fields.has(name) ? this.fields.get(name) : null;
+    }
+    entries() {
+      return this.fields.entries();
+    }
+  }
+  class ReplacingFormData extends AppendOnlyFormData {
+    private ready = false;
+    append(name: string, value: any) {
+      if (!this.ready) {
+        throw new Error(`delete was not called before append(${name})`);
+      }
+      this.ready = false;
+      super.append(name, value);
+    }
+    delete() {
+      this.ready = true;
+    }
+  }
+  const serialise = (form: AppendOnlyFormData) => {
+    const merchi = new Merchi();
+    const cart = new merchi.Cart();
+    cart.isTest = false;
+    const domain = new merchi.Domain();
+    domain.id = 9;
+    cart.domain = domain;
+    cart.toFormData({existing: form as unknown as FormData});
+    return form;
+  };
+
+  const appended = serialise(new AppendOnlyFormData());
+  expect(appended.get('isTest')).toBe('false');
+  expect(appended.get('domain-0-id')).toBe('9');
+  expect(appended.get('domain-count')).toBe('1');
+
+  const replaced = serialise(new ReplacingFormData());
+  expect(replaced.get('isTest')).toBe('false');
+  expect(replaced.get('domain-0-id')).toBe('9');
+  expect(replaced.get('domain-count')).toBe('1');
+});
+
 test('preserves source attribution', () => {
   const merchi = new Merchi();
   const entity = new merchi.Cart();

package/src/entity.ts

@@ -928,6 +928,19 @@ export class Entity {
     if (fileIndex === undefined) {
       fileIndex = {value: 0};
     }
+    // Prefer set so a repeated key is replaced. Fall back to append for
+    // FormData implementations that never added set.
+    const writeField = (target: FormData, name: string, value: any) => {
+      if (typeof target.set === 'function') {
+        target.set(name, value);
+        return;
+      }
+      const legacy = target as FormData & {delete?: (field: string) => void};
+      if (typeof legacy.delete === 'function') {
+        legacy.delete(name);
+      }
+      target.append(name, value);
+    };
     const appendData = (name: string, value: any) => {
       /* istanbul ignore next */
       if (name === undefined || value === undefined) {
@@ -937,10 +950,10 @@ export class Entity {
       if (prefix) {
         name = prefix + '-' + name;
       }
-      result.set(name, value);
+      writeField(result, name, value);
     };
     if ((this as any).fileData !== undefined) {
-      result.set(String(fileIndex.value), (this as any).fileData);
+      writeField(result, String(fileIndex.value), (this as any).fileData);
       appendData('fileDataIndex', fileIndex.value);
       fileIndex.value++;
     }