@memori.ai/memori-react 8.11.0 → 8.12.0

package/src/components/DateSelector/DateSelector.css

@@ -1,137 +1,158 @@
+/* Screen reader only - visually hidden but accessible */
+.sr-only {
+    position: absolute;
+    overflow: hidden;
+    width: 1px;
+    height: 1px;
+    padding: 0;
+    border-width: 0;
+    margin: -1px;
+    clip: rect(0, 0, 0, 0);
+    white-space: nowrap;
+}
+
+/* Base Container */
 .memori--date-selector {
-    display: flex;
-    flex-wrap: nowrap;
+    width: 100%;
+    /* margin-top: 1.5rem; */
 }
 
-.memori--date-selector__select {
-    width: 30%;
+/* Mobile Styles */
+.memori--date-selector--mobile {
+    display: flex;
+    width: 100%;
     max-width: 100%;
-    margin: 1.5rem 1.5% 0;
+    box-sizing: border-box;
+    flex-direction: column;
+    padding: 0;
+    margin: 1rem 0;
 }
 
-.memori--date-selector__select-button {
-    position: relative;
+.memori--date-selector__mobile-label {
+    display: block;
     width: 100%;
-    padding-top: 0.5rem;
-    padding-right: 2.5rem;
-    padding-bottom: 0.5rem;
-    padding-left: 0.75rem;
-    border: 1px solid #e5e7eb;
-    border-radius: 0.5rem;
-    background: #fff;
-    box-shadow: rgba(0, 0, 0, 0) 0px 0px 0px 0px, rgba(0, 0, 0, 0) 0px 0px 0px 0px, rgba(0, 0, 0, 0.1) 0px 4px 6px -1px,
-        rgba(0, 0, 0, 0.1) 0px 2px 4px -2px;
-    cursor: pointer;
+    margin-bottom: 0.5rem;
+    color: #374151;
+    font-size: 0.95rem;
+    font-weight: 500;
     text-align: left;
 }
 
-.memori--date-selector__select-button:focus {
-    border-color: #cbd5e0;
-    box-shadow: 0 0 0 3px rgba(66, 153, 225, 0.5);
-}
-
-.memori--date-selector__select-button:focus-visible {
-    border-color: #63b3ed;
-    box-shadow: 0 0 0 3px rgba(66, 153, 225, 0.5);
+.memori--date-selector__mobile-input {
+    width: 100%;
+    max-width: 100%;
+    min-height: 48px;
+    box-sizing: border-box;
+    padding: 0.875rem 1rem;
+    border: 1px solid #e5e7eb;
+    border-radius: 0.5rem;
+    -webkit-appearance: none;
+    appearance: none;
+    background: #ffffff;
+    /* Touch-friendly */
+    box-shadow: 0 1px 2px rgba(0, 0, 0, 0.05);
+    color: #1f2937;
+    font-size: 1rem;
+    transition: all 0.2s ease;
 }
 
-.memori--date-selector__select-button:hover {
-    border-color: #e2e8f0;
+.memori--date-selector__mobile-input:focus {
+    border-color: var(--memori-primary, #9333ea);
+    box-shadow: 0 0 0 3px rgba(147, 51, 234, 0.1);
+    outline: none;
 }
 
-.memori--date-selector__select-button:active {
-    border-color: #e2e8f0;
+.memori--date-selector__mobile-input:active {
+    border-color: var(--memori-primary, #9333ea);
 }
 
-.memori--date-selector__select-button:disabled {
-    border-color: #e2e8f0;
-    background-color: #f7fafc;
-    color: #a0aec0;
+.memori--date-selector__mobile-input:disabled {
+    background-color: #f9fafb;
+    color: #9ca3af;
     cursor: not-allowed;
+    opacity: 0.6;
 }
 
-@media (min-width: 640px) {
-    .memori--date-selector__select-button {
-        font-size: 0.875rem;
-        line-height: 1.25rem;
-    }
-}
-
-.memori--date-selector__select-label {
-    display: inline-block;
-    margin-bottom: 0.25rem;
+/* Desktop Styles */
+.memori--date-selector--desktop {
+    display: flex;
+    flex-wrap: wrap;
+    justify-content: center;
+    gap: 1rem;
 }
 
-.memori--date-selector__select--value {
-    display: block;
-    overflow: hidden;
-    text-overflow: ellipsis;
-    white-space: nowrap;
+.memori--date-selector__input-group {
+    display: flex;
+    min-width: 80px;
+    /* flex: 1; */
+    flex-direction: column;
 }
 
-.memori--date-selector__select--icon {
-    position: absolute;
-    top: 0;
-    right: 0;
-    bottom: 0;
-    display: flex;
-    align-items: center;
-    padding-right: 0.5rem;
-    pointer-events: none;
+.memori--date-selector__input-group--year {
+    min-width: 100px;
 }
 
-.memori--date-selector__select--icon svg {
-    width: 1.25rem;
-    height: 1.25rem;
-    color: rgb(156 163 175/1);
+.memori--date-selector__label {
+    display: inline-block;
+    margin-bottom: 0.5rem;
+    color: #4b5563;
+    font-size: 0.875rem;
+    font-weight: 500;
+    letter-spacing: 0.01em;
 }
 
-ul.memori--date-selector__select-options {
-    position: absolute;
-    z-index: 1;
-    overflow: auto;
+.memori--date-selector__input {
     width: 100%;
-    max-width: min(18rem, 30%);
-    max-height: 15rem;
-    padding-top: 0.25rem;
-    padding-right: 0;
-    padding-bottom: 0.25rem;
-    padding-left: 0;
-    border-radius: 0.375rem;
-    margin-top: 0.25rem;
-    margin-right: 0;
-    margin-bottom: 0;
-    margin-left: 0;
-    background: #fff;
-    box-shadow: rgb(255, 255, 255) 0px 0px 0px 0px, rgba(0, 0, 0, 0.05) 0px 0px 0px 1px,
-        rgba(0, 0, 0, 0.1) 0px 10px 15px -3px, rgba(0, 0, 0, 0.1) 0px 4px 6px -4px;
-    list-style: none;
-}
-
-@media (min-width: 640px) {
-    .memori--date-selector__select-options {
-        font-size: 0.875rem;
-        line-height: 1.25rem;
-    }
+    padding: 0.75rem 1rem;
+    border: 2px solid #e5e7eb;
+    border-radius: 0.75rem;
+    -moz-appearance: textfield;
+    appearance: textfield;
+    /* Remove spinner buttons */
+    background: #ffffff;
+    color: #1f2937;
+    font-size: 0.95rem;
+    transition: all 0.2s cubic-bezier(0.4, 0, 0.2, 1);
+}
+
+.memori--date-selector__input::-webkit-outer-spin-button,
+.memori--date-selector__input::-webkit-inner-spin-button {
+    margin: 0;
+    -webkit-appearance: none;
+}
+
+.memori--date-selector__input:focus {
+    border-color: var(--memori-primary);
+  box-shadow: 0 0 0 4px rgba(var(--memori-primary-rgb), 0.1);
+    outline: none;
+    transform: translateY(-1px);
+}
+
+.memori--date-selector__input:disabled {
+    border-color: #e5e7eb;
+    background: #f9fafb;
+    color: #9ca3af;
+    cursor: not-allowed;
+    opacity: 0.6;
 }
 
-li.memori--date-selector__select-option {
-    position: relative;
-    padding-top: 0.5rem;
-    padding-right: 1rem;
-    padding-bottom: 0.5rem;
-    padding-left: 1rem;
-    color: rgb(17 24 39/1);
-    cursor: pointer;
-    user-select: none;
+.memori--date-selector__input::placeholder {
+    color: #9ca3af;
 }
 
-li.memori--date-selector__select-option:hover,
-li.memori--date-selector__select-option:focus {
-    background-color: #f7fafc;
-}
+/* Responsive adjustments */
+@media (max-width: 767px) {
+    .memori--date-selector--desktop {
+        display: none;
+        /* Hide desktop version on mobile if both are rendered for some reason */
+    }
 
-li.memori--date-selector__select-option:focus {
-    outline: 2px solid #63b3ed;
-    outline-offset: 2px;
-}
+    .memori--date-selector--mobile {
+        margin: 0.75rem 0;
+    }
+
+    .memori--date-selector__mobile-input {
+        min-height: 44px;
+        font-size: 16px; /* Prevents zoom on iOS */
+    }
+}

package/src/components/DateSelector/DateSelector.stories.tsx

@@ -34,5 +34,5 @@ export const Disabled = Template.bind({});
 Disabled.args = {
   defaultDate: new Date(Date.now()),
   onChange: () => {},
-  disabled: false,
+  disabled: true,
 };

package/src/components/DateSelector/DateSelector.test.tsx

@@ -1,6 +1,5 @@
-import { render } from '@testing-library/react';
+import { render, screen, fireEvent, waitFor } from '@testing-library/react';
 import DateSelector from './DateSelector';
-import { DateTime } from 'luxon';
 
 const dateMock = new Date(Date.UTC(2022, 8, 24, 0, 0, 0, 0));
 
@@ -9,27 +8,142 @@ Date.now = jest.fn(() => dateMock.valueOf());
 
 jest.spyOn(Date, 'now').mockImplementation(() => dateMock.valueOf());
 
-it('renders DateSelector unchanged', () => {
-  const { container } = render(
-    <DateSelector defaultDate={new Date(Date.now())} onChange={jest.fn()} />
-  );
-  expect(container).toMatchSnapshot();
-});
+describe('DateSelector', () => {
+  const mockOnChange = jest.fn();
 
-it('renders DateSelector with default value unchanged', () => {
-  const { container } = render(
-    <DateSelector defaultDate="2023-12-14T08:48:06.977Z" onChange={jest.fn()} />
-  );
-  expect(container).toMatchSnapshot();
-});
+  beforeEach(() => {
+    mockOnChange.mockClear();
+  });
+
+  it('renders DateSelector with empty inputs when no defaultDate provided', () => {
+    render(<DateSelector onChange={mockOnChange} />);
+
+    const dayInput = screen.getByLabelText(/day/i);
+    const monthInput = screen.getByLabelText(/month/i);
+    const yearInput = screen.getByLabelText(/year/i);
+
+    expect(dayInput).toHaveValue(null); // number input value is null/empty string
+    expect(monthInput).toHaveValue(null);
+    expect(yearInput).toHaveValue(null);
+
+    // Should call onChange with undefined initially or not at all if we want strict behavior
+    // Based on implementation: useEffect triggers on mount. If empty, calls onChange(undefined).
+    expect(mockOnChange).toHaveBeenCalledWith(undefined);
+  });
+
+  it('renders DateSelector with default value correctly', () => {
+    const defaultDate = new Date(Date.now());
+    render(
+      <DateSelector defaultDate={defaultDate} onChange={mockOnChange} />
+    );
+
+    const dayInput = screen.getByLabelText(/day/i);
+    const monthInput = screen.getByLabelText(/month/i);
+    const yearInput = screen.getByLabelText(/year/i);
+
+    expect(dayInput).toHaveValue(defaultDate.getDate());
+    expect(monthInput).toHaveValue(defaultDate.getMonth() + 1);
+    expect(yearInput).toHaveValue(defaultDate.getFullYear());
+  });
+
+  describe('Desktop View', () => {
+    it('updates day and calls onChange with undefined if incomplete', () => {
+      render(<DateSelector onChange={mockOnChange} />);
+      const dayInput = screen.getByLabelText(/day/i);
+
+      fireEvent.change(dayInput, { target: { value: '15' } });
+
+      expect(dayInput).toHaveValue(15);
+      expect(mockOnChange).toHaveBeenCalledWith(undefined);
+    });
+
+    it('calls onChange with valid date when all fields are filled', () => {
+      render(<DateSelector onChange={mockOnChange} />);
+      const dayInput = screen.getByLabelText(/day/i);
+      const monthInput = screen.getByLabelText(/month/i);
+      const yearInput = screen.getByLabelText(/year/i);
+
+      fireEvent.change(dayInput, { target: { value: '15' } });
+      fireEvent.change(monthInput, { target: { value: '5' } });
+      fireEvent.change(yearInput, { target: { value: '1990' } });
+
+      expect(mockOnChange).toHaveBeenCalledWith(
+        expect.objectContaining({
+          year: 1990,
+          month: 5,
+          day: 15,
+        })
+      );
+    });
+
+    it('auto-focuses month after day is filled', () => {
+      render(<DateSelector onChange={mockOnChange} />);
+      const dayInput = screen.getByLabelText(/day/i);
+      const monthInput = screen.getByLabelText(/month/i);
+
+      fireEvent.change(dayInput, { target: { value: '12' } });
+
+      expect(monthInput).toHaveFocus();
+    });
+
+    it('auto-focuses year after month is filled', () => {
+      render(<DateSelector onChange={mockOnChange} />);
+      const monthInput = screen.getByLabelText(/month/i);
+      const yearInput = screen.getByLabelText(/year/i);
+
+      fireEvent.change(monthInput, { target: { value: '12' } });
+
+      expect(yearInput).toHaveFocus();
+    });
+
+    it('disables all inputs when disabled prop is true', () => {
+      render(<DateSelector disabled onChange={mockOnChange} />);
+
+      const dayInput = screen.getByLabelText(/day/i);
+      const monthInput = screen.getByLabelText(/month/i);
+      const yearInput = screen.getByLabelText(/year/i);
+
+      expect(dayInput).toBeDisabled();
+      expect(monthInput).toBeDisabled();
+      expect(yearInput).toBeDisabled();
+    });
+  });
+
+  describe('Mobile View', () => {
+    it('renders native date input on mobile', () => {
+      render(<DateSelector onChange={mockOnChange} />);
+
+      const dateInput = screen.getByLabelText(/date/i);
+      expect(dateInput).toBeInTheDocument();
+      expect(dateInput).toHaveAttribute('type', 'date');
+    });
+
+    it('calls onChange when mobile date input changes', async () => {
+      render(<DateSelector onChange={mockOnChange} />);
+
+      const dateInput = screen.getByLabelText(/date/i);
+      fireEvent.change(dateInput, { target: { value: '1995-06-15' } });
+
+      await waitFor(() => {
+        expect(mockOnChange).toHaveBeenCalledWith(
+          expect.objectContaining({
+            year: 1995,
+            month: 6,
+            day: 15
+          })
+        );
+      });
+    });
+
+    it('calls onChange with undefined when mobile input is cleared', async () => {
+      render(<DateSelector defaultDate="1995-06-15" onChange={mockOnChange} />);
+
+      const dateInput = screen.getByLabelText(/date/i);
+      fireEvent.change(dateInput, { target: { value: '' } });
 
-it('renders DateSelector disabled unchanged', () => {
-  const { container } = render(
-    <DateSelector
-      disabled
-      defaultDate={new Date(Date.now())}
-      onChange={jest.fn()}
-    />
-  );
-  expect(container).toMatchSnapshot();
+      await waitFor(() => {
+        expect(mockOnChange).toHaveBeenCalledWith(undefined);
+      });
+    });
+  });
 });