@memberjunction/sqlglot-ts 6.1.0-edge.6 → 6.1.0-edge.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@memberjunction/sqlglot-ts",
-  "version": "6.1.0-edge.6",
+  "version": "6.1.0-edge.7",
   "description": "TypeScript wrapper for Python's sqlglot SQL transpiler. Manages a local Python FastAPI microservice to provide deterministic SQL dialect conversion.",
   "type": "module",
   "main": "dist/index.js",

package/src/python/mj_postgres.py

@@ -1997,7 +1997,30 @@ def _transpile_if_exists_begin(m: _IfExistsMatch) -> tuple[str, list[dict], list
         body_sql, u2, d2 = _transpile_extprop_segment(raw_body)
     if not cond_full or not body_sql.strip():
         return "", (u1 + u2 + [{"kind": "IF-EXISTS-BEGIN", "snippet": m.group(0)[:80]}]), (d1 + d2)
+    # PostgreSQL refuses CREATE INDEX on a table carrying pending (deferred) trigger events:
+    #   cannot CREATE INDEX "Entity" because it has pending trigger events
+    # A migration that seeds FK-bearing rows and then indexes the REFERENCED table hits this,
+    # because the FK checks queued by those inserts are still outstanding for COMMIT. SQL Server
+    # has no equivalent restriction, so the T-SQL original is perfectly legal and the failure
+    # appears only after conversion — and only at apply time, never in the converter's summary.
+    # Flushing first is semantically free: SET CONSTRAINTS ALL IMMEDIATE runs the deferred checks
+    # now instead of at COMMIT, so anything that would have failed still fails, just earlier and
+    # attached to a clearer statement. Emitted only when the guarded body actually creates an
+    # index, so ordinary guards are unchanged.
+    # The flush is a TOP-LEVEL statement, deliberately outside the DO block. SET CONSTRAINTS is
+    # transaction-scoped, and issuing it inside plpgsql does not clear events already queued by
+    # earlier statements in the migration — verified live: emitting it inside the block left the
+    # apply still failing with the same error. The committed ledger already uses the statement-level
+    # form for exactly this purpose (see V202608042204__APIKey_Scope_RowFilterID.pg.sql), so this
+    # matches shipped precedent rather than inventing a second convention.
+    flush = (
+        "-- Flush any pending deferred trigger events from prior DML so the index DDL below can proceed.\n"
+        "SET CONSTRAINTS ALL IMMEDIATE;\n"
+        if _re.search(r"\bCREATE\s+(?:UNIQUE\s+)?INDEX\b", body_sql, _re.IGNORECASE)
+        else ""
+    )
     do = (
+        f"{flush}"
         "DO $$\nBEGIN\n"
         f"  IF {cond_full} THEN\n"
         f"    {body_sql.strip()}\n"

package/src/python/test_mj_postgres.py

@@ -596,6 +596,34 @@ check("block-less IF NOT EXISTS(sys.indexes) CREATE INDEX → pg_indexes DO bloc
       must_not_contain=["sys.", "OBJECT_ID"],
       expect_unhandled=0)
 
+# A guarded CREATE INDEX must flush deferred FK triggers first. PostgreSQL refuses
+# `CREATE INDEX` on a table with pending trigger events ("cannot CREATE INDEX \"Entity\"
+# because it has pending trigger events"), which a migration hits whenever it seeds
+# FK-bearing rows and then indexes the REFERENCED table. SQL Server has no such rule, so
+# the T-SQL is legal and the breakage appears only after conversion, at apply time. -----
+check("guarded CREATE INDEX flushes deferred FK triggers",
+      "IF NOT EXISTS (\n"
+      "    SELECT 1 FROM sys.indexes\n"
+      "    WHERE name = 'IDX_AUTO_MJ_FKEY_Entity_ParentID'\n"
+      "      AND object_id = OBJECT_ID('${flyway:defaultSchema}.Entity'))\n"
+      "    CREATE INDEX IDX_AUTO_MJ_FKEY_Entity_ParentID\n"
+      "        ON ${flyway:defaultSchema}.Entity ([ParentID]);",
+      must_contain=["SET CONSTRAINTS ALL IMMEDIATE;", "CREATE INDEX", "pg_indexes"],
+      expect_unhandled=0)
+
+# ...and a guard that does NOT create an index must be left exactly as it was — the flush
+# is emitted only where it is needed, not sprayed across every guard. -------------------
+check("guard without CREATE INDEX emits no constraint flush",
+      "IF NOT EXISTS (\n"
+      "    SELECT 1 FROM sys.columns\n"
+      "    WHERE name = 'Foo' AND object_id = OBJECT_ID('${flyway:defaultSchema}.Entity'))\n"
+      "BEGIN\n"
+      "    ALTER TABLE ${flyway:defaultSchema}.Entity ADD [Foo] INT NULL;\n"
+      "END",
+      must_contain=["DO $$", "ALTER TABLE"],
+      must_not_contain=["SET CONSTRAINTS"],
+      expect_unhandled=0)
+
 # Inline named DEFAULT constraint (issue #3252 RC3): T-SQL allows a name on a column
 # default (`CONSTRAINT [DF_x] DEFAULT (75)`); PG does NOT — it is a `syntax error at or
 # near "CONSTRAINT"`. The name must be stripped, leaving a bare (unnamed) DEFAULT.