@memberjunction/server 6.2.0-edge.6 → 6.2.0-edge.7

package/dist/integration/ConnectionPause.js

@@ -0,0 +1,183 @@
+/**
+ * ConnectionPause — what "pause this connection" has to mean, beyond a flag.
+ *
+ * `IntegrationDeactivateConnection` used to set `IsActive = false` and stop. The engine reads
+ * that flag before a sync, so syncs did stop — but nothing else did:
+ *
+ *   - The SCHEDULED jobs kept firing. A sync schedule woke on cron, was refused, and wrote a
+ *     failed run. Every cron tick, for as long as the connection stayed paused, so a paused
+ *     connector's history filled with failures it did not cause.
+ *   - The DISCOVERY schedule kept firing and was NOT refused, because nothing gated discovery
+ *     on IsActive. A paused connection went on rescanning the vendor on a timer — spending the
+ *     customer's rate budget, and rewriting the very catalog the pause was meant to freeze.
+ *   - An IN-FLIGHT sync ran to completion. "Paused" arrived only after the thing the operator
+ *     was watching had finished.
+ *
+ * So pause has to touch three things, and resume has to put back exactly what pause took —
+ * which is the part that needs state rather than a rule.
+ *
+ * WHY THE PRIOR STATE IS RECORDED RATHER THAN INFERRED. "Resume = set every schedule Active" is
+ * wrong: a connection can legitimately be paused while one of its two schedules was ALREADY off
+ * because the operator turned it off weeks ago. Inferring would silently re-enable it, and the
+ * first symptom is a sync nobody asked for. So pause records which jobs it actually moved, and
+ * resume restores only those.
+ *
+ * WHY PAUSE IS IDEMPOTENT AT THE RECORD, NOT AT THE WRITE. Deactivating an already-deactivated
+ * connection finds every job already Paused, so the set it "moved" is empty. Writing that empty
+ * set over the real record is the bug that loses the state — resume would then restore nothing
+ * and both schedules would stay off forever, with no error anywhere. {@link DecidePauseWrite}
+ * is the guard: the FIRST pause's record stands until a resume consumes it, and a later pause only
+ * ever adds to it.
+ *
+ * Everything here is a pure function over plain values. The resolver owns the reads and writes.
+ */
+import { UUIDSet } from '@memberjunction/global';
+/** Key under CompanyIntegration.Configuration where the record lives. */
+export const PAUSED_SCHEDULES_KEY = 'pausedSchedules';
+/**
+ * Which schedules a pause should move, and the record to remember them by.
+ *
+ * Only jobs that are currently `Active` are moved. A job already `Paused`, or in any other
+ * status, is left exactly as found and is deliberately absent from the record — that absence
+ * is what stops resume from turning it on.
+ */
+export function DecideSchedulesToPause(jobs) {
+    return jobs
+        .filter(j => j.Status === 'Active')
+        .map(j => ({ ID: j.ID, Kind: j.Kind }));
+}
+/**
+ * Whether this pause's record should be written, given whatever record is already stored.
+ *
+ * Returns the record to persist, or `null` to leave the stored one untouched. A second pause of
+ * an already-paused connection moves nothing, and must not overwrite the first pause's record
+ * with its own empty one — see the class comment.
+ *
+ * A pause that DOES move jobs while a record is stored adds them to it: the stored entries stay
+ * exactly as they were, and the new ones are appended by job ID. That happens when a job was
+ * created or switched back on while the connection was paused, or when a resume could not clear
+ * its record. A job paused here but left out of the record is one resume can never put back.
+ */
+export function DecidePauseWrite(stored, newlyPaused) {
+    const known = new UUIDSet(stored.map(r => r.ID));
+    const added = newlyPaused.filter(r => !known.Has(r.ID));
+    if (added.length === 0)
+        return null; // nothing new moved — any stored record stands as it is
+    return [...stored, ...added];
+}
+/**
+ * Which schedules a resume should re-activate.
+ *
+ * A recorded job is restored only when it STILL EXISTS and is STILL `Paused`. Both guards matter:
+ * a job deleted while the connection was paused must not be resurrected, and a job someone has
+ * already moved back to Active must not be written again for no reason. Jobs absent from the
+ * record are never touched, however they look now.
+ */
+export function DecideSchedulesToResume(stored, jobs) {
+    const live = new Map(jobs.map(j => [j.ID, j]));
+    return stored
+        .filter(r => live.get(r.ID)?.Status === 'Paused')
+        .map(r => r.ID);
+}
+/** Reads the stored record out of a CompanyIntegration.Configuration JSON blob. */
+export function ReadPausedSchedules(configuration) {
+    if (!configuration)
+        return [];
+    let parsed;
+    try {
+        parsed = JSON.parse(configuration);
+    }
+    catch {
+        // A Configuration we cannot parse is not an error to raise here: pause/resume is not the
+        // operation that owns that blob. Report "no record" and let the rest of the flow proceed.
+        return [];
+    }
+    if (typeof parsed !== 'object' || parsed === null)
+        return [];
+    const raw = parsed[PAUSED_SCHEDULES_KEY];
+    if (!Array.isArray(raw))
+        return [];
+    const out = [];
+    for (const item of raw) {
+        if (typeof item !== 'object' || item === null)
+            continue;
+        const rec = item;
+        const id = rec.ID;
+        const kind = rec.Kind;
+        if (typeof id !== 'string' || id.length === 0)
+            continue;
+        out.push({ ID: id, Kind: kind === 'discovery' ? 'discovery' : 'sync' });
+    }
+    return out;
+}
+/**
+ * Returns the Configuration JSON with the record set (or cleared, when `record` is empty).
+ *
+ * Preserves every other key. An unparseable Configuration is REPLACED rather than merged — the
+ * alternative is refusing to pause because of unrelated corruption, and losing one broken blob
+ * is the better failure.
+ */
+export function WritePausedSchedules(configuration, record) {
+    let base = {};
+    if (configuration) {
+        try {
+            const parsed = JSON.parse(configuration);
+            if (typeof parsed === 'object' && parsed !== null && !Array.isArray(parsed)) {
+                base = parsed;
+            }
+        }
+        catch {
+            base = {};
+        }
+    }
+    if (record.length === 0) {
+        delete base[PAUSED_SCHEDULES_KEY];
+    }
+    else {
+        base[PAUSED_SCHEDULES_KEY] = record.map(r => ({ ID: r.ID, Kind: r.Kind }));
+    }
+    return JSON.stringify(base);
+}
+/**
+ * Classifies the cancel from observable facts, not from which API was called.
+ *
+ * Deliberately derived rather than hardcoded per lineage: the durable path needs a run-row column
+ * that only exists on newer tenants, so the SAME code has to tell the truth on a tenant where
+ * that column is absent and the in-process registry is the only signal there is.
+ */
+export function DescribeCancelScope(facts) {
+    if (!facts.liveRunPresent)
+        return 'none';
+    if (facts.durableRequestRecorded)
+        return 'durable';
+    if (facts.runningInThisProcess)
+        return 'this-process';
+    return 'unknown';
+}
+/** Operator-facing sentence for a cancel scope. Never claims a stop it cannot deliver. */
+export function DescribeCancelOutcome(scope) {
+    switch (scope) {
+        case 'durable':
+        case 'this-process':
+            return 'A sync was running — it will stop after the current batch.';
+        case 'unknown':
+            return 'A sync is running in another process and will finish; no new sync will start.';
+        case 'none':
+            return '';
+    }
+}
+/** Operator-facing sentence for what pause did to the schedules. */
+export function DescribePauseOutcome(paused, alreadyPaused) {
+    if (alreadyPaused)
+        return 'Schedules were already paused.';
+    if (paused.length === 0)
+        return 'No active schedules to pause.';
+    const kinds = paused.map(p => p.Kind);
+    const parts = [];
+    if (kinds.includes('sync'))
+        parts.push('data sync');
+    if (kinds.includes('discovery'))
+        parts.push('schema refresh');
+    return `Paused the ${parts.join(' and ')} schedule${parts.length > 1 ? 's' : ''}.`;
+}
+//# sourceMappingURL=ConnectionPause.js.map

package/dist/integration/ConnectionPause.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ConnectionPause.js","sourceRoot":"","sources":["../../src/integration/ConnectionPause.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAgCG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,wBAAwB,CAAC;AAoBjD,yEAAyE;AACzE,MAAM,CAAC,MAAM,oBAAoB,GAAG,iBAAiB,CAAC;AAEtD;;;;;;GAMG;AACH,MAAM,UAAU,sBAAsB,CAAC,IAAqC;IACxE,OAAO,IAAI;SACN,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,QAAQ,CAAC;SAClC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;AAChD,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,gBAAgB,CAC5B,MAA2C,EAC3C,WAAgD;IAEhD,MAAM,KAAK,GAAG,IAAI,OAAO,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IACjD,MAAM,KAAK,GAAG,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IACxD,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC,CAAU,wDAAwD;IACtG,OAAO,CAAC,GAAG,MAAM,EAAE,GAAG,KAAK,CAAC,CAAC;AACjC,CAAC;AAED;;;;;;;GAOG;AACH,MAAM,UAAU,uBAAuB,CACnC,MAA2C,EAC3C,IAAqC;IAErC,MAAM,IAAI,GAAG,IAAI,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IAC/C,OAAO,MAAM;SACR,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,MAAM,KAAK,QAAQ,CAAC;SAChD,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;AACxB,CAAC;AAED,mFAAmF;AACnF,MAAM,UAAU,mBAAmB,CAAC,aAAwC;IACxE,IAAI,CAAC,aAAa;QAAE,OAAO,EAAE,CAAC;IAC9B,IAAI,MAAe,CAAC;IACpB,IAAI,CAAC;QACD,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC;IACvC,CAAC;IAAC,MAAM,CAAC;QACL,yFAAyF;QACzF,0FAA0F;QAC1F,OAAO,EAAE,CAAC;IACd,CAAC;IACD,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,MAAM,KAAK,IAAI;QAAE,OAAO,EAAE,CAAC;IAC7D,MAAM,GAAG,GAAI,MAAkC,CAAC,oBAAoB,CAAC,CAAC;IACtE,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC;QAAE,OAAO,EAAE,CAAC;IACnC,MAAM,GAAG,GAA2B,EAAE,CAAC;IACvC,KAAK,MAAM,IAAI,IAAI,GAAG,EAAE,CAAC;QACrB,IAAI,OAAO,IAAI,KAAK,QAAQ,IAAI,IAAI,KAAK,IAAI;YAAE,SAAS;QACxD,MAAM,GAAG,GAAG,IAA+B,CAAC;QAC5C,MAAM,EAAE,GAAG,GAAG,CAAC,EAAE,CAAC;QAClB,MAAM,IAAI,GAAG,GAAG,CAAC,IAAI,CAAC;QACtB,IAAI,OAAO,EAAE,KAAK,QAAQ,IAAI,EAAE,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QACxD,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,IAAI,KAAK,WAAW,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC;IAC5E,CAAC;IACD,OAAO,GAAG,CAAC;AACf,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,oBAAoB,CAChC,aAAwC,EACxC,MAA2C;IAE3C,IAAI,IAAI,GAA4B,EAAE,CAAC;IACvC,IAAI,aAAa,EAAE,CAAC;QAChB,IAAI,CAAC;YACD,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC;YACzC,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,MAAM,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC;gBAC1E,IAAI,GAAG,MAAiC,CAAC;YAC7C,CAAC;QACL,CAAC;QAAC,MAAM,CAAC;YACL,IAAI,GAAG,EAAE,CAAC;QACd,CAAC;IACL,CAAC;IACD,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACtB,OAAO,IAAI,CAAC,oBAAoB,CAAC,CAAC;IACtC,CAAC;SAAM,CAAC;QACJ,IAAI,CAAC,oBAAoB,CAAC,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAC/E,CAAC;IACD,OAAO,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC;AAChC,CAAC;AAiBD;;;;;;GAMG;AACH,MAAM,UAAU,mBAAmB,CAAC,KAInC;IACG,IAAI,CAAC,KAAK,CAAC,cAAc;QAAE,OAAO,MAAM,CAAC;IACzC,IAAI,KAAK,CAAC,sBAAsB;QAAE,OAAO,SAAS,CAAC;IACnD,IAAI,KAAK,CAAC,oBAAoB;QAAE,OAAO,cAAc,CAAC;IACtD,OAAO,SAAS,CAAC;AACrB,CAAC;AAED,0FAA0F;AAC1F,MAAM,UAAU,qBAAqB,CAAC,KAAkB;IACpD,QAAQ,KAAK,EAAE,CAAC;QACZ,KAAK,SAAS,CAAC;QACf,KAAK,cAAc;YACf,OAAO,4DAA4D,CAAC;QACxE,KAAK,SAAS;YACV,OAAO,+EAA+E,CAAC;QAC3F,KAAK,MAAM;YACP,OAAO,EAAE,CAAC;IAClB,CAAC;AACL,CAAC;AAED,oEAAoE;AACpE,MAAM,UAAU,oBAAoB,CAAC,MAA2C,EAAE,aAAsB;IACpG,IAAI,aAAa;QAAE,OAAO,gCAAgC,CAAC;IAC3D,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,+BAA+B,CAAC;IAChE,MAAM,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;IACtC,MAAM,KAAK,GAAa,EAAE,CAAC;IAC3B,IAAI,KAAK,CAAC,QAAQ,CAAC,MAAM,CAAC;QAAE,KAAK,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IACpD,IAAI,KAAK,CAAC,QAAQ,CAAC,WAAW,CAAC;QAAE,KAAK,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAC;IAC9D,OAAO,cAAc,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,YAAY,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,GAAG,CAAC;AACvF,CAAC"}

package/dist/integration/CustomColumnPromoter.d.ts

@@ -24,12 +24,55 @@
  * of. The JSON spread of staged values into those columns happens here too.
  */
 import { type UserInfo, type IMetadataProvider, type EntityInfo } from '@memberjunction/core';
-import { type SchemaPromotionResult, type CustomKeyStat } from '@memberjunction/integration-engine';
-import { type RSUPendingWork } from '@memberjunction/schema-engine';
+import { type SchemaPromotionResult, type PromotionCandidate, type CustomKeyStat } from '@memberjunction/integration-engine';
+import { type RSUPipelineInput, type RSUPendingWork } from '@memberjunction/schema-engine';
+/** A coverage-passing key with its resolved column + what work it still needs (M4: promote OR recover). */
+interface WorkItem {
+    candidate: PromotionCandidate;
+    /** Original source key — the field map's SourceFieldName + the IOF Name. */
+    sourceKey: string;
+    /** Sanitized, collision-resolved column / DestinationFieldName / EntityField name. */
+    columnName: string;
+    /** The real DB column does not exist yet → needs ADD COLUMN. */
+    needsColumn: boolean;
+    /** No active field map for this source key → needs one (covers the partial-promotion crash window). */
+    needsFieldMap: boolean;
+    /**
+     * Column AND field map already exist, but rows may still hold the value only in the overflow
+     * JSON — a run interrupted between ADD COLUMN and the value spread leaves exactly this state,
+     * and nothing else ever finishes it: the key is no longer "unmapped" so capture stops, and the
+     * old terminate check skipped it as done. A spread-recovery item re-runs ONLY the backfill
+     * (no DDL, no metadata writes); the idempotent spread settles it to a no-op once every row is
+     * filled. Never surfaced as a UI candidate and never counted as a column added.
+     */
+    recoverSpread?: boolean;
+}
 /** Registers the post-sync custom-column promotion hook on the IntegrationEngine singleton. */
 export declare function RegisterIntegrationCustomColumnPromoter(): void;
 /** @deprecated Use {@link RegisterIntegrationCustomColumnPromoter}. */
 export declare function registerIntegrationCustomColumnPromoter(): void;
+interface EntityPlan {
+    entityName: string;
+    entityInfo: EntityInfo;
+    entityMap: {
+        ID: string;
+        ExternalObjectName: string;
+    };
+    work: WorkItem[];
+    /** Index of this entity's input in the RSU batch; -1 when it needs no DDL. */
+    batchIndex: number;
+}
+/** What {@link IntegrationCustomColumnPromoter.PlanPromotion} worked out, before anything runs. */
+export interface PromotionPlan {
+    IntegrationID: string;
+    Plans: EntityPlan[];
+    /**
+     * The ADD COLUMN migrations, ready to run. The FIRST entry carries the durable post-restart
+     * PendingWork for the whole plan — RSU registers PendingWork from every input in a batch, so
+     * these can be appended to someone else's batch without losing it.
+     */
+    BatchInputs: RSUPipelineInput[];
+}
 /**
  * Orchestrates promotion for one sync run. One instance per invocation (carries the per-sync
  * context user + provider so it respects the bound provider, never the global default blindly).
@@ -40,6 +83,24 @@ export declare class IntegrationCustomColumnPromoter {
     constructor(user: UserInfo, providerOverride?: IMetadataProvider);
     private get provider();
     private get dbProvider();
+    /**
+     * PHASE 1 only: work out what WOULD be promoted, and the ADD COLUMN migrations that would do
+     * it, without running a pipeline.
+     *
+     * Split out so a caller that is ALREADY running an RSU batch can fold these migrations into
+     * it. A schema refresh that offers the accumulated overflow columns and then promotes them in
+     * its own second batch would restart the workspace twice in a row for one user action, and a
+     * restart storm is its own incident class here. One batch, one migration, one restart.
+     *
+     * Side effects are deliberate and belong to planning, not to promotion: stale already-promoted
+     * keys are purged from the staging JSON here, BEFORE any column is created and before the RSU
+     * pass that would restart this process. That runs even when nothing new is promoted, which is
+     * the only way residue on rows a sync never rewrites gets cleaned rather than endlessly
+     * re-detected as a phantom "new column".
+     *
+     * Returns null when there is nothing to do.
+     */
+    PlanPromotion(companyIntegrationID: string, entityNames: string[], customKeyStats?: Record<string, CustomKeyStat[]>): Promise<PromotionPlan | null>;
     /** Entry point: promote custom columns for every entity touched by the sync. */
     PromoteForSync(companyIntegrationID: string, syncedEntityNames: string[], customKeyStats?: Record<string, CustomKeyStat[]>): Promise<SchemaPromotionResult>;
     /**
@@ -54,6 +115,12 @@ export declare class IntegrationCustomColumnPromoter {
      * Idempotent, because a pending row is marked Completed only after success and so stays
      * re-processable after a crash: field maps are filtered against those already active, and the
      * spread only fills a destination that is still empty.
+     *
+     * One entity's failure does not stop the others, but it is not swallowed either: after every
+     * entry has run, any failure is THROWN, so the caller fails the pending row instead of marking
+     * it Completed over columns that exist in the database and are never mapped.
+     *
+     * @throws PROMOTION_INCOMPLETE naming each entity that failed.
      */
     CompletePromotion(promoted: NonNullable<RSUPendingWork['PromotedColumns']>, knownEntities?: ReadonlyMap<string, EntityInfo>): Promise<Array<{
         EntityName: string;
@@ -122,6 +189,8 @@ export declare class IntegrationCustomColumnPromoter {
     private toTargetColumn;
     /** Creates an IOF row per promoted field (IsCustom, MetadataSource='Discovered'). */
     private createIntegrationObjectFields;
+    /** The catalog writes of {@link createIntegrationObjectFields}, run inside the connection's scope. */
+    private writeIntegrationObjectFields;
     /** Creates a field map (source key → new column) so the next sync maps natively → terminate. */
     private createFieldMaps;
     /**
@@ -177,11 +246,8 @@ export declare class IntegrationCustomColumnPromoter {
     private resolveIntegrationID;
     /** Finds the entity map (ExternalObject↔Entity) for this CI + target entity. */
     private findEntityMap;
-    /** Existing IOF field names (lowercased) for an object — for idempotent IOF creation. */
-    private existingIOFsByName;
-    /** Resolves the IntegrationObject ID for an external object name under an integration. */
-    private resolveIntegrationObjectID;
     private escape;
     private msg;
 }
+export {};
 //# sourceMappingURL=CustomColumnPromoter.d.ts.map

package/dist/integration/CustomColumnPromoter.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"CustomColumnPromoter.d.ts","sourceRoot":"","sources":["../../src/integration/CustomColumnPromoter.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AACH,OAAO,EAMH,KAAK,QAAQ,EACb,KAAK,iBAAiB,EAEtB,KAAK,UAAU,EAClB,MAAM,sBAAsB,CAAC;AAC9B,OAAO,EASH,KAAK,qBAAqB,EAE1B,KAAK,aAAa,EAErB,MAAM,oCAAoC,CAAC;AAiB5C,OAAO,EAAuE,KAAK,cAAc,EAAE,MAAM,+BAA+B,CAAC;AAoEzI,+FAA+F;AAC/F,wBAAgB,uCAAuC,IAAI,IAAI,CA6B9D;AAED,uEAAuE;AACvE,wBAAgB,uCAAuC,IAAI,IAAI,CAE9D;AAcD;;;GAGG;AACH,qBAAa,+BAA+B;IAEpC,OAAO,CAAC,QAAQ,CAAC,IAAI;IACrB,OAAO,CAAC,QAAQ,CAAC,gBAAgB,CAAC;gBADjB,IAAI,EAAE,QAAQ,EACd,gBAAgB,CAAC,EAAE,iBAAiB;IAGzD,OAAO,KAAK,QAAQ,GAEnB;IAED,OAAO,KAAK,UAAU,GAErB;IAED,gFAAgF;IACnE,cAAc,CACvB,oBAAoB,EAAE,MAAM,EAC5B,iBAAiB,EAAE,MAAM,EAAE,EAC3B,cAAc,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,aAAa,EAAE,CAAC,GACjD,OAAO,CAAC,qBAAqB,CAAC;IA8KjC;;;;;;;;;;;;OAYG;IACU,iBAAiB,CAC1B,QAAQ,EAAE,WAAW,CAAC,cAAc,CAAC,iBAAiB,CAAC,CAAC,EACxD,aAAa,CAAC,EAAE,WAAW,CAAC,MAAM,EAAE,UAAU,CAAC,GAChD,OAAO,CAAC,KAAK,CAAC;QAAE,UAAU,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAiD7D;;;;;;OAMG;YACW,iBAAiB;IA8D/B;;;;OAIG;IACU,cAAc,CACvB,oBAAoB,EAAE,MAAM,EAC5B,UAAU,EAAE,MAAM,GACnB,OAAO,CAAC,KAAK,CAAC;QAAE,UAAU,EAAE,MAAM,CAAC;QAAC,SAAS,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAC;QAAC,YAAY,EAAE,MAAM,CAAC;QAAC,WAAW,EAAE,OAAO,CAAA;KAAE,CAAC,CAAC;IAc5H,gGAAgG;IAChG,OAAO,CAAC,mBAAmB;IAW3B,qGAAqG;YACvF,uBAAuB;IAerC;;;;;;;OAOG;IACU,qBAAqB,CAC9B,oBAAoB,EAAE,MAAM,EAC5B,iBAAiB,EAAE,MAAM,EAAE,EAC3B,aAAa,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,aAAa,EAAE,CAAC,GAChD,OAAO,CAAC,IAAI,CAAC;IA0ChB,8FAA8F;YAChF,YAAY;IAgB1B;;;;;OAKG;IACH,OAAO,CAAC,gBAAgB;IAoCxB;;;;;;;OAOG;YACW,eAAe;IAoB7B,kGAAkG;IAClG,OAAO,CAAC,gBAAgB;IASxB;;;;OAIG;IACH,OAAO,CAAC,gBAAgB;IAmDxB,yEAAyE;IACzE,OAAO,CAAC,cAAc;IActB,qFAAqF;YACvE,6BAA6B;IA6D3C,gGAAgG;YAClF,eAAe;IAgB7B;;;;;;;OAOG;YACW,mBAAmB;IAajC;;;;;;;;;OASG;YACW,sBAAsB;IAwCpC;;;;;;;;;;OAUG;YACW,kBAAkB;IAiChC;;;;;;;OAOG;YACW,WAAW;IAkCzB;;;OAGG;YACW,YAAY;IAiD1B,0FAA0F;YAC5E,uBAAuB;IAKrC,OAAO,CAAC,aAAa;IAUrB,oDAAoD;YACtC,oBAAoB;IAMlC,gFAAgF;YAClE,aAAa;IAe3B,yFAAyF;YAC3E,kBAAkB;IAehC,0FAA0F;YAC5E,0BAA0B;IAaxC,OAAO,CAAC,MAAM;IAId,OAAO,CAAC,GAAG;CAGd"}
+{"version":3,"file":"CustomColumnPromoter.d.ts","sourceRoot":"","sources":["../../src/integration/CustomColumnPromoter.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AACH,OAAO,EAMH,KAAK,QAAQ,EACb,KAAK,iBAAiB,EAEtB,KAAK,UAAU,EAClB,MAAM,sBAAsB,CAAC;AAC9B,OAAO,EASH,KAAK,qBAAqB,EAC1B,KAAK,kBAAkB,EACvB,KAAK,aAAa,EAIrB,MAAM,oCAAoC,CAAC;AAmB5C,OAAO,EAAwB,KAAK,gBAAgB,EAA0B,KAAK,cAAc,EAAE,MAAM,+BAA+B,CAAC;AA8CzI,2GAA2G;AAC3G,UAAU,QAAQ;IACd,SAAS,EAAE,kBAAkB,CAAC;IAC9B,4EAA4E;IAC5E,SAAS,EAAE,MAAM,CAAC;IAClB,sFAAsF;IACtF,UAAU,EAAE,MAAM,CAAC;IACnB,gEAAgE;IAChE,WAAW,EAAE,OAAO,CAAC;IACrB,uGAAuG;IACvG,aAAa,EAAE,OAAO,CAAC;IACvB;;;;;;;OAOG;IACH,aAAa,CAAC,EAAE,OAAO,CAAC;CAC3B;AAED,+FAA+F;AAC/F,wBAAgB,uCAAuC,IAAI,IAAI,CA6B9D;AAED,uEAAuE;AACvE,wBAAgB,uCAAuC,IAAI,IAAI,CAE9D;AAYD,UAAU,UAAU;IAChB,UAAU,EAAE,MAAM,CAAC;IACnB,UAAU,EAAE,UAAU,CAAC;IACvB,SAAS,EAAE;QAAE,EAAE,EAAE,MAAM,CAAC;QAAC,kBAAkB,EAAE,MAAM,CAAA;KAAE,CAAC;IACtD,IAAI,EAAE,QAAQ,EAAE,CAAC;IACjB,8EAA8E;IAC9E,UAAU,EAAE,MAAM,CAAC;CACtB;AAED,mGAAmG;AACnG,MAAM,WAAW,aAAa;IAC1B,aAAa,EAAE,MAAM,CAAC;IACtB,KAAK,EAAE,UAAU,EAAE,CAAC;IACpB;;;;OAIG;IACH,WAAW,EAAE,gBAAgB,EAAE,CAAC;CACnC;AAID;;;GAGG;AACH,qBAAa,+BAA+B;IAEpC,OAAO,CAAC,QAAQ,CAAC,IAAI;IACrB,OAAO,CAAC,QAAQ,CAAC,gBAAgB,CAAC;gBADjB,IAAI,EAAE,QAAQ,EACd,gBAAgB,CAAC,EAAE,iBAAiB;IAGzD,OAAO,KAAK,QAAQ,GAEnB;IAED,OAAO,KAAK,UAAU,GAErB;IAED;;;;;;;;;;;;;;;;OAgBG;IACU,aAAa,CACtB,oBAAoB,EAAE,MAAM,EAC5B,WAAW,EAAE,MAAM,EAAE,EACrB,cAAc,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,aAAa,EAAE,CAAC,GACjD,OAAO,CAAC,aAAa,GAAG,IAAI,CAAC;IAiFhC,gFAAgF;IACnE,cAAc,CACvB,oBAAoB,EAAE,MAAM,EAC5B,iBAAiB,EAAE,MAAM,EAAE,EAC3B,cAAc,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,aAAa,EAAE,CAAC,GACjD,OAAO,CAAC,qBAAqB,CAAC;IA6FjC;;;;;;;;;;;;;;;;;;OAkBG;IACU,iBAAiB,CAC1B,QAAQ,EAAE,WAAW,CAAC,cAAc,CAAC,iBAAiB,CAAC,CAAC,EACxD,aAAa,CAAC,EAAE,WAAW,CAAC,MAAM,EAAE,UAAU,CAAC,GAChD,OAAO,CAAC,KAAK,CAAC;QAAE,UAAU,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAyD7D;;;;;;OAMG;YACW,iBAAiB;IA8D/B;;;;OAIG;IACU,cAAc,CACvB,oBAAoB,EAAE,MAAM,EAC5B,UAAU,EAAE,MAAM,GACnB,OAAO,CAAC,KAAK,CAAC;QAAE,UAAU,EAAE,MAAM,CAAC;QAAC,SAAS,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAC;QAAC,YAAY,EAAE,MAAM,CAAC;QAAC,WAAW,EAAE,OAAO,CAAA;KAAE,CAAC,CAAC;IAc5H,gGAAgG;IAChG,OAAO,CAAC,mBAAmB;IAW3B,qGAAqG;YACvF,uBAAuB;IAerC;;;;;;;OAOG;IACU,qBAAqB,CAC9B,oBAAoB,EAAE,MAAM,EAC5B,iBAAiB,EAAE,MAAM,EAAE,EAC3B,aAAa,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,aAAa,EAAE,CAAC,GAChD,OAAO,CAAC,IAAI,CAAC;IA0ChB,8FAA8F;YAChF,YAAY;IAgB1B;;;;;OAKG;IACH,OAAO,CAAC,gBAAgB;IAoCxB;;;;;;;OAOG;YACW,eAAe;IAoB7B,kGAAkG;IAClG,OAAO,CAAC,gBAAgB;IASxB;;;;OAIG;IACH,OAAO,CAAC,gBAAgB;IAmDxB,yEAAyE;IACzE,OAAO,CAAC,cAAc;IActB,qFAAqF;YACvE,6BAA6B;IA4B3C,sGAAsG;YACxF,4BAA4B;IAqE1C,gGAAgG;YAClF,eAAe;IAgB7B;;;;;;;OAOG;YACW,mBAAmB;IAajC;;;;;;;;;OASG;YACW,sBAAsB;IAwCpC;;;;;;;;;;OAUG;YACW,kBAAkB;IAiChC;;;;;;;OAOG;YACW,WAAW;IAkCzB;;;OAGG;YACW,YAAY;IAiD1B,0FAA0F;YAC5E,uBAAuB;IAKrC,OAAO,CAAC,aAAa;IAUrB,oDAAoD;YACtC,oBAAoB;IAMlC,gFAAgF;YAClE,aAAa;IAkB3B,OAAO,CAAC,MAAM;IAId,OAAO,CAAC,GAAG;CAGd"}

package/dist/integration/CustomColumnPromoter.js

@@ -24,7 +24,9 @@
  * of. The JSON spread of staged values into those columns happens here too.
  */
 import { LogError, LogStatus, LogStatusEx, Metadata, RunView, } from '@memberjunction/core';
-import { IntegrationEngine, CUSTOM_OVERFLOW_COLUMN, CONTENT_HASH_COLUMN, computeContentHash, buildOverflowStats, planPromotions, sanitizeColumnName, inferColumnTypeFromStats, } from '@memberjunction/integration-engine';
+import { IntegrationEngine, CUSTOM_OVERFLOW_COLUMN, CONTENT_HASH_COLUMN, computeContentHash, buildOverflowStats, planPromotions, sanitizeColumnName, inferColumnTypeFromStats, BuildCatalogWriter, WithCatalogScope, } from '@memberjunction/integration-engine';
+import { UUIDsEqual } from '@memberjunction/global';
+import { IntegrationEngineBase } from '@memberjunction/integration-engine-base';
 import { DDLGenerator } from '@memberjunction/integration-schema-builder';
 import { RuntimeSchemaManager } from '@memberjunction/schema-engine';
 /** Max rows sampled from the overflow column to compute coverage + infer types (bounded memory). */
@@ -114,14 +116,34 @@ export class IntegrationCustomColumnPromoter {
     get dbProvider() {
         return this.provider;
     }
-    /** Entry point: promote custom columns for every entity touched by the sync. */
-    async PromoteForSync(companyIntegrationID, syncedEntityNames, customKeyStats) {
+    /**
+     * PHASE 1 only: work out what WOULD be promoted, and the ADD COLUMN migrations that would do
+     * it, without running a pipeline.
+     *
+     * Split out so a caller that is ALREADY running an RSU batch can fold these migrations into
+     * it. A schema refresh that offers the accumulated overflow columns and then promotes them in
+     * its own second batch would restart the workspace twice in a row for one user action, and a
+     * restart storm is its own incident class here. One batch, one migration, one restart.
+     *
+     * Side effects are deliberate and belong to planning, not to promotion: stale already-promoted
+     * keys are purged from the staging JSON here, BEFORE any column is created and before the RSU
+     * pass that would restart this process. That runs even when nothing new is promoted, which is
+     * the only way residue on rows a sync never rewrites gets cleaned rather than endlessly
+     * re-detected as a phantom "new column".
+     *
+     * Returns null when there is nothing to do.
+     */
+    async PlanPromotion(companyIntegrationID, entityNames, customKeyStats) {
         const integrationID = await this.resolveIntegrationID(companyIntegrationID);
         if (!integrationID)
-            return NOT_PROMOTED;
+            return null;
+        // ── PHASE 1: PLAN — build every entity's work list + its RSU input; run NO pipeline. ──
+        // The old shape ran the FULL RSU pipeline per entity — a sync touching N entities with
+        // candidates paid N CodeGen + compile passes where the batch API exists precisely to pay
+        // one. Plan everything first, then promote once.
         const plans = [];
         const batchInputs = [];
-        for (const entityName of syncedEntityNames) {
+        for (const entityName of entityNames) {
             try {
                 const planned = await this.planWorkForEntity(companyIntegrationID, entityName, customKeyStats?.[entityName]);
                 if (!planned)
@@ -158,7 +180,7 @@ export class IntegrationCustomColumnPromoter {
             }
         }
         if (plans.length === 0)
-            return NOT_PROMOTED;
+            return null;
         // Register the follow-up DURABLY before the restart, the way the apply-objects path does
         // (IntegrationDiscoveryResolver: `rsuInput.PendingWork = [pendingPayload]`). The restart is
         // what loads the regenerated entity classes, so everything downstream of the DDL — the IOF
@@ -191,6 +213,15 @@ export class IntegrationCustomColumnPromoter {
                 }];
             batchInputs[0].ContextUser = this.user;
         }
+        return { IntegrationID: integrationID, Plans: plans, BatchInputs: batchInputs };
+    }
+    /** Entry point: promote custom columns for every entity touched by the sync. */
+    async PromoteForSync(companyIntegrationID, syncedEntityNames, customKeyStats) {
+        const promotionPlan = await this.PlanPromotion(companyIntegrationID, syncedEntityNames, customKeyStats);
+        if (!promotionPlan)
+            return NOT_PROMOTED;
+        const plans = promotionPlan.Plans;
+        const batchInputs = promotionPlan.BatchInputs;
         // ── PHASE 2: ONE batched RSU pass for ALL entities' ADD COLUMN migrations. ──
         // RunPipelineBatch runs every migration under one lock, then ONE CodeGen + compile +
         // restart + git commit — which is now genuinely one restart and one commit for the whole
@@ -260,7 +291,7 @@ export class IntegrationCustomColumnPromoter {
                         EntityName: plan.entityName,
                         EntityMapID: plan.entityMap.ID,
                         ExternalObjectName: plan.entityMap.ExternalObjectName,
-                        IntegrationID: integrationID,
+                        IntegrationID: promotionPlan.IntegrationID,
                         Columns: plan.work.map(w => ({
                             SourceKey: w.sourceKey,
                             ColumnName: w.columnName,
@@ -294,9 +325,16 @@ export class IntegrationCustomColumnPromoter {
      * Idempotent, because a pending row is marked Completed only after success and so stays
      * re-processable after a crash: field maps are filtered against those already active, and the
      * spread only fills a destination that is still empty.
+     *
+     * One entity's failure does not stop the others, but it is not swallowed either: after every
+     * entry has run, any failure is THROWN, so the caller fails the pending row instead of marking
+     * it Completed over columns that exist in the database and are never mapped.
+     *
+     * @throws PROMOTION_INCOMPLETE naming each entity that failed.
      */
     async CompletePromotion(promoted, knownEntities) {
         const columnsAdded = [];
+        const failures = [];
         for (const entry of promoted) {
             try {
                 // Provider first — post-restart it holds the REGENERATED class, which is the whole
@@ -305,6 +343,7 @@ export class IntegrationCustomColumnPromoter {
                 const entityInfo = this.provider.EntityByName(entry.EntityName) ?? knownEntities?.get(entry.EntityName);
                 if (!entityInfo) {
                     LogError(`[CustomColumnPromoter] Post-restart: entity '${entry.EntityName}' not found; skipping.`);
+                    failures.push(`${entry.EntityName}: entity not found`);
                     continue;
                 }
                 // Destination names are CARRIED, never recomputed: uniqueColumnName may have
@@ -329,17 +368,21 @@ export class IntegrationCustomColumnPromoter {
                     needsColumn: false,
                     needsFieldMap: !existingMaps.has(c.SourceKey.toLowerCase()),
                 }));
-                await this.createIntegrationObjectFields(entry.IntegrationID, entry.ExternalObjectName, named);
+                await this.createIntegrationObjectFields(entry.IntegrationID, entry.EntityMapID, entry.ExternalObjectName, named);
                 await this.createFieldMaps(entry.EntityMapID, named.filter(n => n.needsFieldMap));
                 await this.spreadAndRebaseline(entry.EntityName, entry.EntityMapID, entityInfo, named);
                 LogStatus(`[CustomColumnPromoter] Post-restart: completed ${named.length} promoted column(s) on ${entry.EntityName}: ${named.map(n => n.columnName).join(', ')}`);
                 columnsAdded.push(...named.map(n => ({ EntityName: entry.EntityName, ColumnName: n.columnName })));
             }
             catch (err) {
-                // One entity must not abort the others; the pending row stays open for retry.
+                // One entity must not abort the others; the failure is thrown once they have all run.
                 LogError(`[CustomColumnPromoter] Post-restart completion failed for '${entry.EntityName}': ${this.msg(err)}`);
+                failures.push(`${entry.EntityName}: ${this.msg(err)}`);
             }
         }
+        if (failures.length > 0) {
+            throw new Error(`PROMOTION_INCOMPLETE: ${failures.length} of ${promoted.length} entity(ies) failed to complete — ${failures.join('; ')}`);
+        }
         return columnsAdded;
     }
     /**
@@ -668,10 +711,31 @@ export class IntegrationCustomColumnPromoter {
         };
     }
     /** Creates an IOF row per promoted field (IsCustom, MetadataSource='Discovered'). */
-    async createIntegrationObjectFields(integrationID, externalObjectName, named) {
-        const objectID = await this.resolveIntegrationObjectID(integrationID, externalObjectName);
+    async createIntegrationObjectFields(integrationID, entityMapID, externalObjectName, named) {
+        // Resolve the CONNECTION from the entity map rather than hopping connection → integration
+        // and writing the shared rows. That hop is what let one tenant's promoted column appear in
+        // the catalog every other tenant on the same connector reads.
+        const entityMap = IntegrationEngineBase.Instance.EntityMaps.find(m => UUIDsEqual(m.ID, entityMapID));
+        const companyIntegration = entityMap
+            ? IntegrationEngineBase.Instance.GetCompanyIntegrationByID(entityMap.CompanyIntegrationID)
+            : undefined;
+        if (!companyIntegration) {
+            LogError(`[CustomColumnPromoter] Could not resolve the connection behind entity map ${entityMapID}; catalog rows skipped for '${externalObjectName}'.`);
+            return;
+        }
+        // In the connection's own scope, entered here per entry: the post-restart consumer calls
+        // in with no scope, and unscoped a connection with per-connection rows reads as having none,
+        // so BuildCatalogWriter throws PER_CONNECTION_CATALOG_MISSING. Per entry, so a batch that
+        // spans connections resolves each one to its own catalog.
+        await WithCatalogScope(companyIntegration.ID, () => this.writeIntegrationObjectFields(companyIntegration, integrationID, externalObjectName, named), this.user);
+    }
+    /** The catalog writes of {@link createIntegrationObjectFields}, run inside the connection's scope. */
+    async writeIntegrationObjectFields(companyIntegration, integrationID, externalObjectName, named) {
+        const writer = BuildCatalogWriter(this.provider, companyIntegration, this.user);
+        const objectID = (await writer.ObjectsInScope())
+            .find(o => o.Name.toLowerCase() === externalObjectName.toLowerCase())?.ID ?? null;
         if (!objectID) {
-            LogError(`[CustomColumnPromoter] No IntegrationObject '${externalObjectName}' for integration ${integrationID}; IOF rows skipped.`);
+            LogError(`[CustomColumnPromoter] No catalog object '${externalObjectName}' for integration ${integrationID}; catalog field rows skipped.`);
             return;
         }
         // Lookup-or-reactivate-or-create — NEVER blind-create over an existing field. A field the source
@@ -679,13 +743,16 @@ export class IntegrationCustomColumnPromoter {
         // key reappears in the payload and reaches promotion, the IOF already exists: reactivate it (so the
         // active-filtered ApplyAll re-materializes the still-present column) instead of creating a duplicate.
         // This is the "removed-then-re-added" case + the recovery case (column existed, field map missing).
-        const existingIOFs = await this.existingIOFsByName(objectID);
+        const existingIOFs = new Map();
+        for (const f of await writer.FieldsForObject(objectID)) {
+            existingIOFs.set((f.Name ?? '').toLowerCase(), { ID: f.ID, Status: f.Status ?? 'Active' });
+        }
         for (const n of named) {
             const existing = existingIOFs.get(n.sourceKey.toLowerCase());
             if (existing) {
                 if (existing.Status !== 'Active') {
-                    const reIof = await this.provider.GetEntityObject('MJ: Integration Object Fields', this.user);
-                    if (await reIof.Load(existing.ID)) {
+                    const reIof = await writer.LoadField(existing.ID);
+                    if (reIof) {
                         reIof.Status = 'Active';
                         const ok = await reIof.Save();
                         if (!ok)
@@ -694,8 +761,10 @@ export class IntegrationCustomColumnPromoter {
                 }
                 continue;
             }
-            const iof = await this.provider.GetEntityObject('MJ: Integration Object Fields', this.user);
-            iof.NewRecord();
+            const iof = await writer.NewFieldRow();
+            // An overflow-promoted column was seen in live data, never described by an endpoint and
+            // never declared — so its provenance is 'Sampled', and it has no declared row behind it.
+            writer.StampNewField(iof, null, 'Sampled');
             iof.IntegrationObjectID = objectID;
             iof.Name = n.sourceKey;
             iof.DisplayName = n.sourceKey;
@@ -957,39 +1026,11 @@ export class IntegrationCustomColumnPromoter {
             ExtraFilter: `CompanyIntegrationID='${companyIntegrationID}' AND Entity='${this.escape(entityName)}'`,
             ResultType: 'simple',
             MaxRows: 1,
+            SkipTotalRowCount: true,
         }, this.user);
         const row = res.Success ? res.Results?.[0] : undefined;
         return row ? { ID: row.ID, ExternalObjectName: row.ExternalObjectName } : null;
     }
-    /** Existing IOF field names (lowercased) for an object — for idempotent IOF creation. */
-    async existingIOFsByName(objectID) {
-        const rv = new RunView();
-        const res = await rv.RunView({
-            EntityName: 'MJ: Integration Object Fields',
-            ExtraFilter: `IntegrationObjectID='${objectID}'`,
-            Fields: ['ID', 'Name', 'Status'],
-            ResultType: 'simple',
-        }, this.user);
-        const map = new Map();
-        if (res.Success)
-            for (const r of res.Results ?? []) {
-                map.set((r.Name ?? '').toLowerCase(), { ID: String(r.ID), Status: r.Status ?? 'Active' });
-            }
-        return map;
-    }
-    /** Resolves the IntegrationObject ID for an external object name under an integration. */
-    async resolveIntegrationObjectID(integrationID, externalObjectName) {
-        const rv = new RunView();
-        const res = await rv.RunView({
-            EntityName: 'MJ: Integration Objects',
-            ExtraFilter: `IntegrationID='${integrationID}' AND Name='${this.escape(externalObjectName)}'`,
-            Fields: ['ID', 'Name', 'IntegrationID'],
-            ResultType: 'simple',
-            MaxRows: 1,
-        }, this.user);
-        const row = res.Success ? res.Results?.[0] : undefined;
-        return row ? row.ID : null;
-    }
     escape(value) {
         return value.replace(/'/g, "''");
     }