@memberjunction/server 6.1.0-edge.1 → 6.1.0-edge.3

package/src/__tests__/ResolverBase.transportMapping.test.ts

@@ -0,0 +1,289 @@
+// ResolverBase transitively pulls in type-graphql decorators, which need the
+// Reflect.metadata polyfill at import time.
+import 'reflect-metadata';
+import { describe, it, expect } from 'vitest';
+import type { DatabaseProviderBase, RunViewParams, RunViewResult, UserInfo } from '@memberjunction/core';
+import type { MJUserViewEntityExtended } from '@memberjunction/core-entities';
+import { FieldMapper } from '@memberjunction/graphql-dataprovider';
+import { ResolverBase } from '../generic/ResolverBase.js';
+import type { UserPayload } from '../types.js';
+
+/**
+ * Regression guard for the server-cache corruption behind
+ * "Field _mj__CreatedAt does not exist on MJ: Template Categories".
+ *
+ * GraphQL reserves the `__` prefix, so MJ renames `__mj_*` columns to the
+ * transport alias `_mj__*` on the way out. `ResolverBase` used to apply that
+ * rename IN PLACE over `result.Results` — but those are the data provider's own
+ * row objects, and the server's cache holds them BY REFERENCE. Preparing one
+ * GraphQL response therefore rewrote the keys inside the live cache, and every
+ * subsequent read served from it handed the client transport-shaped rows that
+ * `BaseEntity.SetMany` rejects. Process-wide cache ⇒ one response poisoned every
+ * later request, across all workers.
+ *
+ * The fix is copy-then-map. The first block exercises the REAL resolver path (so a
+ * revert to in-place mapping fails here); the second pins the two `FieldMapper`
+ * invariants that make the fix correct.
+ *
+ * These copies are now LOAD-BEARING rather than merely defensive: `LocalCacheManager`
+ * deep-freezes cached rows on reference-sharing storage providers, so mapping in place
+ * would throw a `TypeError` instead of silently corrupting the cache. The third block
+ * pins that the copy-then-map pattern still works on frozen input — the shape the cache
+ * actually hands out — and that in-place mapping is now refused outright.
+ */
+
+/** A cache-held row, shaped the way the provider hands them back. */
+type CachedRow = Record<string, unknown>;
+
+/**
+ * Reaches the protected `RunViewGenericInternal` and records what
+ * `ArrayFilterEncryptedFieldsForAPI` was handed — the second in-place mutator that
+ * must also see copies, and stubbed here so the assertion needs no live Metadata.
+ */
+class Probe extends ResolverBase {
+    public filteredRows: Record<string, unknown>[] | null = null;
+
+    protected override async ArrayFilterEncryptedFieldsForAPI(
+        _entityName: string,
+        dataObjectArray: Record<string, unknown>[]
+    ): Promise<Record<string, unknown>[]> {
+        this.filteredRows = dataObjectArray;
+        return dataObjectArray;
+    }
+
+    public Run(provider: DatabaseProviderBase, viewInfo: MJUserViewEntityExtended, userPayload: UserPayload) {
+        return this.RunViewGenericInternal(
+            provider,
+            viewInfo,
+            '', // extraFilter
+            '', // orderBy
+            '', // userSearchString
+            undefined, // excludeUserViewRunID
+            undefined, // overrideExcludeFilter
+            undefined, // saveViewResults
+            undefined, // fields
+            undefined, // ignoreMaxRows
+            undefined, // excludeDataFromAllPriorViewRuns
+            undefined, // forceAuditLog
+            undefined, // auditLogDescription
+            'simple', // resultType
+            userPayload,
+            undefined, // maxRows
+            undefined // startRow
+        );
+    }
+}
+
+const ENTITY_NAME = 'MJ: Template Categories';
+
+/** Minimal provider: the entity lookup + the RunView the resolver awaits. */
+function fakeProvider(rows: CachedRow[]): DatabaseProviderBase {
+    return {
+        Entities: [{ Name: ENTITY_NAME, PrimaryKeys: [{ Name: 'ID' }] }],
+        RunView: async (_params: RunViewParams): Promise<RunViewResult> =>
+            ({ Success: true, Results: rows, RowCount: rows.length, TotalRowCount: rows.length, ErrorMessage: '' } as RunViewResult),
+    } as unknown as DatabaseProviderBase;
+}
+
+const fakeViewInfo = () =>
+    ({ ID: 'view-1', Name: 'Test View', Entity: ENTITY_NAME } as unknown as MJUserViewEntityExtended);
+
+/** `userRecord` short-circuits the UserCache lookup; no apiKeyHash skips the scope check. */
+const fakePayload = () =>
+    ({ email: 'tester@example.com', userRecord: { Email: 'tester@example.com' } as UserInfo } as UserPayload);
+
+describe('ResolverBase.RunViewGenericInternal — cache safety', () => {
+    it('leaves the provider\'s (cache-held) rows untouched while returning transport keys', async () => {
+        const cachedRow: CachedRow = { ID: 'a1', Name: 'Cat', __mj_CreatedAt: 'T0', __mj_UpdatedAt: 'T1' };
+        const probe = new Probe();
+
+        const result = await probe.Run(fakeProvider([cachedRow]), fakeViewInfo(), fakePayload());
+
+        // The pre-fix code renamed these keys in place — this is the assertion that fails on a revert.
+        expect(cachedRow.__mj_CreatedAt).toBe('T0');
+        expect(cachedRow.__mj_UpdatedAt).toBe('T1');
+        expect(cachedRow._mj__CreatedAt).toBeUndefined();
+
+        // The outgoing rows carry the GraphQL-legal aliases, and are NOT the cached objects.
+        const wire = result?.Results as Record<string, unknown>[];
+        expect(wire[0]._mj__CreatedAt).toBe('T0');
+        expect(wire[0]).not.toBe(cachedRow);
+    });
+
+    it('hands the encrypted-field filter the copies, not the cached rows', async () => {
+        const cachedRow: CachedRow = { ID: 'a1', Secret: 'plaintext', __mj_CreatedAt: 'T0' };
+        const probe = new Probe();
+
+        await probe.Run(fakeProvider([cachedRow]), fakeViewInfo(), fakePayload());
+
+        expect(probe.filteredRows).not.toBeNull();
+        expect(probe.filteredRows![0]).not.toBe(cachedRow);
+    });
+});
+
+describe('FieldMapper transport mapping — the invariants the fix rests on', () => {
+    it('MapFields MUTATES its argument (the hazard the resolver must not expose the cache to)', () => {
+        // Documents WHY the resolver must copy. If this ever becomes non-mutating,
+        // the copy in ResolverBase is redundant rather than load-bearing — and this
+        // test failing is the signal to revisit it.
+        const row: Record<string, unknown> = { ID: 'a1', Name: 'Cat', __mj_CreatedAt: 'T0' };
+
+        new FieldMapper().MapFields(row);
+
+        expect(row.__mj_CreatedAt).toBeUndefined();
+        expect(row._mj__CreatedAt).toBe('T0');
+    });
+
+    it('post-map mutation of the copy cannot reach the cached row', () => {
+        // ArrayFilterEncryptedFieldsForAPI redacts in place after mapping; on the
+        // pre-fix code that stripped secrets out of the CACHED row too.
+        const mapper = new FieldMapper();
+        const cachedRow: Record<string, unknown> = { ID: 'a1', Secret: 'plaintext', __mj_CreatedAt: 'T0' };
+
+        const wireRow = mapper.MapFields({ ...cachedRow })!;
+        wireRow.Secret = null; // stand-in for the encrypted-field filter
+
+        expect(cachedRow.Secret).toBe('plaintext');
+        expect(wireRow.Secret).toBeNull();
+    });
+
+    it('round-trips a mapped copy back to entity field names', () => {
+        // The client's ConvertBackToMJFields must undo exactly what the server did.
+        const mapper = new FieldMapper();
+        const original: Record<string, unknown> = { ID: 'a1', __mj_CreatedAt: 'T0', __mj_UpdatedAt: 'T1' };
+
+        const wire = mapper.MapFields({ ...original })!;
+        const back = mapper.ReverseMapFields({ ...wire });
+
+        expect(back).toEqual(original);
+    });
+
+    it('leaves rows without __mj_ fields structurally unchanged', () => {
+        const mapper = new FieldMapper();
+        const row = { ID: 'a1', Name: 'Cat' };
+
+        expect(mapper.MapFields({ ...row })).toEqual(row);
+    });
+});
+
+describe('transport mapping against FROZEN cache rows', () => {
+    // The cache deep-freezes rows it hands out (LocalCacheManager freeze-on-write), so the
+    // resolver's input is frozen in the deployment that matters — MJAPI on the in-memory
+    // storage provider. That turns the copy from a precaution into a requirement.
+    it('copy-then-map works on a frozen row', () => {
+        const mapper = new FieldMapper();
+        const cachedRow = Object.freeze({ ID: 'a1', Name: 'Cat', __mj_CreatedAt: 'T0' }) as Record<string, unknown>;
+
+        const wireRow = mapper.MapFields({ ...cachedRow })!;
+
+        expect(wireRow._mj__CreatedAt).toBe('T0');
+        expect(wireRow.__mj_CreatedAt).toBeUndefined();
+        // The copy is mutable, so the encrypted-field filter can still redact in place.
+        expect(Object.isFrozen(wireRow)).toBe(false);
+        // And the frozen cached row is untouched.
+        expect(cachedRow.__mj_CreatedAt).toBe('T0');
+    });
+
+    it('in-place mapping of a frozen row THROWS — silent corruption is now impossible', () => {
+        // This is the safety net the freeze adds on top of the copy: if a future refactor
+        // reverts to in-place mapping, it fails loudly at the offending line instead of
+        // quietly rewriting process-wide state.
+        const mapper = new FieldMapper();
+        const cachedRow = Object.freeze({ ID: 'a1', __mj_CreatedAt: 'T0' }) as Record<string, unknown>;
+
+        expect(() => mapper.MapFields(cachedRow)).toThrow(TypeError);
+    });
+});
+
+/**
+ * The BATCH path (`RunViewsGenericInternal`), which the single-view tests above do not reach
+ * (PR #3425 review, finding M8).
+ *
+ * This is the path multi-view clients actually take — MJExplorer batches its view loads — so
+ * leaving it uncovered meant the original corruption bug could be reintroduced on the more
+ * heavily used of the two legs with CI still green.
+ */
+class BatchProbe extends ResolverBase {
+    public filteredRows: Record<string, unknown>[] | null = null;
+
+    protected override async ArrayFilterEncryptedFieldsForAPI(
+        _entityName: string,
+        dataObjectArray: Record<string, unknown>[]
+    ): Promise<Record<string, unknown>[]> {
+        this.filteredRows = dataObjectArray;
+        return dataObjectArray;
+    }
+
+    public RunBatch(provider: DatabaseProviderBase, viewInfos: MJUserViewEntityExtended[], userPayload: UserPayload) {
+        return this.RunViewsGenericInternal(
+            viewInfos.map(viewInfo => ({ provider, viewInfo, userPayload, resultType: 'simple' })) as never
+        );
+    }
+}
+
+/** Batch provider: `RunViews` returns one result per param, in order. */
+function fakeBatchProvider(rowsPerView: CachedRow[][]): DatabaseProviderBase {
+    return {
+        Entities: [{ Name: ENTITY_NAME, PrimaryKeys: [{ Name: 'ID' }] }],
+        EntityByName: (name: string) => (name === ENTITY_NAME ? { Name: ENTITY_NAME } : undefined),
+        RunViews: async (params: RunViewParams[]): Promise<RunViewResult[]> =>
+            params.map((_p, i) => {
+                const rows = rowsPerView[i] ?? [];
+                return { Success: true, Results: rows, RowCount: rows.length, TotalRowCount: rows.length, ErrorMessage: '' } as RunViewResult;
+            }),
+    } as unknown as DatabaseProviderBase;
+}
+
+describe('ResolverBase.RunViewsGenericInternal (batch) — cache safety', () => {
+    it('leaves every view\'s cache-held rows untouched while returning transport keys', async () => {
+        const viewARow: CachedRow = { ID: 'a1', Name: 'Cat', __mj_CreatedAt: 'T0', __mj_UpdatedAt: 'T1' };
+        const viewBRow: CachedRow = { ID: 'b1', Name: 'Dog', __mj_CreatedAt: 'T2', __mj_UpdatedAt: 'T3' };
+        const probe = new BatchProbe();
+
+        const results = await probe.RunBatch(
+            fakeBatchProvider([[viewARow], [viewBRow]]),
+            [fakeViewInfo(), fakeViewInfo()],
+            fakePayload()
+        );
+
+        // Both source rows keep entity field names — the assertion that fails on a revert
+        // to in-place mapping in the batch loop.
+        expect(viewARow.__mj_CreatedAt).toBe('T0');
+        expect(viewARow._mj__CreatedAt).toBeUndefined();
+        expect(viewBRow.__mj_CreatedAt).toBe('T2');
+        expect(viewBRow._mj__CreatedAt).toBeUndefined();
+
+        // ...and both outgoing views carry the aliases, on objects that are not the cached ones.
+        const wireA = results[0].Results as Record<string, unknown>[];
+        const wireB = results[1].Results as Record<string, unknown>[];
+        expect(wireA[0]._mj__CreatedAt).toBe('T0');
+        expect(wireB[0]._mj__CreatedAt).toBe('T2');
+        expect(wireA[0]).not.toBe(viewARow);
+        expect(wireB[0]).not.toBe(viewBRow);
+    });
+
+    it('maps FROZEN cache rows rather than throwing on them', async () => {
+        // The shape the cache actually hands out on a hit.
+        const frozenRow = Object.freeze({ ID: 'a1', Name: 'Cat', __mj_CreatedAt: 'T0' }) as CachedRow;
+        const probe = new BatchProbe();
+
+        const results = await probe.RunBatch(
+            fakeBatchProvider([[frozenRow]]),
+            [fakeViewInfo()],
+            fakePayload()
+        );
+
+        expect((results[0].Results as Record<string, unknown>[])[0]._mj__CreatedAt).toBe('T0');
+        expect(frozenRow.__mj_CreatedAt).toBe('T0');
+    });
+
+    it('hands the encrypted-field filter copies, not the cached rows', async () => {
+        const cachedRow: CachedRow = { ID: 'a1', Secret: 'plaintext', __mj_CreatedAt: 'T0' };
+        const probe = new BatchProbe();
+
+        await probe.RunBatch(fakeBatchProvider([[cachedRow]]), [fakeViewInfo()], fakePayload());
+
+        expect(probe.filteredRows).not.toBeNull();
+        expect(probe.filteredRows![0]).not.toBe(cachedRow);
+    });
+});

package/src/__tests__/SchemaRefreshLaunch.test.ts

@@ -0,0 +1,114 @@
+import { describe, it, expect } from 'vitest';
+import { BuildCreateConnectionMessage, BuildDetachedRefreshMessage, BuildUpdateConnectionMessage } from '../integration/SchemaRefreshLaunch.js';
+import type { SchemaRefreshSummaryLike } from '../integration/SchemaRefreshLaunch.js';
+
+/**
+ * A detached schema refresh returns placeholder zero counts because it hasn't run yet. The one
+ * thing this message must never do is report those zeros as findings — "0 created, 0 updated"
+ * reads as "the refresh found nothing", which is the opposite of "still running".
+ */
+function summary(over: Partial<SchemaRefreshSummaryLike> = {}): SchemaRefreshSummaryLike {
+    return {
+        RunID: 'connector-1783000000000-abc123',
+        InProgress: false,
+        Succeeded: true,
+        ObjectsCreated: 12,
+        ObjectsUpdated: 3,
+        UnresolvedObjects: ['Widgets'],
+        ...over,
+    };
+}
+
+describe('BuildCreateConnectionMessage', () => {
+    it('reports the run ID to tail — and NO counts — for a detached refresh', () => {
+        const msg = BuildCreateConnectionMessage(true, summary({
+            InProgress: true,
+            ObjectsCreated: 0,
+            ObjectsUpdated: 0,
+            UnresolvedObjects: [],
+        }));
+
+        expect(msg).toContain('connector-1783000000000-abc123');
+        expect(msg).toMatch(/running/i);
+        // The placeholder zeros must not surface as results.
+        expect(msg).not.toMatch(/\d+ created/);
+        expect(msg).not.toMatch(/\d+ updated/);
+        expect(msg).not.toMatch(/PK-unresolved/);
+    });
+
+    it('reports real counts once the refresh has completed inline', () => {
+        const msg = BuildCreateConnectionMessage(true, summary());
+
+        expect(msg).toContain('12 created');
+        expect(msg).toContain('3 updated');
+        expect(msg).toContain('1 PK-unresolved');
+        expect(msg).not.toMatch(/running/i);
+        // A completed refresh needs no run ID in the message — the counts ARE the answer.
+        expect(msg).not.toContain('connector-1783000000000-abc123');
+    });
+
+    it('omits the test-passed clause when no connection test was requested', () => {
+        expect(BuildCreateConnectionMessage(false, summary())).not.toMatch(/test passed/);
+        expect(BuildCreateConnectionMessage(true, summary())).toMatch(/test passed/);
+    });
+
+    it('falls back to the test-only message when no refresh was requested', () => {
+        expect(BuildCreateConnectionMessage(true, undefined)).toBe('Connection created and test passed');
+    });
+
+    it('counts PK-unresolved objects, not just reports presence', () => {
+        const msg = BuildCreateConnectionMessage(false, summary({ UnresolvedObjects: ['A', 'B', 'C'] }));
+        expect(msg).toContain('3 PK-unresolved');
+    });
+});
+
+/**
+ * A pipeline that fails at ConnectionTest RETURNS — it does not throw — with every count at zero.
+ * Verified live: a real HubSpot refresh whose credential check failed produced
+ * "Updated, schema refresh: 0 created, 0 updated, 0 PK-unresolved", indistinguishable from a clean
+ * no-op run. These tests pin the distinction.
+ */
+describe('failed-refresh reporting', () => {
+    const failed = summary({
+        Succeeded: false,
+        FailureMessage: 'ConnectionTest failed: No HubSpot credentials found',
+        ObjectsCreated: 0,
+        ObjectsUpdated: 0,
+        UnresolvedObjects: [],
+    });
+
+    it('never reports a failed refresh as a zero-count success (create)', () => {
+        const msg = BuildCreateConnectionMessage(true, failed);
+        expect(msg).toMatch(/FAILED/);
+        expect(msg).toContain('No HubSpot credentials found');
+        expect(msg).not.toMatch(/0 created/);
+    });
+
+    it('never reports a failed refresh as a zero-count success (update)', () => {
+        const msg = BuildUpdateConnectionMessage(failed);
+        expect(msg).toMatch(/FAILED/);
+        expect(msg).toContain('No HubSpot credentials found');
+        expect(msg).not.toMatch(/0 created/);
+    });
+
+    it('points at the run when the pipeline reported no reason', () => {
+        const msg = BuildUpdateConnectionMessage(summary({ Succeeded: false, FailureMessage: undefined }));
+        expect(msg).toContain('connector-1783000000000-abc123');
+        expect(msg).toMatch(/no reason reported/);
+    });
+
+    it('still reports counts for a refresh that genuinely succeeded (update)', () => {
+        const msg = BuildUpdateConnectionMessage(summary());
+        expect(msg).toContain('12 created');
+        expect(msg).toContain('3 updated');
+        expect(msg).not.toMatch(/FAILED/);
+    });
+});
+
+describe('BuildDetachedRefreshMessage', () => {
+    it('names the run to tail', () => {
+        const msg = BuildDetachedRefreshMessage('connector-42-zz');
+        expect(msg).toContain('connector-42-zz');
+        expect(msg).toMatch(/running/i);
+    });
+});

package/src/__tests__/SessionManager.test.ts

@@ -43,7 +43,7 @@ vi.mock('@memberjunction/core', async (importOriginal) => {
 // --- Partial mock: control ONLY UserCache.GetSystemUser (the scoped-anonymous elevation seam,
 //     issue #3371); everything else in the data provider stays real ---
 const getSystemUserMock = vi.fn<[], UserInfo | undefined>();
-vi.mock('@memberjunction/sqlserver-dataprovider', async (importOriginal) => {
+vi.mock('@memberjunction/generic-database-provider', async (importOriginal) => {
     const actual = await importOriginal<Record<string, unknown>>();
     return {
         ...actual,

package/src/__tests__/UserResolver.currentUser.test.ts

@@ -0,0 +1,87 @@
+import { describe, it, expect, vi, afterEach } from 'vitest';
+import { LogError } from '@memberjunction/core';
+import {
+  AssertRoleLoadSucceeded,
+  RequireContextUser,
+  RequireLoadedUser,
+  RequireRoleProvider,
+  UserIdExtraFilter,
+} from '../resolvers/currentUserRoles.js';
+
+vi.mock('@memberjunction/core', async (importOriginal) => {
+  const actual = await importOriginal<typeof import('@memberjunction/core')>();
+  return {
+    ...actual,
+    LogError: vi.fn(),
+  };
+});
+
+describe('CurrentUser role-load guards', () => {
+  afterEach(() => {
+    vi.clearAllMocks();
+  });
+
+  describe('RequireLoadedUser', () => {
+    it('returns the user when ID is present', () => {
+      const user = { ID: 'u-1', Email: 'a@b.com' };
+      expect(RequireLoadedUser(user, 'a@b.com')).toBe(user);
+    });
+
+    it('throws when the email fallback finds no user', () => {
+      expect(() => RequireLoadedUser(null, 'missing@example.com'))
+        .toThrow("CurrentUser: no user found for email 'missing@example.com'");
+      expect(() => RequireLoadedUser({ Email: 'x' }, undefined))
+        .toThrow("CurrentUser: no user found for email ''");
+    });
+  });
+
+  describe('RequireContextUser', () => {
+    it('returns the session user when present', () => {
+      const user = { ID: 'u-1' };
+      expect(RequireContextUser(user)).toBe(user);
+    });
+
+    it('throws when GetUserFromPayload would have handed undefined to RunView', () => {
+      expect(() => RequireContextUser(undefined))
+        .toThrow('CurrentUser: authenticated context user is required to load roles');
+    });
+  });
+
+  describe('RequireRoleProvider', () => {
+    it('throws when no provider is available', () => {
+      expect(() => RequireRoleProvider(null))
+        .toThrow('CurrentUser: no data provider available to load roles');
+    });
+  });
+
+  describe('UserIdExtraFilter', () => {
+    it('wraps a UUID in a UserID equality filter', () => {
+      expect(UserIdExtraFilter('aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa'))
+        .toBe("UserID='aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa'");
+    });
+
+    it('quote-escapes a value that contains a single quote', () => {
+      expect(UserIdExtraFilter("O'Brien")).toBe("UserID='O''Brien'");
+    });
+  });
+
+  describe('AssertRoleLoadSucceeded', () => {
+    it('is a no-op on Success', () => {
+      expect(() => AssertRoleLoadSucceeded({ Success: true }, 'u-1')).not.toThrow();
+      expect(LogError).not.toHaveBeenCalled();
+    });
+
+    it('logs and throws on failure instead of returning an empty role set', () => {
+      expect(() => AssertRoleLoadSucceeded({ Success: false, ErrorMessage: 'permission denied' }, 'u-1'))
+        .toThrow('CurrentUser: failed to load roles: permission denied');
+      expect(LogError).toHaveBeenCalledWith(
+        'CurrentUser: failed to load roles for user u-1: permission denied',
+      );
+    });
+
+    it('uses a fallback message when ErrorMessage is missing', () => {
+      expect(() => AssertRoleLoadSucceeded({ Success: false }, 'u-1'))
+        .toThrow('CurrentUser: failed to load roles: unknown error');
+    });
+  });
+});