@memberjunction/server 5.44.0 → 5.45.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@memberjunction/server",
-  "version": "5.44.0",
+  "version": "5.45.1",
   "description": "MemberJunction: This project provides API access via GraphQL to the common data store.",
   "main": "./dist/index.js",
   "types": "./src/index.ts",
@@ -27,88 +27,93 @@
     "@as-integrations/express5": "^1.0.0",
     "@graphql-tools/schema": "latest",
     "@graphql-tools/utils": "^11.0.0",
-    "@memberjunction/actions": "5.44.0",
-    "@memberjunction/actions-apollo": "5.44.0",
-    "@memberjunction/actions-base": "5.44.0",
-    "@memberjunction/actions-bizapps-accounting": "5.44.0",
-    "@memberjunction/actions-bizapps-crm": "5.44.0",
-    "@memberjunction/actions-bizapps-formbuilders": "5.44.0",
-    "@memberjunction/actions-bizapps-lms": "5.44.0",
-    "@memberjunction/actions-bizapps-social": "5.44.0",
-    "@memberjunction/ai": "5.44.0",
-    "@memberjunction/ai-agent-manager": "5.44.0",
-    "@memberjunction/ai-agent-manager-actions": "5.44.0",
-    "@memberjunction/ai-agents": "5.44.0",
-    "@memberjunction/ai-bridge-server": "5.44.0",
-    "@memberjunction/ai-core-plus": "5.44.0",
-    "@memberjunction/ai-engine-base": "5.44.0",
-    "@memberjunction/ai-mcp-client": "5.44.0",
-    "@memberjunction/ai-prompts": "5.44.0",
-    "@memberjunction/ai-provider-bundle": "5.44.0",
-    "@memberjunction/ai-vector-sync": "5.44.0",
-    "@memberjunction/ai-vectordb": "5.44.0",
-    "@memberjunction/ai-vectors-pinecone": "5.44.0",
-    "@memberjunction/aiengine": "5.44.0",
-    "@memberjunction/api-keys": "5.44.0",
-    "@memberjunction/auth-providers": "5.44.0",
-    "@memberjunction/clustering-engine": "5.44.0",
-    "@memberjunction/codegen-lib": "5.44.0",
-    "@memberjunction/communication-engine": "5.44.0",
-    "@memberjunction/communication-ms-graph": "5.44.0",
-    "@memberjunction/notifications": "5.44.0",
-    "@memberjunction/communication-sendgrid": "5.44.0",
-    "@memberjunction/communication-types": "5.44.0",
-    "@memberjunction/component-registry-client-sdk": "5.44.0",
-    "@memberjunction/computer-use": "5.44.0",
-    "@memberjunction/computer-use-engine": "5.44.0",
-    "@memberjunction/config": "5.44.0",
-    "@memberjunction/core": "5.44.0",
-    "@memberjunction/core-actions": "5.44.0",
-    "@memberjunction/core-entities": "5.44.0",
-    "@memberjunction/core-entities-server": "5.44.0",
-    "@memberjunction/data-context": "5.44.0",
-    "@memberjunction/data-context-server": "5.44.0",
-    "@memberjunction/doc-utils": "5.44.0",
-    "@memberjunction/encryption": "5.44.0",
-    "@memberjunction/entity-communications-base": "5.44.0",
-    "@memberjunction/entity-communications-server": "5.44.0",
-    "@memberjunction/esignature": "5.44.0",
-    "@memberjunction/external-change-detection": "5.44.0",
-    "@memberjunction/generic-database-provider": "5.44.0",
-    "@memberjunction/global": "5.44.0",
-    "@memberjunction/graphql-dataprovider": "5.44.0",
-    "@memberjunction/integration-engine": "5.44.0",
-    "@memberjunction/integration-progress-artifacts": "5.44.0",
-    "@memberjunction/integration-schema-builder": "5.44.0",
-    "@memberjunction/interactive-component-types": "5.44.0",
-    "@memberjunction/lists": "5.44.0",
-    "@memberjunction/lists-base": "5.44.0",
-    "@memberjunction/livekit-room-server": "5.44.0",
-    "@memberjunction/postgresql-dataprovider": "5.44.0",
-    "@memberjunction/queue": "5.44.0",
-    "@memberjunction/record-comparison": "5.44.0",
-    "@memberjunction/redis-provider": "5.44.0",
-    "@memberjunction/remote-browser-base": "5.44.0",
-    "@memberjunction/remote-browser-cdp": "5.44.0",
-    "@memberjunction/remote-browser-selfhost": "5.44.0",
-    "@memberjunction/remote-browser-server": "5.44.0",
-    "@memberjunction/scheduling-actions": "5.44.0",
-    "@memberjunction/scheduling-base-types": "5.44.0",
-    "@memberjunction/scheduling-engine": "5.44.0",
-    "@memberjunction/scheduling-engine-base": "5.44.0",
-    "@memberjunction/schema-engine": "5.44.0",
-    "@memberjunction/search-engine": "5.44.0",
-    "@memberjunction/server-extensions-core": "5.44.0",
-    "@memberjunction/skip-types": "5.44.0",
-    "@memberjunction/sql-dialect": "5.44.0",
-    "@memberjunction/sqlserver-dataprovider": "5.44.0",
-    "@memberjunction/storage": "5.44.0",
-    "@memberjunction/tag-engine": "5.44.0",
-    "@memberjunction/tag-engine-base": "5.44.0",
-    "@memberjunction/templates": "5.44.0",
-    "@memberjunction/testing-engine": "5.44.0",
-    "@memberjunction/testing-engine-base": "5.44.0",
-    "@memberjunction/version-history": "5.44.0",
+    "@memberjunction/actions": "5.45.1",
+    "@memberjunction/actions-apollo": "5.45.1",
+    "@memberjunction/actions-base": "5.45.1",
+    "@memberjunction/actions-bizapps-accounting": "5.45.1",
+    "@memberjunction/actions-bizapps-crm": "5.45.1",
+    "@memberjunction/actions-bizapps-formbuilders": "5.45.1",
+    "@memberjunction/actions-bizapps-lms": "5.45.1",
+    "@memberjunction/actions-bizapps-social": "5.45.1",
+    "@memberjunction/ai": "5.45.1",
+    "@memberjunction/ai-agent-manager": "5.45.1",
+    "@memberjunction/ai-agent-manager-actions": "5.45.1",
+    "@memberjunction/ai-agents": "5.45.1",
+    "@memberjunction/ai-bridge-base": "5.45.1",
+    "@memberjunction/ai-bridge-ringcentral": "5.45.1",
+    "@memberjunction/ai-bridge-server": "5.45.1",
+    "@memberjunction/ai-bridge-teams": "5.45.1",
+    "@memberjunction/ai-bridge-twilio": "5.45.1",
+    "@memberjunction/ai-bridge-vonage": "5.45.1",
+    "@memberjunction/ai-core-plus": "5.45.1",
+    "@memberjunction/ai-engine-base": "5.45.1",
+    "@memberjunction/ai-mcp-client": "5.45.1",
+    "@memberjunction/ai-prompts": "5.45.1",
+    "@memberjunction/ai-provider-bundle": "5.45.1",
+    "@memberjunction/ai-vector-sync": "5.45.1",
+    "@memberjunction/ai-vectordb": "5.45.1",
+    "@memberjunction/ai-vectors-pinecone": "5.45.1",
+    "@memberjunction/aiengine": "5.45.1",
+    "@memberjunction/api-keys": "5.45.1",
+    "@memberjunction/auth-providers": "5.45.1",
+    "@memberjunction/clustering-engine": "5.45.1",
+    "@memberjunction/codegen-lib": "5.45.1",
+    "@memberjunction/communication-engine": "5.45.1",
+    "@memberjunction/communication-ms-graph": "5.45.1",
+    "@memberjunction/notifications": "5.45.1",
+    "@memberjunction/communication-sendgrid": "5.45.1",
+    "@memberjunction/communication-types": "5.45.1",
+    "@memberjunction/component-registry-client-sdk": "5.45.1",
+    "@memberjunction/computer-use": "5.45.1",
+    "@memberjunction/computer-use-engine": "5.45.1",
+    "@memberjunction/config": "5.45.1",
+    "@memberjunction/core": "5.45.1",
+    "@memberjunction/core-actions": "5.45.1",
+    "@memberjunction/core-entities": "5.45.1",
+    "@memberjunction/core-entities-server": "5.45.1",
+    "@memberjunction/credentials": "5.45.1",
+    "@memberjunction/data-context": "5.45.1",
+    "@memberjunction/data-context-server": "5.45.1",
+    "@memberjunction/doc-utils": "5.45.1",
+    "@memberjunction/encryption": "5.45.1",
+    "@memberjunction/entity-communications-base": "5.45.1",
+    "@memberjunction/entity-communications-server": "5.45.1",
+    "@memberjunction/esignature": "5.45.1",
+    "@memberjunction/external-change-detection": "5.45.1",
+    "@memberjunction/generic-database-provider": "5.45.1",
+    "@memberjunction/global": "5.45.1",
+    "@memberjunction/graphql-dataprovider": "5.45.1",
+    "@memberjunction/integration-engine": "5.45.1",
+    "@memberjunction/integration-progress-artifacts": "5.45.1",
+    "@memberjunction/integration-schema-builder": "5.45.1",
+    "@memberjunction/interactive-component-types": "5.45.1",
+    "@memberjunction/lists": "5.45.1",
+    "@memberjunction/lists-base": "5.45.1",
+    "@memberjunction/livekit-room-server": "5.45.1",
+    "@memberjunction/postgresql-dataprovider": "5.45.1",
+    "@memberjunction/queue": "5.45.1",
+    "@memberjunction/record-comparison": "5.45.1",
+    "@memberjunction/redis-provider": "5.45.1",
+    "@memberjunction/remote-browser-base": "5.45.1",
+    "@memberjunction/remote-browser-cdp": "5.45.1",
+    "@memberjunction/remote-browser-selfhost": "5.45.1",
+    "@memberjunction/remote-browser-server": "5.45.1",
+    "@memberjunction/scheduling-actions": "5.45.1",
+    "@memberjunction/scheduling-base-types": "5.45.1",
+    "@memberjunction/scheduling-engine": "5.45.1",
+    "@memberjunction/scheduling-engine-base": "5.45.1",
+    "@memberjunction/schema-engine": "5.45.1",
+    "@memberjunction/search-engine": "5.45.1",
+    "@memberjunction/server-extensions-core": "5.45.1",
+    "@memberjunction/sql-dialect": "5.45.1",
+    "@memberjunction/sqlserver-dataprovider": "5.45.1",
+    "@memberjunction/storage": "5.45.1",
+    "@memberjunction/tag-engine": "5.45.1",
+    "@memberjunction/tag-engine-base": "5.45.1",
+    "@memberjunction/templates": "5.45.1",
+    "@memberjunction/testing-engine": "5.45.1",
+    "@memberjunction/testing-engine-base": "5.45.1",
+    "@memberjunction/version-history": "5.45.1",
     "@octokit/auth-app": "^7.1.5",
     "@octokit/rest": "^21.1.1",
     "@types/compression": "^1.8.1",

package/src/__tests__/RunAIAgentResolver.streaming.test.ts

@@ -0,0 +1,128 @@
+/**
+ * @fileoverview Wire-shape tests for RunAIAgentResolver's streaming callback.
+ *
+ * The conversation client (ConversationsRuntime's ConversationStreaming) parses the
+ * exact JSON this resolver publishes to the PushStatusUpdates topic — in particular
+ * `data.type === 'streaming'` and `data.streaming.{content,isPartial,kind}`. These
+ * tests pin the published shape so the server and client can't silently drift
+ * (the client's own parsing of this same shape is pinned in
+ * packages/ConversationsRuntime/src/__tests__/ConversationStreaming.test.ts).
+ */
+import 'reflect-metadata'; // must precede any type-graphql decorator evaluation
+import { describe, it, expect, vi } from 'vitest';
+import type { PubSubEngine } from 'type-graphql';
+
+// type-graphql's real decorators need emitDecoratorMetadata to infer field types
+// (`@Field() success: boolean`), which vitest's esbuild transform does not emit.
+// The GraphQL schema is irrelevant here — no-op every decorator so the resolver
+// module can be imported and its streaming callback exercised directly.
+vi.mock('type-graphql', () => {
+    const decoratorFactory = (..._args: unknown[]) => (..._decorated: unknown[]) => undefined;
+    const exportNames = [
+        'Resolver', 'Query', 'Mutation', 'Subscription', 'Arg', 'Args', 'ArgsType', 'Ctx', 'Root',
+        'Info', 'Field', 'FieldResolver', 'ObjectType', 'InputType', 'InterfaceType', 'Authorized',
+        'UseMiddleware', 'Extensions', 'Directive', 'ID', 'Int', 'Float', 'GraphQLISODateTime',
+        'GraphQLTimestamp', 'registerEnumType', 'createMethodDecorator', 'createParamDecorator',
+        'buildSchema', 'buildSchemaSync', 'PubSub',
+    ];
+    return Object.fromEntries(exportNames.map((name) => [name, decoratorFactory]));
+});
+import type { AgentExecutionStreamingCallback } from '@memberjunction/ai-core-plus';
+
+import { RunAIAgentResolver } from '../resolvers/RunAIAgentResolver.js';
+import type { UserPayload } from '../types.js';
+
+/** Access the private factory without widening the class's public API. */
+interface StreamingCallbackFactory {
+    createStreamingCallback(
+        pubSub: PubSubEngine,
+        sessionId: string,
+        userPayload: UserPayload,
+        agentRunRef: { current: unknown }
+    ): AgentExecutionStreamingCallback;
+}
+
+function buildHarness() {
+    const publish = vi.fn().mockResolvedValue(undefined);
+    const pubSub = { publish } as unknown as PubSubEngine;
+    const userPayload = { sessionId: 'session-1' } as UserPayload;
+    const agentRunRef = {
+        current: {
+            ID: 'run-1',
+            GetAll: () => ({ ID: 'run-1', ConversationDetailID: 'detail-1', Agent: 'Betty' }),
+        },
+    };
+    const resolver = new RunAIAgentResolver() as unknown as StreamingCallbackFactory;
+    const callback = resolver.createStreamingCallback(pubSub, 'session-1', userPayload, agentRunRef);
+    return { publish, callback };
+}
+
+/** Parse the published envelope back out of the pubSub.publish mock. */
+function publishedData(publish: ReturnType<typeof vi.fn>): Record<string, unknown> {
+    expect(publish).toHaveBeenCalledOnce();
+    const envelope = publish.mock.calls[0][1] as { message: string };
+    const parsed = JSON.parse(envelope.message) as Record<string, unknown>;
+    expect(parsed.type).toBe('StreamingContent');
+    expect(parsed.resolver).toBe('RunAIAgentResolver');
+    return parsed.data as Record<string, unknown>;
+}
+
+describe('RunAIAgentResolver.createStreamingCallback', () => {
+    it('publishes the streaming wire shape the conversation client parses', () => {
+        const { publish, callback } = buildHarness();
+
+        callback({ content: 'Hel', isComplete: false, stepType: 'prompt', modelName: 'gpt-x', kind: 'final-response' });
+
+        const data = publishedData(publish);
+        expect(data.type).toBe('streaming');
+        expect(data.agentRunId).toBe('run-1');
+        expect((data.agentRun as Record<string, unknown>).ConversationDetailID).toBe('detail-1');
+        expect(data.streaming).toMatchObject({
+            content: 'Hel',
+            isPartial: true,
+            stepName: 'prompt',
+            kind: 'final-response',
+        });
+    });
+
+    it('maps isComplete=true to isPartial=false on the final chunk', () => {
+        const { publish, callback } = buildHarness();
+
+        callback({ content: '', isComplete: true, kind: 'final-response' });
+
+        const data = publishedData(publish);
+        expect((data.streaming as Record<string, unknown>).isPartial).toBe(false);
+    });
+
+    it('passes an absent kind through untouched — unmarked raw streams must stay unrendered', () => {
+        // Guard rail: if the resolver ever defaults unmarked chunks to a renderable
+        // kind (e.g. `chunk.kind ?? 'final-response'` left in from local testing),
+        // every Loop agent's raw JSON envelope would render into chat bubbles.
+        // This test fails the moment such a fallback exists.
+        const { publish, callback } = buildHarness();
+
+        callback({ content: '{"taskComplete":', isComplete: false, stepType: 'prompt' });
+
+        const data = publishedData(publish);
+        expect((data.streaming as Record<string, unknown>).kind).toBeUndefined();
+    });
+
+    it('does not publish when no agent run is available yet', () => {
+        const publish = vi.fn();
+        const pubSub = { publish } as unknown as PubSubEngine;
+        const resolver = new RunAIAgentResolver() as unknown as StreamingCallbackFactory;
+        const callback = resolver.createStreamingCallback(
+            pubSub,
+            'session-1',
+            { sessionId: 'session-1' } as UserPayload,
+            { current: null }
+        );
+        const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => undefined);
+        try {
+            callback({ content: 'early', isComplete: false });
+            expect(publish).not.toHaveBeenCalled();
+        } finally {
+            consoleSpy.mockRestore();
+        }
+    });
+});

package/src/__tests__/magicLink.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect } from 'vitest';
 import jwt from 'jsonwebtoken';
-import { createPublicKey } from 'node:crypto';
+import { createPublicKey, type JsonWebKey } from 'node:crypto';
 import {
   generateRawToken,
   hashToken,
@@ -228,6 +228,56 @@ describe('magic-link core', () => {
     });
   });
 
+  describe('buildConsumeInviteSQL (postgresql dialect)', () => {
+    // PG uses `schema.table` (unquoted — PostgreSQLDataProvider.ExecuteSQL auto-quotes
+    // the PascalCase identifiers). SS uses the bracket-quoted `[schema].[table]` form.
+    const pgTable = '__mj.MagicLinkInvite';
+    const pgSql = buildConsumeInviteSQL(pgTable, 'postgresql');
+
+    it('targets the supplied unquoted schema.table', () => {
+      expect(pgSql).toContain(`UPDATE ${pgTable} `);
+    });
+
+    it('uses UPDATE … RETURNING as the atomic single-use gate (no OUTPUT/DECLARE table var)', () => {
+      expect(pgSql).toContain('RETURNING ID;');
+      expect(pgSql).not.toContain('OUTPUT');
+      expect(pgSql).not.toContain('DECLARE');
+    });
+
+    it('binds the invite ID as PG positional param $1, not T-SQL @p0 (injection-safe)', () => {
+      expect(pgSql).toContain('ID = $1');
+      expect(pgSql).not.toContain('@p0');
+      expect(pgSql).not.toMatch(/@/); // no T-SQL @-anything survives on PG
+      expect(pgSql).not.toMatch(/ID = '/);
+    });
+
+    it('uses PG timestamp expressions, not T-SQL SYSUTCDATETIME()', () => {
+      expect(pgSql).not.toContain('SYSUTCDATETIME');
+      expect(pgSql).toContain("(now() AT TIME ZONE 'utc')");
+      expect(pgSql).toContain("ConsumedAt = COALESCE(ConsumedAt, (now() AT TIME ZONE 'utc'))");
+    });
+
+    it('guards atomically on Active + not-exhausted + not-expired (same predicate as SS)', () => {
+      const where = pgSql.slice(pgSql.indexOf('WHERE'));
+      expect(where).toContain("Status = 'Active'");
+      expect(where).toContain('UseCount < MaxUses');
+      expect(where).toContain("ExpiresAt > (now() AT TIME ZONE 'utc')");
+    });
+
+    it('increments UseCount and flips Status on the last use (same semantics as SS)', () => {
+      expect(pgSql).toContain('UseCount = UseCount + 1');
+      expect(pgSql).toContain("Status = CASE WHEN UseCount + 1 >= MaxUses THEN 'Consumed' ELSE Status END");
+    });
+
+    it('rejects a non-whitelisted PG table identifier (defense-in-depth against injection)', () => {
+      // Bracket-quoted (SS) form is not a valid PG identifier here.
+      expect(() => buildConsumeInviteSQL('[__mj].[MagicLinkInvite]', 'postgresql')).toThrow();
+      expect(() => buildConsumeInviteSQL('__mj.MagicLinkInvite; DROP TABLE x;--', 'postgresql')).toThrow();
+      expect(() => buildConsumeInviteSQL('__mj.Magic Link', 'postgresql')).toThrow();
+      expect(() => buildConsumeInviteSQL(pgTable, 'postgresql')).not.toThrow();
+    });
+  });
+
   describe('canIssueInvites', () => {
     it('always allows Owners, regardless of issuer-role config (case/space-insensitive)', () => {
       expect(canIssueInvites('Owner', [], [])).toBe(true);
@@ -351,7 +401,7 @@ describe('MagicLinkKeyManager', () => {
     expect(header.kid).toBe(jwk.kid);
 
     // Full verification against the public key reconstructed from the JWK.
-    const publicKey = createPublicKey({ key: jwk as object, format: 'jwk' });
+    const publicKey = createPublicKey({ key: jwk as unknown as JsonWebKey, format: 'jwk' });
     const decoded = jwt.verify(token, publicKey, {
       algorithms: ['RS256'],
       issuer: 'http://localhost:4051',
@@ -375,7 +425,7 @@ describe('MagicLinkKeyManager', () => {
       ttlSeconds: 3600,
     });
     const token = km.Sign(claims);
-    const publicKey = createPublicKey({ key: km.GetJWKS().keys[0] as object, format: 'jwk' });
+    const publicKey = createPublicKey({ key: km.GetJWKS().keys[0] as unknown as JsonWebKey, format: 'jwk' });
 
     // Flip a character in the payload segment.
     const parts = token.split('.');

package/src/__tests__/search-knowledge-tags.test.ts

@@ -127,7 +127,7 @@ describe('SearchKnowledgeResolver', () => {
             const resolver = createResolver();
             mockSearch.mockResolvedValueOnce(createMockSearchResult());
 
-            const result = await resolver.SearchKnowledge('test query', 20, undefined, undefined, fakeContext as never);
+            const result = await resolver.SearchKnowledge('test query', 20, undefined, undefined, undefined, undefined, undefined, fakeContext as never);
 
             expect(mockSearch).toHaveBeenCalledOnce();
             expect(result.Success).toBe(true);
@@ -139,7 +139,7 @@ describe('SearchKnowledgeResolver', () => {
             const resolver = createResolver();
             mockSearch.mockResolvedValueOnce(createMockSearchResult());
 
-            await resolver.SearchKnowledge('cheese', 50, undefined, undefined, fakeContext as never);
+            await resolver.SearchKnowledge('cheese', 50, undefined, undefined, undefined, undefined, undefined, fakeContext as never);
 
             const searchParams = mockSearch.mock.calls[0][0];
             expect(searchParams.Query).toBe('cheese');
@@ -151,7 +151,7 @@ describe('SearchKnowledgeResolver', () => {
             mockSearch.mockResolvedValueOnce(createMockSearchResult());
 
             const filters = { EntityNames: ['Contacts'], SourceTypes: undefined, Tags: ['VIP'] };
-            await resolver.SearchKnowledge('test', 20, filters as never, undefined, fakeContext as never);
+            await resolver.SearchKnowledge('test', 20, filters as never, undefined, undefined, undefined, undefined, fakeContext as never);
 
             const searchParams = mockSearch.mock.calls[0][0];
             expect(searchParams.Filters).toEqual({
@@ -165,7 +165,7 @@ describe('SearchKnowledgeResolver', () => {
             const resolver = createResolver();
             mockSearch.mockResolvedValueOnce(createMockSearchResult());
 
-            await resolver.SearchKnowledge('test', 20, undefined, 0.5, fakeContext as never);
+            await resolver.SearchKnowledge('test', 20, undefined, 0.5, undefined, undefined, undefined, fakeContext as never);
 
             const searchParams = mockSearch.mock.calls[0][0];
             expect(searchParams.MinScore).toBe(0.5);
@@ -175,7 +175,7 @@ describe('SearchKnowledgeResolver', () => {
             const resolver = createResolver();
             mockSearch.mockResolvedValueOnce(createMockSearchResult());
 
-            const result = await resolver.SearchKnowledge('test', 20, undefined, undefined, fakeContext as never);
+            const result = await resolver.SearchKnowledge('test', 20, undefined, undefined, undefined, undefined, undefined, fakeContext as never);
 
             const item = result.Results[0];
             expect(item.ID).toBe('result-1');
@@ -193,7 +193,7 @@ describe('SearchKnowledgeResolver', () => {
                 SourceCounts: { Vector: 5, FullText: 3, Entity: 10, Storage: 0 }
             }));
 
-            const result = await resolver.SearchKnowledge('test', 20, undefined, undefined, fakeContext as never);
+            const result = await resolver.SearchKnowledge('test', 20, undefined, undefined, undefined, undefined, undefined, fakeContext as never);
 
             expect(result.SourceCounts.Vector).toBe(5);
             expect(result.SourceCounts.FullText).toBe(3);
@@ -204,7 +204,7 @@ describe('SearchKnowledgeResolver', () => {
             const resolver = createResolver();
             mockSearch.mockResolvedValueOnce(createMockSearchResult({ Success: false, ErrorMessage: 'Query cannot be empty' }));
 
-            const result = await resolver.SearchKnowledge('   ', 20, undefined, undefined, fakeContext as never);
+            const result = await resolver.SearchKnowledge('   ', 20, undefined, undefined, undefined, undefined, undefined, fakeContext as never);
 
             expect(mockSearch).toHaveBeenCalled();
             expect(result.Success).toBe(false);
@@ -214,7 +214,7 @@ describe('SearchKnowledgeResolver', () => {
             const resolver = new SearchKnowledgeResolver();
             (resolver as Record<string, unknown>)['GetUserFromPayload'] = vi.fn().mockReturnValue(null);
 
-            const result = await resolver.SearchKnowledge('test', 20, undefined, undefined, fakeContext as never);
+            const result = await resolver.SearchKnowledge('test', 20, undefined, undefined, undefined, undefined, undefined, fakeContext as never);
 
             expect(result.Success).toBe(false);
             expect(result.ErrorMessage).toContain('current user');
@@ -224,7 +224,7 @@ describe('SearchKnowledgeResolver', () => {
             const resolver = createResolver();
             mockSearch.mockRejectedValueOnce(new Error('Connection failed'));
 
-            const result = await resolver.SearchKnowledge('test', 20, undefined, undefined, fakeContext as never);
+            const result = await resolver.SearchKnowledge('test', 20, undefined, undefined, undefined, undefined, undefined, fakeContext as never);
 
             expect(result.Success).toBe(false);
             expect(result.ErrorMessage).toContain('Connection failed');

package/src/__tests__/teams-meetings-service.test.ts

@@ -0,0 +1,65 @@
+import { describe, it, expect, vi } from 'vitest';
+import { TeamsMeetingsService } from '../telephony/TeamsMeetingsService.js';
+import { TeamsAcsMediaRegistry } from '../telephony/teamsAcsMediaRegistry.js';
+import { RealTeamsBindings } from '@memberjunction/ai-bridge-teams';
+import type { BaseRealtimeBridge } from '@memberjunction/ai-bridge-base';
+import type { TeamsMeetingsConfig } from '../config.js';
+
+const CONFIG: TeamsMeetingsConfig = {
+    enabled: true,
+    tenantId: 'tenant-1',
+    botAccessToken: 'tok',
+    notificationClientState: 'secret',
+    acsSampleRate: 16000,
+    modelSampleRate: 16000,
+};
+
+describe('TeamsMeetingsService.buildBindSdk', () => {
+    it('binds a RealTeamsBindings factory onto the Teams driver (the live Graph + ACS wiring seam)', () => {
+        const service = new TeamsMeetingsService(CONFIG, new TeamsAcsMediaRegistry());
+        const setSdkFactory = vi.fn();
+        const fakeDriver = { SetSdkFactory: setSdkFactory } as unknown as BaseRealtimeBridge;
+        // A minimal fake Graph client (only used as a constructor arg here).
+        const graphClient = { CreateCall: vi.fn() } as unknown as Parameters<typeof service.buildBindSdk>[0];
+
+        service.buildBindSdk(graphClient)(fakeDriver);
+
+        expect(setSdkFactory).toHaveBeenCalledTimes(1);
+        const factory = setSdkFactory.mock.calls[0][0] as () => unknown;
+        expect(typeof factory).toBe('function');
+        // The factory yields a real (bound) RealTeamsBindings — proving the offline seam meets live plumbing.
+        expect(factory()).toBeInstanceOf(RealTeamsBindings);
+    });
+});
+
+describe('TeamsMeetingsService.JoinMeetingByUrl', () => {
+    it('returns accepted=false (never throws) when the agent identity is missing', async () => {
+        const provider = {
+            GetEntityObject: vi.fn().mockResolvedValue({ Load: vi.fn().mockResolvedValue(false), IsActive: false }),
+        };
+        const service = new TeamsMeetingsService(CONFIG, new TeamsAcsMediaRegistry());
+        const result = await service.JoinMeetingByUrl(
+            'identity-1',
+            'https://teams.microsoft.com/l/meetup-join/x',
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any -- minimal UserInfo stub for a pure-branch test
+            { ID: 'u1' } as never,
+            provider as never,
+        );
+        expect(result.accepted).toBe(false);
+        expect(result.reason).toMatch(/not found or inactive/i);
+    });
+});
+
+describe('TeamsMeetingsService notification drive helpers', () => {
+    it('tears down the call + registry on call-ended (no throw when no client registered)', () => {
+        const registry = new TeamsAcsMediaRegistry();
+        registry.RegisterCall('call-1');
+        expect(registry.HasCall('call-1')).toBe(true);
+        const service = new TeamsMeetingsService(CONFIG, registry);
+
+        service.DriveCallEnded('call-1');
+        expect(registry.HasCall('call-1')).toBe(false);
+        // An unknown roster drive is a silent no-op.
+        expect(() => service.DriveParticipantsUpdated('unknown', [{ id: 'p1' }])).not.toThrow();
+    });
+});

package/src/__tests__/teamsAcsMediaRegistry.test.ts

@@ -0,0 +1,82 @@
+import { describe, it, expect } from 'vitest';
+import { TeamsAcsMediaRegistry, type IAcsMediaTransport } from '../telephony/teamsAcsMediaRegistry.js';
+import type { AcsInboundAudioFrame } from '@memberjunction/ai-bridge-teams';
+
+class FakeTransport implements IAcsMediaTransport {
+    public readonly Sent: ArrayBuffer[] = [];
+    public Closed = false;
+    public sendAudioFrame(pcm: ArrayBuffer): void {
+        this.Sent.push(pcm);
+    }
+    public close(): void {
+        this.Closed = true;
+    }
+}
+
+const frame = (bytes: number): ArrayBuffer => new ArrayBuffer(bytes);
+
+describe('TeamsAcsMediaRegistry', () => {
+    it('exposes the configured ACS sample rate', () => {
+        expect(new TeamsAcsMediaRegistry().SampleRate).toBe(16000);
+        expect(new TeamsAcsMediaRegistry(8000).SampleRate).toBe(8000);
+    });
+
+    it('buffers outbound PCM before the transport attaches, then flushes on attach', () => {
+        const registry = new TeamsAcsMediaRegistry();
+        const a = frame(4);
+        const b = frame(8);
+        registry.Send('call-1', a);
+        registry.Send('call-1', b);
+
+        const transport = new FakeTransport();
+        registry.AttachTransport('call-1', transport);
+
+        expect(transport.Sent).toEqual([a, b]);
+    });
+
+    it('sends immediately once the transport is attached', () => {
+        const registry = new TeamsAcsMediaRegistry();
+        const transport = new FakeTransport();
+        registry.AttachTransport('call-1', transport);
+        const a = frame(4);
+        registry.Send('call-1', a);
+        expect(transport.Sent).toEqual([a]);
+    });
+
+    it('dispatches inbound frames to all registered handlers for the call', () => {
+        const registry = new TeamsAcsMediaRegistry();
+        const seen: AcsInboundAudioFrame[] = [];
+        registry.OnFrame('call-1', (f) => seen.push(f));
+        registry.OnFrame('call-1', (f) => seen.push(f));
+        const f: AcsInboundAudioFrame = { Pcm: frame(2), ParticipantId: 'p1' };
+        registry.DispatchInbound('call-1', f);
+        expect(seen).toEqual([f, f]);
+    });
+
+    it('dispatches hand-raise signals to registered hand-raise handlers', () => {
+        const registry = new TeamsAcsMediaRegistry();
+        let raised: boolean | undefined;
+        registry.OnHandRaise('call-1', (_p, r) => (raised = r));
+        registry.DispatchHandRaise('call-1', 'p1', true);
+        expect(raised).toBe(true);
+    });
+
+    it('ignores inbound dispatch + hand-raise for unknown calls (no throw)', () => {
+        const registry = new TeamsAcsMediaRegistry();
+        expect(() => registry.DispatchInbound('nope', { Pcm: frame(2), ParticipantId: 'p1' })).not.toThrow();
+        expect(() => registry.DispatchHandRaise('nope', 'p1', true)).not.toThrow();
+    });
+
+    it('closes the transport and forgets the call on EndCall', () => {
+        const registry = new TeamsAcsMediaRegistry();
+        const transport = new FakeTransport();
+        registry.AttachTransport('call-1', transport);
+        expect(registry.HasCall('call-1')).toBe(true);
+
+        registry.EndCall('call-1');
+        expect(transport.Closed).toBe(true);
+        expect(registry.HasCall('call-1')).toBe(false);
+        // EndCall on an unknown call is a silent no-op.
+        expect(() => registry.EndCall('unknown')).not.toThrow();
+    });
+});