@memberjunction/server 5.34.1 → 5.36.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@memberjunction/server",
-  "version": "5.34.1",
+  "version": "5.36.0",
   "description": "MemberJunction: This project provides API access via GraphQL to the common data store.",
   "main": "./dist/index.js",
   "types": "./src/index.ts",
@@ -27,73 +27,75 @@
     "@as-integrations/express5": "^1.0.0",
     "@graphql-tools/schema": "latest",
     "@graphql-tools/utils": "^11.0.0",
-    "@memberjunction/actions": "5.34.1",
-    "@memberjunction/actions-apollo": "5.34.1",
-    "@memberjunction/actions-base": "5.34.1",
-    "@memberjunction/actions-bizapps-accounting": "5.34.1",
-    "@memberjunction/actions-bizapps-crm": "5.34.1",
-    "@memberjunction/actions-bizapps-formbuilders": "5.34.1",
-    "@memberjunction/actions-bizapps-lms": "5.34.1",
-    "@memberjunction/actions-bizapps-social": "5.34.1",
-    "@memberjunction/ai": "5.34.1",
-    "@memberjunction/ai-agent-manager": "5.34.1",
-    "@memberjunction/ai-agent-manager-actions": "5.34.1",
-    "@memberjunction/ai-agents": "5.34.1",
-    "@memberjunction/ai-core-plus": "5.34.1",
-    "@memberjunction/ai-mcp-client": "5.34.1",
-    "@memberjunction/ai-prompts": "5.34.1",
-    "@memberjunction/ai-provider-bundle": "5.34.1",
-    "@memberjunction/ai-vector-sync": "5.34.1",
-    "@memberjunction/ai-vectordb": "5.34.1",
-    "@memberjunction/ai-vectors-pinecone": "5.34.1",
-    "@memberjunction/aiengine": "5.34.1",
-    "@memberjunction/api-keys": "5.34.1",
-    "@memberjunction/auth-providers": "5.34.1",
-    "@memberjunction/codegen-lib": "5.34.1",
-    "@memberjunction/communication-ms-graph": "5.34.1",
-    "@memberjunction/communication-sendgrid": "5.34.1",
-    "@memberjunction/communication-types": "5.34.1",
-    "@memberjunction/component-registry-client-sdk": "5.34.1",
-    "@memberjunction/computer-use-engine": "5.34.1",
-    "@memberjunction/config": "5.34.1",
-    "@memberjunction/core": "5.34.1",
-    "@memberjunction/core-actions": "5.34.1",
-    "@memberjunction/core-entities": "5.34.1",
-    "@memberjunction/core-entities-server": "5.34.1",
-    "@memberjunction/data-context": "5.34.1",
-    "@memberjunction/data-context-server": "5.34.1",
-    "@memberjunction/doc-utils": "5.34.1",
-    "@memberjunction/encryption": "5.34.1",
-    "@memberjunction/entity-communications-base": "5.34.1",
-    "@memberjunction/entity-communications-server": "5.34.1",
-    "@memberjunction/external-change-detection": "5.34.1",
-    "@memberjunction/generic-database-provider": "5.34.1",
-    "@memberjunction/global": "5.34.1",
-    "@memberjunction/graphql-dataprovider": "5.34.1",
-    "@memberjunction/integration-engine": "5.34.1",
-    "@memberjunction/integration-schema-builder": "5.34.1",
-    "@memberjunction/interactive-component-types": "5.34.1",
-    "@memberjunction/notifications": "5.34.1",
-    "@memberjunction/postgresql-dataprovider": "5.34.1",
-    "@memberjunction/queue": "5.34.1",
-    "@memberjunction/redis-provider": "5.34.1",
-    "@memberjunction/scheduling-actions": "5.34.1",
-    "@memberjunction/scheduling-base-types": "5.34.1",
-    "@memberjunction/scheduling-engine": "5.34.1",
-    "@memberjunction/scheduling-engine-base": "5.34.1",
-    "@memberjunction/schema-engine": "5.34.1",
-    "@memberjunction/search-engine": "5.34.1",
-    "@memberjunction/server-extensions-core": "5.34.1",
-    "@memberjunction/skip-types": "5.34.1",
-    "@memberjunction/sql-dialect": "5.34.1",
-    "@memberjunction/sqlserver-dataprovider": "5.34.1",
-    "@memberjunction/storage": "5.34.1",
-    "@memberjunction/tag-engine": "5.34.1",
-    "@memberjunction/tag-engine-base": "5.34.1",
-    "@memberjunction/templates": "5.34.1",
-    "@memberjunction/testing-engine": "5.34.1",
-    "@memberjunction/testing-engine-base": "5.34.1",
-    "@memberjunction/version-history": "5.34.1",
+    "@memberjunction/actions": "5.36.0",
+    "@memberjunction/actions-apollo": "5.36.0",
+    "@memberjunction/actions-base": "5.36.0",
+    "@memberjunction/actions-bizapps-accounting": "5.36.0",
+    "@memberjunction/actions-bizapps-crm": "5.36.0",
+    "@memberjunction/actions-bizapps-formbuilders": "5.36.0",
+    "@memberjunction/actions-bizapps-lms": "5.36.0",
+    "@memberjunction/actions-bizapps-social": "5.36.0",
+    "@memberjunction/ai": "5.36.0",
+    "@memberjunction/ai-agent-manager": "5.36.0",
+    "@memberjunction/ai-agent-manager-actions": "5.36.0",
+    "@memberjunction/ai-agents": "5.36.0",
+    "@memberjunction/ai-core-plus": "5.36.0",
+    "@memberjunction/ai-mcp-client": "5.36.0",
+    "@memberjunction/ai-prompts": "5.36.0",
+    "@memberjunction/ai-provider-bundle": "5.36.0",
+    "@memberjunction/ai-vector-sync": "5.36.0",
+    "@memberjunction/ai-vectordb": "5.36.0",
+    "@memberjunction/ai-vectors-pinecone": "5.36.0",
+    "@memberjunction/aiengine": "5.36.0",
+    "@memberjunction/api-keys": "5.36.0",
+    "@memberjunction/auth-providers": "5.36.0",
+    "@memberjunction/codegen-lib": "5.36.0",
+    "@memberjunction/communication-ms-graph": "5.36.0",
+    "@memberjunction/communication-sendgrid": "5.36.0",
+    "@memberjunction/communication-types": "5.36.0",
+    "@memberjunction/component-registry-client-sdk": "5.36.0",
+    "@memberjunction/computer-use-engine": "5.36.0",
+    "@memberjunction/config": "5.36.0",
+    "@memberjunction/core": "5.36.0",
+    "@memberjunction/core-actions": "5.36.0",
+    "@memberjunction/core-entities": "5.36.0",
+    "@memberjunction/core-entities-server": "5.36.0",
+    "@memberjunction/data-context": "5.36.0",
+    "@memberjunction/data-context-server": "5.36.0",
+    "@memberjunction/doc-utils": "5.36.0",
+    "@memberjunction/encryption": "5.36.0",
+    "@memberjunction/entity-communications-base": "5.36.0",
+    "@memberjunction/entity-communications-server": "5.36.0",
+    "@memberjunction/external-change-detection": "5.36.0",
+    "@memberjunction/generic-database-provider": "5.36.0",
+    "@memberjunction/global": "5.36.0",
+    "@memberjunction/graphql-dataprovider": "5.36.0",
+    "@memberjunction/integration-engine": "5.36.0",
+    "@memberjunction/integration-schema-builder": "5.36.0",
+    "@memberjunction/interactive-component-types": "5.36.0",
+    "@memberjunction/lists": "5.36.0",
+    "@memberjunction/lists-base": "5.36.0",
+    "@memberjunction/notifications": "5.36.0",
+    "@memberjunction/postgresql-dataprovider": "5.36.0",
+    "@memberjunction/queue": "5.36.0",
+    "@memberjunction/redis-provider": "5.36.0",
+    "@memberjunction/scheduling-actions": "5.36.0",
+    "@memberjunction/scheduling-base-types": "5.36.0",
+    "@memberjunction/scheduling-engine": "5.36.0",
+    "@memberjunction/scheduling-engine-base": "5.36.0",
+    "@memberjunction/schema-engine": "5.36.0",
+    "@memberjunction/search-engine": "5.36.0",
+    "@memberjunction/server-extensions-core": "5.36.0",
+    "@memberjunction/skip-types": "5.36.0",
+    "@memberjunction/sql-dialect": "5.36.0",
+    "@memberjunction/sqlserver-dataprovider": "5.36.0",
+    "@memberjunction/storage": "5.36.0",
+    "@memberjunction/tag-engine": "5.36.0",
+    "@memberjunction/tag-engine-base": "5.36.0",
+    "@memberjunction/templates": "5.36.0",
+    "@memberjunction/testing-engine": "5.36.0",
+    "@memberjunction/testing-engine-base": "5.36.0",
+    "@memberjunction/version-history": "5.36.0",
     "@types/compression": "^1.8.1",
     "@types/cors": "^2.8.19",
     "@types/jsonwebtoken": "9.0.10",

package/src/__tests__/ListOperationsResolver.test.ts

@@ -0,0 +1,182 @@
+/**
+ * Tests for the pure boundary converters in ListOperationsResolver.
+ *
+ * The resolver itself depends on type-graphql + AppContext, which would
+ * require a full test harness. The converters are standalone functions
+ * doing the GraphQL ↔ @memberjunction/lists translation — they have no
+ * side effects and are the most likely site of drift if either side's
+ * shape changes, so they're the right test target.
+ */
+
+// type-graphql decorators (`@Field`, `@InputType`, etc.) call
+// `Reflect.getMetadata`, which only exists when this polyfill is loaded
+// first. Vitest doesn't bring it in automatically — `import` ordering
+// matters: this line MUST come before any import that pulls in the
+// resolver file.
+import 'reflect-metadata';
+
+import { describe, expect, it } from 'vitest';
+
+import type { ApplyResult, ListDelta } from '@memberjunction/lists-base';
+
+import {
+  ApplyDeltaInput,
+  ListSourceInput,
+  fromCoreApplyResult,
+  fromCoreDelta,
+  fromCoreWarning,
+  rebuildDeltaFromInput,
+  toCoreSource,
+} from '../resolvers/ListOperationsResolver.js';
+
+describe('ListOperationsResolver — boundary converters', () => {
+  describe('toCoreSource', () => {
+    it('maps a list-kind input to a core ListSource', () => {
+      const input = Object.assign(new ListSourceInput(), { Kind: 'list', ListID: 'list-1' });
+      const result = toCoreSource(input);
+      expect(result).toEqual({ kind: 'list', listId: 'list-1' });
+    });
+
+    it('maps a view-kind input to a core ListSource', () => {
+      const input = Object.assign(new ListSourceInput(), { Kind: 'view', ViewID: 'view-1' });
+      expect(toCoreSource(input)).toEqual({ kind: 'view', viewId: 'view-1' });
+    });
+
+    it('maps an adhoc-kind input to a core ListSource', () => {
+      const input = Object.assign(new ListSourceInput(), {
+        Kind: 'adhoc',
+        EntityName: 'Contacts',
+        ExtraFilter: "Status='Active'",
+      });
+      expect(toCoreSource(input)).toEqual({
+        kind: 'adhoc',
+        entityName: 'Contacts',
+        extraFilter: "Status='Active'",
+      });
+    });
+
+    it('throws when list-kind input has no ListID', () => {
+      const input = Object.assign(new ListSourceInput(), { Kind: 'list' });
+      expect(() => toCoreSource(input)).toThrow(/ListID is required/);
+    });
+
+    it('throws when view-kind input has no ViewID', () => {
+      const input = Object.assign(new ListSourceInput(), { Kind: 'view' });
+      expect(() => toCoreSource(input)).toThrow(/ViewID is required/);
+    });
+
+    it('throws when adhoc-kind input lacks EntityName or ExtraFilter', () => {
+      const input = Object.assign(new ListSourceInput(), { Kind: 'adhoc', EntityName: 'X' });
+      expect(() => toCoreSource(input)).toThrow(/EntityName and ExtraFilter/);
+    });
+
+    it('throws on an unknown discriminator', () => {
+      const input = Object.assign(new ListSourceInput(), { Kind: 'mystery' as never });
+      expect(() => toCoreSource(input)).toThrow(/Unknown ListSourceInput\.Kind/);
+    });
+  });
+
+  describe('fromCoreDelta', () => {
+    it('mirrors all fields and stringifies warning details', () => {
+      const delta: ListDelta = {
+        TargetListId: 'list-1',
+        EntityName: 'Contacts',
+        ToAdd: ['a', 'b'],
+        ToRemove: ['c'],
+        Unchanged: ['d', 'e'],
+        Counts: { Add: 2, Remove: 1, Unchanged: 2, SourceTotal: 4, TargetTotal: 3 },
+        Warnings: [
+          { Code: 'WILL_REMOVE_RECORDS', Message: '1 record will be removed', Details: { Count: 1 } },
+        ],
+        DeltaToken: 'abc.def',
+      };
+      const output = fromCoreDelta(delta);
+      expect(output).toMatchObject({
+        TargetListId: 'list-1',
+        EntityName: 'Contacts',
+        ToAdd: ['a', 'b'],
+        ToRemove: ['c'],
+        Unchanged: ['d', 'e'],
+        DeltaToken: 'abc.def',
+      });
+      expect(output.Counts).toEqual(delta.Counts);
+      expect(output.Warnings[0]).toMatchObject({
+        Code: 'WILL_REMOVE_RECORDS',
+        Message: '1 record will be removed',
+      });
+      const parsed = JSON.parse(output.Warnings[0].DetailsJSON!);
+      expect(parsed).toEqual({ Count: 1 });
+    });
+  });
+
+  describe('fromCoreWarning', () => {
+    it('leaves DetailsJSON undefined when no details supplied', () => {
+      const output = fromCoreWarning({ Code: 'EMPTY_SOURCE', Message: 'No records' });
+      expect(output.DetailsJSON).toBeUndefined();
+    });
+  });
+
+  describe('fromCoreApplyResult', () => {
+    it('flattens Counts into AddedCount / RemovedCount / FailedCount', () => {
+      const result: ApplyResult = {
+        Success: true,
+        ResultCode: 'SUCCESS',
+        Message: 'OK',
+        TargetListId: 'list-1',
+        CreatedListId: 'list-1',
+        Counts: { Added: 5, Removed: 2, Failed: 0 },
+      };
+      const output = fromCoreApplyResult(result);
+      expect(output).toMatchObject({
+        Success: true,
+        ResultCode: 'SUCCESS',
+        AddedCount: 5,
+        RemovedCount: 2,
+        FailedCount: 0,
+        CreatedListId: 'list-1',
+        TargetListId: 'list-1',
+      });
+    });
+
+    it('preserves Errors array when present', () => {
+      const result: ApplyResult = {
+        Success: false,
+        ResultCode: 'PARTIAL_SUCCESS',
+        Message: 'partial',
+        Errors: ['failed record a'],
+      };
+      expect(fromCoreApplyResult(result).Errors).toEqual(['failed record a']);
+    });
+  });
+
+  describe('rebuildDeltaFromInput', () => {
+    it('reconstructs a core ListDelta from a flat ApplyDeltaInput', () => {
+      const input = Object.assign(new ApplyDeltaInput(), {
+        TargetListId: 'list-1',
+        EntityName: 'Contacts',
+        ToAdd: ['a'],
+        ToRemove: ['b'],
+        Unchanged: ['c'],
+        AddCount: 1,
+        RemoveCount: 1,
+        UnchangedCount: 1,
+        SourceTotal: 2,
+        TargetTotal: 2,
+        DeltaToken: 'tok',
+        ConfirmDrops: true,
+      });
+      const out = rebuildDeltaFromInput(input);
+      expect(out).toMatchObject({
+        TargetListId: 'list-1',
+        EntityName: 'Contacts',
+        ToAdd: ['a'],
+        ToRemove: ['b'],
+        Unchanged: ['c'],
+        DeltaToken: 'tok',
+      });
+      expect(out.Counts).toEqual({ Add: 1, Remove: 1, Unchanged: 1, SourceTotal: 2, TargetTotal: 2 });
+      // Warnings are dropped on rebuild (they don't survive the wire round-trip in either direction)
+      expect(out.Warnings).toEqual([]);
+    });
+  });
+});