@memberjunction/react-runtime 2.95.0 → 2.96.0

package/src/utilities/core-libraries.ts

@@ -1,61 +1,75 @@
 import { ExternalLibraryConfig } from '../types/library-config';
 
 /**
- * Core runtime libraries required for the React runtime to function.
- * These are not plugin libraries and are always loaded.
+ * Get the React CDN URL based on debug mode
  */
-export const CORE_RUNTIME_LIBRARIES: ExternalLibraryConfig[] = [
-  {
-    id: 'react',
-    name: 'react',
-    displayName: 'React',
-    category: 'runtime',
-    globalVariable: 'React',
-    version: '18.2.0',
-    cdnUrl: 'https://unpkg.com/react@18.2.0/umd/react.production.min.js',
-    description: 'React core library',
-    isEnabled: true,
-    isCore: true,
-    isRuntimeOnly: true
-  },
-  {
-    id: 'react-dom',
-    name: 'react-dom',
-    displayName: 'ReactDOM',
-    category: 'runtime',
-    globalVariable: 'ReactDOM',
-    version: '18.2.0',
-    cdnUrl: 'https://unpkg.com/react-dom@18.2.0/umd/react-dom.production.min.js',
-    description: 'React DOM library',
-    isEnabled: true,
-    isCore: true,
-    isRuntimeOnly: true
-  },
-  {
-    id: 'babel-standalone',
-    name: '@babel/standalone',
-    displayName: 'Babel Standalone',
-    category: 'runtime',
-    globalVariable: 'Babel',
-    version: '7.24.4',
-    cdnUrl: 'https://unpkg.com/@babel/standalone@7.24.4/babel.min.js',
-    description: 'Babel compiler for JSX transformation',
-    isEnabled: true,
-    isCore: true,
-    isRuntimeOnly: true
-  }
-];
+function getReactUrl(debug: boolean = false): string {
+  return debug 
+    ? 'https://unpkg.com/react@18.2.0/umd/react.development.js'
+    : 'https://unpkg.com/react@18.2.0/umd/react.production.min.js';
+}
+
+/**
+ * Get the ReactDOM CDN URL based on debug mode
+ */
+function getReactDOMUrl(debug: boolean = false): string {
+  return debug
+    ? 'https://unpkg.com/react-dom@18.2.0/umd/react-dom.development.js'
+    : 'https://unpkg.com/react-dom@18.2.0/umd/react-dom.production.min.js';
+}
 
 /**
  * Get the core runtime libraries configuration
+ * @param debug Whether to use development builds for better error messages
  */
-export function getCoreRuntimeLibraries(): ExternalLibraryConfig[] {
-  return CORE_RUNTIME_LIBRARIES;
+export function getCoreRuntimeLibraries(debug: boolean = false): ExternalLibraryConfig[] {
+  return [
+    {
+      id: 'react',
+      name: 'react',
+      displayName: 'React',
+      category: 'runtime',
+      globalVariable: 'React',
+      version: '18.2.0',
+      cdnUrl: getReactUrl(debug),
+      description: 'React core library',
+      isEnabled: true,
+      isCore: true,
+      isRuntimeOnly: true
+    },
+    {
+      id: 'react-dom',
+      name: 'react-dom',
+      displayName: 'ReactDOM',
+      category: 'runtime',
+      globalVariable: 'ReactDOM',
+      version: '18.2.0',
+      cdnUrl: getReactDOMUrl(debug),
+      description: 'React DOM library',
+      isEnabled: true,
+      isCore: true,
+      isRuntimeOnly: true
+    },
+    {
+      id: 'babel-standalone',
+      name: '@babel/standalone',
+      displayName: 'Babel Standalone',
+      category: 'runtime',
+      globalVariable: 'Babel',
+      version: '7.24.4',
+      cdnUrl: 'https://unpkg.com/@babel/standalone@7.24.4/babel.min.js',
+      description: 'Babel compiler for JSX transformation',
+      isEnabled: true,
+      isCore: true,
+      isRuntimeOnly: true
+    }
+  ];
 }
 
 /**
  * Check if a library ID is a core runtime library
  */
 export function isCoreRuntimeLibrary(libraryId: string): boolean {
-  return CORE_RUNTIME_LIBRARIES.some(lib => lib.id === libraryId);
+  const coreLibraries = getCoreRuntimeLibraries();
+  return coreLibraries.some((lib: ExternalLibraryConfig) => lib.id === libraryId);
 }

package/src/utilities/library-dependency-resolver.ts

@@ -420,15 +420,33 @@ export class LibraryDependencyResolver {
     const errors: string[] = [];
     const warnings: string[] = [];
 
+    // Filter out null, undefined, and non-string values from requestedLibs
+    const validRequestedLibs = requestedLibs.filter(lib => {
+      if (!lib || typeof lib !== 'string') {
+        const warning = `Invalid library name: ${lib} (type: ${typeof lib})`;
+        warnings.push(warning);
+        if (this.debug || options?.debug) {
+          console.warn(`⚠️ ${warning}`);
+        }
+        return false;
+      }
+      return true;
+    });
+
     if (this.debug || options?.debug) {
       console.log('🔍 Getting load order for requested libraries:');
-      console.log('  📝 Requested:', requestedLibs);
+      console.log('  📝 Requested (raw):', requestedLibs);
+      console.log('  📝 Requested (valid):', validRequestedLibs);
       console.log('  📚 Total available libraries:', allLibs.length);
     }
 
     // Build a map for quick lookup (case-insensitive)
     const libMap = new Map<string, ComponentLibraryEntity[]>();
     for (const lib of allLibs) {
+      if (!lib?.Name) {
+        warnings.push(`Library with missing name found in available libraries`);
+        continue;
+      }
       const key = lib.Name.toLowerCase();
       if (!libMap.has(key)) {
         libMap.set(key, []);
@@ -438,7 +456,7 @@ export class LibraryDependencyResolver {
 
     // Collect all libraries needed (requested + their dependencies)
     const needed = new Set<string>();
-    const toProcess = [...requestedLibs];
+    const toProcess = [...validRequestedLibs];
     const processed = new Set<string>();
     const versionRequirements = new Map<string, VersionRequirement[]>();
     let depth = 0;
@@ -446,6 +464,17 @@ export class LibraryDependencyResolver {
 
     while (toProcess.length > 0 && depth < maxDepth) {
       const current = toProcess.shift()!;
+      
+      // Extra safety check for null/undefined
+      if (!current || typeof current !== 'string') {
+        const warning = `Unexpected invalid library name during processing: ${current}`;
+        warnings.push(warning);
+        if (this.debug || options?.debug) {
+          console.warn(`⚠️ ${warning}`);
+        }
+        continue;
+      }
+      
       if (processed.has(current)) continue;
 
       processed.add(current);

package/src/utilities/library-loader.ts

@@ -65,10 +65,12 @@ export class LibraryLoader {
    * This is the main method that should be used by test harness and Angular wrapper
    * @param config Optional full library configuration to replace the default
    * @param additionalLibraries Optional additional libraries to merge with the configuration
+   * @param options Optional options including debug mode flag
    */
   static async loadAllLibraries(
     config?: LibraryConfiguration, 
-    additionalLibraries?: ExternalLibraryConfig[]
+    additionalLibraries?: ExternalLibraryConfig[],
+    options?: { debug?: boolean }
   ): Promise<LibraryLoadResult> {
     if (config) {
       StandardLibraryManager.setConfiguration(config);
@@ -87,15 +89,15 @@ export class LibraryLoader {
       StandardLibraryManager.setConfiguration(mergedConfig);
     }
     
-    return this.loadLibrariesFromConfig();
+    return this.loadLibrariesFromConfig(undefined, options?.debug);
   }
 
   /**
    * Load libraries based on the current configuration
    */
-  static async loadLibrariesFromConfig(options?: ConfigLoadOptions): Promise<LibraryLoadResult> {
+  static async loadLibrariesFromConfig(options?: ConfigLoadOptions, debug?: boolean): Promise<LibraryLoadResult> {
     // Always load core runtime libraries first
-    const coreLibraries = getCoreRuntimeLibraries();
+    const coreLibraries = getCoreRuntimeLibraries(debug);
     const corePromises = coreLibraries.map(lib => 
       this.loadScript(lib.cdnUrl, lib.globalVariable)
     );