@memberjunction/ng-explorer-core 5.22.0 → 5.24.0

package/dist/lib/shell/components/tabs/tab-container.component.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"tab-container.component.d.ts","sourceRoot":"","sources":["../../../../../src/lib/shell/components/tabs/tab-container.component.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,MAAM,EACN,SAAS,EACT,aAAa,EAEb,UAAU,EACV,cAAc,EACd,mBAAmB,EAInB,iBAAiB,EAGjB,YAAY,EAEb,MAAM,eAAe,CAAC;AAEvB,OAAO,EACL,mBAAmB,EACnB,qBAAqB,EACrB,kBAAkB,EAKnB,MAAM,qCAAqC,CAAC;;AAQ7C;;;;;;;;;GASG;AACH,qBAOa,qBAAsB,YAAW,MAAM,EAAE,SAAS,EAAE,aAAa;IAkD1E,OAAO,CAAC,aAAa;IACrB,OAAO,CAAC,gBAAgB;IACxB,OAAO,CAAC,UAAU;IAClB,OAAO,CAAC,MAAM;IACd,OAAO,CAAC,mBAAmB;IAC3B,OAAO,CAAC,GAAG;IAtDgC,WAAW,EAAG,UAAU,CAAC,cAAc,CAAC,CAAC;IAC9B,sBAAsB,EAAG,UAAU,CAAC,cAAc,CAAC,CAAC;IAE5G;;;;OAIG;IACO,yBAAyB,qBAA4B;IAE/D;;;OAGG;IACO,eAAe,qBAA4B;IAErD,OAAO,CAAC,UAAU,CAA6B;IAC/C,OAAO,CAAC,aAAa,CAAsB;IAC3C,OAAO,CAAC,oBAAoB,CAAK;IACjC,OAAO,CAAC,QAAQ,CAAC,uBAAuB,CAAK;IAC7C,OAAO,CAAC,iBAAiB,CAAS;IAClC,OAAO,CAAC,yBAAyB,CAAS;IAG1C,OAAO,CAAC,aAAa,CAA0D;IAK/E,OAAO,CAAC,oBAAoB,CAAqB;IAGjD,OAAO,CAAC,YAAY,CAAwB;IAI5C,qBAAqB,UAAS;IAC9B,OAAO,CAAC,0BAA0B,CAAoD;IACtF,OAAO,CAAC,qBAAqB,CAAwB;IACrD,OAAO,CAAC,8BAA8B,CAAuB;IAC7D,OAAO,CAAC,qBAAqB,CAAS;IAGtC,kBAAkB,UAAS;IAC3B,YAAY,SAAK;IACjB,YAAY,SAAK;IACjB,gBAAgB,EAAE,MAAM,GAAG,IAAI,CAAQ;gBAG7B,aAAa,EAAE,mBAAmB,EAClC,gBAAgB,EAAE,qBAAqB,EACvC,UAAU,EAAE,kBAAkB,EAC9B,MAAM,EAAE,cAAc,EACtB,mBAAmB,EAAE,mBAAmB,EACxC,GAAG,EAAE,iBAAiB;IAMhC,QAAQ,IAAI,IAAI;IA2DhB,eAAe,IAAI,IAAI;IAUvB;;;OAGG;IACH,OAAO,CAAC,sBAAsB;IAmH9B,WAAW,IAAI,IAAI;IAiBnB;;;;OAIG;IAEH,cAAc,IAAI,IAAI;IAMtB;;OAEG;IACH,OAAO,CAAC,4BAA4B;IAyEpC;;OAEG;YACW,yBAAyB;IAuHvC;;OAEG;IACH,OAAO,CAAC,8BAA8B;IActC;;;OAGG;IACH,OAAO,CAAC,sBAAsB;IAgB9B;;OAEG;IACH,OAAO,CAAC,SAAS;IAoBjB;;OAEG;YACW,UAAU;IAQxB;;;OAGG;YACW,cAAc;IA4I5B;;;OAGG;YACW,oBAAoB;IAyClC;;OAEG;YACW,0BAA0B;IAwBxC;;OAEG;YACW,sBAAsB;IA2DpC,OAAO,CAAC,MAAM,CAAC,qBAAqB,CAAkC;IAEtE;;OAEG;YACW,qBAAqB;YA8BrB,iBAAiB;IAQ/B;;OAEG;IACH,OAAO,CAAC,wBAAwB;IAgChC;;;OAGG;IACH,OAAO,CAAC,qBAAqB;IAkB7B;;;OAGG;IACH,OAAO,CAAC,mBAAmB;IAkB3B;;OAEG;IACH,OAAO,CAAC,yBAAyB;IA8EjC;;OAEG;IACH,eAAe,CAAC,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,IAAI;IA8B1D;;OAEG;IACH,eAAe,IAAI,IAAI;IAKvB;;OAEG;IACH,IAAI,kBAAkB,IAAI,OAAO,CAIhC;IAED;;OAEG;IACH,YAAY,IAAI,IAAI;IAOpB;;OAEG;IACH,cAAc,IAAI,IAAI;IAOtB;;OAEG;IACH,oBAAoB,IAAI,IAAI;IAO5B;;OAEG;IACH,qBAAqB,IAAI,IAAI;IAO7B;;OAEG;IACH,IAAI,wBAAwB,IAAI,OAAO,CAMtC;IAED;;OAEG;IACG,kBAAkB,IAAI,OAAO,CAAC,IAAI,CAAC;IAsDzC;;OAEG;IACH,OAAO,CAAC,mBAAmB;IAY3B;;OAEG;YACW,0BAA0B;IA2BxC;;;OAGG;IACU,sBAAsB,IAAI,OAAO,CAAC,MAAM,GAAG,SAAS,CAAC;IAiBlE;;;;OAIG;IACH,OAAO,CAAC,yBAAyB;yCAzuCtB,qBAAqB;2CAArB,qBAAqB;CA4uCjC"}
+{"version":3,"file":"tab-container.component.d.ts","sourceRoot":"","sources":["../../../../../src/lib/shell/components/tabs/tab-container.component.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,MAAM,EACN,SAAS,EACT,aAAa,EAEb,UAAU,EACV,cAAc,EACd,mBAAmB,EAInB,iBAAiB,EAGjB,YAAY,EAEb,MAAM,eAAe,CAAC;AAEvB,OAAO,EACL,mBAAmB,EACnB,qBAAqB,EACrB,kBAAkB,EAKnB,MAAM,qCAAqC,CAAC;;AAQ7C;;;;;;;;;GASG;AACH,qBAOa,qBAAsB,YAAW,MAAM,EAAE,SAAS,EAAE,aAAa;IAoD1E,OAAO,CAAC,aAAa;IACrB,OAAO,CAAC,gBAAgB;IACxB,OAAO,CAAC,UAAU;IAClB,OAAO,CAAC,MAAM;IACd,OAAO,CAAC,mBAAmB;IAC3B,OAAO,CAAC,GAAG;IAxDgC,WAAW,EAAG,UAAU,CAAC,cAAc,CAAC,CAAC;IAC9B,sBAAsB,EAAG,UAAU,CAAC,cAAc,CAAC,CAAC;IAE5G;;;;OAIG;IACO,yBAAyB,qBAA4B;IAE/D;;;OAGG;IACO,eAAe,qBAA4B;IAErD,OAAO,CAAC,UAAU,CAA6B;IAC/C,OAAO,CAAC,aAAa,CAAsB;IAC3C,OAAO,CAAC,oBAAoB,CAAK;IACjC,OAAO,CAAC,QAAQ,CAAC,uBAAuB,CAAK;IAC7C,OAAO,CAAC,iBAAiB,CAAS;IAClC,OAAO,CAAC,yBAAyB,CAAS;IAG1C,OAAO,CAAC,aAAa,CAA0D;IAK/E,OAAO,CAAC,oBAAoB,CAAqB;IAGjD,OAAO,CAAC,YAAY,CAAwB;IAI5C,qBAAqB,UAAS;IAC9B,OAAO,CAAC,0BAA0B,CAAoD;IACtF,6EAA6E;IAC7E,OAAO,CAAC,2BAA2B,CAAwF;IAC3H,OAAO,CAAC,qBAAqB,CAAwB;IACrD,OAAO,CAAC,8BAA8B,CAAuB;IAC7D,OAAO,CAAC,qBAAqB,CAAS;IAGtC,kBAAkB,UAAS;IAC3B,YAAY,SAAK;IACjB,YAAY,SAAK;IACjB,gBAAgB,EAAE,MAAM,GAAG,IAAI,CAAQ;gBAG7B,aAAa,EAAE,mBAAmB,EAClC,gBAAgB,EAAE,qBAAqB,EACvC,UAAU,EAAE,kBAAkB,EAC9B,MAAM,EAAE,cAAc,EACtB,mBAAmB,EAAE,mBAAmB,EACxC,GAAG,EAAE,iBAAiB;IAMhC,QAAQ,IAAI,IAAI;IAmEhB,eAAe,IAAI,IAAI;IAUvB;;;OAGG;IACH,OAAO,CAAC,sBAAsB;IAmH9B,WAAW,IAAI,IAAI;IAiBnB;;;;OAIG;IAEH,cAAc,IAAI,IAAI;IAMtB;;OAEG;IACH,OAAO,CAAC,4BAA4B;IA2EpC;;OAEG;YACW,yBAAyB;IAuJvC;;OAEG;IACH;;;;;;;;;;;;;;;;;;;;;;;;OAwBG;IACH;;;;OAIG;IACH,OAAO,CAAC,+BAA+B;IAYvC,OAAO,CAAC,8BAA8B;IAsBtC;;;OAGG;IACH,OAAO,CAAC,sBAAsB;IAgB9B;;OAEG;IACH,OAAO,CAAC,SAAS;IAoBjB;;OAEG;YACW,UAAU;IAQxB;;;OAGG;YACW,cAAc;IA4I5B;;;OAGG;YACW,oBAAoB;IAyClC;;OAEG;YACW,0BAA0B;IAwBxC;;OAEG;YACW,sBAAsB;IA2DpC,OAAO,CAAC,MAAM,CAAC,qBAAqB,CAAkC;IAEtE;;OAEG;YACW,qBAAqB;YA8BrB,iBAAiB;IAQ/B;;OAEG;IACH,OAAO,CAAC,wBAAwB;IAgChC;;;OAGG;IACH,OAAO,CAAC,qBAAqB;IAkB7B;;;OAGG;IACH,OAAO,CAAC,mBAAmB;IAkB3B;;OAEG;IACH,OAAO,CAAC,yBAAyB;IA8EjC;;OAEG;IACH,eAAe,CAAC,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,IAAI;IA8B1D;;OAEG;IACH,eAAe,IAAI,IAAI;IAKvB;;OAEG;IACH,IAAI,kBAAkB,IAAI,OAAO,CAIhC;IAED;;OAEG;IACH,YAAY,IAAI,IAAI;IAOpB;;OAEG;IACH,cAAc,IAAI,IAAI;IAOtB;;OAEG;IACH,oBAAoB,IAAI,IAAI;IAO5B;;OAEG;IACH,qBAAqB,IAAI,IAAI;IAO7B;;OAEG;IACH,IAAI,wBAAwB,IAAI,OAAO,CAMtC;IAED;;OAEG;IACG,kBAAkB,IAAI,OAAO,CAAC,IAAI,CAAC;IAsDzC;;OAEG;IACH,OAAO,CAAC,mBAAmB;IAY3B;;OAEG;YACW,0BAA0B;IA2BxC;;;OAGG;IACU,sBAAsB,IAAI,OAAO,CAAC,MAAM,GAAG,SAAS,CAAC;IAiBlE;;;;OAIG;IACH,OAAO,CAAC,yBAAyB;yCAv0CtB,qBAAqB;2CAArB,qBAAqB;CA00CjC"}

package/dist/lib/shell/components/tabs/tab-container.component.js

@@ -119,6 +119,8 @@ export class TabContainerComponent {
     // This avoids the 20px height issue when GL header is hidden
     useSingleResourceMode = false;
     singleResourceComponentRef = null;
+    /** Cache identity of the current single-resource component for detachment */
+    singleResourceCacheIdentity = null;
     previousTabBarVisible = null;
     currentSingleResourceSignature = null; // Track loaded content signature to avoid unnecessary reloads
     isCreatingInitialTabs = false; // Flag to prevent syncTabsWithConfiguration during initial tab creation
@@ -166,8 +168,17 @@ export class TabContainerComponent {
                     if (activeTab) {
                         const signature = this.getTabContentSignature(activeTab);
                         if (signature !== this.currentSingleResourceSignature) {
+                            // DO NOT call saveCurrentComponentQueryParams() here — by the time this
+                            // subscription fires, OpenTab has already replaced the tab config with the
+                            // new nav item's config, so queryParams are gone. The cache entry already
+                            // has the correct queryParams from the most recent unchanged-signature save.
                             this.loadSingleResourceContent();
                         }
+                        else {
+                            // Signature unchanged — sync queryParams to cache entry so it stays current.
+                            // This catches incremental queryParam updates (e.g., user selects a conversation).
+                            this.saveCurrentComponentQueryParams();
+                        }
                     }
                 }
                 else if (this.layoutRestorationComplete && !this.isCreatingInitialTabs) {
@@ -331,7 +342,9 @@ export class TabContainerComponent {
         const shouldUseSingleResourceMode = !tabBarVisible;
         if (shouldUseSingleResourceMode !== this.useSingleResourceMode) {
             this.useSingleResourceMode = shouldUseSingleResourceMode;
-            this.cdr.detectChanges();
+            // Defer detectChanges to next microtask to avoid ExpressionChangedAfterItHasBeenCheckedError
+            // when this handler fires during an already-running change detection cycle.
+            Promise.resolve().then(() => this.cdr.detectChanges());
             if (this.useSingleResourceMode) {
                 // Transitioning to single-resource mode
                 // **CRITICAL FIX**: Wait for the template to render directContentContainer
@@ -412,7 +425,6 @@ export class TabContainerComponent {
         // Get the container element
         const container = this.directContentContainer?.nativeElement;
         if (!container) {
-            console.warn('Direct content container not available yet, retrying...');
             // Retry after view is updated
             setTimeout(() => this.loadSingleResourceContent(), 50);
             return;
@@ -430,13 +442,26 @@ export class TabContainerComponent {
         if (cached) {
             // Clean up previous single-resource component (if different)
             this.cleanupSingleResourceComponent();
-            // Detach from tab tracking (it was attached to a tab in Golden Layout)
-            this.cacheManager.markAsDetached(activeTab.id);
+            // Mark cached component as attached to this tab (it was detached / available for reuse).
+            // IMPORTANT: We use markAsAttached here, NOT markAsDetached — the component is being
+            // reattached to the DOM and should NOT be eligible for LRU eviction.
+            this.cacheManager.markAsAttached(driverClass, resourceData.ResourceRecordID || '', activeTab.applicationId, activeTab.id);
             // Reattach the cached wrapper element to single-resource container
             cached.wrapperElement.style.height = "100%"; // Ensure full height
             container.appendChild(cached.wrapperElement);
-            // Store reference for cleanup
+            // Store reference and identity for cleanup/detachment
             this.singleResourceComponentRef = cached.componentRef;
+            this.singleResourceCacheIdentity = { driverClass, recordId: resourceData.ResourceRecordID || '', appId: activeTab.applicationId, tabId: activeTab.id };
+            // Restore saved queryParams to the tab config so the URL reflects
+            // the component's preserved state (e.g., selected conversation, collection drill-down).
+            if (cached.savedQueryParams) {
+                this.workspaceManager.UpdateTabConfiguration(activeTab.id, {
+                    queryParams: cached.savedQueryParams
+                });
+                // Do NOT clear savedQueryParams here — the else branch (unchanged-signature saves)
+                // will keep it current while the component is active. Clearing it would cause the
+                // queryParams to be lost on the next detach/reattach cycle.
+            }
             return;
         }
         // Get the component registration (with lazy loading fallback via ClassFactory)
@@ -460,13 +485,16 @@ export class TabContainerComponent {
         instance.LoadCompleteEvent = () => {
             this.emitFirstLoadCompleteOnce();
         };
-        // Wire up display name change for single-resource mode
-        // Use a closure that resolves the tab ID at call time, not at wire-up time,
-        // because the tab may not be active yet when the component is first created.
+        // Wire up display name change for single-resource mode.
+        // Guard: only update the title if THIS component is the currently displayed one.
+        // Without this guard, cached components (detached but alive) can fire this callback
+        // and overwrite the active tab's title with a stale name.
         instance.DisplayNameChangedEvent = (newName) => {
-            const tabId = this.workspaceManager.GetActiveTabId();
-            if (tabId) {
-                this.workspaceManager.UpdateTabTitle(tabId, newName);
+            if (this.singleResourceComponentRef?.instance === instance) {
+                const tabId = this.workspaceManager.GetActiveTabId();
+                if (tabId) {
+                    this.workspaceManager.UpdateTabTitle(tabId, newName);
+                }
             }
         };
         // Get the native element and append to container
@@ -476,22 +504,76 @@ export class TabContainerComponent {
         if (container.children?.length > 0) {
             container.children[0].style.height = "100%";
         }
-        // Store reference for cleanup
+        // Cache the component for reuse when switching between nav items within the same app.
+        // Without this, every nav switch creates a brand new component from scratch.
+        const wrapperElement = nativeElement;
+        this.cacheManager.cacheComponent(componentRef, wrapperElement, resourceData, activeTab.id);
+        // Store reference and identity for cleanup/detachment
         this.singleResourceComponentRef = componentRef;
+        this.singleResourceCacheIdentity = { driverClass, recordId: resourceData.ResourceRecordID || '', appId: activeTab.applicationId, tabId: activeTab.id };
     }
     /**
      * Clean up single-resource mode component
      */
+    /**
+     * Detaches the current single-resource component from the DOM and marks it as
+     * available for reuse in the component cache.
+     *
+     * ╔══════════════════════════════════════════════════════════════════════════╗
+     * ║  ⚠️  DO NOT DESTROY THE COMPONENT HERE — INTENTIONAL DESIGN CHOICE  ⚠️  ║
+     * ║                                                                        ║
+     * ║  The component is DETACHED from the DOM, NOT destroyed. It stays alive ║
+     * ║  in the ComponentCacheManager with its full Angular state preserved     ║
+     * ║  (properties, subscriptions, loaded data, scroll position, etc).       ║
+     * ║                                                                        ║
+     * ║  When the user returns to this tab, the cached component is reattached ║
+     * ║  instantly — no data reload, no API calls, no flash of empty content.  ║
+     * ║                                                                        ║
+     * ║  Destroying components here "for memory optimization" is a net         ║
+     * ║  NEGATIVE: the reload on return is far more expensive (DB queries,     ║
+     * ║  API calls, re-rendering) than keeping the component in memory.        ║
+     * ║  The LRU eviction in ComponentCacheManager handles memory limits —     ║
+     * ║  when MaxDetachedComponents is exceeded, the LEAST recently used       ║
+     * ║  components are evicted automatically.                                 ║
+     * ║                                                                        ║
+     * ║  If you think memory is a problem, adjust MaxDetachedComponents        ║
+     * ║  instead of destroying components here.                                ║
+     * ╚══════════════════════════════════════════════════════════════════════════╝
+     */
+    /**
+     * Save the currently displayed component's queryParams to its cache entry.
+     * Called on every config change so the cache entry always has the latest queryParams,
+     * even after the tab config is overwritten by a new nav item.
+     */
+    saveCurrentComponentQueryParams() {
+        if (!this.singleResourceCacheIdentity)
+            return;
+        const { tabId } = this.singleResourceCacheIdentity;
+        const tab = this.workspaceManager.GetTab(tabId);
+        const qp = tab?.configuration?.['queryParams'];
+        const cached = this.cacheManager.getComponentByTabId(tabId);
+        if (cached) {
+            cached.savedQueryParams = (qp && Object.keys(qp).length > 0) ? { ...qp } : undefined;
+        }
+    }
     cleanupSingleResourceComponent() {
         if (this.singleResourceComponentRef) {
-            this.appRef.detachView(this.singleResourceComponentRef.hostView);
-            this.singleResourceComponentRef.destroy();
+            if (this.singleResourceCacheIdentity) {
+                const { driverClass, recordId, appId } = this.singleResourceCacheIdentity;
+                // Mark as DETACHED by resource identity — the ONE consistent key used everywhere.
+                this.cacheManager.markAsDetached(driverClass, recordId, appId);
+            }
             this.singleResourceComponentRef = null;
+            this.singleResourceCacheIdentity = null;
         }
-        // Clear the container
+        // Remove children from the container. This detaches the wrapper DOM element
+        // without destroying the Angular component — it lives on in the cache.
+        // Using removeChild (not innerHTML='') to avoid aggressive DOM cleanup.
         const container = this.directContentContainer?.nativeElement;
         if (container) {
-            container.innerHTML = '';
+            while (container.firstChild) {
+                container.removeChild(container.firstChild);
+            }
         }
     }
     /**
@@ -842,7 +924,7 @@ export class TabContainerComponent {
      */
     cleanupTabComponent(tabId) {
         // First, try to detach from cache (preserves component for reuse)
-        const cachedInfo = this.cacheManager.markAsDetached(tabId);
+        const cachedInfo = this.cacheManager.findAndDetachByTabId(tabId);
         if (cachedInfo) {
             // Remove from legacy componentRefs but keep in cache
             this.componentRefs.delete(tabId);