@memberjunction/ng-conversations 6.2.0-edge.5 → 6.2.0-edge.6

package/dist/lib/components/conversation/conversation-chat-area.component.js

@@ -22,6 +22,8 @@ import { RealtimeSessionReviewService } from '../../services/realtime-session-re
 import { GenerateAndApplyConversationName, GenerateAndApplyForkName, SaveForkName } from '../../services/conversation-naming';
 import { CollectRealtimeSessionIDs, MapRealtimeSessionMeta, REALTIME_SESSION_META_FIELDS } from '../../utils/realtime-session-timeline';
 import { ResolveDateJumpTarget, CombineDateJumpOutcome, DescribeDateJumpOutcome, DATE_JUMP_MAX_PAGES } from '../../utils/date-jump';
+import { CompareMessagesByCreatedAt, UpsertMessageById } from '../../utils/message-list-order';
+import { SavePinState } from '../../utils/pin-state';
 import { InjectFrameZone } from '../../util/frame-zone';
 import { MessageListComponent } from '../message/message-list.component';
 import { IsForkPointOrEarlier } from '../../utils/conversation-branching';
@@ -31,6 +33,7 @@ import { NormalizeUUID, UUIDsEqual, UUIDSet, IndexByUUID, IsValidUUID } from '@m
 // PR 2c — Widget extension surface
 import { ChatSlotDirective } from '../../directives/chat-slot.directive';
 import { ConversationCallStartOptions } from '../realtime/capture/realtime-capture-channel';
+import { DescribeCallFailureNotice } from '../realtime/realtime-call-failure-notice';
 import { BeforeToolInvokedEventArgs, AfterToolInvokedEventArgs, BeforeStopClickedEventArgs, AfterStopClickedEventArgs, SessionStartedEventArgs, SessionChannelStateChangedEventArgs, SessionEndedEventArgs, } from '../../events/chat-events';
 import * as i0 from "@angular/core";
 import * as i1 from "../../services/agent-state.service";
@@ -2803,6 +2806,8 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
         this.syncSendSlot();
     }
     _inProgressMessageIds = [];
+    /** Tracks the ID each in-progress reply entity was last registered under so adopting the server's row ID drops the local placeholder UUID. */
+    inProgressIdByEntity;
     // ── The composer's send slot as the stop control ──────────────────────────────────────
     // While replies are in flight the composer's send slot is the stop control (one run: "Stop
     // {agent}"; several: "Stop all N", and each reply shows its own pill as well). The slot's mode,
@@ -3631,6 +3636,16 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
             namedThisSession = false;
             this.onRealtimeSessionStarted();
         });
+        // A call that ends over a failure (a failed start, a dropped connection, a time limit) is ended by the
+        // runtime itself, which closes the call surface with it: say why, or the call just vanishes.
+        this.RealtimeSession.SessionEnded$
+            .pipe(takeUntil(this.destroy$))
+            .subscribe((ended) => {
+            if (ended.reason === 'error') {
+                const notice = DescribeCallFailureNotice(this.RealtimeSession.LastStartError, this.RealtimeSession.LastSessionError);
+                MJNotificationService.Instance.CreateSimpleNotification(notice, 'error', 6000);
+            }
+        });
         let voiceWasActive = false;
         this.RealtimeSession.Active$
             .pipe(takeUntil(this.destroy$))
@@ -4112,13 +4127,27 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
             this.conversationLoadEnded$?.next();
         }
     }
+    _cachedInputsArray = [];
+    _cachedInputsKey = '';
     /**
-     * Returns array of cached message-input metadata for rendering
+     * Returns array of cached message-input metadata for rendering.
      * This allows multiple message-input components to exist simultaneously (hidden)
-     * preserving their state when switching conversations
+     * preserving their state when switching conversations.
+     * Memoized on cache contents so template `@for` loops receive a stable array reference across CD ticks.
      */
     GetCachedInputs() {
-        return Array.from(this.messageInputMetadataCache.values());
+        if (this.messageInputMetadataCache.size === 0) {
+            return this._cachedInputsArray.length === 0 ? this._cachedInputsArray : (this._cachedInputsArray = []);
+        }
+        let key = '';
+        for (const [id, meta] of this.messageInputMetadataCache.entries()) {
+            key += `${id}:${meta.conversationName ?? ''}|`;
+        }
+        if (key !== this._cachedInputsKey) {
+            this._cachedInputsKey = key;
+            this._cachedInputsArray = Array.from(this.messageInputMetadataCache.values());
+        }
+        return this._cachedInputsArray;
     }
     /** @deprecated Use {@link GetCachedInputs}. */
     getCachedInputs() {
@@ -4655,18 +4684,11 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
         this.windowStore.ApplyLocalDetail(message);
         // Check if message already exists in the array (by ID) to prevent duplicates
         // Messages can be emitted multiple times as they're updated (e.g., status changes)
-        const existingIndex = this.messages.findIndex(m => UUIDsEqual(m.ID, message.ID));
-        if (existingIndex >= 0) {
-            // Update existing message in place (replace with updated version)
-            this.messages = [
-                ...this.messages.slice(0, existingIndex),
-                message,
-                ...this.messages.slice(existingIndex + 1)
-            ];
-        }
-        else {
-            // Add new message to the list
-            this.messages = [...this.messages, message];
+        // An agent reply's placeholder takes the server row's ID when the run is acknowledged; a refresh may already have
+        // brought that row in, so other copies of the ID are dropped.
+        const upsert = UpsertMessageById(this.messages, message);
+        this.messages = upsert.Messages;
+        if (!upsert.Existed) {
             // Ensure current user is in the avatar map for new messages
             this.ensureCurrentUserInAvatarMap();
             // Invalidate cache when new message is added.
@@ -4687,8 +4709,17 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
         // row does not stay In-Progress until the conversation is opened again. Register the row
         // for the live callback either way — an update of an existing In-Progress row included.
         if (message.Status === 'In-Progress' && message.ID) {
-            if (!this.InProgressMessageIds.some((id) => UUIDsEqual(id, message.ID))) {
-                this.InProgressMessageIds = [...this.InProgressMessageIds, message.ID];
+            const entityMap = (this.inProgressIdByEntity ??= new WeakMap());
+            const previousId = entityMap.get(message);
+            entityMap.set(message, message.ID);
+            const withoutPrevious = previousId && !UUIDsEqual(previousId, message.ID)
+                ? this.InProgressMessageIds.filter((id) => !UUIDsEqual(id, previousId))
+                : this.InProgressMessageIds;
+            if (!withoutPrevious.some((id) => UUIDsEqual(id, message.ID))) {
+                this.InProgressMessageIds = [...withoutPrevious, message.ID];
+            }
+            else if (withoutPrevious !== this.InProgressMessageIds) {
+                this.InProgressMessageIds = withoutPrevious;
             }
             const recentCompletion = this.streamingService.GetRecentCompletion(message.ID);
             if (recentCompletion) {
@@ -4700,7 +4731,7 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
         }
         // Where the viewport goes: a fresh send follows — an in-place update of a message that
         // is already on screen must not re-run the send path's scroll.
-        this.followTranscript(existingIndex >= 0 ? 'update' : 'new', message);
+        this.followTranscript(upsert.Existed ? 'update' : 'new', message);
         // Force change detection — zone.js 0.15 no longer patches graphql-ws WebSocket callbacks,
         // so progress updates that arrive via PubSub run outside Angular's zone. Without this,
         // the UI does not update when the messages array is modified from a streaming callback.
@@ -4931,8 +4962,7 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
                     merged.set(msg.ID, msg);
                 }
             }
-            this.messages = Array.from(merged.values())
-                .sort((a, b) => (a.__mj_CreatedAt?.getTime() || 0) - (b.__mj_CreatedAt?.getTime() || 0));
+            this.messages = Array.from(merged.values()).sort(CompareMessagesByCreatedAt);
             // Find newly discovered messages (delegated agents)
             const newMessages = engineDetails.filter(m => !existingMessageIds.has(m.ID));
             // Check engine cache for agent runs on new messages
@@ -6680,17 +6710,30 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
     get hasSystemArtifacts() {
         return this.HasSystemArtifacts;
     }
+    _artifactsArrayCache = [];
+    _artifactsArrayKey = '';
     /**
-     * Get unique artifacts grouped by artifact ID (not by conversation detail)
-     * Returns the latest version info for each unique artifact with all versions
-     * Works with LazyArtifactInfo - uses display data without loading full entities
-     * Respects showSystemArtifacts toggle
+     * Get unique artifacts grouped by artifact ID (not by conversation detail).
+     * Returns the latest version info for each unique artifact with all versions.
+     * Works with LazyArtifactInfo - uses display data without loading full entities.
+     * Respects showSystemArtifacts toggle and memoizes the result across CD passes.
      */
     GetArtifactsArray() {
+        const effectiveMap = this.EffectiveArtifactsMap;
+        let sig = `${this.ShowSystemArtifacts ? 1 : 0}|${effectiveMap.size}|`;
+        for (const artifactList of effectiveMap.values()) {
+            for (const info of artifactList) {
+                sig += `${info.artifactVersionId}:${info.artifactName ?? ''};`;
+            }
+        }
+        if (sig === this._artifactsArrayKey) {
+            return this._artifactsArrayCache;
+        }
+        this._artifactsArrayKey = sig;
         const artifactMap = new Map();
         // Group by artifactId, collecting all version details
         // Use effectiveArtifactsMap to respect showSystemArtifacts toggle
-        for (const artifactList of this.EffectiveArtifactsMap.values()) {
+        for (const artifactList of effectiveMap.values()) {
             for (const info of artifactList) {
                 const artifactId = info.artifactId;
                 const versionId = info.artifactVersionId;
@@ -6717,7 +6760,7 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
             }
         }
         // Convert to array with version count, sorted by version number descending
-        return Array.from(artifactMap.values()).map(item => ({
+        this._artifactsArrayCache = Array.from(artifactMap.values()).map(item => ({
             artifactId: item.artifactId,
             versionId: item.versionId,
             name: item.name,
@@ -6725,6 +6768,7 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
             versionCount: item.versions.length,
             versions: item.versions.sort((a, b) => b.versionNumber - a.versionNumber)
         }));
+        return this._artifactsArrayCache;
     }
     /** @deprecated Use {@link GetArtifactsArray}. */
     getArtifactsArray() {
@@ -7111,7 +7155,9 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
         message.IsPinned = false;
         this.cdr.detectChanges();
         try {
-            await message.Save();
+            if (!(await SavePinState(this.ProviderToUse, message.ID, false))) {
+                throw new Error(`the pin on message ${message.ID} could not be saved`);
+            }
             this.OnMessagePinToggled(message);
         }
         catch (err) {
@@ -9698,5 +9744,5 @@ export class ConversationChatAreaComponent extends BaseAngularComponent {
             type: ViewChild,
             args: ['forksButton', { read: ElementRef }]
         }] }); })();
-(() => { (typeof ngDevMode === "undefined" || ngDevMode) && i0.ɵsetClassDebugInfo(ConversationChatAreaComponent, { className: "ConversationChatAreaComponent", filePath: "src/lib/components/conversation/conversation-chat-area.component.ts", lineNumber: 201 }); })();
+(() => { (typeof ngDevMode === "undefined" || ngDevMode) && i0.ɵsetClassDebugInfo(ConversationChatAreaComponent, { className: "ConversationChatAreaComponent", filePath: "src/lib/components/conversation/conversation-chat-area.component.ts", lineNumber: 204 }); })();
 //# sourceMappingURL=conversation-chat-area.component.js.map