@memberjunction/ai-agents 5.4.1 → 5.6.0

package/dist/base-agent.js

@@ -13,7 +13,7 @@
 import { Metadata, RunView, LogStatus, LogStatusEx, LogError, LogErrorEx, IsVerboseLoggingEnabled } from '@memberjunction/core';
 import { AIPromptRunner } from '@memberjunction/ai-prompts';
 import { BaseAgentType } from './agent-types/base-agent-type.js';
-import { CopyScalarsAndArrays, JSONValidator, SafeExpressionEvaluator } from '@memberjunction/global';
+import { CopyScalarsAndArrays, JSONValidator, SafeExpressionEvaluator, UUIDsEqual } from '@memberjunction/global';
 import { AIEngine } from '@memberjunction/aiengine';
 import { ActionEngineServer } from '@memberjunction/actions';
 import { AIAgentPermissionHelper } from '@memberjunction/ai-engine-base';
@@ -1340,7 +1340,7 @@ export class BaseAgent {
             metadataOptional = true;
         }
         // Find the agent type
-        const agentType = engine.AgentTypes.find(at => at.ID === agent.TypeID);
+        const agentType = engine.AgentTypes.find(at => UUIDsEqual(at.ID, agent.TypeID));
         if (!agentType && !metadataOptional) {
             return {
                 success: false,
@@ -1351,13 +1351,13 @@ export class BaseAgent {
         const agentTypeInstance = await BaseAgentType.GetAgentTypeInstance(agentType);
         const requiresAgentLevelPrompts = agentTypeInstance.RequiresAgentLevelPrompts;
         // Find the system prompt (optional for some agent types)
-        const systemPrompt = engine.Prompts.find(p => p.ID === agentType.SystemPromptID);
+        const systemPrompt = engine.Prompts.find(p => UUIDsEqual(p.ID, agentType.SystemPromptID));
         if (!systemPrompt) {
             metadataOptional = true; // If no system prompt, we can skip some validations
         }
         // Find the first active agent prompt (optional for agent types that don't require them)
         const agentPrompt = engine.AgentPrompts
-            .filter(ap => ap.AgentID === agent.ID && ap.Status === 'Active')
+            .filter(ap => UUIDsEqual(ap.AgentID, agent.ID) && ap.Status === 'Active')
             .sort((a, b) => a.ExecutionOrder - b.ExecutionOrder)[0];
         if (!agentPrompt && !metadataOptional && requiresAgentLevelPrompts) {
             return {
@@ -1366,7 +1366,7 @@ export class BaseAgent {
             };
         }
         // Find the actual prompt entity (will be undefined for agent types with only step-level prompts)
-        const childPrompt = agentPrompt ? engine.Prompts.find(p => p.ID === agentPrompt.PromptID) : undefined;
+        const childPrompt = agentPrompt ? engine.Prompts.find(p => UUIDsEqual(p.ID, agentPrompt.PromptID)) : undefined;
         if (!childPrompt && !metadataOptional && requiresAgentLevelPrompts) {
             return {
                 success: false,
@@ -1654,7 +1654,7 @@ export class BaseAgent {
         // Fall back to database-configured actions if _effectiveActions is empty
         const effectiveActions = this.getEffectiveActionsForValidation(params.agent.ID);
         // Also get the database-configured agent actions for MaxExecutionsPerRun lookup
-        const dbAgentActions = AIEngine.Instance.AgentActions.filter(aa => aa.AgentID === params.agent.ID && aa.Status === 'Active');
+        const dbAgentActions = AIEngine.Instance.AgentActions.filter(aa => UUIDsEqual(aa.AgentID, params.agent.ID) && aa.Status === 'Active');
         const missingActions = nextStep.actions?.filter(action => {
             const actionName = action.name.trim().toLowerCase();
             // Try exact match first against effective actions (by Name property)
@@ -1702,7 +1702,7 @@ export class BaseAgent {
                 if (!actionEntity)
                     continue;
                 // Check for limit from database-configured agent action
-                const dbAgentAction = dbAgentActions.find(aa => aa.ActionID === actionEntity.ID);
+                const dbAgentAction = dbAgentActions.find(aa => UUIDsEqual(aa.ActionID, actionEntity.ID));
                 let maxExecutions = null;
                 if (dbAgentAction?.MaxExecutionsPerRun != null) {
                     // Database-configured action with limit
@@ -1756,8 +1756,8 @@ export class BaseAgent {
             return this._effectiveActions;
         }
         // Fallback: compute from database configuration
-        const agentActions = AIEngine.Instance.AgentActions.filter(aa => aa.AgentID === agentId && aa.Status === 'Active');
-        return ActionEngineServer.Instance.Actions.filter(a => agentActions.some(aa => aa.ActionID === a.ID) && a.Status === 'Active');
+        const agentActions = AIEngine.Instance.AgentActions.filter(aa => UUIDsEqual(aa.AgentID, agentId) && aa.Status === 'Active');
+        return ActionEngineServer.Instance.Actions.filter(a => agentActions.some(aa => UUIDsEqual(aa.ActionID, a.ID)) && a.Status === 'Active');
     }
     /**
      * Validates that the Success next step is valid and can be executed by the current agent. Subclasses can override
@@ -2874,18 +2874,18 @@ The context is now within limits. Please retry your request with the recovered c
         try {
             const engine = AIEngine.Instance;
             // Find sub-agents using AIEngine
-            const activeSubAgents = engine.Agents.filter(a => a.ParentID === agent.ID && a.Status === 'Active')
+            const activeSubAgents = engine.Agents.filter(a => UUIDsEqual(a.ParentID, agent.ID) && a.Status === 'Active')
                 .sort((a, b) => a.ExecutionOrder - b.ExecutionOrder);
-            const activeAgentRelationships = engine.AgentRelationships.filter(ar => ar.AgentID === agent.ID && ar.Status === 'Active');
+            const activeAgentRelationships = engine.AgentRelationships.filter(ar => UUIDsEqual(ar.AgentID, agent.ID) && ar.Status === 'Active');
             // now combine the child sub-agents from the direct parentID relationships with the agentRelationships array, distinct to not repeat
             // unique ID values
             const uniqueActiveSubAgentIDs = new Set();
             activeSubAgents.forEach(a => uniqueActiveSubAgentIDs.add(a.ID));
             activeAgentRelationships.forEach(ar => uniqueActiveSubAgentIDs.add(ar.SubAgentID));
-            const uniqueActiveSubAgents = Array.from(uniqueActiveSubAgentIDs).map(id => engine.Agents.find(a => a.ID === id));
+            const uniqueActiveSubAgents = Array.from(uniqueActiveSubAgentIDs).map(id => engine.Agents.find(a => UUIDsEqual(a.ID, id)));
             // Load available actions from database configuration
-            const agentActions = engine.AgentActions.filter(aa => aa.AgentID === agent.ID && aa.Status === 'Active');
-            let actions = ActionEngineServer.Instance.Actions.filter(a => agentActions.some(aa => aa.ActionID === a.ID));
+            const agentActions = engine.AgentActions.filter(aa => UUIDsEqual(aa.AgentID, agent.ID) && aa.Status === 'Active');
+            let actions = ActionEngineServer.Instance.Actions.filter(a => agentActions.some(aa => UUIDsEqual(aa.ActionID, a.ID)));
             // Apply runtime action changes if provided
             if (actionChanges?.length) {
                 const isRoot = this._depth === 0;
@@ -2897,7 +2897,7 @@ The context is now within limits. Please retry your request with the recovered c
             const activeActions = actions.filter(a => a.Status === 'Active');
             this._effectiveActions = activeActions;
             // Build agent type prompt params (merged from schema defaults, agent config, and runtime overrides)
-            const agentType = engine.AgentTypes.find(at => at.ID === agent.TypeID);
+            const agentType = engine.AgentTypes.find(at => UUIDsEqual(at.ID, agent.TypeID));
             const runtimePromptParamOverrides = extraData?.__agentTypePromptParams;
             const agentTypePromptParams = this.buildAgentTypePromptParams(agentType, agent, runtimePromptParamOverrides);
             const contextData = {
@@ -3146,7 +3146,7 @@ The context is now within limits. Please retry your request with the recovered c
         const engine = AIEngine.Instance;
         let messages = [];
         // Check for related sub-agent configuration (AIAgentRelationship)
-        const relationship = engine.AgentRelationships.find(r => r.AgentID === params.agent.ID && r.SubAgentID === subAgent.ID);
+        const relationship = engine.AgentRelationships.find(r => UUIDsEqual(r.AgentID, params.agent.ID) && UUIDsEqual(r.SubAgentID, subAgent.ID));
         // Get MessageMode and MaxMessages from either relationship or child agent
         let messageMode = relationship?.MessageMode || subAgent.MessageMode || 'None';
         let maxMessages = relationship?.MaxMessages || subAgent.MaxMessages || null;
@@ -3338,11 +3338,11 @@ The context is now within limits. Please retry your request with the recovered c
     getAgentPromptParameters(agent) {
         const engine = AIEngine.Instance;
         const agentPrompt = engine.AgentPrompts
-            .filter(ap => ap.AgentID === agent.ID && ap.Status === 'Active')
+            .filter(ap => UUIDsEqual(ap.AgentID, agent.ID) && ap.Status === 'Active')
             .sort((a, b) => a.ExecutionOrder - b.ExecutionOrder)[0];
         if (!agentPrompt)
             return [];
-        const prompt = engine.Prompts.find(p => p.ID === agentPrompt.PromptID);
+        const prompt = engine.Prompts.find(p => UUIDsEqual(p.ID, agentPrompt.PromptID));
         if (!prompt)
             return [];
         // Return parameters as key-value pairs
@@ -3446,7 +3446,7 @@ The context is now within limits. Please retry your request with the recovered c
      * @private
      */
     getAgentTypeName(typeID) {
-        const agentType = AIEngine.Instance.AgentTypes.find(at => at.ID === typeID);
+        const agentType = AIEngine.Instance.AgentTypes.find(at => UUIDsEqual(at.ID, typeID));
         return agentType?.Name || 'Unknown';
     }
     /**
@@ -3490,8 +3490,8 @@ The context is now within limits. Please retry your request with the recovered c
             if (change.mode === 'add') {
                 // Add actions that aren't already present
                 for (const actionId of change.actionIds) {
-                    if (!actions.some(a => a.ID === actionId)) {
-                        const actionToAdd = ActionEngineServer.Instance.Actions.find(a => a.ID === actionId);
+                    if (!actions.some(a => UUIDsEqual(a.ID, actionId))) {
+                        const actionToAdd = ActionEngineServer.Instance.Actions.find(a => UUIDsEqual(a.ID, actionId));
                         if (actionToAdd) {
                             actions.push(actionToAdd);
                             // Store execution limit if provided
@@ -3507,7 +3507,7 @@ The context is now within limits. Please retry your request with the recovered c
             }
             else if (change.mode === 'remove') {
                 // Remove actions by ID
-                actions = actions.filter(a => !change.actionIds.includes(a.ID));
+                actions = actions.filter(a => !change.actionIds.some(id => UUIDsEqual(id, a.ID)));
             }
         }
         return { actions, dynamicLimits };
@@ -4551,7 +4551,7 @@ The context is now within limits. Please retry your request with the recovered c
         };
         // Get sub-agent entity to access payload paths
         const subAgentEntity = AIEngine.Instance.Agents.find(a => a.Name === subAgentRequest.name &&
-            a.ParentID === params.agent.ID);
+            UUIDsEqual(a.ParentID, params.agent.ID));
         if (!subAgentEntity) {
             throw new Error(`Sub-agent '${subAgentRequest.name}' not found`);
         }
@@ -4800,7 +4800,7 @@ The context is now within limits. Please retry your request with the recovered c
             };
         }
         // Find the sub-agent - check both child and related agents
-        const childAgents = AIEngine.Instance.Agents.filter(a => a.ParentID === params.agent.ID &&
+        const childAgents = AIEngine.Instance.Agents.filter(a => UUIDsEqual(a.ParentID, params.agent.ID) &&
             a.Status === 'Active');
         const childAgent = childAgents.find(a => a.Name.trim().toLowerCase() === name.trim().toLowerCase());
         if (childAgent) {
@@ -4808,10 +4808,10 @@ The context is now within limits. Please retry your request with the recovered c
             return await this.executeChildSubAgentStep(params, previousDecision, parentStepId, subAgentPayloadOverride, stepCount);
         }
         // Check for related agent
-        const activeRelationships = AIEngine.Instance.AgentRelationships.filter(ar => ar.AgentID === params.agent.ID &&
+        const activeRelationships = AIEngine.Instance.AgentRelationships.filter(ar => UUIDsEqual(ar.AgentID, params.agent.ID) &&
             ar.Status === 'Active');
         for (const relationship of activeRelationships) {
-            const relatedAgent = AIEngine.Instance.Agents.find(a => a.ID === relationship.SubAgentID &&
+            const relatedAgent = AIEngine.Instance.Agents.find(a => UUIDsEqual(a.ID, relationship.SubAgentID) &&
                 a.Status === 'Active');
             if (relatedAgent && relatedAgent.Name.trim().toLowerCase() === name.trim().toLowerCase()) {
                 // This is a related agent - use message-based coupling
@@ -5327,12 +5327,12 @@ The context is now within limits. Please retry your request with the recovered c
             }
             const actionEngine = ActionEngineServer.Instance;
             // Get the AIAgentAction metadata records for this agent (used for expiration settings)
-            const agentActions = AIEngine.Instance.AgentActions.filter(aa => aa.AgentID === params.agent.ID);
+            const agentActions = AIEngine.Instance.AgentActions.filter(aa => UUIDsEqual(aa.AgentID, params.agent.ID));
             // Use _effectiveActions which includes runtime action changes applied in gatherPromptTemplateData
             // Fall back to database-configured actions if _effectiveActions is empty (shouldn't happen in normal flow)
             const effectiveActions = this._effectiveActions.length > 0
                 ? this._effectiveActions
-                : actionEngine.Actions.filter(a => agentActions.some(aa => aa.ActionID === a.ID));
+                : actionEngine.Actions.filter(a => agentActions.some(aa => UUIDsEqual(aa.ActionID, a.ID)));
             // Call agent type's pre-processing for actions
             try {
                 const currentPayload = previousDecision?.newPayload || previousDecision?.previousPayload || params.payload;
@@ -5424,7 +5424,7 @@ The context is now within limits. Please retry your request with the recovered c
             // If multiple actions, use the most restrictive (shortest) expiration settings
             let metadata;
             const agentActionConfigs = actionResults
-                .map(r => agentActions.find(aa => aa.ActionID === r.actionEntity.ID))
+                .map(r => agentActions.find(aa => UUIDsEqual(aa.ActionID, r.actionEntity.ID)))
                 .filter(aa => aa != null);
             if (agentActionConfigs.length > 0) {
                 // Find the most restrictive expiration settings
@@ -5629,8 +5629,8 @@ The context is now within limits. Please retry your request with the recovered c
     }
     validateSubAgentInAgent(subAgentName) {
         // check to make sure sub-agent is valid
-        const relatedAgents = AIEngine.Instance.AgentRelationships.filter(ar => ar.AgentID === this._agentRun.AgentID);
-        const childAgents = AIEngine.Instance.Agents.filter(a => a.ParentID === this._agentRun.AgentID);
+        const relatedAgents = AIEngine.Instance.AgentRelationships.filter(ar => UUIDsEqual(ar.AgentID, this._agentRun.AgentID));
+        const childAgents = AIEngine.Instance.Agents.filter(a => UUIDsEqual(a.ParentID, this._agentRun.AgentID));
         // now check to make sure that subAgentName is either in relatedAgents or childAgents
         let subAgent = relatedAgents.filter(ra => ra.SubAgent?.trim().toLowerCase() === subAgentName.trim().toLowerCase());
         if (subAgent.length === 0) {
@@ -6268,7 +6268,7 @@ The context is now within limits. Please retry your request with the recovered c
         const violations = [];
         // Check action minimum requirements from database-configured actions only.
         // Dynamically added actions do not have MinExecutionsPerRun requirements.
-        const agentActions = AIEngine.Instance.AgentActions.filter(aa => aa.AgentID === agent.ID &&
+        const agentActions = AIEngine.Instance.AgentActions.filter(aa => UUIDsEqual(aa.AgentID, agent.ID) &&
             aa.Status === 'Active' &&
             aa.MinExecutionsPerRun != null &&
             aa.MinExecutionsPerRun > 0);
@@ -6491,7 +6491,7 @@ The context is now within limits. Please retry your request with the recovered c
                     // 3. Action.DefaultCompactPromptID
                     // 4. System default compact prompt
                     const promptId = metadata.compactPromptId || this.getSystemDefaultCompactPromptId();
-                    const prompt = AIEngine.Instance.Prompts.find(p => p.ID === promptId);
+                    const prompt = AIEngine.Instance.Prompts.find(p => UUIDsEqual(p.ID, promptId));
                     if (!prompt) {
                         // Fallback to First N Chars if prompt not found
                         console.warn(`Compact prompt ${promptId} not found, falling back to First N Chars`);
@@ -6614,7 +6614,7 @@ The context is now within limits. Please retry your request with the recovered c
                 return DEFAULT_LIMIT;
             }
             // Find the vendor-specific entry
-            const vendorEntry = modelVendors.find((mv) => mv.VendorID === vendorSelected.ID);
+            const vendorEntry = modelVendors.find((mv) => UUIDsEqual(mv.VendorID, vendorSelected.ID));
             if (!vendorEntry) {
                 this.logStatus(`No matching vendor entry found in ModelVendors, using default limit: ${DEFAULT_LIMIT}`, true);
                 return DEFAULT_LIMIT;