@memberjunction/ai-agent-manager 2.110.0 → 2.111.0

package/src/agents/architect-agent.ts

@@ -308,7 +308,7 @@ export class AgentArchitectAgent extends BaseAgent {
                 }
 
                 if (!foundIds.has(action.ActionID)) {
-                    errors.push(`❌ Action with ID "${action.ActionID}" not found in database. Please use "Find Best Action" or "List Actions" to get valid action IDs.`);
+                    errors.push(`❌ Action with ID "${action.ActionID}" not found in database. Please use "Find Candidate Actions" or "List Actions" to get valid action IDs.`);
                 }
             }
 
@@ -406,9 +406,18 @@ export class AgentArchitectAgent extends BaseAgent {
             }
 
             // Validate related-specific fields
-            if (subAgent.Type === 'related' && !subAgent.AgentRelationshipID) {
+            if (subAgent.Type === 'related') {
                 // AgentRelationshipID can be empty for new relationships, it will be created on save
-                // This is not an error
+
+                // IMPORTANT: Related agents REQUIRE existing agent ID
+                if (!subAgent.SubAgent.ID || subAgent.SubAgent.ID === '') {
+                    errors.push(`❌ Related SubAgent[${i}] "${subAgent.SubAgent.Name}" must have existing agent ID. Use Find Candidate Agents to get the ID.`);
+                }
+
+                // IMPORTANT: Related agents REQUIRE mapping fields
+                if (!subAgent.SubAgentInputMapping && !subAgent.SubAgentOutputMapping) {
+                    errors.push(`❌ Related SubAgent[${i}] "${subAgent.SubAgent.Name}" must have at least SubAgentInputMapping or SubAgentOutputMapping`);
+                }
             }
 
             // Recursively validate nested sub-agents

package/src/agents/builder-agent.ts

@@ -5,6 +5,7 @@ import { Metadata } from '@memberjunction/core';
 import { AIAgentRunStepEntityExtended } from '@memberjunction/core-entities';
 import { AgentSpecSync } from '../agent-spec-sync';
 import { TemplateEngineServer } from '@memberjunction/templates';
+import { AIEngineBase } from '@memberjunction/ai-engine-base';
 
 /**
  * Builder Agent - Persists validated AgentSpec to database via AgentSpecSync
@@ -54,6 +55,11 @@ export class AgentBuilderAgent extends BaseAgent {
             const specSync = new AgentSpecSync(agentSpec, params.contextUser);
             specSync.markDirty();
 
+            // If updating existing agent (ID exists), mark as loaded so delete logic runs
+            if (agentSpec.ID && agentSpec.ID !== '') {
+                specSync.markLoaded();
+            }
+
             const result = await specSync.SaveToDatabase();
 
             if (!result.success) {
@@ -71,6 +77,11 @@ export class AgentBuilderAgent extends BaseAgent {
             await templateEngine.Config(true, params.contextUser);
             console.log('✅ Builder Agent: Metadata and template caches refreshed');
 
+            // Refresh AIEngine cache so newly created agents are immediately available
+            const aiEngine = AIEngineBase.Instance;
+            await aiEngine.Config(true, params.contextUser);
+            console.log('✅ Builder Agent: AIEngine cache refreshed');
+
             // Create AI Agent Run Step record directly
             const agentRunId = params.parentRun?.ID || 'unknown';
             const stepEntity = await md.GetEntityObject<AIAgentRunStepEntityExtended>(

package/src/old/agent-definition.interface.ts

@@ -207,7 +207,7 @@ export interface AgentManagerPayload {
     changeSummary: string;
     /** Fields that will be updated (field name -> old/new values) */
     fieldsToUpdate?: Record<string, { old: any; new: any }>;
-    /** Actions to add (with action IDs from Find Best Action) */
+    /** Actions to add (with action IDs from Find Candidate Actions) */
     actionsToAdd?: Array<{ id: string; name: string; reason: string }>;
     /** Action IDs to remove from the agent */
     actionsToRemove?: string[];