@membank/cli 0.3.0 → 0.4.1

package/README.md

@@ -33,7 +33,7 @@ Options:
 --json             Machine-readable output
 ```
 
-Supported harnesses: `claude-code`, `copilot`, `codex`, `opencode`
+Supported harnesses: `claude-code`, `copilot`, `codex`, `opencode` (see `membank setup` for harness-specific setup instructions)
 
 ## Commands
 
@@ -125,6 +125,16 @@ Output session context formatted for a harness. Called automatically by session
 membank inject --harness claude-code --scope <project-scope>
 ```
 
+### `membank dashboard`
+
+Start the web dashboard for browsing and managing memories.
+
+```bash
+membank dashboard
+```
+
+Opens http://localhost:3847 by default. Features: full-text search, filtering by type/scope/pin status, edit memory metadata, view dedup reviews, and storage statistics.
+
 ## Global flags
 
 ```
@@ -143,11 +153,9 @@ Starts the stdio MCP server. This is what harnesses connect to — `setup` write
 
 ## Session hooks
 
-`setup` installs two hooks:
-
-**Session start** — calls `membank inject` to prepend pinned memories into the LLM context at the beginning of every session.
+`setup` installs a hook for Claude Code that injects memories at the start of each session:
 
-**Session stop (Claude Code only)** — prompts the LLM to review the session and call `save_memory` for any notable corrections, preferences, or decisions.
+**SessionStart** — calls `membank inject` to prepend pinned memories into the LLM context at the beginning of every session.
 
 ## Requirements
 

package/dist/index.mjs

@@ -134,7 +134,7 @@ async function importCommand(filePath, db, formatter, prompt) {
 }
 //#endregion
 //#region src/commands/inject.ts
-const MEMORY_GUIDANCE = "[Memory Guidance]: query_memory before answering on topics where past preferences, corrections, or decisions may apply; save_memory when user corrects you, states a preference, makes a decision, or shares something worth retaining across sessions; update_memory to refine an existing memory (query first to find it) or to set pinned=true/false; delete_memory when a memory is wrong or no longer relevant; pin high-value memories that should always appear at session start";
+const MEMORY_GUIDANCE = "[Memory Guidance]: Persistent memory is available via query_memory, save_memory, update_memory, delete_memory. Skipping save_memory when the user gives a correction or preference means they have to repeat themselves next session — that is the failure mode to avoid. Skipping query_memory on topics that touch prior decisions means contradicting yourself. Default to saving (type: correction|preference|decision|learning|fact) when in doubt; rely on dedup to handle redundancy. Pin anything that should appear at every session start.";
 function formatContext(ctx) {
 	const lines = [];
 	const statParts = Object.entries(ctx.stats).filter(([, count]) => count > 0).map(([type, count]) => `${count} ${type}${count !== 1 ? "s" : ""}`);
@@ -160,51 +160,6 @@ function outputAdditionalContext(text, harness, eventName) {
 	}
 	process.stdout.write(`${text}\n`);
 }
-async function readStdin() {
-	if (process.stdin.isTTY) return "";
-	return new Promise((resolve) => {
-		const chunks = [];
-		const timeout = setTimeout(() => resolve(""), 1e3);
-		process.stdin.on("data", (chunk) => chunks.push(chunk));
-		process.stdin.on("end", () => {
-			clearTimeout(timeout);
-			resolve(Buffer.concat(chunks).toString("utf8"));
-		});
-		process.stdin.on("error", () => {
-			clearTimeout(timeout);
-			resolve("");
-		});
-	});
-}
-const FEEDBACK_PATTERNS = [
-	/\bdon'?t\b/i,
-	/\bstop\b/i,
-	/\bnever\b/i,
-	/\balways\b/i,
-	/\bremember\b/i,
-	/\bprefer\b/i,
-	/\bi (like|want|hate|dislike)\b/i,
-	/\bfrom now on\b/i,
-	/\bkeep in mind\b/i,
-	/\bnote that\b/i,
-	/\bstop doing\b/i,
-	/\bstop using\b/i,
-	/\bthat'?s wrong\b/i,
-	/\bno,?\s+(actually|that'?s)\b/i,
-	/\bplease (don'?t|stop|always|never)\b/i
-];
-function looksLikeFeedback(prompt) {
-	return FEEDBACK_PATTERNS.some((p) => p.test(prompt));
-}
-function isToolFailure(data) {
-	if (data.hook_event_name === "PostToolUseFailure") return true;
-	if (typeof data.error_message === "string" && data.error_message.length > 0) return true;
-	const response = data.tool_result ?? data.tool_response;
-	if (typeof response === "object" && response !== null) {
-		if (response.is_error === true) return true;
-	}
-	return false;
-}
 async function handleSessionStart(opts) {
 	const projectScope = opts.scope ?? await resolveScope();
 	const db = DatabaseManager.open();
@@ -218,41 +173,8 @@ async function handleSessionStart(opts) {
 	const harness = opts.harness;
 	outputAdditionalContext(text, harness, "SessionStart");
 }
-async function handleUserPrompt(harness) {
-	const raw = await readStdin();
-	if (!raw) process.exit(0);
-	let data;
-	try {
-		data = JSON.parse(raw);
-	} catch {
-		process.exit(0);
-	}
-	if (!looksLikeFeedback(typeof data.prompt === "string" ? data.prompt : "")) process.exit(0);
-	outputAdditionalContext("User prompt may contain a correction, preference, or decision worth saving. After responding, evaluate: should this be saved as a memory? If yes, call save_memory with the appropriate type (correction/preference/decision/learning) and scope (global or project).", harness, "UserPromptSubmit");
-}
-async function handleToolFailure(harness) {
-	const raw = await readStdin();
-	if (!raw) process.exit(0);
-	let data;
-	try {
-		data = JSON.parse(raw);
-	} catch {
-		process.exit(0);
-	}
-	if (!isToolFailure(data)) process.exit(0);
-	outputAdditionalContext(`Tool "${typeof data.tool_name === "string" ? data.tool_name : "unknown"}" failed. If this reveals a non-obvious constraint, environment issue, or repeatable failure pattern, call save_memory with type "learning" to prevent repeating it.`, harness, "PostToolUseFailure");
-}
 async function injectCommand(opts) {
-	const harness = opts.harness;
-	const event = opts.event ?? "session-start";
-	if (event === "user-prompt") {
-		await handleUserPrompt(harness);
-		return;
-	}
-	if (event === "tool-failure") {
-		await handleToolFailure(harness);
-		return;
-	}
+	if (opts.event !== void 0 && opts.event !== "session-start") process.exit(0);
 	await handleSessionStart(opts);
 }
 //#endregion
@@ -491,6 +413,7 @@ function assertCliFound(result, cli) {
 }
 const MEMBANK_NPX_ARGS = [
 	"npx",
+	"-y",
 	"@membank/cli@latest",
 	"--mcp"
 ];
@@ -532,7 +455,11 @@ const writers$1 = {
 				...cfg.mcpServers,
 				membank: {
 					command: "npx",
-					args: ["@membank/cli@latest", "--mcp"]
+					args: [
+						"-y",
+						"@membank/cli@latest",
+						"--mcp"
+					]
 				}
 			}
 		});
@@ -575,6 +502,7 @@ const writers$1 = {
 					type: "local",
 					command: [
 						"npx",
+						"-y",
 						"@membank/cli@latest",
 						"--mcp"
 					]
@@ -632,10 +560,10 @@ function findMembankHookCommand(hooks, pattern) {
 	return "";
 }
 function containsMembankInject(hooks) {
-	return findMembankHookCommand(hooks, "@membank/cli inject") !== "";
+	return findMembankHookCommand(hooks, "@membank/cli") !== "";
 }
 function extractInjectCommand(hooks) {
-	return findMembankHookCommand(hooks, "@membank/cli inject");
+	return findMembankHookCommand(hooks, "@membank/cli");
 }
 function filterOutMembank(groups) {
 	return groups.filter((g) => !containsMembankInject(getHooksArray(g)));
@@ -643,154 +571,139 @@ function filterOutMembank(groups) {
 function filterOutMembankFlat(hooks) {
 	return hooks.filter((h) => !containsMembankInject([h]));
 }
+function pruneNestedEvent(hooks, eventKey) {
+	const existing = hooks[eventKey];
+	if (!Array.isArray(existing)) return;
+	const cleaned = filterOutMembank(existing);
+	if (cleaned.length === 0) delete hooks[eventKey];
+	else hooks[eventKey] = cleaned;
+}
+function pruneFlatEvent(hooks, eventKey) {
+	const existing = hooks[eventKey];
+	if (!Array.isArray(existing)) return;
+	const cleaned = filterOutMembankFlat(existing);
+	if (cleaned.length === 0) delete hooks[eventKey];
+	else hooks[eventKey] = cleaned;
+}
 const writers = {
 	"claude-code": {
-		replacement: "npx @membank/cli inject --harness claude-code",
-		write(resolver, overwrite = false) {
+		inspect(resolver) {
+			const hooks = readJson(join(resolver.home(), ".claude", "settings.json")).hooks ?? {};
+			return {
+				status: "ready",
+				hooks: [{
+					event: "SessionStart",
+					command: "npx -y @membank/cli@latest inject --harness claude-code",
+					existingCommand: extractInjectCommand((Array.isArray(hooks.SessionStart) ? hooks.SessionStart : []).flatMap(getHooksArray)) || null
+				}]
+			};
+		},
+		write(resolver, events) {
 			const cfgPath = join(resolver.home(), ".claude", "settings.json");
 			const cfg = readJson(cfgPath);
-			const hooks = cfg.hooks;
-			const existingSessionStart = Array.isArray(hooks?.SessionStart) ? hooks.SessionStart : [];
-			const innerHooks = existingSessionStart.flatMap(getHooksArray);
-			if (!overwrite && containsMembankInject(innerHooks)) return {
-				status: "already-configured",
-				existing: extractInjectCommand(innerHooks),
-				replacement: this.replacement
-			};
-			const filteredSessionStart = overwrite ? filterOutMembank(existingSessionStart) : existingSessionStart;
-			const existingUserPrompt = Array.isArray(hooks?.UserPromptSubmit) ? hooks.UserPromptSubmit : [];
-			const existingToolFailure = Array.isArray(hooks?.PostToolUseFailure) ? hooks.PostToolUseFailure : [];
+			const hooks = cfg.hooks ?? {};
+			const newHooks = { ...hooks };
+			pruneNestedEvent(newHooks, "UserPromptSubmit");
+			pruneNestedEvent(newHooks, "PostToolUseFailure");
+			if (events.includes("SessionStart")) newHooks.SessionStart = [...filterOutMembank(Array.isArray(hooks.SessionStart) ? hooks.SessionStart : []), {
+				matcher: "",
+				hooks: [{
+					type: "command",
+					command: "npx -y @membank/cli@latest inject --harness claude-code"
+				}]
+			}];
 			writeJsonAtomic(cfgPath, {
 				...cfg,
-				hooks: {
-					...hooks ?? {},
-					SessionStart: [...filteredSessionStart, {
-						matcher: "",
-						hooks: [{
-							type: "command",
-							command: "npx @membank/cli inject --harness claude-code"
-						}]
-					}],
-					UserPromptSubmit: [...filterOutMembank(existingUserPrompt), {
-						matcher: "",
-						hooks: [{
-							type: "command",
-							command: "npx @membank/cli inject --event user-prompt --harness claude-code"
-						}]
-					}],
-					PostToolUseFailure: [...filterOutMembank(existingToolFailure), {
-						matcher: "",
-						hooks: [{
-							type: "command",
-							command: "npx @membank/cli inject --event tool-failure --harness claude-code"
-						}]
-					}]
-				}
+				hooks: newHooks
 			});
 			return { status: "written" };
 		}
 	},
 	"copilot-cli": {
-		replacement: "npx @membank/cli inject --harness copilot-cli",
-		write(resolver, overwrite = false) {
+		inspect(resolver) {
+			const hooks = readJson(join(resolver.home(), ".copilot", "settings.json")).hooks ?? {};
+			return {
+				status: "ready",
+				hooks: [{
+					event: "sessionStart",
+					command: "npx -y @membank/cli@latest inject --harness copilot-cli",
+					existingCommand: extractInjectCommand(Array.isArray(hooks.sessionStart) ? hooks.sessionStart : []) || null
+				}]
+			};
+		},
+		write(resolver, events) {
 			const cfgPath = join(resolver.home(), ".copilot", "settings.json");
 			const cfg = readJson(cfgPath);
-			const hooks = cfg.hooks;
-			const existingSessionStart = Array.isArray(hooks?.sessionStart) ? hooks.sessionStart : [];
-			if (!overwrite && containsMembankInject(existingSessionStart)) return {
-				status: "already-configured",
-				existing: extractInjectCommand(existingSessionStart),
-				replacement: this.replacement
-			};
-			const filteredSessionStart = overwrite ? filterOutMembankFlat(existingSessionStart) : existingSessionStart;
-			const existingUserPrompt = Array.isArray(hooks?.userPromptSubmitted) ? hooks.userPromptSubmitted : [];
-			const existingToolFailure = Array.isArray(hooks?.postToolUseFailure) ? hooks.postToolUseFailure : [];
+			const hooks = cfg.hooks ?? {};
+			const newHooks = { ...hooks };
+			pruneFlatEvent(newHooks, "userPromptSubmitted");
+			pruneFlatEvent(newHooks, "postToolUseFailure");
+			if (events.includes("sessionStart")) newHooks.sessionStart = [...filterOutMembankFlat(Array.isArray(hooks.sessionStart) ? hooks.sessionStart : []), {
+				type: "command",
+				bash: "npx -y @membank/cli@latest inject --harness copilot-cli",
+				timeoutSec: 30
+			}];
 			writeJsonAtomic(cfgPath, {
 				version: cfg.version ?? 1,
 				...cfg,
-				hooks: {
-					...hooks ?? {},
-					sessionStart: [...filteredSessionStart, {
-						type: "command",
-						bash: "npx @membank/cli inject --harness copilot-cli",
-						timeoutSec: 30
-					}],
-					userPromptSubmitted: [...filterOutMembankFlat(existingUserPrompt), {
-						type: "command",
-						bash: "npx @membank/cli inject --event user-prompt --harness copilot-cli",
-						timeoutSec: 30
-					}],
-					postToolUseFailure: [...filterOutMembankFlat(existingToolFailure), {
-						type: "command",
-						bash: "npx @membank/cli inject --event tool-failure --harness copilot-cli",
-						timeoutSec: 30
-					}]
-				}
+				hooks: newHooks
 			});
 			return { status: "written" };
 		}
 	},
 	codex: {
-		replacement: "npx @membank/cli inject --harness codex",
-		write(resolver, overwrite = false) {
+		inspect(resolver) {
+			const hooks = readJson(join(resolver.home(), ".codex", "hooks.json")).hooks ?? {};
+			return {
+				status: "ready",
+				hooks: [{
+					event: "SessionStart",
+					command: "npx -y @membank/cli@latest inject --harness codex",
+					existingCommand: extractInjectCommand((Array.isArray(hooks.SessionStart) ? hooks.SessionStart : []).flatMap(getHooksArray)) || null
+				}]
+			};
+		},
+		write(resolver, events) {
 			const cfgPath = join(resolver.home(), ".codex", "hooks.json");
 			const cfg = readJson(cfgPath);
-			const hooks = cfg.hooks;
-			const existingSessionStart = Array.isArray(hooks?.SessionStart) ? hooks.SessionStart : [];
-			const innerHooks = existingSessionStart.flatMap(getHooksArray);
-			if (!overwrite && containsMembankInject(innerHooks)) return {
-				status: "already-configured",
-				existing: extractInjectCommand(innerHooks),
-				replacement: this.replacement
-			};
-			const filteredSessionStart = overwrite ? filterOutMembank(existingSessionStart) : existingSessionStart;
-			const existingUserPrompt = Array.isArray(hooks?.UserPromptSubmit) ? hooks.UserPromptSubmit : [];
-			const existingToolFailure = Array.isArray(hooks?.PostToolUse) ? hooks.PostToolUse : [];
+			const hooks = cfg.hooks ?? {};
+			const newHooks = { ...hooks };
+			pruneNestedEvent(newHooks, "UserPromptSubmit");
+			pruneNestedEvent(newHooks, "PostToolUse");
+			if (events.includes("SessionStart")) newHooks.SessionStart = [...filterOutMembank(Array.isArray(hooks.SessionStart) ? hooks.SessionStart : []), {
+				matcher: "",
+				hooks: [{
+					type: "command",
+					command: "npx -y @membank/cli@latest inject --harness codex",
+					timeout: 30
+				}]
+			}];
 			writeJsonAtomic(cfgPath, {
 				...cfg,
-				hooks: {
-					...hooks ?? {},
-					SessionStart: [...filteredSessionStart, {
-						matcher: "",
-						hooks: [{
-							type: "command",
-							command: "npx @membank/cli inject --harness codex",
-							timeout: 30
-						}]
-					}],
-					UserPromptSubmit: [...filterOutMembank(existingUserPrompt), {
-						matcher: "",
-						hooks: [{
-							type: "command",
-							command: "npx @membank/cli inject --event user-prompt --harness codex",
-							timeout: 30
-						}]
-					}],
-					PostToolUse: [...filterOutMembank(existingToolFailure), {
-						matcher: "",
-						hooks: [{
-							type: "command",
-							command: "npx @membank/cli inject --event tool-failure --harness codex",
-							timeout: 30
-						}]
-					}]
-				}
+				hooks: newHooks
 			});
 			return { status: "written" };
 		}
 	},
 	opencode: {
-		replacement: "npx @membank/cli inject",
-		write(resolver, overwrite = false) {
+		inspect(resolver) {
 			const pluginPath = join(resolver.home(), ".config", "opencode", "plugins", "membank.js");
-			if (!overwrite && existsSync(pluginPath)) {
-				const existing = readFileSync(pluginPath, "utf8");
-				if (existing.includes("@membank/cli inject")) return {
-					status: "already-configured",
-					existing: existing.trim(),
-					replacement: newOpencodePlugin()
-				};
+			let existingCommand = null;
+			if (existsSync(pluginPath)) {
+				if (readFileSync(pluginPath, "utf8").includes("@membank/cli")) existingCommand = pluginPath;
 			}
+			return {
+				status: "ready",
+				hooks: [{
+					event: "plugin",
+					command: pluginPath,
+					existingCommand
+				}]
+			};
+		},
+		write(resolver, events) {
+			if (events.length === 0) return { status: "written" };
+			const pluginPath = join(resolver.home(), ".config", "opencode", "plugins", "membank.js");
 			mkdirSync(dirname(pluginPath), { recursive: true });
 			writeFileSync(pluginPath, `${newOpencodePlugin()}\n`, "utf8");
 			return { status: "written" };
@@ -802,19 +715,7 @@ function newOpencodePlugin() {
 		"export default {",
 		"  hooks: {",
 		"    \"session.start\": async ({ $ }) => {",
-		"      return await $`npx @membank/cli inject`.text();",
-		"    },",
-		"    \"chat.message\": async ({ $, message }) => {",
-		"      const input = JSON.stringify({ prompt: message?.content ?? \"\" });",
-		"      return await $`npx @membank/cli inject --event user-prompt`.stdin(input).text();",
-		"    },",
-		"    \"tool.execute.after\": async ({ $, result }) => {",
-		"      if (!result?.exitCode && !result?.error) return;",
-		"      const payload = JSON.stringify({",
-		"        tool_name: result.tool ?? \"unknown\",",
-		"        error_message: result.error ?? (\"exit code \" + result.exitCode),",
-		"      });",
-		"      return await $`npx @membank/cli inject --event tool-failure`.stdin(payload).text();",
+		"      return await $`npx -y @membank/cli@latest inject`.text();",
 		"    },",
 		"  },",
 		"};"
@@ -825,10 +726,15 @@ var InjectionHookWriter = class {
 	constructor(resolver = defaultPathResolver) {
 		this.#resolver = resolver;
 	}
-	write(harness, overwrite) {
+	inspect(harness) {
+		const writer = writers[harness];
+		if (!writer) return { status: "not-supported" };
+		return writer.inspect(this.#resolver);
+	}
+	write(harness, events) {
 		const writer = writers[harness];
 		if (!writer) return { status: "not-supported" };
-		return writer.write(this.#resolver, overwrite);
+		return writer.write(this.#resolver, events);
 	}
 };
 //#endregion
@@ -1062,8 +968,7 @@ var SetupOrchestrator = class {
 		out("");
 		const injectionHooksConfigured = [];
 		if (this.#hookWriter) {
-			const w = this.#hookWriter;
-			injectionHooksConfigured.push(...await this.#runHookLoop(detected, "injection hook", (h, ow) => w.write(h, ow), yes, out));
+			injectionHooksConfigured.push(...await this.#runHookSetup(detected, yes, out));
 			out("");
 		}
 		let modelDownloaded = false;
@@ -1086,28 +991,33 @@ var SetupOrchestrator = class {
 		}
 		return results;
 	}
-	async #runHookLoop(detected, label, write, yes, out) {
+	async #runHookSetup(detected, yes, out) {
 		const configured = [];
+		const w = this.#hookWriter;
 		for (const h of detected) try {
-			const result = write(h.name);
-			if (result.status === "not-supported") continue;
-			if (result.status === "written") {
-				out(`  ✓ ${h.name}: ${label} written`);
-				configured.push(h.name);
+			const inspected = w.inspect(h.name);
+			if (inspected.status === "not-supported") continue;
+			const toWrite = [];
+			for (const hook of inspected.hooks) if (hook.existingCommand === null) {
+				out(`  ${h.name}: ${hook.event} injection hook`);
+				out(`    Command: ${hook.command}`);
+				if (yes || await this.#prompter(`  Configure ${hook.event} injection hook for ${h.name}?`)) toWrite.push(hook.event);
 			} else {
-				out(`  ⚠ ${h.name}: ${label} already configured`);
-				out(`    Current: ${result.existing}`);
-				out(`    New:     ${result.replacement}`);
-				if (yes || await this.#prompter(`  Replace ${label} for ${h.name}?`)) {
-					if (write(h.name, true).status === "written") {
-						out(`  ✓ ${h.name}: ${label} replaced`);
-						configured.push(h.name);
-					}
-				}
+				out(`  ⚠ ${h.name}: ${hook.event} injection hook already configured`);
+				out(`    Current: ${hook.existingCommand}`);
+				if (hook.existingCommand !== hook.command) out(`    New:     ${hook.command}`);
+				if (yes || await this.#prompter(`  Replace ${hook.event} injection hook for ${h.name}?`)) toWrite.push(hook.event);
+			}
+			if (toWrite.length > 0) {
+				w.write(h.name, toWrite);
+				const skippedCount = inspected.hooks.length - toWrite.length;
+				const label = skippedCount > 0 ? `${toWrite.length} injection hook(s) written, ${skippedCount} skipped` : `${toWrite.length} injection hook(s) written`;
+				out(`  ✓ ${h.name}: ${label}`);
+				configured.push(h.name);
 			}
 		} catch (err) {
 			const msg = err instanceof Error ? err.message : String(err);
-			out(`  ✗ ${h.name} ${label}: ${msg}`);
+			out(`  ✗ ${h.name} injection hooks: ${msg}`);
 		}
 		return configured;
 	}
@@ -1241,7 +1151,7 @@ program.command("import <file>").description("import memories from a JSON export
 		db.close();
 	}
 });
-program.command("inject").description("output session context for harness injection (used by setup hooks)").option("--harness <name>", "format output for a specific harness (claude-code|copilot-cli|codex|opencode)").option("--scope <scope>", "project scope override (default: auto-detect from git remote)").option("--event <event>", "hook event type (session-start|user-prompt|tool-failure)", "session-start").action(async (cmdOptions) => {
+program.command("inject").description("output session context for harness injection (used by setup hooks)").option("--harness <name>", "format output for a specific harness (claude-code|copilot-cli|codex|opencode)").option("--scope <scope>", "project scope override (default: auto-detect from git remote)").option("--event <event>", "hook event type (only session-start is supported; other values no-op for legacy hook compatibility)", "session-start").action(async (cmdOptions) => {
 	try {
 		await injectCommand(cmdOptions);
 	} catch (err) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@membank/cli",
-  "version": "0.3.0",
+  "version": "0.4.1",
   "type": "module",
   "repository": {
     "type": "git",
@@ -17,9 +17,9 @@
     "@huggingface/transformers": "^4.2.0",
     "commander": "^14.0.3",
     "ora": "^9.4.0",
-    "@membank/dashboard": "0.1.0",
-    "@membank/mcp": "0.3.0",
-    "@membank/core": "0.3.0"
+    "@membank/core": "0.4.1",
+    "@membank/dashboard": "0.2.1",
+    "@membank/mcp": "0.4.1"
   },
   "devDependencies": {
     "@types/node": "^25.6.0",