@melonjs/spine-plugin 1.2.0 → 1.2.1

package/CHANGELOG.md

@@ -0,0 +1,19 @@
+# Changelog
+
+## 1.2.1 - _2023-08-23
+
+- code refactoring and optimization to prepare for future feature additions
+- fix URLs in the package.json file
+
+## 1.2.0 - _2023-08-22
+
+- add support for clipping (coin example is now rendered properly)
+
+## 1.1.0 - _2023-08-19
+
+- add some basic debug rendering
+- optimize code (remove unneeded logic)
+
+## 1.0.0 - _2023-08-16_
+
+initial release

package/README.md

@@ -1,6 +1,6 @@
 # melonJS Spine Plugin
 
-a [Spine](http://en.esotericsoftware.com/spine-in-depth) 4.1 plugin implementation for [melonJS 2](www.melonjs.org)
+a [Spine](http://en.esotericsoftware.com/spine-in-depth) 4.1 plugin implementation for [melonJS 2](http://www.melonjs.org)
 
 ![melonjs-spine-gif](https://github.com/melonjs/spine-plugin/assets/4033090/dc259c8e-def6-419e-83a9-cda374715686)
 

package/dist/@melonjs/spine-plugin.d.ts

@@ -4070,10 +4070,8 @@ declare class CanvasTexture extends Texture {
 }
 declare class SkeletonRenderer {
     constructor(runtime: any);
-    isWebGLRenderer: any;
     skeletonRenderer: any;
     runtime: any;
-    tempColor: Color;
     tintColor: Color$1;
     vertexSize: number;
     debugRendering: boolean;

package/dist/@melonjs/spine-plugin.js

@@ -1,5 +1,5 @@
 /*!
- * melonJS Spine plugin - v1.2.0
+ * melonJS Spine plugin - v1.2.1
  * http://www.melonjs.org
  * @melonjs/spine-plugin is licensed under the MIT License.
  * http://www.opensource.org/licenses/mit-license
@@ -14932,11 +14932,12 @@ class AssetManager {
 const worldVertices = new Float32Array(8);
 const blendModeLUT = ["normal", "additive", "multiply", "screen"];
 
+const regionDebugColor = "green";
+const clipDebugColor = "blue";
+
 class SkeletonRenderer {
-    isWebGLRenderer;
     skeletonRenderer;
     runtime;
-    tempColor = new Color();
     tintColor = new Color$1();
     vertexSize = 2 + 2 + 4;
     debugRendering = false;
@@ -14947,18 +14948,21 @@ class SkeletonRenderer {
     constructor(runtime) {
         this.runtime = runtime;
         this.skeletonRenderer = new runtime.SkeletonRenderer();
-        this.tempColor = new Color();
     }
 
     draw(renderer, skeleton) {
         let clipper = this.clipper;
         let drawOrder = skeleton.drawOrder;
         let skeletonColor = skeleton.color;
+        let clippingMask = this.clippingMask;
+        let debugRendering = this.debugRendering;
 
         for (var i = 0, n = drawOrder.length; i < n; i++) {
             let clippedVertexSize = clipper.isClipping() ? 2 : this.vertexSize;
             let slot = drawOrder[i];
             let bone = slot.bone;
+            let image;
+            let region;
 
             if (!bone.active) {
                 clipper.clipEndWithSlot(slot);
@@ -14969,8 +14973,36 @@ class SkeletonRenderer {
             let attachment = slot.getAttachment();
 
             if (attachment instanceof RegionAttachment) {
-                let region = attachment.region;
-                let image = region.texture.getImage();
+                attachment.computeWorldVertices(slot, worldVertices, 0, clippedVertexSize);
+                region = attachment.region;
+                image = region.texture.getImage();
+            } else if (attachment instanceof MeshAttachment) {
+                /*
+                // commenting for now as totally untested
+                let mesh = attachment;
+                mesh.computeWorldVertices(slot, 0, mesh.worldVerticesLength, worldVertices, 0, 2);
+                region = mesh.region;
+                image = mesh.region.texture.getImage();
+                */
+               console.warn("spine-plugin: MeshAttachment is not supported yet");
+            } else if (attachment instanceof ClippingAttachment) {
+                let clip = attachment;
+                let vertices = this.clippingVertices;
+                clipper.clipStart(slot, clip);
+                clip.computeWorldVertices(slot, 0, clip.worldVerticesLength, vertices, 0, 2);
+                clippingMask.setVertices(vertices, clip.worldVerticesLength);
+                if (debugRendering === true) {
+                    renderer.setColor(clipDebugColor);
+                    renderer.stroke(clippingMask);
+                }
+                continue;
+            } else {
+                clipper.clipEndWithSlot(slot);
+                renderer.clearMask();
+                continue;
+            }
+
+            if (typeof image !== "undefined") {
                 let slotColor = slot.color;
                 let regionColor = attachment.color;
                 let blendMode = slot.data.blendMode;
@@ -14981,8 +15013,6 @@ class SkeletonRenderer {
                     skeletonColor.b * slotColor.b * regionColor.b,
                     skeletonColor.a * slotColor.a * regionColor.a);
 
-                attachment.computeWorldVertices(slot, worldVertices, 0, clippedVertexSize);
-
                 renderer.save();
                 renderer.transform(bone.a, bone.c, bone.b, bone.d, bone.worldX, bone.worldY);
                 renderer.translate(attachment.offset[0], attachment.offset[1]);
@@ -15007,34 +15037,17 @@ class SkeletonRenderer {
                 renderer.setGlobalAlpha(color.a);
 
                 if (clipper.isClipping()) {
-                    renderer.setMask(this.clippingMask);
+                    renderer.setMask(clippingMask);
                 }
 
                 renderer.drawImage(image, image.width * region.u, image.height * region.v, w, h, 0, 0, w, h);
 
-                if (this.debugRendering === true) {
-                    renderer.setColor("green");
+                if (debugRendering === true) {
+                    renderer.setColor(regionDebugColor);
                     renderer.strokeRect(0, 0, w, h);
                 }
 
                 renderer.restore();
-            } else if (attachment instanceof MeshAttachment) {
-                // do nothing for now;
-            } else if (attachment instanceof ClippingAttachment) {
-                let clip = attachment;
-                let vertices = this.clippingVertices;
-                clipper.clipStart(slot, clip);
-                clip.computeWorldVertices(slot, 0, clip.worldVerticesLength, vertices, 0, 2);
-                this.clippingMask.setVertices(vertices, clip.worldVerticesLength);
-                if (this.debugRendering === true) {
-                    renderer.setColor("blue");
-                    renderer.stroke(this.clippingMask);
-                }
-                continue;
-            } else {
-                clipper.clipEndWithSlot(slot);
-                renderer.clearMask();
-                continue;
             }
             clipper.clipEndWithSlot(slot);
             renderer.clearMask();

package/package.json

@@ -1,27 +1,31 @@
 {
   "name": "@melonjs/spine-plugin",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "melonJS Spine plugin",
+  "homepage": "https://github.com/melonjs/spine-plugin#readme",
   "type": "module",
   "keywords": [
     "2D",
     "HTML5",
     "javascript",
     "TypeScript",
-    "es6",
+    "ES6",
     "Canvas",
     "WebGL",
     "WebGL2",
     "melonjs",
-    "Spine",
+    "plugin",
+    "spine",
+    "spine-runtimes",
+    "spine-animation",
     "esotericsoftware"
   ],
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/melonjs/debug-spine.git"
+    "url": "git+https://github.com/melonjs/spine-plugin.git"
   },
   "bugs": {
-    "url": "https://github.com/melonjs/debug-spine/issues"
+    "url": "https://github.com/melonjs/spine-plugin/issues"
   },
   "license": "MIT",
   "author": "AltByte Pte Ltd",
@@ -38,7 +42,8 @@
     "src/",
     "package.json",
     "README.md",
-    "LICENSE"
+    "LICENSE",
+    "CHANGELOG.md"
   ],
   "peerDependencies": {
     "melonjs": "^15.9.0"
@@ -52,12 +57,12 @@
     "@babel/eslint-parser": "^7.22.0",
     "@babel/plugin-syntax-import-assertions": "^7.22.5",
     "@rollup/plugin-commonjs": "^25.0.4",
-    "@rollup/plugin-node-resolve": "^15.2.0",
+    "@rollup/plugin-node-resolve": "^15.2.1",
     "@rollup/plugin-replace": "^5.0.2",
     "del-cli": "^5.0.0",
     "eslint": "^8.47.0",
     "eslint-plugin-jsdoc": "^46.5.0",
-    "rollup": "^3.28.0",
+    "rollup": "^3.28.1",
     "rollup-plugin-bundle-size": "^1.0.3",
     "typescript": "^5.1.6"
   },
@@ -69,9 +74,5 @@
     "prepublishOnly": "npm run build",
     "clean": "del-cli --force dist/*",
     "types": "tsc"
-  },
-  "homepage": "https://github.com/melonjs/spine-plugin#readme",
-  "directories": {
-    "test": "test"
   }
 }

package/src/SkeletonRenderer.js

@@ -1,14 +1,15 @@
 import { Color as MColor, Math as MMath, Polygon } from "melonjs";
-import { SkeletonClipping, ClippingAttachment, MeshAttachment, RegionAttachment, Color } from "@esotericsoftware/spine-core";
+import { SkeletonClipping, ClippingAttachment, MeshAttachment, RegionAttachment } from "@esotericsoftware/spine-core";
 
 const worldVertices = new Float32Array(8);
 const blendModeLUT = ["normal", "additive", "multiply", "screen"];
 
+const regionDebugColor = "green";
+const clipDebugColor = "blue";
+
 export default class SkeletonRenderer {
-    isWebGLRenderer;
     skeletonRenderer;
     runtime;
-    tempColor = new Color();
     tintColor = new MColor();
     vertexSize = 2 + 2 + 4;
     debugRendering = false;
@@ -19,18 +20,21 @@ export default class SkeletonRenderer {
     constructor(runtime) {
         this.runtime = runtime;
         this.skeletonRenderer = new runtime.SkeletonRenderer();
-        this.tempColor = new Color();
     }
 
     draw(renderer, skeleton) {
         let clipper = this.clipper;
         let drawOrder = skeleton.drawOrder;
         let skeletonColor = skeleton.color;
+        let clippingMask = this.clippingMask;
+        let debugRendering = this.debugRendering;
 
         for (var i = 0, n = drawOrder.length; i < n; i++) {
             let clippedVertexSize = clipper.isClipping() ? 2 : this.vertexSize;
             let slot = drawOrder[i];
             let bone = slot.bone;
+            let image;
+            let region;
 
             if (!bone.active) {
                 clipper.clipEndWithSlot(slot);
@@ -41,8 +45,36 @@ export default class SkeletonRenderer {
             let attachment = slot.getAttachment();
 
             if (attachment instanceof RegionAttachment) {
-                let region = attachment.region;
-                let image = region.texture.getImage();
+                attachment.computeWorldVertices(slot, worldVertices, 0, clippedVertexSize);
+                region = attachment.region;
+                image = region.texture.getImage();
+            } else if (attachment instanceof MeshAttachment) {
+                /*
+                // commenting for now as totally untested
+                let mesh = attachment;
+                mesh.computeWorldVertices(slot, 0, mesh.worldVerticesLength, worldVertices, 0, 2);
+                region = mesh.region;
+                image = mesh.region.texture.getImage();
+                */
+               console.warn("spine-plugin: MeshAttachment is not supported yet");
+            } else if (attachment instanceof ClippingAttachment) {
+                let clip = attachment;
+                let vertices = this.clippingVertices;
+                clipper.clipStart(slot, clip);
+                clip.computeWorldVertices(slot, 0, clip.worldVerticesLength, vertices, 0, 2);
+                clippingMask.setVertices(vertices, clip.worldVerticesLength);
+                if (debugRendering === true) {
+                    renderer.setColor(clipDebugColor);
+                    renderer.stroke(clippingMask);
+                }
+                continue;
+            } else {
+                clipper.clipEndWithSlot(slot);
+                renderer.clearMask();
+                continue;
+            }
+
+            if (typeof image !== "undefined") {
                 let slotColor = slot.color;
                 let regionColor = attachment.color;
                 let blendMode = slot.data.blendMode;
@@ -53,8 +85,6 @@ export default class SkeletonRenderer {
                     skeletonColor.b * slotColor.b * regionColor.b,
                     skeletonColor.a * slotColor.a * regionColor.a);
 
-                attachment.computeWorldVertices(slot, worldVertices, 0, clippedVertexSize);
-
                 renderer.save();
                 renderer.transform(bone.a, bone.c, bone.b, bone.d, bone.worldX, bone.worldY);
                 renderer.translate(attachment.offset[0], attachment.offset[1]);
@@ -79,34 +109,17 @@ export default class SkeletonRenderer {
                 renderer.setGlobalAlpha(color.a);
 
                 if (clipper.isClipping()) {
-                    renderer.setMask(this.clippingMask);
+                    renderer.setMask(clippingMask);
                 }
 
                 renderer.drawImage(image, image.width * region.u, image.height * region.v, w, h, 0, 0, w, h);
 
-                if (this.debugRendering === true) {
-                    renderer.setColor("green");
+                if (debugRendering === true) {
+                    renderer.setColor(regionDebugColor);
                     renderer.strokeRect(0, 0, w, h);
                 }
 
                 renderer.restore();
-            } else if (attachment instanceof MeshAttachment) {
-                // do nothing for now;
-            } else if (attachment instanceof ClippingAttachment) {
-                let clip = attachment;
-                let vertices = this.clippingVertices;
-                clipper.clipStart(slot, clip);
-                clip.computeWorldVertices(slot, 0, clip.worldVerticesLength, vertices, 0, 2);
-                this.clippingMask.setVertices(vertices, clip.worldVerticesLength);
-                if (this.debugRendering === true) {
-                    renderer.setColor("blue");
-                    renderer.stroke(this.clippingMask);
-                }
-                continue;
-            } else {
-                clipper.clipEndWithSlot(slot);
-                renderer.clearMask();
-                continue;
             }
             clipper.clipEndWithSlot(slot);
             renderer.clearMask();