@meetquinn/animactl 0.1.13-canary.424.1.efdd965 → 0.1.13

package/dist/server/slack/resilient-socket-mode-receiver.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"resilient-socket-mode-receiver.d.ts","sourceRoot":"","sources":["../../../server/slack/resilient-socket-mode-receiver.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,kBAAkB,EAAE,KAAK,yBAAyB,EAAE,MAAM,aAAa,CAAC;AAEjF,OAAO,EAAgC,KAAK,2BAA2B,EAAE,MAAM,gBAAgB,CAAC;AAOhG,UAAU,kCAAmC,SAAQ,yBAAyB;IAC5E,MAAM,CAAC,EAAE,MAAM,MAAM,CAAC;IACtB,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,mBAAmB,CAAC,EAAE,MAAM,CAAC;IAC7B,aAAa,CAAC,EAAE,IAAI,CAAC,OAAO,EAAE,OAAO,GAAG,KAAK,GAAG,MAAM,CAAC,CAAC;CACzD;AAID,qBAAa,2BAA4B,SAAQ,kBAAkB;IACjE,OAAO,CAAC,QAAQ,CAAC,gBAAgB,CAAS;IAC1C,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAAS;IAC7C,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAe;IACtC,OAAO,CAAC,QAAQ,CAAC,aAAa,CAA0C;IACxE,OAAO,CAAC,aAAa,CAAC,CAAgB;IACtC,OAAO,CAAC,UAAU,CAAC,CAA6C;IAChE,OAAO,CAAC,OAAO,CAAS;IACxB,OAAO,CAAC,QAAQ,CAAS;gBAEb,OAAO,EAAE,kCAAkC;IAgBxC,KAAK,IAAI,OAAO,CAAC,2BAA2B,CAAC;IAQ7C,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC;IAQpC,OAAO,CAAC,cAAc;YASR,mBAAmB;YAQnB,wBAAwB;YAWxB,mBAAmB;IAiCjC,OAAO,CAAC,YAAY;IAWpB,OAAO,CAAC,iBAAiB;YAQX,gBAAgB;CAK/B"}
+{"version":3,"file":"resilient-socket-mode-receiver.d.ts","sourceRoot":"","sources":["../../../server/slack/resilient-socket-mode-receiver.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,kBAAkB,EAAE,KAAK,yBAAyB,EAAE,MAAM,aAAa,CAAC;AAEjF,OAAO,EAAgC,KAAK,2BAA2B,EAAE,MAAM,gBAAgB,CAAC;AAOhG,UAAU,kCAAmC,SAAQ,yBAAyB;IAC5E,MAAM,CAAC,EAAE,MAAM,MAAM,CAAC;IACtB,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,mBAAmB,CAAC,EAAE,MAAM,CAAC;IAC7B,aAAa,CAAC,EAAE,IAAI,CAAC,OAAO,EAAE,OAAO,GAAG,KAAK,GAAG,MAAM,CAAC,CAAC;CACzD;AAQD,qBAAa,2BAA4B,SAAQ,kBAAkB;IACjE,OAAO,CAAC,QAAQ,CAAC,gBAAgB,CAAS;IAC1C,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAAS;IAC7C,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAe;IACtC,OAAO,CAAC,QAAQ,CAAC,aAAa,CAA0C;IACxE,OAAO,CAAC,aAAa,CAAC,CAAgB;IACtC,OAAO,CAAC,UAAU,CAAC,CAA6C;IAChE,OAAO,CAAC,OAAO,CAAS;IACxB,OAAO,CAAC,QAAQ,CAAS;gBAEb,OAAO,EAAE,kCAAkC;IAgBxC,KAAK,IAAI,OAAO,CAAC,2BAA2B,CAAC;IAQ7C,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC;IAQpC,OAAO,CAAC,cAAc;YASR,mBAAmB;YAQnB,wBAAwB;YAWxB,mBAAmB;IAiCjC,OAAO,CAAC,YAAY;IAWpB,OAAO,CAAC,iBAAiB;YAQX,gBAAgB;CAK/B"}

package/dist/server/slack/resilient-socket-mode-receiver.js

@@ -26,11 +26,11 @@ export class ResilientSocketModeReceiver extends SocketModeReceiver {
     }
     async start() {
         this.stopping = false;
-        const connected = await this.connectUntilStopped();
-        if (!connected)
+        const outcome = await this.connectUntilStopped();
+        if (outcome.kind === 'stopped')
             throw new Error('Slack Socket Mode startup stopped before connecting');
         this.started = true;
-        return connected.response;
+        return outcome.response;
     }
     async stop() {
         this.started = false;
@@ -59,8 +59,8 @@ export class ResilientSocketModeReceiver extends SocketModeReceiver {
     }
     async reconnectAfterDisconnect() {
         try {
-            const connected = await this.connectUntilStopped();
-            if (connected && !this.stopping) {
+            const outcome = await this.connectUntilStopped();
+            if (outcome.kind === 'connected' && !this.stopping) {
                 this.runtimeLogger.log('Slack Socket Mode reconnected.');
             }
         }
@@ -76,13 +76,13 @@ export class ResilientSocketModeReceiver extends SocketModeReceiver {
                 // The SDK resolves undefined after a real successful hello despite its
                 // declared AppsConnectionsOpenResponse return type.
                 if (!this.stopping)
-                    return { response };
+                    return { kind: 'connected', response };
                 await this.disconnectClient();
-                return undefined;
+                return { kind: 'stopped' };
             }
             catch (error) {
                 if (this.stopping)
-                    return undefined;
+                    return { kind: 'stopped' };
                 if (fatalSocketStartError(error)) {
                     this.runtimeLogger.error(`Slack Socket Mode connection failed permanently: ${errorMessage(error)}`);
                     throw error;
@@ -92,10 +92,10 @@ export class ResilientSocketModeReceiver extends SocketModeReceiver {
                 this.runtimeLogger.warn(`Slack Socket Mode connection failed; retrying in ${delayMs}ms: ${errorMessage(error)}`);
                 await this.waitForRetry(delayMs);
                 if (this.stopping)
-                    return undefined;
+                    return { kind: 'stopped' };
             }
         }
-        return undefined;
+        return { kind: 'stopped' };
     }
     waitForRetry(delayMs) {
         return new Promise((resolve) => {

package/dist/server/tests/socket-mode-predicate.test.js

@@ -33,8 +33,11 @@ async function probe(make) {
     let attempts = 0;
     receiver.client.start = async () => {
         attempts += 1;
+        // The real SDK fulfills `undefined` after a successful hello, despite its
+        // declared AppsConnectionsOpenResponse return type. Stub the world, not our
+        // idea of it: a `{ ok: true }` stub is what let the .423 outage ship green.
         if (attempts === 1)
-            return { ok: true };
+            return undefined;
         throw make();
     };
     await receiver.start();
@@ -93,9 +96,12 @@ test('stop() during an in-flight connect leaves no live socket', async () => {
     let release;
     receiver.client.start = async () => {
         attempts += 1;
+        // The real SDK fulfills `undefined` after a successful hello, despite its
+        // declared AppsConnectionsOpenResponse return type. Stub the world, not our
+        // idea of it: a `{ ok: true }` stub is what let the .423 outage ship green.
         if (attempts === 1)
-            return { ok: true };
-        return new Promise((resolve) => { release = () => resolve({ ok: true }); });
+            return undefined;
+        return new Promise((resolve) => { release = () => resolve(undefined); });
     };
     await receiver.start();
     receiver.client.emit('disconnected');
@@ -130,8 +136,11 @@ async function delaysFor(random, windowMs = 220) {
     let attempts = 0;
     receiver.client.start = async () => {
         attempts += 1;
+        // The real SDK fulfills `undefined` after a successful hello, despite its
+        // declared AppsConnectionsOpenResponse return type. Stub the world, not our
+        // idea of it: a `{ ok: true }` stub is what let the .423 outage ship green.
         if (attempts === 1)
-            return { ok: true };
+            return undefined;
         throw new Error('transient');
     };
     await receiver.start();
@@ -178,3 +187,30 @@ test('a fatal error during initial start() is loud and rejects', async () => {
     assert.equal(attempts, 1, 'a fatal auth error must not be retried');
     assert.ok(errors.some((m) => /failed permanently/i.test(m)), `startup give-up must be loud, saw: ${JSON.stringify(errors)}`);
 });
+// The class boundary. `start()` is declared Promise<AppsConnectionsOpenResponse>
+// (Bolt's signature, un-widenable in an override) but genuinely resolves the
+// SDK's `undefined` on success. Nothing may branch on that value's truthiness.
+// A comment rots in one refactor; this goes red instead.
+test('start() resolves undefined, and the receiver is still connected (no truthiness gate)', async () => {
+    const receiver = new ResilientSocketModeReceiver({
+        appToken: 'xapp-test',
+        reconnectDelayMs: 2,
+        runtimeLogger: { log() { }, warn() { }, error() { } },
+    });
+    receiver.client.disconnect = async () => { };
+    let starts = 0;
+    receiver.client.start = async () => {
+        starts += 1;
+        return undefined;
+    };
+    const result = await receiver.start();
+    assert.equal(result, undefined, 'start() must surface the SDK\'s undefined, not invent a payload');
+    assert.equal(starts, 1);
+    // The only observable proof that `undefined` was treated as CONNECTED rather
+    // than as "stopped": the receiver now reconnects on a disconnect, which
+    // onDisconnected only does when `started` is true.
+    receiver.client.emit('disconnected');
+    await new Promise((r) => setTimeout(r, 30));
+    assert.ok(starts > 1, `an undefined success must mark the receiver started; saw ${starts} start() calls`);
+    await receiver.stop();
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@meetquinn/animactl",
-  "version": "0.1.13-canary.424.1.efdd965",
+  "version": "0.1.13",
   "license": "Apache-2.0",
   "private": false,
   "description": "Operator CLI for installing and running Anima.",