@meetopenbot/openbot 1.2.1 → 1.2.4

package/dist/history.js

@@ -71,51 +71,75 @@ function appendAssistantOutput(message, text, reasoningParts) {
             insertBeforeToolCalls(parts, [{ type: 'text', text }]);
     }
 }
-/**
- * Ensures every tool-call has a matching tool-result before calling the LLM.
- * Orphaned calls (interrupted run, missing :result event, etc.) get an empty
- * result so the conversation can resume instead of failing validation.
- */
-function fillMissingToolResults(messages) {
-    const filled = [];
-    const pending = new Map();
-    const flushPending = () => {
-        if (pending.size === 0)
-            return;
-        filled.push({
-            role: 'tool',
-            content: [...pending.entries()].map(([toolCallId, toolName]) => ({
+function isToolResultPart(part) {
+    return Boolean(part && typeof part === 'object' && part.type === 'tool-result');
+}
+function assistantToolCalls(message) {
+    if (message.role !== 'assistant' || !Array.isArray(message.content))
+        return [];
+    const calls = [];
+    for (const part of message.content) {
+        if (part.type !== 'tool-call')
+            continue;
+        const toolCall = part;
+        if (typeof toolCall.toolCallId !== 'string')
+            continue;
+        calls.push({
+            toolCallId: toolCall.toolCallId,
+            toolName: typeof toolCall.toolName === 'string' ? toolCall.toolName : 'tool',
+        });
+    }
+    return calls;
+}
+function collectToolResults(messages) {
+    const results = new Map();
+    for (const message of messages) {
+        if (message.role !== 'tool' || !Array.isArray(message.content))
+            continue;
+        for (const part of message.content) {
+            if (!isToolResultPart(part) || results.has(part.toolCallId))
+                continue;
+            results.set(part.toolCallId, part);
+        }
+    }
+    return results;
+}
+function toolMessageForCalls(calls, results) {
+    return {
+        role: 'tool',
+        content: calls.map(({ toolCallId, toolName }) => {
+            const existing = results.get(toolCallId);
+            if (existing) {
+                results.delete(toolCallId);
+                return existing;
+            }
+            return {
                 type: 'tool-result',
                 toolCallId,
                 toolName,
                 output: { type: 'text', value: '' },
-            })),
-        });
-        pending.clear();
+            };
+        }),
     };
+}
+/**
+ * Rebuild tool messages so every `tool-call` is followed immediately by matching
+ * results. Late results (user invoke between call and `:result`) are moved next
+ * to their call; unmatched results are dropped; interrupted calls get an empty
+ * result so the next LLM turn does not fail provider validation.
+ */
+function sanitizeToolPairing(messages) {
+    const results = collectToolResults(messages);
+    const sanitized = [];
     for (const message of messages) {
-        if (message.role === 'tool' && Array.isArray(message.content)) {
-            filled.push(message);
-            for (const part of message.content) {
-                if (part.type === 'tool-result') {
-                    pending.delete(part.toolCallId);
-                }
-            }
+        if (message.role === 'tool')
             continue;
-        }
-        flushPending();
-        filled.push(message);
-        if (message.role === 'assistant' && Array.isArray(message.content)) {
-            for (const part of message.content) {
-                if (part.type === 'tool-call') {
-                    const toolCall = part;
-                    pending.set(toolCall.toolCallId, toolCall.toolName);
-                }
-            }
-        }
+        sanitized.push(message);
+        const calls = assistantToolCalls(message);
+        if (calls.length > 0)
+            sanitized.push(toolMessageForCalls(calls, results));
     }
-    flushPending();
-    return filled;
+    return sanitized;
 }
 function toolResultText(data) {
     if (data && typeof data === 'object') {
@@ -235,5 +259,5 @@ export function eventsToModelMessages(events, options) {
                 break;
         }
     }
-    return fillMissingToolResults(messages);
+    return sanitizeToolPairing(messages);
 }

package/dist/system-prompt.js

@@ -5,7 +5,7 @@ export const OPENBOT_SYSTEM_PROMPT = [
     "",
     "# SECURITY POLICY",
     "- **CRITICAL**: Never request API keys, passwords, or sensitive credentials via text or UI widgets; these are managed deterministically via secure forms and must never enter your context.",
-    `- **Credential Guidance**: If an agent or tool requires credentials, tell the user to add them under ${SETTINGS_VARIABLES_MARKDOWN}. When you know the variable name, link to that page with \`?new=ENV_VAR_NAME\` so the client opens Add Variable with the name filled in. Example: ${settingsVariablesMarkdown('LINEAR_API_KEY')}.`,
+    `- **Credential Guidance**: Only relay a credential requirement after a specialist or tool actually reports a specific missing variable. Then pass through that exact variable name with a link to ${SETTINGS_VARIABLES_MARKDOWN} prefilled via \`?new=ENV_VAR_NAME\` (e.g. ${settingsVariablesMarkdown('LINEAR_API_KEY')}). Never guess, invent, or name an API key or provider that no agent or tool reported.`,
     "",
     "# CORE MISSION",
     "You are a high-level manager. Not every message is project work.",
@@ -45,7 +45,7 @@ export const OPENBOT_SYSTEM_PROMPT = [
     "- **Asking**: You ask specialists with `ask_agent`. If `## MENTIONED AGENTS` is present, you MUST ask those people. You may also ask others if needed. If nobody is mentioned, pick the best match from `## INSTALLED AGENTS` and tell the human who you asked.",
     "- **Models**: When you `ask_agent`, pick `model` from that agent's list in `## INSTALLED AGENTS` using the descriptions — cheaper/faster for simple work, stronger for complex coding or reasoning. Omit `model` to use their default. Do not reuse another agent's ids.",
     "- **Closer**: After `ask_agent`, you are the closer, not a second author of their work. Don't repeat. Add or close. When several people replied, write only the synthesis or decision — not a recap of each.",
-    "- **Missing people**: If no installed agent can do the job, pick a match from `## AVAILABLE AGENTS` and call `install_agent` (human must approve) — only when they asked for that capability or agreed. One agent per call. Then `ask_agent`. If nobody is listed, tell the human who to install from Settings. Do not attempt the specialist work yourself.",
+    "- **Missing people**: If no installed agent can do the job, pick a match from `## AVAILABLE AGENTS` and call `install_agent` (human must approve) — only when they asked for that capability or agreed. One agent per call. Then `ask_agent`. If the capability does not exist anywhere (no `## AVAILABLE AGENTS` match), say plainly that it isn't available and ask the human which agent to install from Settings. Never suggest credentials or an API key as a substitute, and do not attempt the specialist work yourself.",
     "- **Hub-and-spoke**: Specialists cannot talk to each other. You pass context from one to the next.",
     "- **Durable Memory**: Use the `remember` tool to store important facts, preferences, or project details that should persist across sessions.",
     "",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@meetopenbot/openbot",
-  "version": "1.2.1",
+  "version": "1.2.4",
   "description": "OpenBot coordinator runtime: ask specialists, route work into Spaces, and track todos.",
   "type": "module",
   "main": "./dist/index.js",
@@ -25,7 +25,7 @@
     "@ai-sdk/openai": "^4.0.46",
     "ai": "^7.0.77",
     "zod": "^4.3.5",
-    "@meetopenbot/plugin-sdk": "^1.1.2"
+    "@meetopenbot/plugin-sdk": "^1.1.3"
   },
   "devDependencies": {
     "@types/node": "^20.10.1",